Re: [pve-devel] [PATCH proxmox-offline-mirror] Add possibility to create named snapshots

2025-05-08 Thread Fabian Grünbichler
On May 6, 2025 11:09 am, Laurențiu Leahu-Vlăducu wrote: > In addition to the existing timed snapshots, it is now possible to > create named snapshots. For some use cases, it makes sense to give > snapshots a specific name, e.g. to specify the purpose of the snapshot > (instead of a timestamp). This

Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline: convert drive to blockdev syntax

2025-05-08 Thread Fiona Ebner
Am 07.05.25 um 10:41 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 06.05.2025 14:57 CEST geschrieben: >>> + >>> + ($storeid) = PVE::Storage::parse_volume_id($volid, 1); >>> + my $vtype = $storeid ? (PVE::Storage::parse_volname($storecfg, >>> $drive->{file}))[0] : undef; >>> + die "$driv

Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline: convert drive to blockdev syntax

2025-05-08 Thread Fiona Ebner
Am 06.05.25 um 17:40 schrieb DERUMIER, Alexandre: >>> Do we need to handle old client (for example, a pve8 doing a live >>> migrate + lcoal storage migration  sending a nbd:// uri to a pve9 >>> with >>> blockdev support ) ? > > Thinking about this, maybe this is a good reason for version guard too

Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline: convert drive to blockdev syntax

2025-05-08 Thread Fiona Ebner
Am 06.05.25 um 16:20 schrieb DERUMIER, Alexandre: > > Am 22.04.25 um 13:51 schrieb Alexandre Derumier via pve-devel: >> >> fixme: >>  - rbd blockdev don't allow extra options (keyring file for example), >>    do we need to patch qemu ? or write client option in a file ? > > I think following upst

Re: [pve-devel] [PATCH docs 4/7] pvecm: extend cluster Requirements

2025-05-08 Thread Robin Christ
On 07.05.25 17:22, Kevin Schneider wrote: IMO this isn't strict enough and we should empathize on the importance of the problem. I would go for To ensure reliable Corosync redundancy, it's essential to use at least two separate physical and logical networks. Single bonded interfaces do not p

[pve-devel] [PATCH pve_flutter_frontend] ios: add configuration files

2025-05-08 Thread Shan Shaji
This patch adds basic configuration files that are necessary for the flutter app to run on iOS. The changes also includes the update of app name and bundle indetifier to match the Android app. However, please note that app name length needs to be shortened, as the display name on the iOS home scre

Re: [pve-devel] [PATCH proxmox-offline-mirror] Add possibility to create named snapshots

2025-05-08 Thread Laurențiu Leahu-Vlăducu
Thanks for your feedback! Some answers inline. On 08.05.25 11:14, Fabian Grünbichler wrote: On May 6, 2025 11:09 am, Laurențiu Leahu-Vlăducu wrote: In addition to the existing timed snapshots, it is now possible to create named snapshots. For some use cases, it makes sense to give snapshots a s

[pve-devel] applied: [PATCH kernel] debian: find firmware: quote regex metacharacters in directory name

2025-05-08 Thread Thomas Lamprecht
On Mon, 28 Apr 2025 18:34:12 +0200, Friedrich Weber wrote: > The directory name contains the version which may contain characters > with semantics as regex metacharacters, e.g. `+` when building a test > kernel. If they are not quoted, the script does not remove the > directory name from its output