Without this check, the toString method returns '-> null' at the end of
the exception message if there are no details.
Signed-off-by: Michael Köppl
---
lib/src/proxmox_api_exception.dart | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/src/proxmox_api_exception.dart
b/lib
On Mon May 5, 2025 at 9:28 AM CEST, Michael Köppl wrote:
> Without this check, the toString method returns '-> null' at the end of
> the exception message if there are no details.
>
> Signed-off-by: Michael Köppl
The change looks good to me. Please consider this change.
Reviewed-By: Shan Shaji
Am 05.05.25 um 15:57 schrieb Mira Limbeck:
> On 5/5/25 14:57, Fiona Ebner wrote:
>> diff --git a/PVE/QemuServer/Agent.pm b/PVE/QemuServer/Agent.pm
>> index 41e615aa..ef36a6a8 100644
>> --- a/PVE/QemuServer/Agent.pm
>> +++ b/PVE/QemuServer/Agent.pm
>> @@ -119,4 +119,55 @@ sub qemu_exec_status {
>>
On Tue, Apr 15, 2025 at 03:50:21PM +0200, Daniel Kral wrote:
> Move the optional parameter `name` into an optional hash argument at the
> end of the subroutine signature of vdisk_alloc().
>
> This allows to add more optional arguments in the future and makes the
> function call easier to follow wh
On 5/2/25 12:19, Michael Köppl wrote:
> Hi, thanks for tackling this. Noticed a few small things. Find the
> comments inline. Generally, please run dart format on these changes.
> Every changed block contains wrong indentation. Also, the commit message
> needs to be fixed.
>
> On 4/29/25 15:16, Al
As of flutter v3.22 the `background` property is
deprecated. The material guidelines suggest
using the surface color for backgrounds.
https://m3.material.io/styles/color/roles#8562cf18-5cc0-44ae-b783-2e38bdb39585
Due to the difference between the current background color and surface
color, this p
On 2025-05-02 13:00, Christoph Heiss wrote:
Tested both patches on a fresh PVE 8.4 installation, setting up Ceph by
manually providing a repo in /etc/apt/sources.list.d/ and then
installing it
- through the web interface and
- with `pveceph -repository offline -version squid`
Tested-by: Chr
The QemuConfig module uses qga_check_running() which is planned to be
moved to the Agent module and it will use a to-be-added
guest_fsfreeze() helper from the Agent module. Loading the config on
the call-sites of agent_cmd(), qemu_exec() and qemu_exec_status()
makes it possible to avoid introducing
The main bit of the series is patch 07/11:
As reported in the enterprise support, it can happen that a guest
agent command is read, but then the guest agent never sends an answer,
because the service in the guest is stopped/killed. For example, if a
guest reboot happens before the command can be s
Both agent_available() and agent_cmd() have no callers that use the
$noerr argument.
The current implementation was not ideal: agent_cmd() did not check
the return value of agent_available() in the $noerr scenario. It
should return early. In agent_available(), failure was silently
ignored in the $
As reported in the enterprise support, it can happen that a guest
agent command is read, but then the guest agent never sends an answer,
because the service in the guest is stopped/killed. For example, if a
guest reboot happens before the command can be successfully executed.
This is usually not pr
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm | 4 +--
PVE/QemuConfig.pm| 4 +--
PVE/QemuMigrate.pm | 3 ++-
PVE/QemuServer.pm| 53 ++--
PVE/QemuServer/Agent.pm | 53
PVE/VZDump/QemuSe
Signed-off-by: Fiona Ebner
---
PVE/QemuServer/Agent.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Agent.pm b/PVE/QemuServer/Agent.pm
index ef36a6a8..92e02645 100644
--- a/PVE/QemuServer/Agent.pm
+++ b/PVE/QemuServer/Agent.pm
@@ -7,6 +7,7 @@ use JSON;
use
This is most likely a left-over from copy-pasting from an example in
the 'IO::Multiplex' man page. In particular, the method is not called
every second.
Signed-off-by: Fiona Ebner
---
PVE/QMPClient.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index ab
Signed-off-by: Fiona Ebner
---
PVE/QemuServer/Agent.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/Agent.pm b/PVE/QemuServer/Agent.pm
index 945a11c0..264c7018 100644
--- a/PVE/QemuServer/Agent.pm
+++ b/PVE/QemuServer/Agent.pm
@@ -3,10 +3,12 @@ package
Order module import according to style guide and add missing
PVE::QemuConfig import.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu/Agent.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu/Agent.pm b/PVE/API2/Qemu/Agent.pm
index e3102b0a..c9527070 100644
Removes the dependency on PVE::QemuServer in the agent module. This
makes it possible to use the agent module from nearly everywhere
without introducing a(n indirect) cyclic dependency.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm | 5 +++--
PVE/QemuConfig.pm| 4 ++--
PVE/Qe
Signed-off-by: Fiona Ebner
---
PVE/QemuConfig.pm | 2 +-
PVE/QemuMigrate.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index 2ee615fa..a88c12c5 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -279,7 +279,7 @@ sub __snaps
Using the $noerr argument will allow callers to opt-in to handling
errors themselves.
Signed-off-by: Fiona Ebner
---
PVE/QMPClient.pm | 8 +---
PVE/QemuServer/Monitor.pm | 11 ---
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/PVE/QMPClient.pm b/PVE/QMPClie
The information displayed in the task list is based on the content of
/var/log/pve/tasks/index, which does not contain the VM/CT name.
The vmname is, however, available through the PVEResources store. The
render function is therefore adapted to find the name matching the vmid
and uses existing func
As of flutter v3.22, the `onBackground` property is deprecated. The
material guidelines suggest using the `onSurface` property instead.
https://m3.material.io/styles/color/roles#8562cf18-5cc0-44ae-b783-2e38bdb39585
For dark theme, the `onSurface` color and `onBackground` color is
different so it'
Adds a description of the `cache=metadata` mode and references the
upstream patch that introduced it.
Signed-off-by: Markus Frank
---
qm.adoc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qm.adoc b/qm.adoc
index 8b9e096..74f8304 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -131
Signed-off-by: Markus Frank
---
qm.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qm.adoc b/qm.adoc
index 1549705..8cf75ca 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1334,12 +1334,13 @@ All Optional Parameters:
|`expose-acl` |Enables ACL passthrough; implies `expose-xattr
Allows tuning the number of worker threads used by virtiofsd.
Signed-off-by: Markus Frank
---
PVE/QemuServer/Virtiofs.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/PVE/QemuServer/Virtiofs.pm b/PVE/QemuServer/Virtiofs.pm
index cfde92c9..1894c95d 100644
--- a/PVE/QemuServer/Virti
Requires the qemu-server commit named "fix #6370: virtiofs: add support
for thread-pool-size option".
Set the maximum value to '256', the same as for the VM CPU cores.
Signed-off-by: Markus Frank
---
www/manager6/qemu/VirtiofsEdit.js | 10 ++
1 file changed, 10 insertions(+)
diff --git
Removes redundant explanatory text now covered by the table.
Signed-off-by: Markus Frank
---
qm.adoc | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/qm.adoc b/qm.adoc
index 74f8304..1549705 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1325,12 +1325,16 @@ xattrs if
qemu-server:
Markus Frank (1):
fix #6370: virtiofs: add support for thread-pool-size option
PVE/QemuServer/Virtiofs.pm | 9 +
1 file changed, 9 insertions(+)
docs:
Markus Frank (3):
virtiofs: add explanation for cache=metadata behavior
virtiofs: add table for optional parameters
Thank you for tackling this!
On 5/5/25 14:57, Fiona Ebner wrote:
> As reported in the enterprise support, it can happen that a guest
> agent command is read, but then the guest agent never sends an answer,
> because the service in the guest is stopped/killed. For example, if a
> guest reboot happe
Am 23.04.25 um 15:59 schrieb Fabian Grünbichler:
> this is a bit repetitive otherwise, no functional changes intended.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/Storage/RBDPlugin.pm | 55 ++--
> 1 file changed, 27 insertions(+), 28 deletions(-)
>
> di
Am 23.04.25 um 15:59 schrieb Fabian Grünbichler:
> diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
> index 8c67a37..3bb5807 100644
> --- a/src/PVE/Storage/RBDPlugin.pm
> +++ b/src/PVE/Storage/RBDPlugin.pm
> @@ -89,22 +89,17 @@ my $rbd_cmd = sub {
> my ($scfg, $storeid,
30 matches
Mail list logo
