Thanks for tackling this!
On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
> [..]
> +pub fn verify_disks_settings(answer: &Answer) -> Result<()> {
> +if let DiskSelection::Selection(selection) =
> &answer.disks.disk_selection {
> +let min_disks = answer.disks.fs_type.get_min_
The directory name contains the version which may contain characters
with semantics as regex metacharacters, e.g. `+` when building a test
kernel. If they are not quoted, the script does not remove the
directory name from its output, which will cause a build failure in
`fwcheck` even though the fir
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Add test cases for strict negative colocation rules, i.e. where services
> must be kept on separate nodes. These verify the behavior of the
> services in strict negative colocation rules in case of a failover of
> the node of one or more of these services
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Add an option to the VirtFail's name to allow the start and migrate fail
> counts to only apply on a certain node number with a specific naming
> scheme.
>
> This allows a slightly more elaborate test type, e.g. where a service
> can start on one node (o
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Add test cases for strict positive colocation rules, i.e. where services
> must be kept on the same node together. These verify the behavior of the
> services in strict positive colocation rules in case of a failover of
> their assigned nodes in the follo
The `onPopInvoked` callback is deprecated as of
Flutter v3.22.0-12.0.pre. This patch replaces it
with the `onPopInvokedWithResult` callback.
Signed-off-by: Shan Shaji
---
lib/pages/main_layout_slim.dart | 2 +-
lib/states/pve_node_overview_state.dart | 2 --
2 files changed, 1 insertion
On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
> To avoid having multiple places where the minimum number of disks
> required for a certain RAID setup is defined, use get_min_disks in the
> common installer RAID config checks as well, keeping the behavior the
> same as for the answer fil
On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
> Check that the configured swapsize is not greater than the total size
> of the disk and that maxroot is at most hdsize / 4. Define the
> behavior for the auto-installer as well as the TUI and GUI installers.
>
> Signed-off-by: Michael Köpp
On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
> Signed-off-by: Michael Köppl
> ---
> proxmox-installer-common/src/utils.rs | 16 +++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/proxmox-installer-common/src/utils.rs
> b/proxmox-installer-common/src/
Thanks for tackling this.
Reviewed the series and left some comments on the individual patches,
mostly some thoughts and nits.
Also tested `proxmox-auto-install-assistant validate-answer` for the new
cases, as well as the early RAID check in the GUI and the auto
installer.
On Tue Apr 22, 2025 at
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Add a mechanism to the node selection subroutine, which enforces the
> colocation rules defined in the rules config.
>
> The algorithm manipulates the set of nodes directly, which the service
> is allowed to run on, depending on the type and strictness o
Am 11.04.25 um 17:56 schrieb Daniel Kral:
> On 4/3/25 14:17, Fabian Grünbichler wrote:
>> On March 25, 2025 4:12 pm, Daniel Kral wrote:
>>> +sub apply_positive_colocation_rules {
>>> + my ($together, $allowed_nodes) = @_;
>>> +
>>> + return if scalar(keys %$together) < 1;
>>> +
>>> + my $m
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Factor out the prioritized node hash set in the select_service_node as
> it is used multiple times and makes the intent a little clearer.
>
> Signed-off-by: Daniel Kral
Reviewed-by: Fiona Ebner
___
pve-dev
On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
> Implement check if the address entered by the user is valid within the
> given subnet, i.e. not a network address or broadcast address.
>
> Partially closes [0].
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5757
>
> Signed-off-by:
As reported in the community forum [0] and the virtio-win project [1],
virtiofsd will run into its open file limit when used with a Windows
guest that reads too many files. It's also reported that the issue
does not occur with Linux guests and a workaround is using
'--inode-file-handles=mandatory'
--- Begin Message ---
Hello,
for a project we are working on a simple Apparmor profile for KVM-based
VMs in Proxmox.
For now it's a POC with a static profile for the qemu-system-x86_64
binary. The next step would be to patch the Proxmox Perl code to
implement a basic version of dynamic profile
On 4/28/25 13:25, Christoph Heiss wrote:
On Tue Apr 22, 2025 at 6:27 PM CEST, Michael Köppl wrote:
[..]
+pub fn verify_disks_settings(answer: &Answer) -> Result<()> {
+if let DiskSelection::Selection(selection) = &answer.disks.disk_selection {
+let min_disks = answer.disks.fs_type.ge
On 4/28/25 12:22, Christoph Heiss wrote:
At least for IPv4 /31 prefixes, this check (including the network
address part) is wrong. RFC 3021 [0] explicitly allows such subnets for
point-to-point links.
E.g. 192.168.0.0/31 is a valid subnet with 2 hosts, 192.168.0.0/31 and
192.168.0.1/31.
[0] htt
Am 28.04.25 um 14:26 schrieb Fiona Ebner:
> Am 25.03.25 um 16:12 schrieb Daniel Kral:
>> +
>> +delete $allowed_nodes->{$node};
>> +}
>> +} elsif (scalar keys %$possible_nodes) {
>> +# limit to the possible nodes the service should be on, if there are
>> any.
>> +for my $nod
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Add test cases for loose positive and negative colocation rules, i.e.
> where services should be kept on the same node together or kept separate
> nodes. These are copies of their strict counterpart tests, but verify
> the behavior if the colocation rule
On 4/28/25 13:48, Christoph Heiss wrote:
proxmox-installer-common/src/disk_checks.rs | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/proxmox-installer-common/src/disk_checks.rs
b/proxmox-installer-common/src/disk_checks.rs
index ecc43bd..1d17e2c 100644
As of flutter v3.27 the `withOpacity` function
is deprecated. This patch replaces all occurrences
of `withOpacity` with `withValues` function.
Signed-off-by: Shan Shaji
---
lib/main.dart | 4 ++--
lib/pages/main_layout_slim.dart| 12 +
22 matches
Mail list logo
