[pve-devel] [PATCH ifupdown2 2/7] update submodule to 3.9.0

2025-04-23 Thread Christoph Heiss
Allows to drop most upstream patches, expect one for IPv6 SLAAC support due to being stale/unmerged as of 3.9.0. Adds a simple patch dropping a line from setup.py, as it tries to install a non-existing file and would thus otherwise fail the install step. Signed-off-by: Christoph Heiss --- Our if

[pve-devel] [PATCH ifupdown2 1/7] gitignore: add dpkg build artifacts

2025-04-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- .gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..63bd013 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +ifupdown2[-_][0-9]* -- 2.49.0

[pve-devel] [PATCH ifupdown2 3/7] d/changelog: merge in upstream changelog

2025-04-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- debian/changelog | 45 + 1 file changed, 45 insertions(+) diff --git a/debian/changelog b/debian/changelog index 689cc1c..ccb4558 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,48 @@ +ifupdown2 (3.9.0

[pve-devel] [PATCH ifupdown2 5/7] bump version to 3.9.0-1+pmx1

2025-04-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- debian/changelog | 11 +++ 1 file changed, 11 insertions(+) diff --git a/debian/changelog b/debian/changelog index ccb4558..53c781d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,14 @@ +ifupdown2 (3.9.0-1+pmx1) bookworm; urgency=medium

[pve-devel] [RFC PATCH ifupdown2 6/7] d/patches: add patch for adding IPv6 vxlan-local-tunnelip

2025-04-23 Thread Christoph Heiss
This patch makes it possible to use an IPv6 address for the local VXLAN tunnel address. Upstream-Link: https://github.com/CumulusNetworks/ifupdown2/pull/315 Suggested-by: Stefan Hanreich Signed-off-by: Christoph Heiss --- Stefan suggested the inclusion of this patch, as it's been a fairly reques

[pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

2025-04-23 Thread Daniel Herzig
Move the queries for vCLS machines and empty datastore strings into the already existing try-except routine to save `listvms.py` from breaking when `vm.config` is `None`. Do not store the result of the `any` function in a variable anymore, do the same for the datastore query to shorten code. Prep

Re: [pve-devel] [PATCH proxmox-firewall 2/2] firewall: add subcommands to proxmox-firewall binary

2025-04-23 Thread Gabriel Goller
On 14.04.2025 17:44, Stefan Hanreich wrote: [snip] +fn main() -> Result<(), Error> { +let mut args = Arguments::from_env(); + +let parsed_command = args.subcommand()? +.ok_or_else(|| format_err!("no subcommand specified"))? Maybe we could print HELP here again? So that you don't

[pve-devel] [PATCH container v2 3/4] config: support printing a device

2025-04-23 Thread Filip Schauer
Signed-off-by: Filip Schauer --- src/PVE/LXC/Config.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 0740e8c..555767f 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1364,6 +1364,12 @@ sub print_volume { retur

[pve-devel] [PATCH ifupdown2 4/7] d/patches: revert broken bridge-fd `validrange` clamping

2025-04-23 Thread Christoph Heiss
See the patch itself for the rationale behind it. Signed-off-by: Christoph Heiss --- ...-bridge-update-bridge-fd-valid-range.patch | 55 +++ debian/patches/series | 1 + 2 files changed, 56 insertions(+) create mode 100644 debian/patches/pve/0012-Revert

Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

2025-04-23 Thread Daniel Herzig
Daniel Kral writes: > On 4/23/25 16:04, Daniel Herzig wrote: >>> Oops, I should have prefixed my patch with a "fix" at least, but I've >>> sent two patches some days ago for this ;): >>> >>> https://lore.proxmox.com/pve-devel/20250411150634.253684-1-d.k...@proxmox.com/T/#u >>> >> Ha, I missed tha

[pve-devel] [PATCH container v2 4/4] implement device hotplug

2025-04-23 Thread Filip Schauer
This only includes adding devices to a running container. Removing or editing existing devices is still not implemented. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm| 74 ++- src/PVE/LXC/Config.pm | 19 +++ 2 files changed, 92 insertions

[pve-devel] [PATCH container v2 2/4] extract passthrough device node creation to a helper

2025-04-23 Thread Filip Schauer
Signed-off-by: Filip Schauer --- src/PVE/LXC.pm| 29 + src/lxc-pve-prestart-hook | 21 + 2 files changed, 30 insertions(+), 20 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index d929608..d985b88 100644 --- a/src/PVE/LXC.pm

[pve-devel] [PATCH container v2 1/4] extract apparmor profile & namespace switch to a helper

2025-04-23 Thread Filip Schauer
Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 71 +- 1 file changed, 41 insertions(+), 30 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index a58c997..d929608 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -2010,15 +2010,42 @@

[pve-devel] [PATCH container v2 0/4] implement device hotplug

2025-04-23 Thread Filip Schauer
For now this only includes adding devices to a running container. (not removing or editing existing devices) Changes since v1: * Reduce code repetition between lxc-pve-prestart-hook and device_passthrough_hotplug by extracting passthrough device node creation to a helper. Filip Schauer (4):

Re: [pve-devel] [PATCH container 0/3] implement device hotplug

2025-04-23 Thread Filip Schauer
Superseded by: https://lore.proxmox.com/pve-devel/20250423125640.88756-1-f.scha...@proxmox.com/T On 16/12/2024 18:21, Filip Schauer wrote: Filip Schauer (3): extract apparmor profile & namespace switch to its own helper config: support printing a device implement device hotplug src/P

[pve-devel] [PATCH ifupdown2 0/7] bump to upstream 3.9.0 release

2025-04-23 Thread Christoph Heiss
Going by the changelog, there seem to be no actual breaking changes, except one commit - which is reverted w/ patch #4, due to being broken. Other than that, it's just bug fixes and new attributes. I also skimmed the actual git log, nothing otherwise obvious there either. See patch #3 for the upst

[pve-devel] [RFC PATCH ifupdown2 7/7] bump version to 3.9.0-1+pmx2

2025-04-23 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 53c781d..584b410 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +ifupdown2 (3.9.0-1+pmx2) bookworm; urgency=medium + + * a

Re: [pve-devel] [PATCH docs/manager/qemu-server v2 0/3] Make VirtIO network devices always inherit MTU from bridge

2025-04-23 Thread Stefan Hanreich
On 4/22/25 16:48, Thomas Lamprecht wrote: > Am 22.04.25 um 13:33 schrieb Stefan Hanreich: >> A possible regression I can think of is: If the bridge was set to the >> wrong MTU (e.g. 9000) at some point, but external devices in the same >> LAN are still set to use a lower MTU (e.g. 1500). If users n

Re: [pve-devel] [PATCH pve-installer 4/6] run rustfmt

2025-04-23 Thread Christoph Heiss
Have you checked out the latest commit (952832147)? These are apparently the "old" 2021 edition rules which are being applied here - latest master is on the 2024 edition for some time now [0]. The changes here are the exact reverse of some of the changes done in the follow-up tree-wide formatting

[pve-devel] [RFC manager 1/2] fix #5244 pveceph: install: add new repository for offline installation

2025-04-23 Thread Aaron Lauterer
by adding a 4th repository option called 'offline'. If set, the ceph installation step will not touch the repository configuration. We add a simple version check to make sure that the latest version available (and to be installed) does match the selected major Ceph version. Signed-off-by: Aaron L

Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

2025-04-23 Thread Daniel Kral
On 4/23/25 15:03, Daniel Herzig wrote: Move the queries for vCLS machines and empty datastore strings into the already existing try-except routine to save `listvms.py` from breaking when `vm.config` is `None`. Do not store the result of the `any` function in a variable anymore, do the same for t

[pve-devel] [RFC manager 2/2] ui: CephInstallWizard: add option and hint for offline repository

2025-04-23 Thread Aaron Lauterer
The new 'offline' repository option will not try to configure the Ceph repositories during installation. Signed-off-by: Aaron Lauterer --- www/manager6/ceph/CephInstallWizard.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/Cep

Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

2025-04-23 Thread Daniel Kral
On 4/23/25 16:04, Daniel Herzig wrote: Daniel Kral writes: On 4/23/25 15:03, Daniel Herzig wrote: Move the queries for vCLS machines and empty datastore strings into the already existing try-except routine to save `listvms.py` from breaking when `vm.config` is `None`. Do not store the result

[pve-devel] [PATCH storage 2/3] fix #6338: rbd: use image-/snap-spec consistently

2025-04-23 Thread Fabian Grünbichler
this is the recommended way upstream to pass this information, and all commands (other than those not operating on images/snapshots) consume them (rbd(8)): > image-spec is [pool-name/[namespace-name/]]image-name > snap-spec is [pool-name/[namespace-name/]]image-name@snap-nam

[pve-devel] [PATCH storage 3/3] rbd: add protect/unprotect helpers

2025-04-23 Thread Fabian Grünbichler
this is a bit repetitive otherwise, no functional changes intended. Signed-off-by: Fabian Grünbichler --- src/PVE/Storage/RBDPlugin.pm | 55 ++-- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlug

[pve-devel] [PATCH storage 1/3] rbd: extend get_rbd_(dev_)path helpers with $snap parameter

2025-04-23 Thread Fabian Grünbichler
this helper effectively converts a storage config entry and a volume/image name into an RBD image-spec as specified in rbd(8): image-spec is [pool-name/[namespace-name/]]image-name by extending it with an optional $snap parameter it can also convert to a snap-spec: snap-spec

[pve-devel] [RFC storage 0/3] rbd: use image-/snap-spec instead of --pool/..

2025-04-23 Thread Fabian Grünbichler
the 'rbd' CLI tool has two ways of specifying which images/snapshots to operate on: - the deprecated --(dest-)pool, --namespace, --image and --snap parameters - the new style 'spec'-based variant, passing [pool/[namespace/]]image[@snapshot] we are currently using a mix of both (passing pool, name

Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

2025-04-23 Thread Daniel Herzig
Daniel Kral writes: > On 4/23/25 15:03, Daniel Herzig wrote: >> Move the queries for vCLS machines and empty datastore strings into >> the already existing try-except routine to save `listvms.py` from >> breaking when `vm.config` is `None`. >> Do not store the result of the `any` function in a va