[pve-devel] applied-series: [PATCH manager v2] ui: backup: hide change mode detection for vms and non-pbs storage

2025-04-11 Thread Fiona Ebner
Am 10.04.25 um 10:33 schrieb Dominik Csapak: > Since it does not do anything for non-pbs storages and vms, this is only > distracting in these cases, so hide the selector + tooltip help icon. > > Refactor the help icon into a variable, so we can more easily > disable/hide it. > > Signed-off-by: D

[pve-devel] [PATCH docs v3 follow-up] pveceph: add section for rbd namespaces

2025-04-11 Thread Aaron Lauterer
and a few basic examples on how to manage them. Signed-off-by: Aaron Lauterer --- Please use this instead of the original v3 docs patch. It seems I forgot to commit the changes before creating the patch :-/bin changes since v2: * {pve} instead of written out * incorporated other small fixes and

[pve-devel] applied: [PATCH docs] firmware-updates: align apt upgrade to apt full-upgrade

2025-04-11 Thread Aaron Lauterer
Because 'apt-get upgrade' or 'apt upgrade' will not pull in potential new dependencies and that could lead to a broken system. 'apt-get dist-ugprade' or 'apt full-upgrade' will install new dependencies when needed. Signed-off-by: Aaron Lauterer --- firmware-updates.adoc | 2 +- 1 file changed, 1

[pve-devel] [RFC qemu] block/gluster: do not warn about deprecation

2025-04-11 Thread Fiona Ebner
Proxmox VE will not drop the GlusterFS plugin during the PVE 8.x support lifecycle. Avoid scaring users early. Signed-off-by: Fiona Ebner --- The plan is to warn users with pve8to9, but sent as RFC, because keeping this early heads-up is not too bad either. block/gluster.c | 2 -- 1 file chang

[pve-devel] [PATCH widget-toolkit] fix #6312: limit consent window to viewport size

2025-04-11 Thread Dominik Csapak
The consent window will try to size itself according to the max/min constraints set, but those might be too large for some viewport sizes. Since it's not possible to set those to relative viewport sizes (ExtJS does it's own layout, so we can't use CSS), we have to save the original size (while fac

Re: [pve-devel] [PATCH ha-manager 05/15] rules: add colocation rule plugin

2025-04-11 Thread Daniel Kral
Thanks for the review, Fabian! Sorry for the wait, I was more focused on testing other patch series which were already ready to merge for PVE 8.4 ;). But I'm going to be working on this again now, so that it will be ready for the next release or even before that :) Thanks for the suggestions

Re: [pve-devel] [PATCH pve-access-control v2 1/1] permissions: add ACL paths for SDN fabrics

2025-04-11 Thread Stefan Hanreich
On 4/7/25 11:27, Fabian Grünbichler wrote: > >> Stefan Hanreich hat am 07.04.2025 10:51 CEST >> geschrieben: >> >> >> On 4/7/25 10:12, Thomas Lamprecht wrote: >>> Am 07.04.25 um 09:24 schrieb Fabian Grünbichler: On April 4, 2025 7:20 pm, Thomas Lamprecht wrote: > So, without looking a

Re: [pve-devel] [PATCH pve-access-control v2 1/1] permissions: add ACL paths for SDN fabrics

2025-04-11 Thread Stefan Hanreich
Hit send too early when editing On 4/11/25 13:12, Stefan Hanreich wrote: > Imo, #2 and #3 seem like the contenders. #3 is what we use for zones / > vnets / subnets, and it is . #2 makes API definitions a lot nicer, [..] it is established in SDN already and works there. > since we have exactly o

Re: [pve-devel] [PATCH ha-manager 02/15] tools: add hash set helper subroutines

2025-04-11 Thread Daniel Kral
Thanks here for the feedback from both of you. I agree with all the comments and will make the helpers more reusable so that they can be moved to a new data structure/hash module in PVE::Tools. On 4/3/25 14:16, Fabian Grünbichler wrote: On March 25, 2025 6:53 pm, Thomas Lamprecht wrote: Am 2

Re: [pve-devel] [PATCH v1 pve-storage 0/8] Base Module + Documentation for PVE::Storage::Plugin API

2025-04-11 Thread Wolfgang Bumiller
On Wed, Mar 26, 2025 at 03:20:51PM +0100, Max Carrara wrote: > Abstract Base Module + Documentation for PVE::Storage::Plugin API - v1 > == > > This series adds a base module (interface) for PVE::Storage::Plugin, > named PVE::Stora

Re: [pve-devel] [PATCH v1 pve-storage 3/8] pluginbase: document SectionConfig methods

2025-04-11 Thread Wolfgang Bumiller
On Mon, Mar 31, 2025 at 05:13:10PM +0200, Fabian Grünbichler wrote: > On March 26, 2025 3:20 pm, Max Carrara wrote: > > This commit adds docstrings for the relevant PVE::SectionConfig > > methods in the context of the storage plugin API. > > > > Signed-off-by: Max Carrara > > --- > > src/PVE/Sto

Re: [pve-devel] [PATCH v1 pve-storage 6/8] pluginbase: document image operation methods

2025-04-11 Thread Wolfgang Bumiller
On Wed, Mar 26, 2025 at 03:20:57PM +0100, Max Carrara wrote: > Add documentation for the following methods: > - list_images > - create_base > - clone_image > - alloc_image > - free_image > > Signed-off-by: Max Carrara > Co-authored-by: Maximiliano Sandoval > --- > src/PVE/Storage/PluginBase.pm

Re: [pve-devel] [PATCH v1 pve-storage 4/8] pluginbase: document general plugin methods

2025-04-11 Thread Wolfgang Bumiller
On Wed, Apr 02, 2025 at 06:31:54PM +0200, Max Carrara wrote: > On Mon Mar 31, 2025 at 5:12 PM CEST, Fabian Grünbichler wrote: > > On March 26, 2025 3:20 pm, Max Carrara wrote: > > > Add docstrings for the following methods: > > > - check_connection > > > - activate_storage > > > - deactivate_storag

[pve-devel] [PATCH esxi-import-tools 1/2] listvms: add check for vCLS test whether vm configuration is present

2025-04-11 Thread Daniel Kral
It seems that on older ESXi installations, e.g. ESXi 6.7 [0], there are virtual machines, which do not expose a config property for some VMs. Therefore, test whether the config is available before checking if the current entry is a vCLS VM. [0] https://forum.proxmox.com/threads/164900/ Signed-off

[pve-devel] [RFC esxi-import-tools 2/2] listvms: add message when skipping vCLS agent VMs

2025-04-11 Thread Daniel Kral
While at it, factor out the checks to make the control flow a little easier to read and add information why there is an extra check for the vm.config. Signed-off-by: Daniel Kral --- This is not essential, but I thought it wouldn't hurt to let people know of both types being skipped, but could als

[pve-devel] [PATCH storage 1/2] disks: get: separate error path for retrieving SMART data

2025-04-11 Thread Daniel Kral
Make the subroutine get_smart_data() die with the error message from running the `smartctl` command before. This is in preparation for the next patch, which makes that command fail in certain scenarios. Signed-off-by: Daniel Kral --- src/PVE/Diskmanage.pm | 4 +++- 1 file changed, 3 insertions(+

Re: [pve-devel] [RFC esxi-import-tools 2/2] listvms: add message when skipping vCLS agent VMs

2025-04-11 Thread Max Carrara
On Fri Apr 11, 2025 at 5:06 PM CEST, Daniel Kral wrote: > While at it, factor out the checks to make the control flow a little > easier to read and add information why there is an extra check for the > vm.config. Both of these patches LGTM. Neat! Side note: Shame that the type annotations in that

Re: [pve-devel] [PATCH storage 1/2] disks: get: separate error path for retrieving SMART data

2025-04-11 Thread Max Carrara
On Fri Apr 11, 2025 at 5:08 PM CEST, Daniel Kral wrote: > Make the subroutine get_smart_data() die with the error message from > running the `smartctl` command before. This is in preparation for the > next patch, which makes that command fail in certain scenarios. > > Signed-off-by: Daniel Kral >

Re: [pve-devel] [PATCH ha-manager 09/15] manager: apply colocation rules when selecting service nodes

2025-04-11 Thread Daniel Kral
Thanks for the taking the time here too! I'm unsure if the documentation wasn't clear enough or I'm just blinded here in some details how the division between strict/non-strict should be, but I hope I could clarify some points about my understanding here. Please correct me here in any case the

Re: [pve-devel] [PATCH storage 2/2] fix #6224: disks: get: set timeout for retrieval of SMART stat data

2025-04-11 Thread Max Carrara
On Fri Apr 11, 2025 at 5:08 PM CEST, Daniel Kral wrote: > In rare scenarios, `smartctl` takes up to 60 seconds to timeout for SCSI > commands to be completed, as reported in our user forum [0] and bugzilla > [1]. It seems that USB drives handled by the USB Attached SCSI (UAS) > kernel module are mo

[pve-devel] [PATCH storage 2/2] fix #6224: disks: get: set timeout for retrieval of SMART stat data

2025-04-11 Thread Daniel Kral
In rare scenarios, `smartctl` takes up to 60 seconds to timeout for SCSI commands to be completed, as reported in our user forum [0] and bugzilla [1]. It seems that USB drives handled by the USB Attached SCSI (UAS) kernel module are more likely to be affected by this [2], but is more of a case-by-c

Re: [pve-devel] [PATCH pve-access-control v2 1/1] permissions: add ACL paths for SDN fabrics

2025-04-11 Thread Stefan Hanreich
On 4/11/25 1:12 PM, Stefan Hanreich wrote: On 4/7/25 11:27, Fabian Grünbichler wrote: Stefan Hanreich hat am 07.04.2025 10:51 CEST geschrieben: On 4/7/25 10:12, Thomas Lamprecht wrote: Am 07.04.25 um 09:24 schrieb Fabian Grünbichler: On April 4, 2025 7:20 pm, Thomas Lamprecht wrote: S

Re: [pve-devel] [PATCH v4 qemu-server 04/11] blockdev: vm_devices_list : fix block-query

2025-04-11 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi Fabian, > @@ -3937,11 +3937,12 @@ sub vm_devices_list { >   $devices_to_check = $to_check; > } >   > +    #block devices need to be queried at qdev level, as a device > +    #don't always have a blockdev drive media attached (cdrom for > example) > my $resblock