On Wed Mar 5, 2025 at 5:10 PM CET, Laurențiu Leahu-Vlăducu wrote:
> Hello everyone,
>
> I would need some feedback on a feature that was requested multiple
> times by different users over the years. Specifically, many people have
> complained that synchronizing Active Directory groups to PVE
> part
Reported-by: Fiona Ebner
Signed-off-by: Thomas Lamprecht
---
src/PVE/Network/SDN.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index cc5febe..68f9e0f 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -262,
Reported-by: Fiona Ebner
Signed-off-by: Thomas Lamprecht
---
and group and sort correctly while at it.
src/PVE/Network/SDN.pm | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index 8cd9ad8..cc5febe 100644
--- a/src
No point in having the same generic code to prepare variables for an
API request to PowerDNS 7 times basically duplicated.
Signed-off-by: Thomas Lamprecht
---
There might be other such bloat lurking, just stumbled into this by
chance..
src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 77 ++-
when we bump the pve machine version, we also want to include that info
in the meta creation info. With that we can pin guests to the specific
version they were created on.
Signed-off-by: Dominik Csapak
---
we could also give the kvm_version as parameter directly here, since
we already need it...
since they make some problems (e.g. windows hybrid shutdown is enabled
by default then -> which makes vGPU problem). Libvirt/virsh also
disables that by default (and tries preventing enabling it.)
This series introduces a new pve1 version for 9.2 machine versions, and
pins new windows guests to th
but warn when we're out of date compared to the installed one, and die
when we're one major (+1 minor) release behind.
(the warning is not very visible when running tests or when building)
We don't want to depend on the installed QEMU version for such tests,
otherwise a developer might need to ada
So users can disable them (they're enabled by default in QEMU)
Signed-off-by: Dominik Csapak
---
This patch may make sense, regardless if we'll apply the reversal of the
default...
PVE/QemuServer.pm | 2 ++
PVE/QemuServer/Machine.pm | 40 +++
2 files
once with included pve machine and once without
Signed-off-by: Dominik Csapak
---
test/cfg2cmd/q35-windows-pinning-pvever.conf | 5
.../q35-windows-pinning-pvever.conf.cmd | 26 +++
test/cfg2cmd/q35-windows-pinning.conf | 5
test/cfg2cmd/q35-windows-pin
when we don't have a specific machine version on a windows guest, we use
the creation meta info to pin the machine version. Currently we always
append the pve machine version from the current installed kvm version,
which is not necessarily the version we pinned the guest to.
Instead, use either th
Am 06.03.25 um 15:15 schrieb Dominik Csapak:
> On 3/6/25 15:10, Fiona Ebner wrote:
>> Am 06.03.25 um 14:36 schrieb Dominik Csapak:
>>> On 3/6/25 14:10, Fiona Ebner wrote:
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
>
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> when we don't have a specific machine version on a windows guest, we use
> the creation meta info to pin the machine version. Currently we always
> append the pve machine version from the current installed kvm version,
> which is not necessarily the ve
If we have multiple 'globalFlags', we have to encode each one separately
on the commandline with '-global OPTION', since QEMU does not allow to
have multiple options here.
We currently only have one such flag that used the 'globalFlags' list,
so it never popped up. (All other uses directly add an
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> but warn when we're out of date compared to the installed one, and die
> when we're one major (+1 minor) release behind.
> (the warning is not very visible when running tests or when building)
>
> We don't want to depend on the installed QEMU version
Am 06.03.25 um 13:15 schrieb Dominik Csapak:
> On 3/6/25 13:13, Fiona Ebner wrote:
>> Am 06.03.25 um 11:44 schrieb Dominik Csapak:
>>> If we have multiple 'globalFlags', we have to encode each one separately
>>> on the commandline with '-global OPTION', since QEMU does not allow to
>>> have multipl
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> When creating or updating guests with ostype windows, we want to pin the
> machine version to a specific one. Since introduction of that feature,
> we never bumped the pve machine version, so this was missing.
>
> Append the pve machine version if it'
I will review and test the series and then you can add it to the next
version if necessary. Otherwise we can also edit it.
On 3/6/25 14:11, lou.lecriv...@wdz.de wrote:
Re Hannes,
You're welcome :)
Sorry for the "from:", my mistake, must've slipped through before sending the
patches (I ma
On 3/6/25 13:00, Fiona Ebner wrote:
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
but warn when we're out of date compared to the installed one, and die
when we're one major (+1 minor) release behind.
(the warning is not very visible when running tests or when building)
We don't want to depend o
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> So users can disable them (they're enabled by default in QEMU)
>
> Signed-off-by: Dominik Csapak
> ---
> This patch may make sense, regardless if we'll apply the reversal of the
> default...
>
> PVE/QemuServer.pm | 2 ++
> PVE/QemuServer/M
On 3/6/25 14:10, Fiona Ebner wrote:
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
when we don't have a specific machine version on a windows guest, we use
the creation meta info to pin the machine version. Currently we always
append the pve machine version from the current installed kvm version,
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
> once with included pve machine and once without
>
> Signed-off-by: Dominik Csapak
If we go for this fallback approach:
Reviewed-by: Fiona Ebner
In either case, it would be nice to also have a test with an explicitly
pinned 9.2+pve0 too.
___
On 2/8/25 06:42, Thomas Skinner wrote:
> Continues work on adding an option to disable querying the userinfo endpoint
> for an
> OIDC provider.
>
> Changes since v2:
> - Adjust verify_authorization_code in pve-rs to be backwards compatible
> - Fix defaults in wrapper functions
>
> access-control
On 2/8/25 06:42, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner
> ---
> src/PVE/API2/OpenId.pm | 6 +-
> src/PVE/Auth/OpenId.pm | 7 +++
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm
> index 77410e6..456e96a
On 2/8/25 06:42, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner
> ---
> pve-rs/src/openid/mod.rs | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/pve-rs/src/openid/mod.rs b/pve-rs/src/openid/mod.rs
> index 1fa7572..8f914ad 100644
> --- a/pve-rs/src/openid/mod
When creating or updating guests with ostype windows, we want to pin the
machine version to a specific one. Since introduction of that feature,
we never bumped the pve machine version, so this was missing.
Append the pve machine version if it's not 0 so we don't add that
unnecessarily.
Signed-off
On 3/5/25 11:34, Eneko Lacunza via pve-devel wrote:
Hi Dominik,
It is very likely we'll have access to a suitable cluster to test this before summer, provided these
patches are in published packages.
I can test and report back if that's helpful.
Note that this series was superseded by a nex
--- Begin Message ---
Hello All,
Hope this email finds you well.
At Arctera/Veritas, we are exploring the addition of support for data
protection of Proxmox environments within our backup product. We would like to
know if there is a detailed backup/restore API guide available that could serve
a
--- Begin Message ---
From: Lou Lecrivain
This is the initial Nautobot plugin, based on the Netbox
plugin implementation.
Signed-off-by: lou lecrivain
---
src/PVE/API2/Network/SDN/Ipams.pm | 1 +
src/PVE/Network/SDN/Ipams.pm| 3 +
src/PVE/Network/SDN/Ipams/Makefil
--- Begin Message ---
From: Lou Lecrivain
Following review from Hannes,
I have made some improvements to the form of the code for the pve-network part.
No functional changes.
Related changes to pve-manager and pve-docs are also included the email thread.
BR
Lou Lecrivain (3):
ipam: nautobot
--- Begin Message ---
From: Lou Lecrivain
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 29 +--
src/test/ipams/nautobot/expected.add_ip | 11 +++
.../ipams/nautobot/expected.add_ip_notgateway | 11 +++
.../ipams/nautobot/expected.
--- Begin Message ---
From: Jonatan Crystall
Co-authored-by: Jonatan Crystall
Signed-off-by: lou lecrivain
---
pvesdn.adoc | 19 +++
1 file changed, 19 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 5d5d27b..d4744ab 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -56
--- Begin Message ---
From: Jonatan Crystall
Co-authored-by: Jonatan Crystall
Signed-off-by: Lou Lecrivain
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 5 +++
www/manager6/sdn/ipams/NautobotEdit.js | 52 ++
3 files changed
--- Begin Message ---
From: Lou Lecrivain
check that prefix/subnet is empty (only gateway IPs should remain)
before deletion.
Signed-off-by: lou lecrivain
---
src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 73 -
1 file changed, 70 insertions(+), 3 deletions(-)
diff --git a/
Am 06.03.25 um 14:36 schrieb Dominik Csapak:
> On 3/6/25 14:10, Fiona Ebner wrote:
>> Am 06.03.25 um 11:44 schrieb Dominik Csapak:
>>> diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
>>> index f1acde8f..e3da8e21 100644
>>> --- a/PVE/QemuServer/Machine.pm
>>> +++ b/PVE/QemuServer/
On 3/6/25 15:10, Fiona Ebner wrote:
Am 06.03.25 um 14:36 schrieb Dominik Csapak:
On 3/6/25 14:10, Fiona Ebner wrote:
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
index f1acde8f..e3da8e21 100644
--- a/PVE/QemuServer/Machine.pm
+
Am 06.03.25 um 15:10 schrieb Fiona Ebner:
> Am 06.03.25 um 14:36 schrieb Dominik Csapak:
>> On 3/6/25 14:10, Fiona Ebner wrote:
>>> Am 06.03.25 um 11:44 schrieb Dominik Csapak:
diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
index f1acde8f..e3da8e21 100644
--- a/PV
Hi,
and thanks to the both of you!
Can you please resend the mail to our mailing list so that it is
available for everyone please?
Another tiny thing, we don't use "From: Lou Lecrivain
" but "Signed-off-by: Lou Lecrivain
"
which indicates that contribution was created in whole or in part by
On 3/6/25 13:13, Fiona Ebner wrote:
Am 06.03.25 um 11:44 schrieb Dominik Csapak:
If we have multiple 'globalFlags', we have to encode each one separately
on the commandline with '-global OPTION', since QEMU does not allow to
have multiple options here.
We currently only have one such flag that
On Mon, Mar 03, 2025 at 03:42:53PM +0100, Maximiliano Sandoval wrote:
> Dbus has a limit of 512 connections by default and signals should be
> disconnected as soon as they are not needed anymore.
>
> This should alleviate https://bugzilla.proxmox.com/show_bug.cgi?id=5876.
>
> Signed-off-by: Maxim
Am 06.03.25 um 13:07 schrieb Dominik Csapak:
> On 3/6/25 13:00, Fiona Ebner wrote:
>> Am 06.03.25 um 11:44 schrieb Dominik Csapak:
>>> @@ -528,3 +533,19 @@ if (my $file = shift) {
>>> }
>>> done_testing();
>>
>> Nit: Since the check below can die, I'd put it at the very beginning
>> rather th
40 matches
Mail list logo
