Maybe we should think about internally representing the Network Entity
Title and its parts as bytes rather than strings? So [u8; n]? Since in
practice it's exactly that. I think this would simplify a lot of the
methods here, and obsolete some stuff like e.g. length validation. I've
noted some parts
This uses stuff from a later patch, doesn't it? Shouldn't the order of
patches 2 and 3 be flipped?
On 2/14/25 14:39, Gabriel Goller wrote:
> This crate contains types that represent the frr config. For example it
> contains a `Router` and `Interface` struct. This Frr-Representation can
> then be c
Am 03.03.25 um 08:31 schrieb Wolfgang Bumiller:
> On Fri, Feb 28, 2025 at 03:50:18PM +0100, Fiona Ebner wrote:
>> Return the same size as in list context. See also commit "plugin: file
>> size info: be consistent about size of directory subvol".
>>
>> Fixes cloning containers with unsized subvolume
Changes in v2:
* comment out dead code in BTRFS plugin
* improve commit messages regarding clone
* squash patches 5/6 and 6/6 from v1
In list context, the file_size_info() function in Plugin.pm and the
volume_size_info() function in BTRFSPlugin.pm would return 0 for the
size, but in scalar context
The result from the file_size_info() call is not used by
volume_export_formats() and most failure scenarios of file_size_info()
lead to an undefined return value rather than a failure. This includes
the case for a non-existent file. The default path() implementation
doesn't do any existence check e
Return the same size as in list context. See also commit "plugin: file
size info: be consistent about size of directory subvol".
Fixes cloning containers with unsized subvolumes on BTRFS. Before the
change, this would fail with "mkfs.ext4: Device size reported to be
zero.". That is because with no
Superseded by v2:
https://lore.proxmox.com/pve-devel/20250303092445.13873-1-f.eb...@proxmox.com/T/#maf24450cef1ab5c66467e3ceb5c4c073fee69fa8
Am 28.02.25 um 15:50 schrieb Fiona Ebner:
> In list context, the file_size_info() function in Plugin.pm and the
> volume_size_info() function in BTRFSPlugin.
The special case of size being zero is supported if the volume is of
format 'subvol' is a special use case supported in Proxmox VE.
Signed-off-by: Fiona Ebner
---
src/PVE/API2/Storage/Content.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/Storage/Content.p
In list context, the file_size_info() function in Plugin.pm would
return 0 for the size of a subvol directory, but in scalar context 1.
As reported in the community forum [0], the change in commit e50dde0
("volume export: rely on storage plugin's format"), changing the
caller in volume_export() to
Am 20.02.25 um 15:37 schrieb Alexander Abraham:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
>
> Signed-off-by: Alexande
Am 03.03.25 um 10:03 schrieb Fiona Ebner:
> Am 03.03.25 um 08:31 schrieb Wolfgang Bumiller:
>> On Fri, Feb 28, 2025 at 03:50:18PM +0100, Fiona Ebner wrote:
>>> Return the same size as in list context. See also commit "plugin: file
>>> size info: be consistent about size of directory subvol".
>>>
>>
Hi Shannon,
sorry I only just saw this now. (Keeping up with all the emails coming in is
something I still need to get on top of.) At the time this was an oversight on
my part. Apologies for this. I was trying to get the build working and used a
suggestion I saw in an old forum post of someone
Am 28.02.25 um 13:57 schrieb Maximiliano Sandoval:
> ..before running systemctl. Allows for building packages in containers
> not managed by systemd.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> debian/pve-ha-manager.postinst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
appli
Am 03.03.25 um 10:38 schrieb Alexander Abraham:
> Keeping up with all the emails coming in is something I still need to get on
> top of.
I'd recommend setting up mail filter to move all mails that stem from a mailing
list,
i.e. have the List-Id header set, to a dedicated folder for that list. Mo
On Fri, Feb 28, 2025 at 03:50:21PM +0100, Fiona Ebner wrote:
> In the BTRFS plugin, resize_volume() for a subovlume currently fails
> with "failed to get btrfs subvolume ID from: ". This is because the
> btrfs 'subvol show' command is invoked with '-q', so there is no
> output.
Curious. This must
On Fri, Feb 28, 2025 at 03:50:22PM +0100, Fiona Ebner wrote:
> The btrfs_get_subvol_id() function is broken, because the btrfs
> 'subvol show' command is invoked with '-q', so there is no output.
>
> The function currently has no reachable caller.
>
> Signed-off-by: Fiona Ebner
> ---
> src/PVE/
Hi,
thank you for explaining this to me. I will make sure I set this up.
I did read the link that Shannon sent and of course, understood the difference
upon reading it. I wasn't quite sure which to use as the poster used the kts
variety and we are using the Groovy variety. Now I know and I'm cl
thanks!
On February 27, 2025 3:30 pm, Fiona Ebner wrote:
> When the VM is running, after deleting the tpmstate from the
> configuration, the TPM drive will still be active, because it is used
> by swtpm and QEMU will still have the TPM socket.
>
> Also, a subsequent live migration will fail, beca
In the BTRFS plugin, resize_volume() for a subovlume currently fails
with "failed to get btrfs subvolume ID from: ". This is because the
btrfs 'subvol show' command is invoked with '-q', so there is no
output.
As btrfs quotas are currently not implemented, die early with a clean
error instead and
Dbus has a limit of 512 connections by default and signals should be
disconnected as soon as they are not needed anymore.
This should alleviate https://bugzilla.proxmox.com/show_bug.cgi?id=5876.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Systemd.pm | 34 --
Could you please rebase this (patch 3 in particular doesn't apply) and
make sure everything builds debian packages properly (in ve-rs via
build.sh)?
I'll continue tomorrow with the review!
On 2/14/25 14:39, Gabriel Goller wrote:
> This series allows the user to add fabrics such as OpenFabric and
21 matches
Mail list logo
