Re: [pve-devel] [PATCH stable-7 guest-common] storage tunnel: correctly set disk-import parameters

2025-02-12 Thread Fabian Grünbichler
do we still want to bump this? do we also want to include other recent fixes for remote migration if we do so? On November 29, 2024 12:54 pm, Fiona Ebner wrote: > From: Fabian Grünbichler > > according to the schema, else some combinations of migration / guest / > storage settings will fail vali

Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]

2025-02-12 Thread Fabian Grünbichler
> Roland Kammerer via pve-devel hat am 07.02.2025 > 13:34 CET geschrieben: > On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Grünbichler wrote: > > > > > Roland Kammerer via pve-devel hat am > > > 07.02.2025 10:02 CET geschrieben: > > > Hi all, > > > > > > rather simple question I guess, bu

[pve-devel] [PATCH qemu-server v3 3/3] fix #6007: template backup: use minimized configuration for handling the full vm start

2025-02-12 Thread Fiona Ebner
Previously, the template's configuration was used as-is for the rest of handling the VM start even if config_to_command() uses a minimized configuration to build the command. This can lead to issues with a network device with the 'link_down' flag set, because the network device will not be present,

[pve-devel] [PATCH qemu-server v3 1/3] backup: also restore VM power state for early failures

2025-02-12 Thread Fiona Ebner
A failure during enforce_vm_running_for_backup() would result in restore_vm_power_state() not being called, but the VM might already have been started before the failure. In particular, this could happen in the context of bug #6007 [0], where the 'set_link' QMP command fails right after VM start.

[pve-devel] [PATCH-SERIES qemu-server v3 0/3] fix #6007: fix PBS template backup for certain configurations

2025-02-12 Thread Fiona Ebner
Changes in v3: * actually decouple config data and control flow by using a blessed object Changes in v2: * add comment about decoupling config data and metadata Fiona Ebner (3): backup: also restore VM power state for early failures config: add special class that prevents writing the configur

[pve-devel] [PATCH qemu-server v3 2/3] config: add special class that prevents writing the configuration

2025-02-12 Thread Fiona Ebner
To be used in the context of template backup, where a minimized temporary configuration is created to start the VM in 'prelaunch' mode. Issue a warning, so that code paths where this happens will be noted and can be evaluated and adapted. Since the code currently doesn't use blessed config objects

Re: [pve-devel] [PATCH network] sdn: factor out frr config generation and writing

2025-02-12 Thread Stefan Hanreich
This still has some issues (see below), maybe we can look at it together next week (will be gone after today) and see if we can make some additional structural improvements to the whole controller / frr logic? There were also some regressions/bugs with FRR config generation while testing, so this

Re: [pve-devel] [PATCH qemu 1/2] vm-network-scripts: move scripts to /usr/libexec

2025-02-12 Thread Fabian Grünbichler
On November 18, 2024 2:15 pm, Maximiliano Sandoval wrote: > > Fiona Ebner writes: > >> It's the "qemu-server" repository, not "qemu". >> >> Am 09.10.24 um 14:55 schrieb Maximiliano Sandoval: >>> Moves the network scripts from /var/lib/qemu-server into >>> /usr/libexec/qemu-server. >>> >>> /usr/l

Re: [pve-devel] [PATCH manager/nvidia-vgpu-helper v4 0/5] reduce setup steps for nvidia vgpu drivers

2025-02-12 Thread Hannes Dürr
Good point, that will certainly help one or the other. If nobody has anything against it, I would add it to V5. On 2/12/25 14:38, Dominik Csapak wrote: One super tiny nit (that's IMHO almost bike-shed territory) but otherwise LGTM: Maybe we want to print a short log line before blacklisting th

[pve-devel] [PATCH qemu-server v2 2/4] fix 4888: qmrestore: add disk-format option

2025-02-12 Thread Markus Frank
Add an option to choose a file format (qcow2, raw, vmdk) when restoring a vm backup to file based storage. This options allows all disks to be recreated with the specified file format if supported by the target storage. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 6 ++ PVE/CLI/qm

[pve-devel] [PATCH manager v2 4/4] ui: window: add disk-format option to the restore window

2025-02-12 Thread Markus Frank
This is done by changing the StorageSelector to a DiskStorageSelector. Using the hideFormatWhenStorageEmpty option of the DiskStorageSelector to hide the DiskFormatSelector when no storage is selected, as the DiskFormatSelector would show the default value qcow2 in a disabled state, which could co

[pve-devel] [PATCH storage v2 1/4] add standard option for VM disk formats in file-based storages

2025-02-12 Thread Markus Frank
Signed-off-by: Markus Frank --- src/PVE/Storage/Plugin.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 65cf43f..9f21f0b 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -354,6 +354,13 @@ sub verify_

Re: [pve-devel] [PATCH access-control v3 1/1] fix #4411: openid: add logic for openid groups support

2025-02-12 Thread Mira Limbeck
On 2/11/25 06:40, Thomas Skinner wrote: > Signed-off-by: Thomas Skinner > --- > src/PVE/API2/OpenId.pm | 79 > src/PVE/AccessControl.pm | 2 +- > src/PVE/Auth/OpenId.pm | 33 + > src/PVE/Auth/Plugin.pm | 1 + > 4 files changed, 114

Re: [pve-devel] [PATCH SERIES access-control/docs/manager/proxmox-openid v3] fix #4411: add support for openid groups

2025-02-12 Thread Mira Limbeck
On 2/11/25 06:40, Thomas Skinner wrote: > Continued work on adding support for OIDC groups. > > changes since v2: > - Move RE for group name characters to Plugin.pm > - Undo refactoring of user group deletion > - Refactor logic to use hashes instead of arrays > - Cleanup code style > - Add RE and

[pve-devel] [PATCH manager v2 3/4] ui: form: add hideFormatWhenStorageEmpty option to DiskStorageSelector

2025-02-12 Thread Markus Frank
Prerequisite for "ui: window: add diskformat option to restore window" The hide condition is copied from the format selector item in the same file. Signed-off-by: Markus Frank --- www/manager6/form/DiskStorageSelector.js | 9 + 1 file changed, 9 insertions(+) diff --git a/www/manager6/

[pve-devel] [PATCH storage/qemu-server/manager v2 0/4] Restore with a specified file format

2025-02-12 Thread Markus Frank
This patch series allows to restore all VM disks with a specified format if supported by the target storage. The existing storage and the new disk-format options can act as a default/fallback for per disk storage/format customisation in the future (#4275). v2: * renamed diskformat to disk-format *

Re: [pve-devel] [PATCH manager/nvidia-vgpu-helper v4 0/5] reduce setup steps for nvidia vgpu drivers

2025-02-12 Thread Dominik Csapak
One super tiny nit (that's IMHO almost bike-shed territory) but otherwise LGTM: Maybe we want to print a short log line before blacklisting the module? (though we can always add that later) So consider this Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak __

Re: [pve-devel] [PATCH network] sdn: factor out frr config generation and writing

2025-02-12 Thread Stefan Hanreich
On 2/11/25 21:30, Thomas Lamprecht wrote: > Looks OK otherwise, albeit I mostly skimmed it a few days ago and had > this lying around as draft, somebody else (@Stefan) checking would not > hurt. wanted to look into it, will do so today ___ pve-devel ma

Re: [pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v3 0/8] raise minimum root password length to 8 characters

2025-02-12 Thread Christoph Heiss
Ping, still applies cleanly everywhere. On Mon Dec 16, 2024 at 10:40 AM CET, Christoph Heiss wrote: > This idea came to light while talking with Shannon about #5756 [0]. > > It is 2024, so raising the minimum length for the root password as > entered during the installation from 5 to 8 characters

Re: [pve-devel] [PATCH 8/8 docs] pct: document cloudinit for LXC

2025-02-12 Thread Fiona Ebner
Planning to look at the code patches tomorrow, for now I started here :) Am 10.02.25 um 13:07 schrieb Daniel Herzig: > From: Leo Nunner > > adds documentation for Cloud-Init for containers. Most of it has been > taken from the VM documentation, since the configuration mostly works > the same. Ad