Re: [pve-devel] [PATCH docs 3/6] ceph: troubleshooting: revise and add frequently needed information

2025-02-03 Thread Max Carrara
On Mon Feb 3, 2025 at 3:27 PM CET, Alexander Zeidler wrote: > Existing information is slightly modified and retained. > > Add information: > * List which logs are usually helpful for troubleshooting > * Explain how to acknowledge listed Ceph crashes and view details > * List common causes of Ceph p

Re: [pve-devel] [PATCH docs 4/6] ceph: osd: revise and expand the section "Destroy OSDs"

2025-02-03 Thread Max Carrara
On Mon Feb 3, 2025 at 3:27 PM CET, Alexander Zeidler wrote: > Existing information is slightly modified and retained. > > Add information: > * Mention and link to the sections "Troubleshooting" and "Replace OSDs" > * CLI commands (pveceph) must be executed on the affected node > * Check in advance

Re: [pve-devel] [PATCH docs 1/6] ceph: add anchors for use in troubleshooting section

2025-02-03 Thread Max Carrara
On Mon Feb 3, 2025 at 3:27 PM CET, Alexander Zeidler wrote: > Signed-off-by: Alexander Zeidler > --- Some high-level feedback (see comments inline and in patches otherwise): - The writing style is IMO quite clear and straightforward, nice work! - In patch 03, the "_disk_health_monitoring" ancho

Re: [pve-devel] [PATCH manager v2] proxy: ui: vm console: autodetect novnc or xtermjs

2025-02-03 Thread Fiona Ebner
Am 25.11.24 um 11:04 schrieb Aaron Lauterer: > Some users configure their VMs to use serial as their display. The big > benefit is that in combination with the xtermjs remote console, copy & > paste works a lot better than via novnc. > > Unfortunately, the main console panel defaulted to novnc, no

Re: [pve-devel] [PATCH qemu-server v3 2/6] fix #4225: qemuserver: introduce sub eject_nonrequired_isos

2025-02-03 Thread Daniel Herzig
Fiona Ebner writes: > Am 31.01.25 um 14:58 schrieb Daniel Herzig: >> Fiona Ebner writes: >> >>> Am 31.01.25 um 10:36 schrieb Fiona Ebner: Am 30.01.25 um 12:31 schrieb Daniel Herzig: > + > +$drive->{essential} = 1 if !defined($drive->{essential}); This should rather be

[pve-devel] applied: [PATCH i18n] de: update translation

2025-02-03 Thread Fiona Ebner
Am 28.11.24 um 10:12 schrieb Shannon Sterz: > Signed-off-by: Shannon Sterz applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server v3 2/6] fix #4225: qemuserver: introduce sub eject_nonrequired_isos

2025-02-03 Thread Fiona Ebner
Am 31.01.25 um 14:58 schrieb Daniel Herzig: > Fiona Ebner writes: > >> Am 31.01.25 um 10:36 schrieb Fiona Ebner: >>> Am 30.01.25 um 12:31 schrieb Daniel Herzig: + +$drive->{essential} = 1 if !defined($drive->{essential}); >>> >>> This should rather be done when parsing the drive. >>

Re: [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path

2025-02-03 Thread Max Carrara
On Fri Jan 31, 2025 at 1:23 PM CET, Fiona Ebner wrote: > Am 09.01.25 um 15:48 schrieb Max Carrara: > > +=head3 path_join(@paths) > > + > > +Joins multiple paths together. All kinds of paths are supported. > > + > > +Does not perform any C>>. > > + > > +my $joined = path_join("foo", "bar/baz", "

[pve-devel] [PATCH docs 1/6] ceph: add anchors for use in troubleshooting section

2025-02-03 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- pveceph.adoc | 8 1 file changed, 8 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index da39e7f..93c2f8d 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -82,6 +82,7 @@ and vocabulary footnote:[Ceph glossary {cephdocs-url}/glossary]. +[[

[pve-devel] [PATCH docs 3/6] ceph: troubleshooting: revise and add frequently needed information

2025-02-03 Thread Alexander Zeidler
Existing information is slightly modified and retained. Add information: * List which logs are usually helpful for troubleshooting * Explain how to acknowledge listed Ceph crashes and view details * List common causes of Ceph problems and link to recommendations for a healthy cluster * Briefly d

[pve-devel] [PATCH docs 4/6] ceph: osd: revise and expand the section "Destroy OSDs"

2025-02-03 Thread Alexander Zeidler
Existing information is slightly modified and retained. Add information: * Mention and link to the sections "Troubleshooting" and "Replace OSDs" * CLI commands (pveceph) must be executed on the affected node * Check in advance the "Used (%)" of OSDs to avoid blocked I/O * Check and wait until the

[pve-devel] [PATCH docs 6/6] pvecm: remove node: mention Ceph and its steps for safe removal

2025-02-03 Thread Alexander Zeidler
as it has already been missed in the past or the proper procedure was not known. Signed-off-by: Alexander Zeidler --- pvecm.adoc | 47 +++ 1 file changed, 47 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index 15dda4e..8026de4 100644 --- a/pvecm.

Re: [pve-devel] [PATCH v3 pve-common 11/12] introduce PVE::Filesystem

2025-02-03 Thread Max Carrara
On Fri Jan 31, 2025 at 1:44 PM CET, Fiona Ebner wrote: > Am 09.01.25 um 15:48 schrieb Max Carrara: > > + > > +sub fs_canonicalize : prototype($) { > > +my ($path) = @_; > > + > > +croak "\$path is undef" if !defined($path); > > + > > +my $canonicalized_path = Cwd::abs_path($path); > > +

[pve-devel] [PATCH docs 5/6] ceph: maintenance: revise and expand section "Replace OSDs"

2025-02-03 Thread Alexander Zeidler
Remove redundant information that is already described in section “Destroy OSDs” and link to it. Mention and link to the troubleshooting section, as replacing the OSD may not fix the underyling problem. Mention that the replacement disk should be of the same type and size and comply with the reco

Re: [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path

2025-02-03 Thread Fiona Ebner
Am 03.02.25 um 15:21 schrieb Max Carrara: > On Fri Jan 31, 2025 at 1:23 PM CET, Fiona Ebner wrote: >> Am 09.01.25 um 15:48 schrieb Max Carrara: >> >> Why this kind of behavior with absolute paths? Seems surprising to me. >> Wouldn't failing the call be better? > > I decided to stick with Rust's be

[pve-devel] applied: [PATCH common] tools: explain reason for the explicit PerlIO load

2025-02-03 Thread Fiona Ebner
Am 02.12.24 um 17:03 schrieb Filip Schauer: > Explain the reason for the explicit `use PerlIO::scalar;` statement > introduced in c4945bf ("tools: load PerlIO explicitly to avoid odd > failures") > > Signed-off-by: Filip Schauer > --- > src/PVE/Tools.pm | 12 ++-- > 1 file changed, 6 ins

[pve-devel] [PATCH pve-docs v2 0/2] PVE docs: Made small edits.

2025-02-03 Thread Alexander Abraham
Split a long sentence in the section on Swap on ZFS and fixed some typos. Alexander Abraham (2): Section on ZFS and swap corrected. PVE docs: Made small edits. local-zfs.adoc | 37 ++--- 1 file changed, 2 insertions(+), 35 deletions(-) -- 2.39.5 _

[pve-devel] [PATCH pve-docs v2 1/2] Section on ZFS and swap corrected.

2025-02-03 Thread Alexander Abraham
--- local-zfs.adoc | 36 +--- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index c64fb27..bcd02f7 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -627,41 +627,7 @@ You *must reboot* to activate these changes. SWA

[pve-devel] [PATCH pve-docs v2 2/2] PVE docs: Made small edits.

2025-02-03 Thread Alexander Abraham
A long sentence in the section about Swap on ZFS was split into two sentences and some typos were corrected. Signed-off-by: Alexander Abraham --- local-zfs.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index bcd02f7..b662233 100644 ---

[pve-devel] [PATCH docs 2/6] ceph: correct heading capitalization

2025-02-03 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 93c2f8d..90bb975 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -768,7 +768,7 @@ Nautilus: PG merging and autotuning]. [[pve_ceph_dev

[pve-devel] applied: [PATCH manager] api: nodes: add more return descriptions for node status

2025-02-03 Thread Fiona Ebner
Am 16.12.24 um 17:03 schrieb Dominik Csapak: > it's not all fields, but many useful ones > > Signed-off-by: Dominik Csapak For the record, this was already applied: https://git.proxmox.com/?p=pve-manager.git;a=commit;h=80cc262f255d409a06c4b64a5a87330407dc2b46 __

Re: [pve-devel] [PATCH access-control] api: role: remove role references from acl rules on role deletion

2025-02-03 Thread Fiona Ebner
Am 04.12.24 um 16:11 schrieb Daniel Kral: > Let the API endpoint `DELETE /access/roles/{roleid}` or command > `pveum role delete ` remove any ACL rules in the user > configuration, which reference the removed role. > > Before this change, the removal of a role has caused the role to remain > in ex

Re: [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path

2025-02-03 Thread Max Carrara
On Mon Feb 3, 2025 at 4:42 PM CET, Fiona Ebner wrote: > Am 03.02.25 um 15:21 schrieb Max Carrara: > > On Fri Jan 31, 2025 at 1:23 PM CET, Fiona Ebner wrote: > >> Am 09.01.25 um 15:48 schrieb Max Carrara: > >> > >> Why this kind of behavior with absolute paths? Seems surprising to me. > >> Wouldn't

Re: [pve-devel] [PATCH pve-docs v2 1/2] Section on ZFS and swap corrected.

2025-02-03 Thread Fiona Ebner
The subject prefix is correct now. But it seems like most of the other feedback given for v1 still applies [0]. Also, there is no need to have two separate patches if you just fix up the changes you just introduced in the second one. Then the patches can be squashed together into a single one. [0

Re: [pve-devel] [PATCH pve-docs v2 1/2] Section on ZFS and swap corrected.

2025-02-03 Thread Alexander Zeidler
IIRC, there have been some considerations in the past to move the "SWAP on ZFS" section to the chapter "Host System Administration". If doing so: 1. It could be renamed to "SWAP" and, with the current layout, placed between "Disk Health Monitoring" and "Logical Volume Manager (LVM)"? 2. Update

Re: [pve-devel] [PATCH qemu-server v3 2/6] fix #4225: qemuserver: introduce sub eject_nonrequired_isos

2025-02-03 Thread Fiona Ebner
Am 03.02.25 um 11:15 schrieb Daniel Herzig: > Fiona Ebner writes: > >> Am 31.01.25 um 14:58 schrieb Daniel Herzig: >>> Fiona Ebner writes: >>> Am 31.01.25 um 10:36 schrieb Fiona Ebner: > Am 30.01.25 um 12:31 schrieb Daniel Herzig: >> + >> +$drive->{essential} = 1 if !defined

Re: [pve-devel] [PATCH qemu-server v3 2/6] fix #4225: qemuserver: introduce sub eject_nonrequired_isos

2025-02-03 Thread Fiona Ebner
Am 03.02.25 um 14:09 schrieb Fiona Ebner: > This is problematic for live migration, see my initial reply. Either we > need to drop the CD from the config or we need another option "missing" > that gets set if it is missing during start-up (and cleared if it is > there during startup). Then the targ

Re: [pve-devel] [PATCH pve-storage] qcow2: resize: add preallocation support

2025-02-03 Thread Fiona Ebner
Am 19.12.24 um 17:18 schrieb Alexandre Derumier via pve-devel: > Seem that we totally forgot to add it, it's available since 2017 > https://www.mail-archive.com/qemu-devel@nongnu.org/msg436979.html Nit: it's better to link to the commit rather than the mailing list for things that are already appl

Re: [pve-devel] [PATCH pve-storage] qcow2: resize: add preallocation support

2025-02-03 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Message initial De: Fiona Ebner À: Proxmox VE development discussion Cc: Alexandre Derumier Objet: Re: [pve-devel] [PATCH pve-storage] qcow2: resize: add preallocation support Date: 03/02/2025 15:39:41 Am 19.12.24 um 17:18 schrieb Alexandre Derumier via p