Re: [pve-devel] [PATCH v3 pve-storage 2/3] lvmplugin: add qcow2 snapshot

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>one downside with this part in particular - we have to always >>allocate full-size LVs (+qcow2 overhead), even if most of them will >>end up storing just a single snapshot delta which might be a tiny >>part of that full-size.. hopefully if discard is working across the >>who

Re: [pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-01-10 Thread Fiona Ebner
Am 10.01.25 um 08:44 schrieb DERUMIER, Alexandre via pve-devel: > Message initial > De: Fabian Grünbichler > À: Proxmox VE development discussion > Cc: Alexandre Derumier > Objet: Re: [pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve- > qemu] add external qcow2 snapshot

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>Maybe it could even be a bug then?  Yes, it's a bug. I just think that libvirt currently only implement block-commit with disk blockdev on topnode. throttle group are not currently implement in libvirt (but I have seen some commit to add support recently), they still use

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2025-01-10 Thread Fabio Fantoni via pve-devel
--- Begin Message --- Signed-off-by: Fabio Fantoni --- it.po | 67 +-- 1 file changed, 38 insertions(+), 29 deletions(-) diff --git a/it.po b/it.po index b098eb2..5dc0252 100644 --- a/it.po +++ b/it.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id

Re: [pve-devel] [PATCH v3 pve-storage 1/3] qcow2: add external snapshot support

2025-01-10 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 10.01.2025 > 10:10 CET geschrieben: > > +    if ($scfg->{snapext}) { > > + #technically, we could manage multibranch, we it need lot more work > > for snapshot delete > > + #we need to implemente block-stream from deleted snapshot to all > > others child branchs > >

Re: [pve-devel] [PATCH v3 pve-storage 1/3] qcow2: add external snapshot support

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>yes, for the "first" snapshot that is true (since that one is >>basically the baseline data, which will often be huge compared to the >>snapshot delta). but streaming (rebasing) saves us the rename, which >>makes the error handling a lot easier/less risky. maybe we could >sp

Re: [pve-devel] [PATCH v3 qemu-server 03/11] blockdev : convert qemu_driveadd && qemu_drivedel

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Message initial De: Fabian Grünbichler À: Proxmox VE development discussion Cc: Alexandre Derumier Objet: Re: [pve-devel] [PATCH v3 qemu-server 03/11] blockdev : convert qemu_driveadd && qemu_drivedel Date: 08/01/2025 15:26:37 > Alexandre Derumier via pv

Re: [pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Message initial De: Fiona Ebner À: Proxmox VE development discussion , f.gruenbich...@proxmox.com Cc: "DERUMIER, Alexandre" Objet: Re: [pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve- qemu] add external qcow2 snapshot support Date: 10/01/2025 10:5

[pve-devel] better BTRFS integration

2025-01-10 Thread Udo Rader
Hi, I have been using PVE with BTRFS as root on some nodes for some time now and all in all it seems to work quite well. What is missing, however, is a deeper integration into the user interface, for example. Browsing through the ML archives, I see that every now and then something has been do

Re: [pve-devel] [PATCH v3 qemu-server 01/11] blockdev: cmdline: convert drive to blockdev syntax

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > - $device .= ",drive=drive-$drive_id,id=$drive_id"; > + $device .= ",id=$drive_id"; > + $device .= ",drive=drive-$drive_id" if $device_type ne 'cd' || > $drive->{file} ne 'none'; >>is this just because you remove the whole drive when ejecting? not >>sure whether that is re

Re: [pve-devel] [PATCH v3 pve-storage 1/3] qcow2: add external snapshot support

2025-01-10 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 10.01.2025 > 12:51 CET geschrieben: > > > + } else { > > > +     print"commit $snappath\n"; > > > +     $cmd = ['/usr/bin/qemu-img', 'commit', $snappath]; > > > > > > leftover from previous version? not used/overwritten below ;) > > > > no, this is really to commit

Re: [pve-devel] [PATCH docs v2 6/6] pveceph: add section for rbd namespaces

2025-01-10 Thread Aaron Lauterer
thanks. I can send a follow-up if the rest of the series does not require a v3 On 2025-01-02 14:46, Alexander Zeidler wrote: On Mon Dec 23, 2024 at 5:00 PM CET, Aaron Lauterer wrote: and a few basic examples on how to manage them. Signed-off-by: Aaron Lauterer --- changes since v1: none

[pve-devel] [PATCH v2 proxmox-i18n] update Italian translations

2025-01-10 Thread Fabio Fantoni via pve-devel
--- Begin Message --- Signed-off-by: Fabio Fantoni --- Changes in v2: fix other small error in 3 of the changed strings it.po | 67 +-- 1 file changed, 38 insertions(+), 29 deletions(-) diff --git a/it.po b/it.po index b098eb2..f591920 100

Re: [pve-devel] [PATCH v3 pve-storage 1/3] qcow2: add external snapshot support

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>but you don't know up front that you want to collapse all the >>snapshots. for each single removal, you have to merge the delta >>towards the overlay, not the base, else the base contents is no >>longer matching its name. >> >>think about it this way: >> >>you take a snapsho

Re: [pve-devel] [PATCH docs v2 1/2] pvesr: update the chapter and bring it into good condition

2025-01-10 Thread Alexander Zeidler
On Wed Jan 8, 2025 at 11:34 AM CET, Daniel Kral wrote: > Thanks a lot for taking the time to rewrite this! Your changed text > reads great and it feels like the right information is pointed to at the > right time. I've added a few notes inline below. Thank you for the review! Most suggestions are

[pve-devel] [PATCH qemu-server] api: vmlist: add plugged cpu count to vmlist table

2025-01-10 Thread Daniel Kral
Includes the maximum amount of cpu cores in the vmlist as it semantically fits in with the other properties. This allows for a more comfortable view of a node's VM configured CPU core counts in general and by users of "pvereport" without calculating each core count manually with the respective VM's

[pve-devel] [PATCH qemu-server] api: create disks: also convert tpmstate and efidisk to base image for templates

2025-01-10 Thread Daniel Kral
The commit 37a1f42a introduced a conversion step for newly allocated volume disks to base volumes for VM templates. This wrongly excluded efidisk and tmpstate volumes from this conversion, even though those should be converted to base volumes too. Therefore, include efidisks and tpmstate volumes t

Re: [pve-devel] [PATCH container] vncproxy/termproxy: use SSHInfo helpers

2025-01-10 Thread Friedrich Weber
On 31/10/2024 11:16, Fabian Grünbichler wrote: > to pick up the pinned host keys, instead of relying on them being in the local > root user's known hosts file. > > Signed-off-by: Fabian Grünbichler > --- applied this patch and - set up two nodes A and B - ran container C on B - navigated to GUI

[pve-devel] [PATCH docs v3 1/2] pvesr: update the chapter and bring it into good condition

2025-01-10 Thread Alexander Zeidler
Existing information is preserved in a restructured way and usefully supplemented. * restructure and revise the introduction * add subchapter "Considerations" * remove the subchapter "Schedule Format" with its one line of content and link where appropriate directly to the copy under "25. Appendi

[pve-devel] [PATCH manager v3 2/2] replication: update help button reference

2025-01-10 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- v3: * no changes v2: https://lore.proxmox.com/pve-devel/20241218161948.3-2-a.zeid...@proxmox.com/ www/manager6/grid/Replication.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replic

[pve-devel] [RFC PATCH 2/2] common: btrfs: lower minimum amount of disks for raid10 to 2

2025-01-10 Thread Daniel Kral
As the installer allows single-disk RAID0 configurations and BTRFS allows to create a filesystem with the RAID10 profile with only two disks since kernel version 5.15 [0], lower the minimum amount of disks the installer requires for a BTRFS RAID10 setup. The motiviation for this is to allow users

[pve-devel] [RFC PATCH 1/2] install: btrfs: fix raid level falling back to single mode

2025-01-10 Thread Daniel Kral
>From a user's perspective, the BTRFS single mode has been removed since d85180e ("tui: rename raid levels 0/1 to align with GUI installer"). The user can now only select at least the "RAID0" level, but if a user selects any raid level with only one disk configured on the system, BTRFS will be setu

Re: [pve-devel] [PATCH v3 pve-storage 1/3] qcow2: add external snapshot support

2025-01-10 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > @@ -710,11 +715,15 @@ sub filesystem_path { > # Note: qcow2/qed has internal snapshot, so path is always > # the same (with or without snapshot => same file). > die "can't snapshot this image format\n" > - if defined($snapname) && $format !~ m/^(qcow2|qed)$/;

Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2025-01-10 Thread Fiona Ebner
Am 10.01.25 um 08:55 schrieb DERUMIER, Alexandre: > Message initial > De: Fabian Grünbichler > À: Proxmox VE development discussion > Cc: Alexandre Derumier , Fiona > Ebner > Objet: Re: [pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit- > replaces option patch > Date: 08/01/