Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types

2024-12-18 Thread Daniel Kral
On 12/17/24 10:32, Dominik Csapak wrote: namely 'cpu' and 'mem' Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b3d5f8f2..98bc07c2 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuSer

Re: [pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration

2024-12-18 Thread Daniel Kral
On 12/18/24 11:32, Fiona Ebner wrote: [ ... ] --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -303,6 +303,7 @@ sub phase1 { if ($remote) { push @$migratable_storages, 'cifs'; push @$migratable_storages, 'nfs'; + push @$migrata

Re: [pve-devel] [PATCH v2 storage 05/10] rbd plugin: implement volume import/export

2024-12-18 Thread Daniel Kral
On 12/17/24 16:48, Fiona Ebner wrote: [ ... ] + +die "volume export format $format not available for $class\n" if $format ne 'raw+size'; +die "cannot export volumes together with their snapshots in $class\n" if $with_snapshots; +die "cannot export an incremental stream in $class\n"

Re: [pve-devel] [PATCH v2 storage 05/10] rbd plugin: implement volume import/export

2024-12-18 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>Am 18.12.24 um 15:20 schrieb Daniel Kral: > >>- When exporting with "pvesm export ...", the volume has the same > checksum as with "rbd export ..." with the size header prepended >>Well, I totally missed the existence of "rbd export" in my hurry to >>get >>this working. See

[pve-devel] applied: [PATCH qemu-server] vmstatus: make memory description consistent with pve-container

2024-12-18 Thread Thomas Lamprecht
Am 18.12.24 um 16:12 schrieb Daniel Kral: > Fixes a small typo and uses the same wording as used in pve-container's > description of the `mem` property. > > Signed-off-by: Daniel Kral > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! _

[pve-devel] [PATCH docs] pvesr: update the chapter and bring it into good condition

2024-12-18 Thread Alexander Zeidler
* restructure and revise the introduction * add subchapter "Recommendations" * remove the subchapter "Schedule Format" with its one line of content and link where appropriate directly to the copy under "25. Appendix D: Calendar Events". The help button at adding/editing a job links now to the

[pve-devel] [PATCH docs v2 1/2] pvesr: update the chapter and bring it into good condition

2024-12-18 Thread Alexander Zeidler
* restructure and revise the introduction * add subchapter "Recommendations" * remove the subchapter "Schedule Format" with its one line of content and link where appropriate directly to the copy under "25. Appendix D: Calendar Events". The help button at adding/editing a job links now to the

[pve-devel] [PATCH manager v2 2/2] replication: update help button reference

2024-12-18 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- www/manager6/grid/Replication.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js index 79824b9b..51aa9fde 100644 --- a/www/manager6/grid/Replication.js +++ b/www/manager6/g

Re: [pve-devel] [PATCH docs] pvesr: update the chapter and bring it into good condition

2024-12-18 Thread Alexander Zeidler
v2: https://lore.proxmox.com/pve-devel/20241218161948.3-1-a.zeid...@proxmox.com/T/#t ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] api: migration preconditions: add more return type information

2024-12-18 Thread Thomas Lamprecht
Am 18.12.24 um 12:54 schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 49 +++- > 1 file changed, 48 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing

Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types

2024-12-18 Thread Dominik Csapak
On 12/18/24 3:44 PM, Daniel Kral wrote: On 12/17/24 10:32, Dominik Csapak wrote: namely 'cpu' and 'mem' Signed-off-by: Dominik Csapak ---   PVE/QemuServer.pm | 11 +++   1 file changed, 11 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b3d5f8f2..98bc07c2 10064

Re: [pve-devel] [PATCH v2 storage 01/10] iscsi direct plugin: fix return value for path() method in non-array context

2024-12-18 Thread Fiona Ebner
Am 17.12.24 um 16:48 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > > New in v2. > > src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm > b/src/PVE/Storage/ISCSIDirectPlugin.pm > index e

Re: [pve-devel] [PATCH v2 storage 01/10] iscsi direct plugin: fix return value for path() method in non-array context

2024-12-18 Thread Fiona Ebner
Am 18.12.24 um 14:39 schrieb Fiona Ebner: > Am 17.12.24 um 16:48 schrieb Fiona Ebner: >> Signed-off-by: Fiona Ebner >> --- >> >> New in v2. >> >> src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm

Re: [pve-devel] [PATCH v2 storage 06/10] iscsi plugin: support volume export

2024-12-18 Thread Filip Schauer
I tested exporting a volume from an iSCSI storage. First I installed Debian in a VM on a LUN and then exported the volume: ``` $ pvesm export tgtstorage:0.0.1.scsi-36e010001 raw+size output 3915055104 bytes (3.9 GB, 3.6 GiB) copied, 11 s, 356 MB/s 65472+0 records in 6547

Re: [pve-devel] [PATCH v2 storage 07/10] iscsi direct plugin: support volume export

2024-12-18 Thread Filip Schauer
To test exporting a volume from the `iscsidirect` storage backend, I installed `libiscsi-bin` and configured the storage in `/etc/pve/storage.cfg` by using the same options as I used for the `iscsi` storage. ``` $ pvesm export tgtdirectstorage:lun1 raw+size output ``` Then I imported the volume

Re: [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages

2024-12-18 Thread Aaron Lauterer
Did a high-level test between a PVE+Ceph cluster and a single PVE node with the remote-migration of a Windows Server 2022 VM with EFI & TPM disks. Ceph RBD -> remote LVM thin LVM thin -> remote Ceph RBD Worked in both directions, and the VM booted up as expected after each migration. One thi

[pve-devel] [PATCH qemu-server] vmstatus: make memory description consistent with pve-container

2024-12-18 Thread Daniel Kral
Fixes a small typo and uses the same wording as used in pve-container's description of the `mem` property. Signed-off-by: Daniel Kral --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 90d43b78..5cde94a1 100644 --

Re: [pve-devel] [PATCH v2 storage 05/10] rbd plugin: implement volume import/export

2024-12-18 Thread Fiona Ebner
Am 18.12.24 um 15:20 schrieb Daniel Kral: > - When exporting with "pvesm export ...", the volume has the same > checksum as with "rbd export ..." with the size header prepended Well, I totally missed the existence of "rbd export" in my hurry to get this working. Seems to be about 1.5 times faster

Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types

2024-12-18 Thread Daniel Kral
On 12/18/24 16:01, Dominik Csapak wrote: not really, i was probably not careful enough when writing both ;) since this was already applied, you could send a followup to fix both issues (if you want, otherwise I'll see when i can find the time for this) Perfect, sent a quick patch to the list

[pve-devel] [PATCH qemu-server] api: migration preconditions: add more return type information

2024-12-18 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 49 +++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c7f45051..db356b7e 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -4581,27 +45

Re: [pve-devel] [PATCH v2 storage 09/10] common: introduce common module

2024-12-18 Thread Fiona Ebner
Am 18.12.24 um 10:36 schrieb Max Carrara: > On Tue Dec 17, 2024 at 4:48 PM CET, Fiona Ebner wrote: >> From: Max Carrara >> >> This module's purpose is to provide shared functions, constants, etc. >> for storage plugins and storage-related operations. >> >> It also contains the `get_deprecation_war

[pve-devel] [PATCH container 1/2] migration: allow rbd storages for remote migration

2024-12-18 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- This is a follow-up for: https://lore.proxmox.com/pve-devel/20241217154814.82121-1-f.eb...@proxmox.com/T/#m669d0a02ebf10ab54ad18f27589902ee0b2cbace src/PVE/LXC/Migrate.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migr

[pve-devel] [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9

2024-12-18 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- src/PVE/LXC/Migrate.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index e1e6cab..a550d70 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -292,6 +292,8 @@ sub phase1 { my ($sid

[pve-devel] maintenance downtime of lore.proxmox.com (list-archive)

2024-12-18 Thread Stoiko Ivanov
Hi, We will run maintenance on parts of our infrastructure, which hosts https://lore.proxmox.com - our public-inbox instance used for archiving our mailing-lists. The service will be unavailable for a short period. Best Regards, Stoiko Ivanov ___ pve

Re: [pve-devel] [PATCH v2 storage 00/10] import/export for shared storages

2024-12-18 Thread Fiona Ebner
Sent a follow-up for container remote migration: https://lore.proxmox.com/pve-devel/20241218103206.20822-1-f.eb...@proxmox.com/T/#u ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 storage 09/10] common: introduce common module

2024-12-18 Thread Max Carrara
On Tue Dec 17, 2024 at 4:48 PM CET, Fiona Ebner wrote: > From: Max Carrara > > This module's purpose is to provide shared functions, constants, etc. > for storage plugins and storage-related operations. > > It also contains the `get_deprecation_warning` subroutine that makes > it easier to warn de