[pve-devel] [PATCH proxmox-backup] python3.12 compat: docs/_ext/proxmox-scanrefs.py: cast to string for re.sub()

2024-12-16 Thread Jing Luo via pve-devel
--- Begin Message --- This fixes a FTBFS with python 3.12. We need to cast "filename" to string. Sphinx version: 8.1.3 Python version: 3.12.8 (CPython) Docutils version: 0.21.2 Jinja2 version: 3.1.3 Pygments version: 2.18.0 Last messages: copying assets... copying assets: done writin

[pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v3 0/8] raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
This idea came to light while talking with Shannon about #5756 [0]. It is 2024, so raising the minimum length for the root password as entered during the installation from 5 to 8 characters seems very sensible. NIST also recommends a minimum length of 8 characters for passwords [1]. See also the

[pve-devel] [PATCH installer v3 5/8] auto: add negative tests for root password option

2024-12-16 Thread Christoph Heiss
Extends our test runner for the parse-answer tests to also run some tests which are expected to fail, with a pre-determined error message given in the accompanying json. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased; use separate test function for tests instead of retro-fit

[pve-devel] [PATCH pmg-docs v3 7/8] installation: adapt to raised root password length requirement

2024-12-16 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v1 -> v2: * new patch pmg-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pmg-installation

[pve-devel] [PATCH installer v3 1/8] common: convert `InstallRootPassword` into an enum

2024-12-16 Thread Christoph Heiss
It's more appropriate for that type of data, since only one of both variants is ever allowed to be set. Makes it also a bit more ergonomic to handle. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * added rustdoc for `InstallRootPassword` Changes v1 -> v2: * new patch proxmox-auto-in

[pve-devel] [PATCH proxmox-backup v3 8/8] using-the-installer: adapt to raised root password length requirement

2024-12-16 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v1 -> v2: * new patch docs/using-the-installer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/usin

[pve-devel] [PATCH installer v3 2/8] proxinstall: raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * no changes Changes v1 -> v2: * rebased on

[pve-devel] [PATCH installer v3 4/8] auto: raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. While at it, refactor the `InstallRootPassword` struct into an enum, as suggested by Stefan. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-o

[pve-devel] [PATCH installer v3 3/8] tui: raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
.. in accordance with current NIST recommendations [0]. It's 2024; so reasonable to expect an 8-character-password at the minimum. [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * no changes Changes v1 -> v2: * rebased on

[pve-devel] [PATCH pve-docs v3 6/8] installation: adapt to raised root password length requirement

2024-12-16 Thread Christoph Heiss
It's been raised in the installer across the board, so adapt it here too. Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * rebased on latest master Changes v1 -> v2: * new patch pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation

[pve-devel] [PATCH container 1/3] extract apparmor profile & namespace switch to its own helper

2024-12-16 Thread Filip Schauer
Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 71 +- 1 file changed, 41 insertions(+), 30 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index e78e365..12a4378 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1982,15 +1982,42 @@

[pve-devel] [PATCH container 2/3] config: support printing a device

2024-12-16 Thread Filip Schauer
Signed-off-by: Filip Schauer --- src/PVE/LXC/Config.pm | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 5cc37f7..b44bcce 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1333,6 +1333,14 @@ s

[pve-devel] [PATCH container 0/3] implement device hotplug

2024-12-16 Thread Filip Schauer
Filip Schauer (3): extract apparmor profile & namespace switch to its own helper config: support printing a device implement device hotplug src/PVE/LXC.pm| 164 ++ src/PVE/LXC/Config.pm | 35 +++-- 2 files changed, 163 insertions(+), 36 d

[pve-devel] [PATCH container 3/3] implement device hotplug

2024-12-16 Thread Filip Schauer
Signed-off-by: Filip Schauer --- src/PVE/LXC.pm| 93 ++- src/PVE/LXC/Config.pm | 19 + 2 files changed, 111 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 12a4378..06902a1 100644 --- a/src/PVE/LXC.pm +++ b/s

[pve-devel] [PATCH v3 qemu-server 02/11] blockdev: fix cfg2cmd tests

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- test/cfg2cmd/bootorder-empty.conf.cmd | 12 ++ test/cfg2cmd/bootorder-legacy.conf.cmd| 12 ++ test/cfg2cmd/bootorder.conf.cmd | 12 ++ ...putype-icelake-client-deprecation.conf.cmd |

[pve-devel] [PATCH v3 qemu-server 10/11] blockdev: add backing_chain support

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- We need to define name-nodes for all backing chain images, to be able to live rename them with blockdev-reopen For linked clone, we don't need to definebase image(s) chain. They are auto added with #block nodename. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm |

[pve-devel] [PATCH v3 qemu-server 01/11] blockdev: cmdline: convert drive to blockdev syntax

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- The blockdev chain is: -throttle-group-node (drive-(ide|scsi|virtio)x) - format-node (fmt-drive-x) - file-node (file-drive -x) fixme: implement iscsi:// path Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 351 +++--

[pve-devel] [PATCH v3 qemu-server 05/11] blockdev: convert cdrom media eject/insert

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 3b33fd7d..758c8240 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5694,7 +5694

[pve-devel] [PATCH v3 qemu-server 03/11] blockdev : convert qemu_driveadd && qemu_drivedel

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- fixme/testme : PVE/VZDump/QemuServer.pm:eval { PVE::QemuServer::qemu_drivedel($vmid, "tpmstate0-backup"); }; Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 64 +-- 1 file changed, 45 insertions(+), 19 deletions(-)

[pve-devel] [PATCH v3 qemu-server 06/11] blockdev: block_resize: convert to blockdev

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- We need to use the top blocknode (throttle) as name-node Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 758c8240..22b011e1 100644 --- a/PVE/QemuServer.pm

[pve-devel] [PATCH v3 pve-storage 1/3] qcow2: add external snapshot support

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/DirPlugin.pm | 1 + src/PVE/Storage/Plugin.pm| 207 +-- 2 files changed, 176 insertions(+), 32 deletions(-) diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm i

[pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This patch series implement qcow2 external snapshot support for files && lvm volumes The current internal qcow2 snapshots have bad write performance because no metadatas can be preallocated. This is particulary visible on a shared filesystem like ocfs2 or gfs2. Also other

[pve-devel] [PATCH v3 qemu-server 09/11] blockdev: mirror: change aio on target if io_uring is not default.

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This was a limitation of drive-mirror, blockdev mirror is able to reopen image with a different aio Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 41 ++--- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/PVE/Qe

[pve-devel] [PATCH v3 qemu-server 11/11] qcow2: add external snapshot support

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuConfig.pm | 4 +- PVE/QemuServer.pm | 345 -- 2 files changed, 335 insertions(+), 14 deletions(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index ffdf9f03..c17edb46 100644 -

[pve-devel] [PATCH v3 qemu-server 07/11] blockdev: nbd_export: block-export-add : use drive-$id for nodename

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- we have fixed nodename now Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 22b011e1..6bebb906 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm

[pve-devel] [PATCH v3 pve-storage 2/3] lvmplugin: add qcow2 snapshot

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/LVMPlugin.pm | 231 --- 1 file changed, 213 insertions(+), 18 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 88fd612..1257cd3 100644 --- a/src/

[pve-devel] [PATCH v1 pve-qemu 1/1] add block-commit-replaces option patch

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This is needed for external snapshot live commit, when the top blocknode is not the fmt-node. (in our case, the throttle-group node is the topnode) Signed-off-by: Alexandre Derumier --- ...052-block-commit-add-replaces-option.patch | 137 ++ debian/patches/s

[pve-devel] [PATCH v3 qemu-server 04/11] blockdev: vm_devices_list : fix block-query

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Look at qdev value, as cdrom drives can be empty without any inserted media Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index baf78ec0..3b33fd7d 1006

[pve-devel] [PATCH v3 pve-storage 3/3] storage: vdisk_free: remove external snapshots

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage.pm | 18 +- src/test/run_test_zfspoolplugin.pl | 18 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index 3b4f041.

[pve-devel] [PATCH v3 qemu-server 08/11] blockdev: convert drive_mirror to blockdev_mirror

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- PVE/QemuMigrate.pm | 2 +- PVE/QemuServer.pm | 106 +++-- 2 files changed, 83 insertions(+), 25 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index ed5ede30..88627ce4 100644

Re: [pve-devel] [PATCH network 2/4] fix #5900: add helper functions

2024-12-16 Thread Daniel Herzig
Hey Stefan, thanks for the feedback! Stefan Hanreich writes: > > If we do it this way (see top-level discussion), I think we should > abstract this into the IpamPlugins itself, since this implementation is > specific to the PVE Plugin, but that's just one type of IPAM plugin. > Something like:

Re: [pve-devel] [PATCH guest-common 1/4] fix #5900: add helper function

2024-12-16 Thread Daniel Herzig
Hi Stefan, thanks for the feedback. Thanks for hinting at ~PVE::LXC::Config::parse_lxc_network~. I oversaw that and did not want to pull ~PVE::QemuServer::parse_net~ into LXC's deps. Stefan Hanreich writes: > On 12/5/24 17:33, Daniel Herzig wrote: >> This patch adds a small helper function to

[pve-devel] [PATCH pve-docs] sdn: evpn: add a note about nf_conntrack_allow_invalid with multiple exit-nodes

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- reported on the forum: https://forum.proxmox.com/threads/evpn-vpls-with-multi-exit-nodes-firewall-drop-packet-with-asymetric-routing.158225 With multiple exit-nodes, traffic can be asymetric, so we need to enable invalid conntrack Signed-off-by: Alexandre Derumier --- pve

[pve-devel] [PATCH pve-firewall] rename sysctl.d/pve-firewall.conf to 10-pve-firewall.conf

2024-12-16 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Currently, It's not possible to override the values in sysctl.conf because pve-firewall.conf is exected after. * Applying /usr/lib/sysctl.d/10-pve-ct-inotify-limits.conf ... * Applying /usr/lib/sysctl.d/10-pve.conf ... * Applying /etc/sysctl.d/30-ceph-osd.conf ... * Applying

Re: [pve-devel] [PATCH installer/{pve, pmg}-docs/proxmox-backup v2 0/8] raise minimum root password length to 8 characters

2024-12-16 Thread Christoph Heiss
v2: https://lore.proxmox.com/pve-devel/20241216094114.476756-1-c.he...@proxmox.com/ On Fri Nov 29, 2024 at 1:21 PM CET, Christoph Heiss wrote: > [..] ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/list

[pve-devel] [PATCH manager] api: nodes: add more return descriptions for node status

2024-12-16 Thread Dominik Csapak
it's not all fields, but many useful ones Signed-off-by: Dominik Csapak --- PVE/API2/Nodes.pm | 75 +++ 1 file changed, 75 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index e8ff6dd9..9cdf19db 100644 --- a/PVE/API2/Nodes.pm +++ b/P