Re: [pve-devel] [PATCH container/manager v2 0/3] Show container ip in summary and network tab

there is both a bugzilla entry for this, and a patch as well: https://lore.proxmox.com/pve-devel/mailman.710.1713473387.450.pve-de...@lists.proxmox.com/ granted, both happened after Leo's initial patch below, but please still coordinate/communicate with Johannes as well ;) On December 10, 2024 4

[pve-devel] [PATCH qemu-server 1/3] api: clone: always do a full clone of tpmstate volumes

since there is no reliable way to check whether a linked clone would end up being something other than a raw file, and the volumes are tiny anyway. otherwise on directory storages, the following sequence of events could happen: - linked clone using raw file as base and qcow2 as overlay - swtpm_set

[pve-devel] [PATCH qemu-server 2/3] swtpm: check that format of tpmstate volume is raw

since swtpm currently doesn't support anything else, and might overwrite a file using qcow2 or vmdk format by accident.. Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8192599a..fe7984eb 10

[pve-devel] [PATCH qemu-server 3/3] swtpm: drop unused $volname variable

Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index fe7984eb..e1ee328c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3210,7 +3210,7 @@ sub start_swtpm { my $stat

[pve-devel] [PATCH qemu-server 0/3] fix tpmstate format issues

pre-existing bug exposed by our new format checks, reported on the forum: https://forum.proxmox.com/threads/backup-vm-failed-after-upgrade-to-new-version.158926/ Fabian Grünbichler (3): api: clone: always do a full clone of tpmstate volumes swtpm: check that format of tpmstate volume is raw

Re: [pve-devel] [PATCH qemu-server 3/3] swtpm: drop unused $volname variable

Am 12.12.24 um 09:51 schrieb Fabian Grünbichler: > Signed-off-by: Fabian Grünbichler Reviewed-by: Fiona Ebner ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server 1/3] api: clone: always do a full clone of tpmstate volumes

Am 12.12.24 um 09:51 schrieb Fabian Grünbichler: > since there is no reliable way to check whether a linked clone would end up > being something other than a raw file, and the volumes are tiny anyway. > > otherwise on directory storages, the following sequence of events could > happen: > - linked

Re: [pve-devel] [PATCH qemu-server 2/3] swtpm: check that format of tpmstate volume is raw

Am 12.12.24 um 10:11 schrieb Fiona Ebner: > > Can we add a format check in create_disks() when creating/adding the > volume as tpmstate0 too, please :)? I guess for creating we already force raw, so just adding ;) ___ pve-devel mailing list pve-devel@

Re: [pve-devel] [PATCH qemu-server 2/3] swtpm: check that format of tpmstate volume is raw

Am 12.12.24 um 09:51 schrieb Fabian Grünbichler: > since swtpm currently doesn't support anything else, and might overwrite a > file > using qcow2 or vmdk format by accident.. > > Signed-off-by: Fabian Grünbichler Except the nit below Reviewed-by: Fiona Ebner > --- > PVE/QemuServer.pm | 2 +

Re: [pve-devel] [PATCH] Add UI option for boot optional mapped usb device

On 12/4/24 22:50, Tyst Marin wrote: Hey Dominik, Hi, Appreciate the info and context you provided. I just sent the cla to off...@proxmox.com so hopefully that's good now(my bad for missing that). Hopefully the below answers at least some part of your questions.

[pve-devel] applied-series: [PATCH qemu-server 0/3] fix tpmstate format issues

with Fiona's R-B and the newline nit folded in, thanks! > Fabian Grünbichler hat am 12.12.2024 09:51 CET > geschrieben: > > > pre-existing bug exposed by our new format checks, reported on the forum: > > https://forum.proxmox.com/threads/backup-vm-failed-after-upgrade-to-new-version.158926/

[pve-devel] [PATCH qemu-server v2] create_disks: disallow adding of non-raw tpmstate0 volumes

when creating new ones, we already force raw as format, but adding existing volumes as tpmstate0 had no such checks. Suggested-by: Fiona Ebner Signed-off-by: Fabian Grünbichler --- Notes: v2: addressed nits by Fiona, thanks! PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff -

[pve-devel] superseded: [PATCH qemu-server] create_disks: forbid adding of non-raw tpmstate0 volumes

> Fiona Ebner hat am 12.12.2024 11:16 CET geschrieben: > > Am 12.12.24 um 10:54 schrieb Fabian Grünbichler: > > when creating new ones, we already force raw as format, but adding existing > > volumes as tpmstate0 had no such checks. > > > > Suggested-by: Fiona Ebner > > Signed-off-by: Fabian G

[pve-devel] applied: [PATCH qemu-server v2] create_disks: disallow adding of non-raw tpmstate0 volumes

Am 12.12.24 um 11:28 schrieb Fabian Grünbichler: > when creating new ones, we already force raw as format, but adding existing > volumes as tpmstate0 had no such checks. > > Suggested-by: Fiona Ebner > Signed-off-by: Fabian Grünbichler applied, thanks!

Re: [pve-devel] [PATCH pve-network] Fix #5496: NetBox add ip range

On 12/12/24 00:38, nurohman wrote: > diff --git a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > index d923269..5591b0b 100644 > --- a/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > +++ b/src/PVE/Network/SDN/Ipams/NetboxPlugin.pm > @@ -151,7 +151,7 @@ sub ad

Re: [pve-devel] SPAM: [PATCH pve-network v2 1/4] vnet: do not skip if no range is defined, ask for allocation inside prefix instead

Gave this a quick spin on my machine. The remark regarding the check for dhcp-range could be massaged in or submitted by me in a separate patch, depending on preference. Otherwise, consider this: Tested-by: Stefan Hanreich Reviewed-by: Stefan Hanreich __

[pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.2.7 and refresh patches

drop the cherry-picked kernel 6.11 compatibility patches. this upstream release [0] is a bit larger than usual, and might have a bit of potential for regressions. apart from the compatibilty fixes for newer kernels (up until 6.12), fixes to the testsystem,ci and fixes for FreeBSD the following mi

Re: [pve-devel] [PATCH network 2/4] fix #5900: add helper functions

I think in this case it is a lot easier to ask for forgiveness rather than asking for permission. One could just try to allocate the IP and check if that fails, avoiding the need to implement a complete check for the IP allocation. Checking beforehand also leads to some TOCTOU issues (admittedly s

[pve-devel] [PATCH qemu-server 2/2] qmp client: add default timeouts for more blockdev commands

For the HMP 'drive_add' command, the used timeout is 1 minute and for the 'drive_del' command, the used timeout is 10 minutes, because IO might need to be finished. Use the same for 'blockdev-add' respectively 'blockdev-del'. For 'drive-mirror', 10 minutes is used, so use the same for 'blockdev-mi

[pve-devel] [PATCH qemu-server 1/2] fix #5985: qmp client: increase timeout for {device, netdev, object}_{add, del} commands

In the bug report, the user mentioned that 7 seconds was enough. For the HMP 'drive_add' command, the used timeout is 1 minute and for the 'drive_del' command, the used timeout is 10 minutes, because IO might need to be finished. While something similar might be true for certain objects/devices, th

[pve-devel] [PATCH qemu-server] create_disks: forbid adding of non-raw tpmstate0 volumes

when creating new ones, we already force raw as format, but adding existing volumes as tpmstate0 had no such checks. Suggested-by: Fiona Ebner Signed-off-by: Fabian Grünbichler --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c

Re: [pve-devel] [PATCH qemu-server] create_disks: forbid adding of non-raw tpmstate0 volumes

Am 12.12.24 um 10:54 schrieb Fabian Grünbichler: > when creating new ones, we already force raw as format, but adding existing > volumes as tpmstate0 had no such checks. > > Suggested-by: Fiona Ebner > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 2 ++ > 1 file changed, 2 insert

Re: [pve-devel] [PATCH pve-network] Fix #5496: NetBox add ip range

On 12/12/24 08:20, DERUMIER, Alexandre wrote: > but shouldn't theses ranges be added when the dhcp ranges are submitted > on subnet create/update api call ? (I'm not 100% sure, but I think it > was missing a hook to call the sdn api when submitting the dhcp ranges > ) Yes, I also think this should

Re: [pve-devel] [PATCH guest-common 1/4] fix #5900: add helper function

On 12/5/24 17:33, Daniel Herzig wrote: > This patch adds a small helper function to retrieve the bridge name > from the netN parameter string of a container or VM configuration. > > Signed-off-by: Daniel Herzig > --- > src/PVE/GuestHelpers.pm | 11 +++ > 1 file changed, 11 insertions(

Re: [pve-devel] (no subject)

On 12/9/24 12:31, Lou Lecrivain wrote: > (configure_range is now noop) > > Signed-off-by: lou lecrivain > --- > src/PVE/Network/SDN/Dhcp.pm | 3 ++- > src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 23 ++- > 2 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a

Re: [pve-devel] SPAM: [PATCH pve-network 00/16] add support for Nautobot IPAM

On 12/10/24 14:19, lou.lecriv...@wdz.de wrote: Hello Hannes, Thank you also very much for the feedback, I appreciate it. It's my first time writing Perl and contributing to Proxmox :) I was initially in contact with your colleague S. Hanreich, who told me to start with the Netbox plugin. Give