* instead of manually setting margin/paddings and the fieldLabel, just
use a FieldContainer instead of Container. That implements the
Ext.form.Labelable mixin, which correctly positions the label. This
also has the effect that the labels are now styled correctly.
* modify the margins to get
so one can more easily see what gets added.
Signed-off-by: Dominik Csapak
---
src/panel/WebhookEditPanel.js | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js
index fcc5b06..8b76d0a 100644
--- a/src/panel/Webhoo
namely 'Key' and 'Value'
Signed-off-by: Dominik Csapak
---
src/panel/WebhookEditPanel.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js
index 8b76d0a..69a38f5 100644
--- a/src/panel/WebhookEditPanel.js
+++ b/src
by implementing Thomas suggestions from here:
https://lore.proxmox.com/pve-devel/f592fea7-e0a5-4858-af48-b0b2ed57b...@proxmox.com/
Dominik Csapak (5):
webhook edit: improve layout and component hierarchy
webhook edit: make items config not static
webhook edit: use type in add button text
w
On 12.11.24 1:27 PM, Fabian Grünbichler wrote:
> On November 7, 2024 5:51 pm, Fiona Ebner wrote:
>> +if ($waited == $wait_limit && scalar(keys $cpids->%*)) {
>> +kill 9, $_ for keys $cpids->%*;
>> +sleep 1;
>> +while ((my $cpid = waitpid(-1, POSIX::WNOHANG)) > 0) {
>
> this could b
Also includes the new `compress` option that has been recently
introduced in the installer.
Signed-off-by: Christoph Heiss
---
The `compress` option will only be included starting with the next (8.3)
ISO release, FWIW.
I can leave it out for later if preferred, but a newer pve-docs will
probabl
modifying static elements from the class, like done here with e.g.
me.items[0][key] = value;
is dangerous, since it directly modifies the class definition of those
arrays/objects.
Instead move the definition in initComponent, which uses a fresh
declaration each time the component is initialized
by calling 'isValid()' once the widget is attached to the grid
Signed-off-by: Dominik Csapak
---
src/panel/WebhookEditPanel.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js
index 69a38f5..ca99333 100644
--- a/src/panel/Web
This actually broke with commit 723afe2 - this patch was quite old
(18.10.2023) and these tests were introduced some time after sending it,
thus is not adjusted for it.
Fix itself is pretty simple, simply ignore non-JSON/invalid message from
the low-level installer, much like the actual progressio
Fixes building each crate on their own.
In a full build (e.g. `make deb`), everything pulls in serde with the
`derive` feature anyway and thus does not exihibit any build failures.
Signed-off-by: Christoph Heiss
---
Only noticed this by pure chance while using `cargo test -p
proxmox-tui-installe
On Tue, Nov 12, 2024 at 02:44:48PM +0100, Thomas Lamprecht wrote:
> Am 12.11.24 um 14:18 schrieb Christoph Heiss:
> > [..]
> > --- a/proxmox-post-hook/src/main.rs
> > +++ b/proxmox-post-hook/src/main.rs
> > @@ -133,6 +133,17 @@ struct CpuInfo {
> > #[derive(Serialize)]
> > #[serde(rename_all = "k
On Mon, Nov 11, 2024 at 06:41:15PM +0100, Thomas Lamprecht wrote:
> Am 11.11.24 um 14:14 schrieb Christoph Heiss:
> > This implements a mechanism for post-installation "notifications" via a
> > POST request [0] when using the auto-installer.
> > [..]
> > Feedback on the post-hook information schema
instead of just using the filterfn directly, return a function from
`getFilterFn`. This way, when we want to filter different things
depending on e.g. local storage values, we don't have to do that for
every element, but only once and return the finished filterFn.
while at it, rename 'filterfn' to
Dropped patch 1/7 that introduced PVE::Tools::list_is_empty. We check
direclty in the two call sites.
Patches 2 & 3 from the previous series have been applied in the
meantime.
this version reworks a few parts since
v5:
* drop PVE::Tools::list_is_empty completely and run the empty check
directly
On Tue Nov 12, 2024 at 10:16 AM CET, Dominik Csapak wrote:
> one comment inline
>
> On 11/11/24 12:35, Timothy Nicholson wrote:
> > Several strings that should probably also be translated now use
> > the gettext function to be translated.
> >
> > Signed-off-by: Timothy Nicholson
> > ---
> > [0]: h
and make it configurable in the tree browser settings.
this makes now use of the new sorting order and the more efficient
'getFilterFn' method of the viewSelector
Signed-off-by: Dominik Csapak
---
not sure if we should make each option seperate, so either
separate options for tag/pool view
or se
when ordering items on the same level, we often sort first by type, but
do this via string comparison of the types.
this leads to weird results if we have e.g. lxc/node/qemu mixed in one
list, as nodes would sort in between lxc and qemu
this patch solves that issue by introducing a fixed order fo
Am 12.11.24 um 12:49 schrieb Thomas Lamprecht:
> Am 12.11.24 um 10:38 schrieb Timothy Nicholson:
>> Signed-off-by: Timothy Nicholson
>> ---
>>
>> I missed one occurence of the String 'TFA' not using gettext, so
>> here is the updated patch.
>
> well that's the only one I'm not 100% certain about,
Am 12.11.24 um 12:45 schrieb Dominik Csapak:
> and make it configurable in the tree browser settings.
> this makes now use of the new sorting order and the more efficient
> 'getFilterFn' method of the viewSelector
works OK besides some eslint warnings (see below), but what I noticed is
that we nev
Am 24.04.24 um 13:03 schrieb Dominik Csapak:
> two similar things to fix here:
> * the 'crypt-allow-edit' field was not submitted, but it's value was
> only ever set with a bind, so a reset always set it to it's
> default 'false' value (disabling the radio buttons, even when
> it was not visi
Am 12.11.24 um 12:45 schrieb Dominik Csapak:
> instead of just using the filterfn directly, return a function from
> `getFilterFn`. This way, when we want to filter different things
> depending on e.g. local storage values, we don't have to do that for
> every element, but only once and return the
Am 12.11.24 um 12:45 schrieb Dominik Csapak:
> when ordering items on the same level, we often sort first by type, but
> do this via string comparison of the types.
>
> this leads to weird results if we have e.g. lxc/node/qemu mixed in one
> list, as nodes would sort in between lxc and qemu
>
> t
Am 12.11.24 um 14:18 schrieb Christoph Heiss:
> This adds a metadata-field `$version` to the post-hook json, indicating
> which schema version (and thus structure) this document uses.
>
> The field is of format ".", following the semantic
> versioning meaning for both the major and minor number. A
Am 12.11.24 um 13:49 schrieb Christoph Heiss:
> Fixes building each crate on their own.
>
> In a full build (e.g. `make deb`), everything pulls in serde with the
> `derive` feature anyway and thus does not exihibit any build failures.
>
> Signed-off-by: Christoph Heiss
> ---
> Only noticed this
Am 12.11.24 um 13:48 schrieb Christoph Heiss:
> This actually broke with commit 723afe2 - this patch was quite old
> (18.10.2023) and these tests were introduced some time after sending it,
> thus is not adjusted for it.
>
> Fix itself is pretty simple, simply ignore non-JSON/invalid message from
Am 12.11.24 um 16:54 schrieb Stefan Hanreich:
> From: Alexandre Derumier via pve-devel
>
> This is allow to block traffic/isolation traffic between all ports
> on the bridge with isolation (so between the vms), ans still allow
> incoming traffic from uplink.
>
> Signed-off-by: Alexandre Derumier
From: Alexandre Derumier via pve-devel
This is allow to block traffic/isolation traffic between all ports
on the bridge with isolation (so between the vms), ans still allow
incoming traffic from uplink.
Signed-off-by: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
Changes from v1 to v2:
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> First, the provider is asked about what restore mechanism to use.
> Currently, 'directory' and 'tar' are possible, for restoring either
> from a directory containing the full filesystem structure (for which
> rsync is used) or a potentially compress
101 - 128 of 128 matches
Mail list logo
