[pve-devel] [PATCH docs 1/2] pvesr: fix possible issues storage ID

2024-11-05 Thread Aaron Lauterer
The same storage needs to be configured on the target node for the replication to work. Signed-off-by: Aaron Lauterer --- pvesr.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesr.adoc b/pvesr.adoc index 9eda008..4fc2de1 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -101

[pve-devel] [PATCH docs 2/2] pvesr: mention how to configure specific network for replication

2024-11-05 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pvesr.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pvesr.adoc b/pvesr.adoc index 4fc2de1..209f306 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -181,6 +181,12 @@ A replication job is identified by a cluster-wide unique ID. This ID is composed of

Re: [pve-devel] [PATCH manager v3 1/2] close #4369: api: optionally only suggest unique IDs

2024-11-05 Thread Aaron Lauterer
besides some smaller things that could be cleaned up in a follow-up, consider this: Tested-By: Aaron Lauterer Reviewed-By: Aaron Lauterer On 2024-11-05 03:00, Severen Redwood wrote: At the moment, the `/cluster/nextid` API endpoint will return the lowest available VM/CT ID, which means tha

Re: [pve-devel] [PATCH container v3] api: record CT ID as used after a container is destroyed

2024-11-05 Thread Aaron Lauterer
beside one small nit that could be cleaned up in a follow-up, consider this: Tested-By: Aaron Lauterer Reviewed-By: Aaron Lauterer On 2024-11-05 03:00, Severen Redwood wrote: After a container is destroyed, record that its ID has been used via the `PVE::UsedVmidList` module so that the `/

Re: [pve-devel] [PATCH qemu-server v3] api: record VM ID as used after a virtual machine is destroyed

2024-11-05 Thread Aaron Lauterer
beside one small nit that could be cleaned up in a follow-up, consider this: Tested-By: Aaron Lauterer Reviewed-By: Aaron Lauterer On 2024-11-05 03:00, Severen Redwood wrote: After a virtual machine is destroyed, record that its ID has been used via the `PVE::UsedVmidList` module so that t

Re: [pve-devel] [PATCH SERIES v3] Add ability to prevent suggesting previously used VM/CT IDs

2024-11-05 Thread Aaron Lauterer
gave this series another spin in my test cluster and so far it seems to work as described. I did a very quick test if we see some noticeable "lag" when destroying a guest by filling the `used_vmids.list` with IDs from 100..3 and a stepsize of 2, so close to 15k lines. But I didn't notice tha

[pve-devel] [PATCH access-control 0/2] improve permission self-service

2024-11-05 Thread Fabian Grünbichler
noticed this while testing https://lore.proxmox.com/pve-devel/20241031134629.144893-1-d.k...@proxmox.com the first patch fixes the already allowed "permission self-service" for users as the web UI implements it (it always passes the $userid parameter). the second patch extends that self-service

[pve-devel] [PATCH access-control 1/2] api: permissions: allow users to view their own permissions

2024-11-05 Thread Fabian Grünbichler
even when specifying an explicit userid matching their own. Signed-off-by: Fabian Grünbichler --- src/PVE/API2/AccessControl.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/AccessControl.pm b/src/PVE/API2/AccessControl.pm index c55a7b3..157a5ee 100644

[pve-devel] [PATCH access-control 2/2] api: permissions: allow users to check their own tokens

2024-11-05 Thread Fabian Grünbichler
even if they lack Sys.Audit on /access - since tokens are self-service, checking whether the ACLs work as expected should also be doable for every user. Signed-off-by: Fabian Grünbichler --- src/PVE/API2/AccessControl.pm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff -

[pve-devel] [RFC manager] triggers: add path-based trigger interest

2024-11-05 Thread Fabian Grünbichler
to avoid the need to mark every package shipping PVE-related perl code as activating the explicit trigger. the explicit trigger can still be used for packages that need to reload the API without shipping a perl module the explicit trigger activation can be dropped in PVE 9.0 in packages that ship

[pve-devel] [PATCH kernel] d/rules: enable CONFIG_MEMCG_V1 needed for legacy containers

2024-11-05 Thread Fiona Ebner
As reported in the community forum [0], containers requiring cgroup v1 would not start anymore, even when systemd.unified_cgroup_hierarchy=0 was set on the kernel commandline. The error message would be: > cgfsng_setup_limits_legacy: 3442 No such file or directory - Failed to set > "memory.limit_

[pve-devel] [PATCH storage] iscsi: fix activation of second iSCSI storage on other cluster nodes

2024-11-05 Thread Friedrich Weber
Assume a cluster that already has an iSCSI storage A configured. After adding a new iSCSI storage B with a different target on node 1, B will only become active on node 1, not on the other nodes. On other nodes, pvestatd logs 'storage B is not online'. The storage does not become available even aft

Re: [pve-devel] [PATCH manager 1/4] ui: api token: remove record context from TokenView add button handler

2024-11-05 Thread Fabian Grünbichler
Consider the whole series Tested-by: Fabian Grünbichler On October 31, 2024 2:46 pm, Daniel Kral wrote: > Removes the record ("rec") variable from the TokenView, as it is always > undefined, because the "Add" button is a ExtJS Button and therefore the > button handler doesn't pass a third parame

[pve-devel] [PATCH common 1/1] sysfstools: file_write: log the actual error if there was one

2024-11-05 Thread Dominik Csapak
the actual error and path is useful to know when tryin to debug or figure out what did not work, so warn here if there was an error. Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/S

[pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour

2024-11-05 Thread Dominik Csapak
As i feared previously in [0], making it a hard error when encountering errors during sysfs writes uncovered some situations where our code was too strict to keep some setups working. One such case is resetting devices, which is seemingly not necessary at all times, so this series * donwgrades th

[pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough

2024-11-05 Thread Dominik Csapak
Since pve-common commit: eff5957 (sysfstools: file_write: properly catch errors) this check here fails now when the reset does not work. It turns out that resetting the device is not always necessary, and we previously ignored most errors when trying to do so. To restore that functionality, dow

Re: [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough

2024-11-05 Thread Stoiko Ivanov
On Tue, 5 Nov 2024 10:24:21 +0100 Dominik Csapak wrote: > Since pve-common commit: > > eff5957 (sysfstools: file_write: properly catch errors) > > this check here fails now when the reset does not work. It turns out > that resetting the device is not always necessary, and we previously > igno

Re: [pve-devel] [PATCH qemu-server 1/1] pci: don't hard require resetting devices for passthrough

2024-11-05 Thread Dominik Csapak
On 11/5/24 11:16, Stoiko Ivanov wrote: On Tue, 5 Nov 2024 10:24:21 +0100 Dominik Csapak wrote: Since pve-common commit: eff5957 (sysfstools: file_write: properly catch errors) this check here fails now when the reset does not work. It turns out that resetting the device is not always nece

Re: [pve-devel] [PATCH common/qemu-server] improve sysfs write behaviour

2024-11-05 Thread Stoiko Ivanov
Thanks big-time for the quick fix! I encountered this at a machine at home with an older GPU (NVIDIA GT1030) passed through to a VM, which seemingly does not handle resets too well. with both patches applied the guest starts again w/o error - the tasklog contains: ``` error writing '1' to '/sys/b

Re: [pve-devel] [PATCH storage v4 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd

2024-11-05 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Maximiliano Sandoval writes: > >> Maximiliano Sandoval writes: >> >> Ping. >> >>> Maximiliano Sandoval writes: >>> >>> Ping. >>> >>> Maximiliano Sandoval writes: > > Ping. Ping. ___ pve-devel mailing list pve-deve