The patch title implies that it only adds a utility function, but the
patch itself also includes usage for it. Something like
"fix #5787: ui: include guest name in confirmation dialog"
or similar would probably be a better fit.
On Tue, Oct 29, 2024 at 11:39:56AM GMT, Timothy Nicholson wrote:
>
Does what it claims to do, setting the parameter `rxbounce` when mapping
the RBD disk.
Therefore:
Tested-By: Aaron Lauterer
But one question inline...
On 2024-10-25 13:13, Friedrich Weber wrote:
When KRBD is enabled for an RBD storage, the storage plugin calls out
to `rbd map` to map an R
Signed-off-by: Timothy Nicholson
---
changes since v1:
- modified function signature
- removed unnecessary questionmark
www/manager6/Utils.js| 4
www/manager6/lxc/CmdMenu.js | 4 ++--
www/manager6/lxc/Config.js | 8 +---
www/manager6/qemu/CmdMenu.js | 4 ++
Looking at the surrounding context, I would rework this section even
more. Before I just apply my approach, what do you think about the
following change?
---
diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
index 4f19f2a..ca07692 100644
--- a/qm-pci-passthrough.adoc
+++ b/qm-pci-pa
On Tue Oct 29, 2024 at 1:22 PM CET, Christoph Heiss wrote:
> The patch title implies that it only adds a utility function, but the
> patch itself also includes usage for it. Something like
>
> "fix #5787: ui: include guest name in confirmation dialog"
>
> or similar would probably be a better fit
--- Begin Message ---
Hi,
Is someone able to review this updated patch series? I think
the previous comments should be addressed.
Also, the actual patches seem to have ended up disconnected
from the cover letter, so for reference, you can find them
here:
https://lore.proxmox.com/pve-devel/mailman
Tested-By: Aaron Lauterer
On 2024-10-24 11:00, Christoph Heiss wrote:
Currently, the TUI does not error out like the GUI if no network
interfaces are found, so remedy that.
Also, while testing, noticed that if an early/setup error is thrown in
the installer, no background header gets display
Does what it says. Will check definedness and not truthyness. Therefore
values that would evaluate as falsy still end up in the config.
Reviewed-By: Aaron Lauterer
Tested-By: Aaron Lauterer
On 2024-10-23 18:48, Tiomet Pelston via pve-devel wrote:
___
On 29/10/2024 14:58, Aaron Lauterer wrote:
> Does what it claims to do, setting the parameter `rxbounce` when mapping
> the RBD disk.
>
> Therefore:
>
> Tested-By: Aaron Lauterer
Thanks for testing!
>> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
>> index 8cc693c..02be257
