> DERUMIER, Alexandre hat am 23.10.2024
> 15:45 CEST geschrieben:
>
>
> >>I am not yet convinced this is somehow a good idea, but maybe you can
> >>convince me otherwise ;)
I maybe judged this too quickly - I thought this was combining LVM + a
dir-based storage, but this is putting the qcow
Am 24/10/2024 um 17:05 schrieb Dominik Csapak:
> On 10/24/24 14:20, Thomas Lamprecht wrote:
>> Am 21/10/2024 um 11:15 schrieb Dominik Csapak:
>>> Signed-off-by: Dominik Csapak
>>> ---
>>> src/PVE/LXC.pm | 43 ++-
>>> 1 file changed, 42 insertions(+), 1 de
Am 21/10/2024 um 11:15 schrieb Dominik Csapak:
> used the same description as for the guests.
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Cluster.pm | 34 ++
> 1 file changed, 34 insertions(+)
>
>
applied, with duplication of netin fixed and similar chang
> DERUMIER, Alexandre hat am 23.10.2024
> 16:31 CEST geschrieben:
>
>
> >>if we want the current volume to keep its name, and the snapshot
> >>volume to actually contain *that* snapshot's data, we need some sort
> >>of rename dance here as well.. i.e., rename the current volume to
> >>have t
Am 09.10.24 um 16:22 schrieb Filip Schauer:
> Introduce the "discard" mount option for rootfs and mount points. This
> ensures that unused container volume blocks are discarded from the
> underlying storage backend when deleting files within the container.
>
> Signed-off-by: Filip Schauer
Review
Am 11/10/2024 um 11:40 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> src/PVE/API2/LXC.pm | 4 ++--
> src/PVE/CLI/pct.pm| 2 +-
> src/PVE/LXC/Config.pm | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>
applied, thanks! But fixed up the following w
We do that check already in the GUI, so add it for TUI (and by
extension, the auto-installer) too.
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/setup.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/proxmox-installer-common/src/setup.rs
b/proxmox-installer-common/src/
Am 09/09/2024 um 14:50 schrieb Filip Schauer:
> Add a checkbox to the device passthrough dialogue for restricting
> write access to a device passed through to a container.
>
> Signed-off-by: Filip Schauer
> ---
> www/manager6/lxc/DeviceEdit.js | 8
> 1 file changed, 8 insertions(+)
>
>
starttime is parsed from a upid with perls `hex` which always returns an
integer
Signed-off-by: Dominik Csapak
---
PVE/API2/Tasks.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index 4ea9832b..ae60d846 100644
--- a/PVE/API2/Tasks.pm
+
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 10 ++
1 file changed, 10 insertions(+)
diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
index ba3c9528..2b53213f 100644
--- a/PVE/API2/Cluster.pm
+++ b/PVE/API2/Cluster.pm
@@ -315,6 +315,11 @@ __PACKAGE__->register_method({
Eject by setting file to none.
Signed-off-by: Daniel Herzig
---
www/manager6/qemu/HardwareView.js | 43 +++
1 file changed, 43 insertions(+)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 59e670db..5d1c18a5 100644
--- a/www/
Am 21/10/2024 um 11:15 schrieb Dominik Csapak:
> i omitted the 'disk' property, since it's non functional currently,
> since we don't query the disk usage here (complicated to calculate,
> depending on the storage, or requires guest agent support, which is also
> non-trivial)
>
> Signed-off-by: Do
When KRBD is enabled for an RBD storage, the storage plugin calls out
to `rbd map` to map an RBD image as a block device on the host.
Sometimes it might be necessary to pass custom options to `rbd map`.
For instance, in some setups with Windows VMs, KRBD logs `bad
crc/signature` and VMs performance
Add an optional `krbd-map-options` property to the RBD storage that can be
used to pass custom map options to KRBD. Currently, only the `rxbounce` option
is supported. Setting this option may be necessary in setups with Windows VMs,
as reported in the forum [1]. For now, the option is not exposed i
Describe the new `krbd-map-options` property, and mention under which
circumstances the `rxbounce` option may be necessary.
Signed-off-by: Friedrich Weber
---
pve-storage-rbd.adoc | 10 ++
1 file changed, 10 insertions(+)
diff --git a/pve-storage-rbd.adoc b/pve-storage-rbd.adoc
index 5f
Currently VMs refuse to to start if a configured isofile becomes unavailable,
be it a deleted file or an unavailable network storage.
This patch series introduces a new parameter in Drive.pm, called 'required'.
Depending on whether this parameter is set or not, the situation will be handled
differ
Current behaviour prevents a VM from starting, if an ISO file defined
in the configuration becomes unavailable.
The function eject_nonrequired_isos checks on whether a cdrom drive is
marked as 'required' or not. If the parameter 'required' is not
defined, it will assume 'required' to be true and k
This stub function can be used for mocking a file's existance in testruns.
Signed-off-by: Daniel Herzig
---
This is just a method to allow for mocking a files (not) existance for testing,
as I did not find a way to mock '-e' itself -- ideas very welcome!
PVE/QemuServer.pm | 5 +
1 file chang
Ease EXPECT_ERROR and EXPECT_WARN string matching with errors/warnings
that have more than one trailing newline.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/test/run_config2command_tests.pl b/test/r
Add parameter to allow for marking a drive as required.
Signed-off-by: Daniel Herzig
---
PVE/QemuServer/Drive.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index 6e98c095..c80c0f07 100644
--- a/PVE/QemuServer/Driv
This adds tests for the errors and warnings issued by
PVE::QemuServer::eject_unrequired_isos.
Empty cmd files were added for the test configurations that are not
expected to have any output (as they die before a command is prepared):
* ide-required-iso-missing.conf
* ide-required-iso-offline-nfs.c
Let cifs-store appear as online to a call from
PVE::Storage::activate_storage.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 13 +
1 file changed, 13 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
index 2911483e..
Strip log_warn wrapper for catching warnings on testruns.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 4
1 file changed, 4 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
index 3414eea7..dd6717e2 100755
--- a/test/run_c
Add a checkbox for marking an iso file as required.
This option is used in the backend to determine if the VM should start
up in case the configured ISO file is not available.
By default this box is not visible and disabled.
Signed-off-by: Daniel Herzig
---
www/manager6/form/IsoSelector.js | 2
Let all files checked by file_exists appear as existing if the path
does not contain the string 'I_DO_NOT_EXIST'.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 4
1 file changed, 4 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_t
Add an nfs-offline storage to allow for comparatative testing
against potentially mocked online storages.
Signed-off-by: Daniel Herzig
---
test/run_config2command_tests.pl | 9 +
1 file changed, 9 insertions(+)
diff --git a/test/run_config2command_tests.pl b/test/run_config2command_test
Enables the 'required' checkbox for the IsoSelector.
If the parameter is not set, the backend will use the default (set to
1).
Behaviour:
* Only send parameter if not default (required=0)
* Checked if parameter is missing (default)
* Unchecked when adding a new CD-ROM
Signed-off-by: Daniel Herzig
--- Begin Message ---
Message initial
De: Fabian Grünbichler
À: Proxmox VE development discussion ,
"DERUMIER, Alexandre"
Cc: Giotta Simon RUAGH
Objet: Re: [pve-devel] [PATCH v2 pve-storage 1/2] add external snasphot
support
Date: 24/10/2024 11:48:03
> Giotta Simon RUAGH via
28 matches
Mail list logo
