[pve-devel] applied: [PATCH storage v2] iscsi: disable Open-iSCSI login retries

2024-10-14 Thread Thomas Lamprecht
Am 11/10/2024 um 14:58 schrieb Friedrich Weber: > Since 90c1b10 ("fix #254: iscsi: add support for multipath targets"), > iSCSI storage activation checks whether a session exists for each > discovered portal. If there is a discovered portal without a session, > it performs a discovery and login in

Re: [pve-devel] applied: [PATCH v2 common] tools: file_set_contents: use syswrite instead of print

2024-10-14 Thread Dominik Csapak
On 10/14/24 10:42, Thomas Lamprecht wrote: Am 30/09/2024 um 13:40 schrieb Filip Schauer: The use of `print` can be inefficient for writing larger files due to its default buffering in 8 KiB blocks. This is especially problematic on `pmxcfs` where files are written in 4 KiB blocks due to the def

Re: [pve-devel] [PATCH v2 common] tools: file_set_contents: use syswrite instead of print

2024-10-14 Thread Thomas Lamprecht
Am 30/09/2024 um 13:40 schrieb Filip Schauer: > + $offset += syswrite($fh, $data, $len - $offset, $offset) > + or die "unable to write '$tmpname' - $!\n"; FYI: Wolfgang noticed something nasty with the subtle difference between the `or` and `||` operator [0] that introduces a b

Re: [pve-devel] applied: [PATCH v2 common] tools: file_set_contents: use syswrite instead of print

2024-10-14 Thread Thomas Lamprecht
Am 14/10/2024 um 11:07 schrieb Dominik Csapak: > hi since you applied this, we probably also want to apply the pmxcfs patch? This is already an improvement on its own independent of where the destination resides on, but yes, the pmxcfs one would have been the next to (re-)look more closely at. >

[pve-devel] applied-series: [PATCH docs v2 1/4] fix some typos

2024-10-14 Thread Thomas Lamprecht
Am 10/10/2024 um 14:34 schrieb Maximiliano Sandoval: > found with: > > typos *.adoc > > Signed-off-by: Maximiliano Sandoval > --- > datacenter.cfg.5-opts.adoc | 2 +- > ha-resources-opts.adoc | 2 +- > notifications.adoc | 2 +- > pct.conf.5-opts.adoc | 2 +- > pve-network

[pve-devel] applied: [PATCH v2 common] tools: file_set_contents: use syswrite instead of print

2024-10-14 Thread Thomas Lamprecht
Am 30/09/2024 um 13:40 schrieb Filip Schauer: > The use of `print` can be inefficient for writing larger files due to > its default buffering in 8 KiB blocks. > > This is especially problematic on `pmxcfs` where files are written in > 4 KiB blocks due to the defaults of `libfuse2`. This leads to >

Re: [pve-devel] [PATCH widget-toolkit] fix external linking to products by setting cookie SameSite attribute to lax

2024-10-14 Thread Dominik Csapak
On 10/8/24 14:10, Max Carrara wrote: On Mon Oct 7, 2024 at 5:02 PM CEST, Dominik Csapak wrote: We introduced the 'strict' setting when browsers warned about our cookies not having any SameSite setting [0] While this works in general, it had an unforeseen side effect: When linking to a URL of o

Re: [pve-devel] [PATCH widget-toolkit] fix external linking to products by setting cookie SameSite attribute to lax

2024-10-14 Thread Dominik Csapak
On 10/14/24 13:57, Dominik Csapak wrote: On 10/8/24 14:10, Max Carrara wrote: On Mon Oct 7, 2024 at 5:02 PM CEST, Dominik Csapak wrote: We introduced the 'strict' setting when browsers warned about our cookies not having any SameSite setting [0] While this works in general, it had an unforesee

[pve-devel] [PATCH cluster] fix #5728: pmxcfs: allow bigger writes than 4k for fuse

2024-10-14 Thread Dominik Csapak
by default libfuse2 limits writes to 4k size, which means that on writes bigger than that, we do a whole write cycle for each 4k block that comes in. To avoid that, add the option 'big_writes' to allow writes bigger than 4k at once (namely up to 128 KiB). This means that if we update a file with m

Re: [pve-devel] [PATCH storage v4 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd

2024-10-14 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Maximiliano Sandoval writes: > > Ping. > >> Maximiliano Sandoval writes: >> >> Ping. >> >> Maximiliano Sandoval writes: Ping. -- Maximiliano ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.prox

[pve-devel] [PATCH http-server] fix external linking when cookie was acquired via HTML formatter

2024-10-14 Thread Dominik Csapak
currently we set the SameSite attribute to `Strict` which prevents linking from external sites with the cookies set. (For a detailed explanation of this see [0]) so with the same rationale as in [0], set the cookie SameSite attribute to 'Lax', which is very similar behavior as 'Strict' but allows

[pve-devel] [PATCH pve-manager] fix #5302: ui: vm cpu affinity displayed in hardware overview

2024-10-14 Thread Timothy Nicholson
Signed-off-by: Timothy Nicholson --- www/manager6/qemu/HardwareView.js | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 86d5f4cf..b607265a 100644 --- a/www/manager6/qemu/HardwareView.js +++

Re: [pve-devel] [PATCH pve-manager] fix #5302: ui: vm cpu affinity displayed in hardware overview

2024-10-14 Thread Dominik Csapak
Hi, Looks mostly good to me, aside from the indentation (as mentioned off-list) so please send a v2 with the indentation fixed, thanks On 10/14/24 14:26, Timothy Nicholson wrote: Signed-off-by: Timothy Nicholson --- www/manager6/qemu/HardwareView.js | 11 +-- 1 file changed, 9 inse

[pve-devel] [PATCH manager v2] fix typos in user visible strings

2024-10-14 Thread Maximiliano Sandoval
Found with the `typos` cli tool. Signed-off-by: Maximiliano Sandoval --- Differences from v1: - Do not fix `state = 'uknown'` typo. It is not user facing - Fix commit message www/manager6/ceph/CephInstallWizard.js | 2 +- www/manager6/node/Certificates.js | 2 +- www/mobile/Toolkit.js