[pve-devel] [PATCH manager] fix typos in user visible strings

2024-10-11 Thread Maximiliano Sandoval
The 'uknown' typo would prevent the right icon [1] from being loaded. [1] https://fontawesome.com/v4/icon/question Signed-off-by: Maximiliano Sandoval --- www/manager6/Utils.js | 2 +- www/manager6/ceph/CephInstallWizard.js | 2 +- www/manager6/node/Certificates.js | 2 +-

Re: [pve-devel] [PATCH manager] fix typos in user visible strings

2024-10-11 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > The 'uknown' typo would prevent the right icon [1] from being loaded. > > [1] https://fontawesome.com/v4/icon/question The commit message is wrong. -- Maximiliano ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] [PATCH storage] iscsi: disable Open-iSCSI login retries to avoid blocking pvestatd

2024-10-11 Thread Friedrich Weber
Since 90c1b10 ("fix #254: iscsi: add support for multipath targets"), iSCSI storage activation checks whether a session exists for each discovered portal. If there is a discovered portal without a session, it performs a discovery and login in the hope of establishing a session to the portal. If the

[pve-devel] [PATCH container] fix typos on user-visible strings

2024-10-11 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/API2/LXC.pm | 4 ++-- src/PVE/CLI/pct.pm| 2 +- src/PVE/LXC/Config.pm | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 918e719..4657ee1 100644 --- a/src/PVE/API2/LXC.pm +++

[pve-devel] [PATCH container] fix #5762: lxc: setup: support `opensuse-slowroll` as OpenSUSE flavor

2024-10-11 Thread Christoph Heiss
See the original bug report [0]. OpenSUSE Tumbleweed Slowroll fails to be detected corrected due to featuring a different ID in /etc/os-release. Simply map that ID to the existing opensuse plugin - much like Tumbleweed itself. Slowroll is basically just a midway solution between Leap and Tumblewee

Re: [pve-devel] [PATCH storage v2] iscsi: disable Open-iSCSI login retries

2024-10-11 Thread Mira Limbeck
On 10/11/24 14:58, Friedrich Weber wrote: > Since 90c1b10 ("fix #254: iscsi: add support for multipath targets"), > iSCSI storage activation checks whether a session exists for each > discovered portal. If there is a discovered portal without a session, > it performs a discovery and login in the ho

[pve-devel] [PATCH storage v2] iscsi: disable Open-iSCSI login retries

2024-10-11 Thread Friedrich Weber
Since 90c1b10 ("fix #254: iscsi: add support for multipath targets"), iSCSI storage activation checks whether a session exists for each discovered portal. If there is a discovered portal without a session, it performs a discovery and login in the hope of establishing a session to the portal. If the

Re: [pve-devel] [PATCH storage] iscsi: disable Open-iSCSI login retries to avoid blocking pvestatd

2024-10-11 Thread Friedrich Weber
Thanks for the test and review! On 11/10/2024 13:20, Mira Limbeck wrote: > [...] >> --- a/src/PVE/Storage/ISCSIPlugin.pm >> +++ b/src/PVE/Storage/ISCSIPlugin.pm >> @@ -132,6 +132,14 @@ sub iscsi_login { >> eval { iscsi_discovery($portals); }; >> warn $@ if $@; >> >> +# Disable retr

Re: [pve-devel] [PATCH storage] iscsi: disable Open-iSCSI login retries to avoid blocking pvestatd

2024-10-11 Thread Mira Limbeck
On 10/11/24 11:37, Friedrich Weber wrote: > Since 90c1b10 ("fix #254: iscsi: add support for multipath targets"), > iSCSI storage activation checks whether a session exists for each > discovered portal. If there is a discovered portal without a session, > it performs a discovery and login in the ho