Re: [pve-devel] [PATCH ifupdown2 0/1] Support IPv6 in vxlan

2024-10-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Hi, Thanks for the patch ! Do you have submitted it also on the ifupdown2 github ? Message initial De: apalrd via pve-devel Répondre à: Proxmox VE development discussion À: pve-devel@lists.proxmox.com Cc: apalrd Objet: [pve-devel] [PATCH ifupdown2 0/1

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2024-10-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Try to look at ifupdown2 github, their are 2 old pull request about this (never merged/ never completed) https://github.com/CumulusNetworks/ifupdown2/pull/172 " For this we would need a new attribute vxlan-local-tunnelip6, we don't want to reuse the same attribute for ipv6

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2024-10-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Personnally, I'm ok with your patch >>Ultimately I disagreed with the solution to use a separate parameter >>for IPv6, for the following reasons: >>- We can only have one local tunnel IP, so having two parameters >>means we need to check if the other one has been set (since s

Re: [pve-devel] [PATCH pve-network 1/1] Update vxlan plugin to emit local tunnel IP

2024-10-09 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- patch logic seem to be ok for me. (I don't have tested it) >> >>     for my $address (@peers) { >>- next if $address eq $ifaceip; >>- push @iface_config, "vxlan_remoteip $address"; >>+     push @iface_config, "vxlan_local_tunnelip $address" if $address eq >>$ifaceip; >>+

[pve-devel] [PATCH qemu 2/2] test: Adapt to changes in network scripts location

2024-10-09 Thread Maximiliano Sandoval
>From the previous commit. Signed-off-by: Maximiliano Sandoval --- test/cfg2cmd/bootorder-empty.conf.cmd| 2 +- test/cfg2cmd/bootorder-legacy.conf.cmd | 2 +- test/cfg2cmd/bootorder.conf.cmd | 2 +- test/cfg2cmd/efidisk-on-rbd.conf.c

[pve-devel] [PATCH qemu 1/2] vm-network-scripts: move scripts to /usr/libexec

2024-10-09 Thread Maximiliano Sandoval
Moves the network scripts from /var/lib/qemu-server into /usr/libexec/qemu-server. /usr/libexec is described as binaries run by programs which are not intended to be directly executed by the user on [FHS 4.7]. On the other hand /var/lib corresponds to variable state information, which does not fit

[pve-devel] [PATCH container] fix #5761: add the "discard" mount option

2024-10-09 Thread Filip Schauer
Introduce the "discard" mount option for rootfs and mount points. This ensures that unused container volume blocks are discarded from the underlying storage backend when deleting files within the container. Signed-off-by: Filip Schauer --- src/PVE/LXC/Config.pm | 2 +- 1 file changed, 1 insertio

Re: [pve-devel] [PATCH pve-network 1/1] Update vxlan plugin to emit local tunnel IP

2024-10-09 Thread Thomas Lamprecht
An actual commit message would be good, including at least a reason for why this is done. Am 08/10/2024 um 06:01 schrieb apalrd: > --- > src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 4 ++-- > src/test/zones/vxlan/basic/expected_sdn_interfaces | 1 + > src/test/zones/vxla