Re: [pve-devel] [PATCH common v4 2/7] fix #3893: network: add vlan id and range parameter definitions

2024-09-10 Thread Fiona Ebner
Am 29.07.24 um 13:55 schrieb Aaron Lauterer: > @@ -595,6 +601,34 @@ sub pve_verify_iface { > return $id; > } > > +# vlan id (vids), single or range > +register_format('pve-vlan-id-or-range', \&pve_verify_vlan_id_or_range); > +sub pve_verify_vlan_id_or_range { > +my ($vlan, $noerr) = @_;

Re: [pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator

2024-09-10 Thread Fiona Ebner
Am 29.07.24 um 13:55 schrieb Aaron Lauterer: > Because the API accepts multiple possible list separators we need to > make sure that we write the bridge_vids with space as separator, no > matter which separator was used when passing it to the API. > Nit: The reason why it's necessary to write out

Re: [pve-devel] [PATCH storage] base plugin: do not decode the empty string

2024-09-10 Thread Fiona Ebner
Am 02.09.24 um 14:47 schrieb Maximiliano Sandoval: > If the json was empty, for example if the qemu-img command times out, a > message > > warn "could not parse qemu-img info command output for '$filename' - > $err\n"; > > would have been printed. > > This message could lead one to think th

[pve-devel] [VEEAM] Release and AMA

2024-09-10 Thread Andreas Neufert via pve-devel
--- Begin Message --- Hello Proxmox pve-developer team, Tim Marx suggested that we reach out to you in this list to share about our release and offer an open dialog directly with the responsible Veeam people. As you know we released the Veeam Data Platform that includes Veeam Backup & Replicati

[pve-devel] Bug 2582 roadmap

2024-09-10 Thread Pavel Tide via pve-devel
--- Begin Message --- Hi Proxmox team, Would you provide any delivery estimates on this item? https://bugzilla.proxmox.com/show_bug.cgi?id=2582 As far as I understand it's been implemented already, but currently stays in the development branch - our lab is up to date and yet we don't see how we

[pve-devel] applied: [PATCH manager] ui: qemu: hardware: fix permission check for adding tpmstate volume

2024-09-10 Thread Fiona Ebner
Am 05.08.24 um 15:33 schrieb Friedrich Weber: > Previously, the "Add -> TPM State" menu item in the GUI was disabled > if the user did not have Sys.Console privileges. This deviated from > the permission check in the backend, which does not require > Sys.Console but (among others) VM.Config.Disk. >

[pve-devel] [PATCH container] api: autocomplete rootdir storages for create, move-volume and clone

2024-09-10 Thread Daniel Kral
Adds a helper subroutine for enumerating storages that are enabled and have the content type `rootdir` set, therefore supporting container directories. The autocompletion is added to the clone command and changed for the create and move-volume commands, which previously suggested any storage devic

Re: [pve-devel] [PATCH qemu-server 1/1] disk import: add additional safeguards for imported image files

2024-09-10 Thread Fiona Ebner
Am 09.08.24 um 13:22 schrieb Fabian Grünbichler: > creating non-raw disk images with arbitrary content is only possible with raw > access to the storage, but checking for references to external files doesn't > hurt. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > requires pve-storag

Re: [pve-devel] [PATCH storage 1/1] file_size_info: implement untrusted mode

2024-09-10 Thread Fiona Ebner
Am 09.08.24 um 13:22 schrieb Fabian Grünbichler: > this allows checking some extra attributes for images which come from a > potentially malicious source. > > since file_size_info is not part of the plugin API, no API bump is needed. if > desired, a similar check could also be implemented in volum

Re: [pve-devel] [PATCH guest-common 1/1] storage tunnel: check just-imported image files

2024-09-10 Thread Fiona Ebner
Am 09.08.24 um 13:22 schrieb Fabian Grünbichler: > remote migration requires elevated privileges already and can thus only be > triggered by trusted sources, but an additional safeguard of checking the > image > for external references doesn't hurt. > > Signed-off-by: Fabian Grünbichler > --- >

Re: [pve-devel] SDN Feature request - add IPAM support for Nautobot

2024-09-10 Thread Stefan Hanreich
Hi! Thanks for your interest in contributing to Proxmox VE. A good start would be to look at the existing Netbox plugin [1], as well as the base plugin [2]. I've shortly tried using the existing Netbox plugin with the Nautobot API, but it seems like the API already diverged too much for it to wor

Re: [pve-devel] [PATCH storage v3 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd

2024-09-10 Thread Fiona Ebner
Am 12.08.24 um 13:44 schrieb Maximiliano Sandoval: > The decompressor_info method calls binaries provided by these packages > so they are (alphabetically) added explicitly as dependencies. > > To avoid a build-time error > > E: libpve-storage-perl: > depends-on-essential-package-without-usin

Re: [pve-devel] [PATCH storage v3 1/2] fix #5267: storage: add bzip2 support

2024-09-10 Thread Fiona Ebner
Am 12.08.24 um 13:44 schrieb Maximiliano Sandoval: > A popular ISO compressed exclusively with bz2 is OPNsense [2]. > > Since this requires adding `bz2` to the list of known compression > formats we add decompression methods for vmz a tar. Typo here I presume. > diff --git a/src/test/list_volume

Re: [pve-devel] [PATCH storage v3 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd

2024-09-10 Thread Fabian Grünbichler
> Fiona Ebner hat am 10.09.2024 14:24 CEST geschrieben: > Am 12.08.24 um 13:44 schrieb Maximiliano Sandoval: > > The decompressor_info method calls binaries provided by these packages > > so they are (alphabetically) added explicitly as dependencies. > > > > To avoid a build-time error > > > >

Re: [pve-devel] [PATCH storage v3 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd

2024-09-10 Thread Fiona Ebner
Am 10.09.24 um 14:52 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 10.09.2024 14:24 CEST geschrieben: >> Am 12.08.24 um 13:44 schrieb Maximiliano Sandoval: >>> The decompressor_info method calls binaries provided by these packages >>> so they are (alphabetically) added explicitly as dependenci

Re: [pve-devel] [PATCH storage 1/2] fix #3873: btrfs: check for correct subvolume taking snapshot

2024-09-10 Thread Fiona Ebner
Am 09.07.24 um 13:51 schrieb Maximiliano Sandoval: > Suppose we are doing a snapshot of disk 0 for VM 100. The > dir_glob_foreach runs over $path=/subvolume/images/100, lists all > snapshot names and appends their names to the path of the disk, e.g. > /subvolume/images/vm-100-disk-0@SNAP_NAME, but

[pve-devel] applied: [PATCH container v3 1/2] add deny-write option for device passthrough

2024-09-10 Thread Thomas Lamprecht
Am 09/09/2024 um 14:50 schrieb Filip Schauer: > Add the deny-write options for device passthrough, to restrict container > access to devices. > > Signed-off-by: Filip Schauer > --- > src/PVE/LXC.pm| 7 ++- > src/PVE/LXC/Config.pm | 6 ++ > 2 files changed, 12 insertions(+), 1 del

[pve-devel] applied: [PATCH container] backup: warn that tar does not honor exclusion pattern with a trailing slash

2024-09-10 Thread Thomas Lamprecht
Am 31/05/2024 um 12:07 schrieb Fiona Ebner: > As reported in the community forum [0], for tar, an exclusion pattern > with a trailing slash will not match a folder with that name. For > rsync and proxmox-backup-client however, such a pattern will exclude > a directory with that name, but not a file

[pve-devel] applied: [PATCH container] api: autocomplete rootdir storages for create, move-volume and clone

2024-09-10 Thread Thomas Lamprecht
Am 10/09/2024 um 13:23 schrieb Daniel Kral: > Adds a helper subroutine for enumerating storages that are enabled and > have the content type `rootdir` set, therefore supporting container > directories. > > The autocompletion is added to the clone command and changed for the > create and move-volum