[pve-devel] [PATCH openid 0/1] Make OIDC userinfo endpoint optional

2024-09-02 Thread Thomas Skinner
In the OpenID Connect documentation (https://openid.net/specs/openid-connect-core-1_0.html), the protocol abstract defined in 1.3 states in step 4 that "The RP can send a request with the Access Token to the UserInfo Endpoint", which would imply that getting information from the UserInfo endpoi

[pve-devel] [PATCH openid 1/1] fix #4234: openid: make userinfo request optional

2024-09-02 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- proxmox-openid/src/lib.rs | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/proxmox-openid/src/lib.rs b/proxmox-openid/src/lib.rs index fe65fded..7cef06e0 100644 --- a/proxmox-openid/src/lib.rs +++ b/proxmox-openid/src/lib.rs @@ -195,7

[pve-devel] [PATCH SERIES openid/access-control/docs/manager] fix #4411: add support for openid groups

2024-09-02 Thread Thomas Skinner
This patch series adds support for groups for OpenID logins. The following options are implemented: - Configurable claim for retrieving a list of groups and adding them to the user in PVE - Allowing "synchronization" of groups on login by overriding groups assigned to the user in PVE

[pve-devel] [PATCH docs 1/1] fix #4411: openid: add docs for openid groups support

2024-09-02 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- api-viewer/apidata.js | 40 pveum.adoc| 32 2 files changed, 72 insertions(+) diff --git a/api-viewer/apidata.js b/api-viewer/apidata.js index 8ba94e4..0edafd7 100644 --- a/api

[pve-devel] [PATCH manager 1/1] fix #4411: openid: add ui config for openid groups support

2024-09-02 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- www/manager6/dc/AuthEditOpenId.js | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js index 544c0de5..30ee050a 100644 --- a/www/manager6/dc/Aut

[pve-devel] [PATCH openid 1/1] fix #4411: openid: add library code for openid groups support

2024-09-02 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- proxmox-openid/src/lib.rs | 55 +-- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/proxmox-openid/src/lib.rs b/proxmox-openid/src/lib.rs index fe65fded..bf8c650b 100644 --- a/proxmox-openid/src/lib.rs +++ b/prox

[pve-devel] [PATCH access-control 1/1] fix #4411: openid: add logic for openid groups support

2024-09-02 Thread Thomas Skinner
Signed-off-by: Thomas Skinner --- src/PVE/API2/OpenId.pm | 32 src/PVE/Auth/OpenId.pm | 21 + 2 files changed, 53 insertions(+) diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm index 77410e6..22a2188 100644 --- a/src/PVE/API2/OpenI

Re: [pve-devel] [PATCH qemu-server] fix #5284: diallow moving vm disks to storages not meant for images

2024-09-02 Thread Filip Schauer
I tried to move a VM disk from a directory storarge to another directory storage that does not support the content type 'images'. ``` $ qm disk move 103 efidisk0 local2 400 Parameter verification failed. storage: storage 'local2' does not support vm images qm disk move [] [OPTIONS] ``` As expe

Re: [pve-devel] Continuing on making the VM ID suggestion strategy configurable

2024-09-02 Thread Daniel Krambrock via pve-devel
--- Begin Message --- Hi everyone, please excuse me for leaving this issue lying around. I am very pleased that Severen is interested in continuing this patch and takes over the work. Am 30.08.24 um 01:08 schrieb Severen Redwood: There's a patch series [2] from a few months ago which addresse

Re: [pve-devel] [PATCH qemu-server] fix #5657: allow configuring RNG device as non-root user

2024-09-02 Thread Fabian Grünbichler
On August 26, 2024 1:08 pm, Filip Schauer wrote: > Allow any user with the VM.Config.HWType permission to add or remove a > VirtIO RNG device on a VM. This is in line with the behaviour of cloning > a VM and restoring a VM backup as defined in > PVE::QemuServer::check_mapping_access. IIRC this was

[pve-devel] [PATCH container] fix #5674: add missing 'proxyto' for LXC interfaces API

2024-09-02 Thread Fabian Grünbichler
else this API endpoint would only work when connected to the node where the container is currently running. Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 741f33c..d9f1c0a 100644 --- a/

[pve-devel] [PATCH storage] base plugin: do not decode the empty string

2024-09-02 Thread Maximiliano Sandoval
If the json was empty, for example if the qemu-img command times out, a message warn "could not parse qemu-img info command output for '$filename' - $err\n"; would have been printed. This message could lead one to think the issue lies in the contents of the json, even if the previous warnin

Re: [pve-devel] [PATCH storage v4] fix #4272: btrfs: add rename feature

2024-09-02 Thread Maximiliano Sandoval
Maximiliano Sandoval writes: > Ping. Ping. -- Maximiliano ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel