Thanks for the review!
On Wed, Aug 14, 2024 at 12:51:27PM GMT, Alexander Zeidler wrote:
> On Fri Aug 9, 2024 at 1:51 PM CEST, Christoph Heiss wrote:
> > [..]
> > diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm
> > index ae70093..6b064b1 100644
> > --- a/Proxmox/Install/Config.pm
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch, split out from later patch
proxmox-fetch-answer/src/fetch_plugins/http.rs | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs
b/proxmox-fetch-answer/src/fet
This implements a mechanism for post-installation "notifications" via a
POST request [0] when using the auto-installer.
It's implemented as a separate, small utility to facilitate separation
of concerns and make the information gathering easier by having it
isolated in one place.
Patches #1 throu
This allows re-using this piece of code in e.g. the post hook, instead
of having to open-code it there.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* change `&PathBuf` parameter to `impl AsRef`
proxmox-auto-installer/tests/par
Makes handling & passing them around a bit more convenient. Will be used
in the upcoming proxmox-post-hook utility.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch, split out from later patch
proxmox-auto-installer/src/udevinfo.rs | 8 +---
1 file changed, 5 insertions(+)
Needed for the post-hook functionality, which sends this information as
part of its information set.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* new patch
Proxmox/Install/RunEnv.pm | 1 +
proxmox-installer-common/src/setup.rs | 12
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* new patch, suggestion by Stefan
proxmox-auto-installer/tests/parse-answer.rs | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/proxmox-auto-installer/tests/parse-answer.rs
b/pro
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* new patch, suggestion by Stefan
proxmox-auto-install-assistant/src/main.rs | 23 +-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/proxmox-auto-install-assistant/src/mai
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch, split out from later patch
proxmox-auto-installer/src/answer.rs | 16 +++-
.../src/bin/proxmox-auto-installer.rs| 11 +--
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git
This enable reusage of this code in other crates. Needed esp. by the
upcoming post-installation notification hook functionality.
No functional changes overall.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* no changes
Cargo.toml
Previously, in the "false" case, it would serialize to an empty string.
In the future this property will be deserialized by (type-safe) Rust
code.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch, found by Aaron
Proxmox/Install/RunEnv.pm | 2 +-
1 file changed, 1 insertion(+),
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* fix some more typos
Changes v1 -> v2:
* new patch
proxmox-auto-install-assistant/src/main.rs | 4 ++--
proxmox-fetch-answer/src/fetch_plugins/http.rs | 2 +-
proxmox-installer-common/src/disk_checks.rs| 2 +-
unconfigured.sh
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* no changes
proxmox-auto-installer/src/utils.rs | 15 +++
proxmox-installer-common/src/setup.rs | 23 ++-
proxmox-tui-installer/src/setup.rs| 2 +-
3 files changed, 14
Rust links in some dynamic libraries even if only used by a disabled
feature gate.
This will be needed due to moving http-related code into the
proxmox-installer-common crate and thus pulling it in at more places.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 ->
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* no changes
proxmox-auto-installer/src/answer.rs | 11 +++
1 file changed, 11 insertions(+)
diff --git a/proxmox-auto-installer/src/answer.rs
b/proxmox-auto-installer/src/answer.rs
index bada8a5..
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* new patch, suggestion by Stefan
proxmox-auto-installer/tests/parse-answer.rs | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/proxmox-auto-installer/tests/parse-answer.rs
b/proxmox-a
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* no changes
unconfigured.sh | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/unconfigured.sh b/unconfigured.sh
index b1c980a..51b7974 100755
--- a/unconfigured.sh
+++ b/unconfigure
Implements the proper de-/serializer directly on the type and then
use serde_plain::derive_display_from_serialize where applicable, instead
of separate serializer functions somewhere else.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* implement FromStr
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* no changes
Cargo.toml| 4
proxmox-auto-install-assistant/Cargo.toml | 14 +++---
proxmox-auto-installer/Cargo.toml | 15 +++
This utility can be called with the low-level install config after a
successful installation to send a notification via a HTTP POST request,
if the user has configured an endpoint for that in the answer file.
Signed-off-by: Christoph Heiss
---
Since it was discussed a bit in the last revision [0
v3 out: https://lists.proxmox.com/pipermail/pve-devel/2024-August/065163.html
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
This functionality will be reused by the post-hook, which sends this
data as part of its information set.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* no changes
Changes v1 -> v2:
* new patch
proxmox-auto-installer/src/sysinfo.rs | 51 +---
proxmox-installer
For one, include the auto-installer arguments, which weren't filtered
out before. Secondely, include the aliases as introduced in [0].
[0] de7f779 ("unconfigured: accept more telling boot cmdline option names")
Reported-by: Friedrich Weber
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
Otherwise, substrings might get replaced, e.g. the replacement
`proxmox-start-auto-installer` -> `pxmox-start-auto-installer` would be
done.
Fixes: a02a78a ("fix #4747: pass kernel cmdline parameters to target system")
Suggested-by: Thomas Lamprecht
Signed-off-by: Christoph Heiss
---
Changes v1
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* new patch
Proxmox/Install/Config.pm| 2 +-
test/Makefile| 7 +++-
test/parse-kernel-cmdline.pl | 62
3 files changed, 69 insertions(+), 2 deletions(-)
create mode 100755 test/pars
Friedrich recently reported that when installing using the
auto-installer, the kernel commandline does not get cleaned up properly.
For building/testing on current master, [0] needs to be applied
beforehand to fix a test failure.
[0] https://lists.proxmox.com/pipermail/pve-devel/2024-July/064815.
v2 out: https://lists.proxmox.com/pipermail/pve-devel/2024-August/065186.html
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Allow the ESXi storage disk entry property "fileName" to be flatcased
("filename") in addition to being camelcased ("fileName"). This adds
compatibility with older ESXi .vmx configuration files.
Signed-off-by: Daniel Kral
---
src/PVE/Storage/ESXiPlugin.pm | 2 +-
1 file changed, 1 insertion(+),
Compatibility for an older naming convention of the "fileName" property
of mounted storage device images in vmx configuration files was
requested at [1].
Previously, it was only possible to import ESXi VMs, where the mentioned
property name was camelcased (e.g. "scsi0:0.fileName"). This patch
allo
Allow the ESXi storage disk entry property "fileName" to be flatcased
("filename") in addition to being camelcased ("fileName"). This adds
compatibility with older ESXi .vmx configuration files.
Signed-off-by: Daniel Kral
---
src/vmx.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
30 matches
Mail list logo
