[pve-devel] [PATCH installer v4 4/4] low-level: install: check for already-existing `rpool` on install

2024-07-16 Thread Christoph Heiss
.. much in the same manner as the detection for LVM works. zpools can only be renamed by importing them with a new name, so unfortunately the import-export dance is needed. Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * rename $response_ok -> $do_rename for clarity in Changes v2 -> v3

[pve-devel] [PATCH installer v4 3/4] install: config: rename option lvm_auto_rename -> existing_storage_auto_rename

2024-07-16 Thread Christoph Heiss
As this is an internal option for the low-level installer anyway, no real functional changes here. Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * rename $response_ok -> $do_rename for clarity in ask_existing_vg_rename_or_abort() Changes v2 -> v3: * new patch Proxmox/Install.pm

[pve-devel] [PATCH installer v4 0/4] add check/rename for already-existing ZFS rpool

2024-07-16 Thread Christoph Heiss
Pretty straight forward overall, implements a check for an existing `rpool` on the system and ask the user whether they would like to rename it, much in the same way as it works for VGs already. Without this, the installer would silently create a second (and thus conflicting) `rpool` and cause a b

[pve-devel] [PATCH installer v4 1/4] proxmox: add zfs module for retrieving importable zpool info

2024-07-16 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * no changes Changes v1 -> v2: * incorporated Aaron suggestion to use anonymous arrays instead * added documentation * renamed parsing function parse_pool_list -> zpool_import_parse_output * split out

[pve-devel] [PATCH installer v4 2/4] test: add test cases for new zfs module

2024-07-16 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * no changes Changes v1 -> v2: * new patch, split out from patch #1 * rewrote tests to use a pre-defined input instead, thus being able to enable the tests unconditionally test/Makefile

Re: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool

2024-07-16 Thread Christoph Heiss
v4 out: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064675.html On Thu, Jul 11, 2024 at 01:57:52PM GMT, Christoph Heiss wrote: > Pretty straight forward overall, implements a check for an existing > `rpool` on the system and ask the user whether they would like to rename > it, much in

Re: [pve-devel] [PATCH proxmox-ve-rs 09/21] sdn: add name types

2024-07-16 Thread Stefan Hanreich
On 6/27/24 12:56, Gabriel Goller wrote: > On 26.06.2024 14:15, Stefan Hanreich wrote: >> diff --git a/proxmox-ve-config/src/sdn/mod.rs >> b/proxmox-ve-config/src/sdn/mod.rs >> new file mode 100644 >> index 000..4e7c525 >> --- /dev/null >> +++ b/proxmox-ve-config/src/sdn/mod.rs >> @@ -0,0 +1,2

Re: [pve-devel] [PATCH proxmox-ve-rs 12/21] sdn: add config module

2024-07-16 Thread Stefan Hanreich
On 6/27/24 12:54, Gabriel Goller wrote: > On 26.06.2024 14:15, Stefan Hanreich wrote: >> diff --git a/proxmox-ve-config/src/sdn/config.rs >> b/proxmox-ve-config/src/sdn/config.rs >> new file mode 100644 >> index 000..8454adf >> --- /dev/null >> +++ b/proxmox-ve-config/src/sdn/config.rs >> @@ -0

[pve-devel] [PATCH manager] www: utils: fix inconsistency in host cpu usage display in search view

2024-07-16 Thread Christoph Heiss
Between the number of CPUs and the actual label, a space was missing - resulting in an inconsistency vs. the "CPU usage" column. Also, fix a rather nonsensical check for `maxcpu` above - noticed that while comparing the implementation to that of Proxmox.Utils.render_cpu(). Signed-off-by: Christop

Re: [pve-devel] [RFC firewall/proxmox{-ve-rs, -firewall, -perl-rs} 00/21] autogenerate ipsets for sdn objects

2024-07-16 Thread Stefan Hanreich
On 6/28/24 15:46, Gabriel Goller wrote: > Already talked with Stefan offlist, but some major things I noted when > testing: >  * It would be cool to have the generated IPSets visible in the IPSet >    menu under Firewall (Datacenter). We could add a checkmark to hide >    them (as there can be qui

Re: [pve-devel] [PATCH kernel 2/2] cherry-pick potential fix for NULL pointer deref with AMD Arcturus GPU during boot

2024-07-16 Thread Alexander Zeidler
> On 10.07.2024 11:37 GMT Fiona Ebner wrote: > The issue was reported in the enterprise support and is handled by > Alexander Zeidler. It has the following trace [0] and causes an issue > with the networking down the line, because 'udevadm settle' would time > out. The customer reported that mainl

[pve-devel] cloudinit: RFC proposal for unwanted and unexpected regeneration of instance-id

2024-07-16 Thread MAbeeTT via pve-devel
--- Begin Message --- Hello all, I am Matias from Spain, raised in Argentina where I met PVE from version 3 when trying to find an opensource KVM and container solution for an internal lab. After backup on proxmox PVE7 and restore in PVE8 [ 8.2.4 ] in my personal lab I got new instance-id's hash f

Re: [pve-devel] cloudinit: RFC proposal for unwanted and unexpected regeneration of instance-id

2024-07-16 Thread Mira Limbeck
Hi Matias, Thank you for providing this detailed description of the issue! We have an open issue in our bug tracker [0]. If it's alright with you I'd add your text as-is to the bug tracker as a comment for additional information/reasoning on why that change would be needed. Feel free to add your

Re: [pve-devel] cloudinit: RFC proposal for unwanted and unexpected regeneration of instance-id

2024-07-16 Thread MAbeeTT via pve-devel
--- Begin Message --- On Tue, Jul 16, 2024 at 4:49 PM Mira Limbeck wrote: > > Hi Matias, > > Thank you for providing this detailed description of the issue! Hello Mira thanks for your quick response! >From my side I offer all my available energy in order to help. > We have an open issue in our

[pve-devel] applied-series: [PATCH installer v4 0/4] add check/rename for already-existing ZFS rpool

2024-07-16 Thread Thomas Lamprecht
Am 16/07/2024 um 10:18 schrieb Christoph Heiss: > Pretty straight forward overall, implements a check for an existing > `rpool` on the system and ask the user whether they would like to rename > it, much in the same way as it works for VGs already. > > Without this, the installer would silently cr

Re: [pve-devel] [PATCH proxmox-ve-rs 01/21] debian: add files for packaging

2024-07-16 Thread Thomas Lamprecht
Am 27/06/2024 um 12:41 schrieb Gabriel Goller: > On 26.06.2024 14:15, Stefan Hanreich wrote: >> Since we now have a standalone repository for Proxmox VE related >> crates, add the required files for packaging the crates contained in >> this repository. > > I know we don't really do this, but could

Re: [pve-devel] [PATCH manager] www: utils: fix inconsistency in host cpu usage display in search view

2024-07-16 Thread Thomas Lamprecht
Am 16/07/2024 um 11:31 schrieb Christoph Heiss: > Between the number of CPUs and the actual label, a space was missing - > resulting in an inconsistency vs. the "CPU usage" column. > > Also, fix a rather nonsensical check for `maxcpu` above - noticed that > while comparing the implementation to th

Re: [pve-devel] [PATCH installer 00/14] fix #5536: implement post-(auto-)installation notification mechanism

2024-07-16 Thread Thomas Lamprecht
Am 15/07/2024 um 16:31 schrieb Christoph Heiss: > With that in mind it definitely could come in handy. Or maybe a separate > object "disks"/"other-disks"/etc. entirely? So as not have to filter out > the (non-)bootdisks again on the receiving end. Could be fine too, albeit I'd slightly prefer a si

[pve-devel] applied: [PATCH access-control] api: ACL update: fix handling of Permissions.Modify

2024-07-16 Thread Thomas Lamprecht
Am 11/07/2024 um 13:44 schrieb Fabian Grünbichler: > with 8.x, the scope of non-"Permissions.Modify"-based ACL update privileges > were reduced (so that users with for example, VM.Allocate on a VM could only > delegate their own privileges, but not arbitrary other ones). that additional > logic had