Am 04/07/2024 um 14:11 schrieb Fiona Ebner:
> Yes, next time we introduce an apiinfo call, we can just have it fail
> hard upon errors.
Oh, and just to avoid potential future error potential here:
For a new topic-specific API version call that might not work, as the fallback
and (lacking) error ha
On Tue, Jul 02, 2024 at 04:29:25PM GMT, Fabian Grünbichler wrote:
> apologies again for the long delay!
>
> > Johannes Cornelis Draaijer via pve-devel hat
> > am 18.04.2024 22:49 CEST geschrieben:
>
> > Signed-off-by: Johannes Cornelis Draaijer
> > ---
> > src/PVE/API2/LXC.pm | 16 +++
> Wolfgang Bumiller hat am 05.07.2024 09:45 CEST
> geschrieben:
>
>
> On Tue, Jul 02, 2024 at 04:29:25PM GMT, Fabian Grünbichler wrote:
> > apologies again for the long delay!
> >
> > > Johannes Cornelis Draaijer via pve-devel
> > > hat am 18.04.2024 22:49 CEST geschrieben:
> >
> > > Sign
Am 19/09/2023 um 16:10 schrieb Alexandre Derumier:
> Requested by a customer using setup with single vxlan devices.
> ---
> debian/patches/series | 3 ++-
> .../upstream/0001-vxlan-fix-vni-filter.patch | 27 +++
> 2 files changed, 29 insertions(+), 1 delet
Important fix, apparently slipped through in April.
"Re-discovered" it yesterday by coincidence while talking to Aaron.
On Fri, Apr 26, 2024 at 10:12:55AM GMT, Fabian Grünbichler wrote:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
>
> Signed-off-by: Fabian G
Am 26/04/2024 um 10:12 schrieb Fabian Grünbichler:
> 'utf-' is a typo, and can trip up some servers that do strict
> checking/matching.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> see
> https://forum.proxmox.com/threads/invalid-charset-on-automated-install-answer-http-fetch.145
Am 04.07.24 um 19:45 schrieb Thomas Lamprecht:
> Am 04/07/2024 um 14:11 schrieb Fiona Ebner:
>> There is no apiinfo call required anymore. No code is the cleanest kind
>
> Yeah, by the assumption you self choose to use and that I question, so
> not really a useful argument.
>
> In practice, users
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> makes them a bit clearer
>
> Signed-off-by: Dominik Csapak
> ---
> split out in v4
> src/PVE/Mapping/PCI.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
___
pve-de
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> to make it clearer what it actually is. Also we want to add the
> 'real' config as parameter too, and so it's less confusing.
>
> Signed-off-by: Dominik Csapak
> ---
> split out in v4
> src/PVE/Mapping/PCI.pm | 12 ++--
> 1 file changed, 6
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> by placing all expected properties from the hardware into an 'expected_props'
> and those fromt he config into 'configured_props'
>
> the names makes clearer what's what, and we can easily extend it, even
> if the data does not come from the mapping
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> but that lives int he 'global' part of the mapping config, not in a
> specific mapping. To check that, add it to the relevant hashes here.
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v3:
> * leave $cfg optional
>
> src/PVE/Mapping/PCI.
Am 06/06/2024 um 11:22 schrieb Dominik Csapak:
> tpmstate0 is already included in `get_vm_volumes`, and our only storage
> plugin that has unmap_volume implemented is the RBDPlugin, where we call
> unmap in `deactivate_volume`. So it's already ummapped by the
> `deactivate_volumes` calls above.
>
Am 06/06/2024 um 11:21 schrieb Dominik Csapak:
> guest-common 1-4; qemu-server 1-6; pve-manager 1,2
> are preparations/cleanups mostly and could be applied independently
Well, yes and no, they have some interdependency between themselves, so
not full independent.
It would be great if you would no
Quoting Fiona Ebner (2024-06-10 14:59:38)
> In particular, useful for setting the 'on-cbw-error' and 'cbw-timeout'
> options (see BlockdevOptionsCbw in QAPI).
>
> Signed-off-by: Fiona Ebner
> ---
> block/backup.c | 10 +++---
> block/replication.c|
Quoting Fiona Ebner (2024-06-10 14:59:42)
> The callback is invoked when cbw is configured to not break the guest
> write and will abort a backup job immediately. Currently the backup
> has to wait for the rest of the block copy operation to finish before
> checking the cbw error state.
>
> Signed
Quoting Fiona Ebner (2024-06-10 14:59:35)
> A long-standing issue with VM backups in Proxmox VE is that a slow or
> unreachable target would lead to a copy-before-write (cbw) operation
> to break the guest write rather than abort the backup. This is
> unexpected to users and the will end up without
Aaron Lauterer writes:
> gave it a try and it does what it should.
> by enabling the rename feature only for `raw` we avoid potential pitfalls if
> we
> encounter a non regular situation on BTRFS. For example, an
> images/{vmid}/vm-{vmid}-disk-X.qcow2 file directly instead of the
> images/{vmid}
Without my changes I get the following error when I try to do it with
the manually places qcow2 file:
Storage does not support moving of this disk to another VM (500)
And if I enable qcow2 for the rename feature without adding the format
check in the rename_volume function:
diff --git a/src/
Adds the ability to change the owner of a guest image.
Btrfs does not need special commands to rename a subvolume and this can
be achieved the same as in Storage/plugin.pm's rename_volume taking
special care of how the directory structure used by Btrfs.
Signed-off-by: Maximiliano Sandoval
---
Di
Aaron Lauterer writes:
> gave it a try and it does what it should.
> by enabling the rename feature only for `raw` we avoid potential pitfalls if
> we
> encounter a non regular situation on BTRFS. For example, an
> images/{vmid}/vm-{vmid}-disk-X.qcow2 file directly instead of the
> images/{vmid}
This might be useful if somebody wants to match on the new
'backup-job' field in a notification match rule.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js | 4
www/manager6/panel/BackupAdvancedOptions.js | 23 +
2 files changed, 23 insertion
This allows us to access us the backup job id in the send_notification
function, where we can set it as metadata for the notification.
The 'job-id' parameter can only be used by 'root@pam' to prevent
abuse. This has the side effect that manually triggered backup jobs
cannot have the 'job-id' parame
This new API route returns known notification metadata fields and
a list of known possible values. This will be used by the UI to
provide suggestions when adding/modifying match rules.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 139 ++
1 file
Signed-off-by: Lukas Wagner
---
www/manager6/Utils.js | 11 +++
1 file changed, 11 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index f5608944..5b9d86ca 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -2059,6 +2059,17 @@ Ext.define('PVE.Utils
Signed-off-by: Lukas Wagner
---
notifications.adoc | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index acca19b..bdfebd0 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -233,11 +233,16 @@ configurable sch
Also introduce a local viewModel that is linked to a parent viewModel,
allowing us to move the formulas to the panel.
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatc
'job-id' is passed when a backup as started as a job and will be
passed to the notification system as matchable metadata. It it
can be considered 'internal'.
Signed-off-by: Lukas Wagner
---
src/PVE/VZDump/Common.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/VZDum
We need
"utils: add mechanism to add and override translatable notification
event descriptions in the product specific UIs"
otherwise there is an error in the browser console.
Signed-off-by: Lukas Wagner
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
This patch series attempts to improve the user experience when creating
notification matchers.
Some of the noteworthy changes:
- Allow setting a custom backup job ID, similar how we handle it for
sync/prune jobs in PBS (to allow recognizable names used in matchers)
- New metadata fields:
Signed-off-by: Lukas Wagner
---
notifications.adoc | 4
1 file changed, 4 insertions(+)
diff --git a/notifications.adoc b/notifications.adoc
index bdfebd0..6425e6c 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -312,6 +312,10 @@ Notification Events
| `job-id` | Job ID
Signed-off-by: Lukas Wagner
---
notifications.adoc | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index 25a9391..acca19b 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -301,19 +301,21 @@ Notification E
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatcherEdit.js | 189 +-
1 file changed, 95 insertions(+), 94 deletions(-)
diff --git a/src/windo
Also introduce a local viewModel that is linked to a parent viewModel,
allowing us to move the formulas to the panel.
This should make the code more cohesive and easier to follow.
No functional changes.
Signed-off-by: Lukas Wagner
Tested-by: Maximiliano Sandoval
---
src/window/NotificationMatc
These changes introduce combogrid pickers for the 'field' and 'value'
form elements for 'match-field' match rules. The 'field' picker shows
a list of all known metadata fields, while the 'value' picker shows a
list of all known values, filtered depending on the current value of
'field'.
The list o
superseded by v8!
On 2024-06-10 10:40, Lukas Wagner wrote:
> This patch series attempts to improve the user experience when creating
> notification matchers.
>
> Some of the noteworthy changes:
> - Fixup inconsistent 'hostname' field. Some notification events sent
> the hostname including a
Fix #5105: Overhaul TLS Handshake Checking Logic
This series fixes bug #5105 [1] by overhauling the TLS handshake
checking logic, which is performed when using a connection acceptor
variant with optional TLS.
In the case of PBS (the only place wher
This adds the structs `AcceptState` and `AcceptFlags` and adapts
relevant method signatures of `AcceptBuilder` accordingly. This makes
it easier to add further parameters in the future.
Signed-off-by: Max Carrara
---
proxmox-rest-server/src/connection.rs | 72 ++-
1 file
On rare occasions, the TLS "client hello" message [1] is delayed after
a connection with the server was established, which causes HTTPS
requests to fail before TLS was even negotiated. In these cases, the
server would incorrectly respond with "HTTP/1.1 400 Bad Request"
instead of closing the connec
.. in order to make debugging easier and logs more helpful.
Signed-off-by: Max Carrara
---
proxmox-rest-server/src/connection.rs | 42 ---
1 file changed, 25 insertions(+), 17 deletions(-)
diff --git a/proxmox-rest-server/src/connection.rs
b/proxmox-rest-server/src/conn
39 matches
Mail list logo
