[pve-devel] [PATCH manager v3 6/6] fix #3893: ui: network: enable bridge_vids field

2024-07-03 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v2: none www/manager6/node/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index d27592ce..7bdfb6d9 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @

[pve-devel] [PATCH widget-toolkit v3] fix #3892: Network: add bridge vids field for bridge_vids

2024-07-03 Thread Aaron Lauterer
The new optional bridge_vids field allows to set that property via the GUI. Since the backend needs to support it, the field needs to be explicitly enabled. For now, Proxmox VE (PVE) is the use case. Signed-off-by: Aaron Lauterer --- changes since v2: * added validation code following how it is

[pve-devel] [PATCH common v3 2/3] fix #3893: network: add vlan id and range parameter definitions

2024-07-03 Thread Aaron Lauterer
This is one step to make it possible to define the VLAN IDs and ranges for bridges. It is expected to be used in combination with the `-list` magic property. Therefore it defines and checks the validity of a single list item that could just be a single VLAN tag ID or a range. Signed-off-by: Aaron

[pve-devel] [PATCH common v3 1/3] tools: add check_list_empty function

2024-07-03 Thread Aaron Lauterer
In some situations we don't want a total empty list. I opted for a dedicated function instead of integrating it as error in the `split_list` function. It is used in many places and the potential fallout from unintended behavior changes is too big. Signed-off-by: Aaron Lauterer --- changes since v

[pve-devel] [PATCH common v3 3/3] inotify: interfaces: make sure bridge_vids use space as separator

2024-07-03 Thread Aaron Lauterer
Because the API accepts multiple possible list separators we need to make sure that we write the bridge_vids with space as separator, no matter which separator was used when passing it to the API. Signed-off-by: Aaron Lauterer --- changes since v2: * added to make sure the format works as expecte

[pve-devel] [PATCH common, widget-toolkit, manager v3 0/3] fix #3893: make bridge vids configurable

2024-07-03 Thread Aaron Lauterer
this version reworks a few parts since v2. * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` * explicitly use spaces when writing interfaces file. This is one possible approach to deal with the fact, that the generic `-list` format will accept quite a few delimiters and w

[pve-devel] [PATCH manager v3 5/6] fix #3893: api: network: add bridge_vids parameter

2024-07-03 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v2: * added checks to handle empty lists PVE/API2/Network.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index f39f04f5..dd3855d1 100644 --- a/PVE/API2/Network.pm +++

Re: [pve-devel] [PATCH v2 common 1/4] fix #3893: network: make bridge vids configurable

2024-07-03 Thread Aaron Lauterer
new patch series (v3) is available https://lists.proxmox.com/pipermail/pve-devel/2024-July/064388.html On 2023-06-14 11:30, Aaron Lauterer wrote: For that we need to add a new format option that checks against valid VLAN tags and ranges, for example: 2 4 100-200 The check, if the default valu

[pve-devel] applied: [PATCH pve-common] tools: fix syscall mknod()

2024-07-03 Thread Wolfgang Bumiller
applied, thanks Interesting how this seems to break on other architectures... On Fri, Jun 07, 2024 at 06:33:13PM GMT, Jing Luo via pve-devel wrote: > From: Jing Luo > To: pve-devel@lists.proxmox.com > Cc: Jing Luo > Subject: [PATCH pve-common] tools: fix syscall mknod() > Date: Fri, 7 Jun 2024

[pve-devel] [PATCH qemu-server] fix #5572: avoid warning about uninitialized value when cloning cloudinit disk

2024-07-03 Thread Fiona Ebner
Some callers like the move disk API endpoint do not pass an explicit completion argument. This is not an issue in general, because qemu_drive_mirror_monitor() defaults to 'complete'. However, there was a string comparision for the cloudinit case that can trigger a warning about the value being unin

[pve-devel] applied: [PATCH v2 qemu] fix #4726: avoid superfluous check in vma code

2024-07-03 Thread Fiona Ebner
Am 14.06.24 um 13:00 schrieb Fiona Ebner: > The 'status' pointer is dereferenced regardless of the NULL check, > i.e. 'status->closed' is accessed after the branch with the check. > Since all callers pass in the address of a struct on the stack, the > pointer can never be NULL. Remove the superfluo

[pve-devel] [PATCH proxmox-firewall 2/3] conntrack: arp: move handling to guest chains

2024-07-03 Thread Stefan Hanreich
In order to make sure we are only affecting VM traffic and no host interfaces that are bridged, move the rules into a chain that gets executed inside the guest chain, rather than setting the rules globally. Since ether type matches on the respective Ethernet header, it doesn't work for packets wit

[pve-devel] [PATCH proxmox-firewall 1/3] cargo: bump dependencies of proxmox-ve-config

2024-07-03 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- proxmox-ve-config/Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-ve-config/Cargo.toml b/proxmox-ve-config/Cargo.toml index cc689c8..b0f3434 100644 --- a/proxmox-ve-config/Cargo.toml +++ b/proxmox-ve-config/Cargo.toml @

[pve-devel] [PATCH proxmox-firewall 3/3] guest: match arp packets via meta

2024-07-03 Thread Stefan Hanreich
When matching via ether type, VLAN packets are not matched. This can cause ARP packets encapsulated in VLAN frames to be dropped. Signed-off-by: Stefan Hanreich --- proxmox-firewall/src/firewall.rs | 2 +- .../tests/snapshots/integration_tests__firewall.snap | 10 ---

[pve-devel] applied: [PATCH storage] volume import: assume target API version is at least 9

2024-07-03 Thread Fiona Ebner
Am 10.06.24 um 11:04 schrieb Fiona Ebner: > The storage API version has been bumped to at least 9 since > libpve-storage = 7.0-4. If the source node is on Proxmox VE 8, where > this change will come in, then the target node can be assumed to be > running either Proxmox VE 8 or, during upgrade, the

[pve-devel] applied: [PATCH qemu-server] fix #5572: avoid warning about uninitialized value when cloning cloudinit disk

2024-07-03 Thread Thomas Lamprecht
Am 03/07/2024 um 10:40 schrieb Fiona Ebner: > Some callers like the move disk API endpoint do not pass an explicit > completion argument. This is not an issue in general, because > qemu_drive_mirror_monitor() defaults to 'complete'. However, there was > a string comparision for the cloudinit case t

[pve-devel] applied: [PATCH qemu-server] autocomplete: backup: also list archives from PBS storages and without compressor extension

2024-07-03 Thread Thomas Lamprecht
Am 14/06/2024 um 13:29 schrieb Fiona Ebner: > While archives with unknown or undetermined subtype could be shown, > this is only for autocompletion, so users can still specify those > manually if required. > > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 inser

[pve-devel] [PATCH storage v2] fix-4272: btrfs: add rename feature

2024-07-03 Thread Maximiliano Sandoval
Adds the ability to change the owner of a guest image. Btrfs does not need special commands to rename a subvolume and this can be achieved the same as in Storage/plugin.pm's rename_volume taking special care of how the directory structure used by Btrfs. Signed-off-by: Maximiliano Sandoval --- s

[pve-devel] applied: [PATCH qemu-server 1/2] api: add missing use statements

2024-07-03 Thread Thomas Lamprecht
Am 12/06/2024 um 14:15 schrieb Fiona Ebner: > --- > PVE/API2/Qemu.pm | 3 +++ > 1 file changed, 3 insertions(+) > > applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinf

[pve-devel] applied: [PATCH docs] backup: mention where fleecing can be configured

2024-07-03 Thread Fabian Grünbichler
On April 29, 2024 4:49 pm, Fiona Ebner wrote: > Reported in the community forum: > https://forum.proxmox.com/threads/145955/post-658380 > > Signed-off-by: Fiona Ebner > --- > vzdump.adoc | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/vzdump.adoc b/vzdump.adoc > in

[pve-devel] applied: [PATCH pve-firmware] d/control: add Conflicts and Replaces for ath9k-htc firmware

2024-07-03 Thread Fabian Grünbichler
On May 17, 2024 11:07 am, Fiona Ebner wrote: > Reported in the community forum [0]. > > Both firmware files that are in the package [1] > >> /lib/firmware/ath9k_htc/htc_7010-1.4.0.fw >> /lib/firmware/ath9k_htc/htc_9271-1.4.0.fw > > seem to have been present since the linux-firmware submodule com

[pve-devel] [PATCH ifupdown2 v2 1/1] fix #5197: do not run scripts ending with .dpkg-{old, new, tmp, dist}

2024-07-03 Thread Stefan Hanreich
This can lead to issue when upgrading from ifupdown to ifupdown2. The particular issue this fixes occurs in the following scenario: * Suppose there is a legacy Debian host with ifupdown and ifenslave installed that has a bond configured in /etc/network/interfaces. * ifenslave installs a script /

Re: [pve-devel] [PATCH ifupdown2 1/1] fix #5197: do not run scripts ending with .dpkg-{old, new, tmp, dist}

2024-07-03 Thread Stefan Hanreich
superseded by https://lists.proxmox.com/pipermail/pve-devel/2024-July/064404.html On 6/27/24 17:01, Stefan Hanreich wrote: > This can lead to issue when upgrading from ifupdown to ifupdown2. The > particular issue this fixes occurs in the following scenario: > > * Suppose there is a legacy Debian

[pve-devel] [PATCH v3 storage] fix #5191: api, cli: implement moving a volume between storages

2024-07-03 Thread Filip Schauer
Add the ability to move a backup, ISO, container template or snippet between storages and nodes via an API method. Moving a VMA backup to a Proxmox Backup Server requires the proxmox-vma-to-pbs package to be installed. Currently only VMA backups can be moved to a Proxmox Backup Server and moving ba

Re: [pve-devel] [PATCH v2 storage] fix #5191: api, cli: implement moving a volume between storages

2024-07-03 Thread Filip Schauer
On 26/06/2024 11:58, Fabian Grünbichler wrote: @@ -1613,6 +1615,15 @@ sub volume_export { run_command(['tar', @COMMON_TAR_FLAGS, '-cf', '-', '-C', $file, '.'], output => '>&'.fileno($fh)); return; + } elsif ($format eq 'backup+size') { nit:

Re: [pve-devel] [PATCH storage] fix-4272: btrfs: add rename feature

2024-07-03 Thread Aaron Lauterer
On 2024-07-03 14:32, Maximiliano Sandoval wrote: Aaron Lauterer writes: Works overall. I did not test edge cases like working around the BTRFS plugin to have qcow2 files instead of the raw files in a subvol. Thanks for testing! [...] I am not too familiar with how BTRFS and our plugi

[pve-devel] applied: [PATCH v2 qemu-server 3/4] backup: prepare: remove outdated QEMU version check

2024-07-03 Thread Fabian Grünbichler
On May 28, 2024 10:50 am, Fiona Ebner wrote: > In Proxmox VE 8, the oldest supported QEMU version is 8.0, so a check > for version 4.0.1 is not required anymore. > > Signed-off-by: Fiona Ebner > --- > > New in v2. > > PVE/VZDump/QemuServer.pm | 4 > 1 file changed, 4 deletions(-) > > dif

[pve-devel] applied: [PATCH v2 qemu-server 2/4] migration: handle replication: remove outdated and inaccurate check for QEMU version

2024-07-03 Thread Fabian Grünbichler
On May 28, 2024 10:50 am, Fiona Ebner wrote: > In Proxmox VE 8, the oldest supported QEMU version is 8.0, so a > check for version 4.2 is not required anymore. The check was also > wrong, because it checked the installed version and not the currently > running one. > > Signed-off-by: Fiona Ebner

Re: [pve-devel] [PATCH v2 qemu-server 1/4] migration: avoid crash with heavy IO on local VM disk

2024-07-03 Thread Fabian Grünbichler
On May 28, 2024 10:50 am, Fiona Ebner wrote: > There is a possibility that the drive-mirror job is not yet done when > the migration wants to inactivate the source's blockdrives: > >> bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' >> failed. > > This can be prevented

Re: [pve-devel] [RFC v2 qemu-server 4/4] move helper to check running QEMU version out of the 'Machine' module

2024-07-03 Thread Fabian Grünbichler
On May 28, 2024 10:50 am, Fiona Ebner wrote: > The version of the running QEMU binary is not related to the machine > version and so it's a bit confusing to have the helper in the > 'Machine' module. It cannot live in the 'Helpers' module, because that > would lead to a cyclic inclusion Helpers <->

Re: [pve-devel] [PATCH v2 qemu-server 1/4] migration: avoid crash with heavy IO on local VM disk

2024-07-03 Thread Fiona Ebner
Am 03.07.24 um 15:15 schrieb Fabian Grünbichler: > On May 28, 2024 10:50 am, Fiona Ebner wrote: >> +eval { >> +mon_cmd( >> +$vmid, >> +"block-job-change", >> +id => $job, >> +type => 'mirror', >> +'copy-mode' => 'write-blocking

Re: [pve-devel] [PATCH v2 qemu-server 1/4] migration: avoid crash with heavy IO on local VM disk

2024-07-03 Thread Fiona Ebner
Am 03.07.24 um 15:44 schrieb Fiona Ebner: > Am 03.07.24 um 15:15 schrieb Fabian Grünbichler: >> On May 28, 2024 10:50 am, Fiona Ebner wrote: >>> + eval { >>> + mon_cmd( >>> + $vmid, >>> + "block-job-change", >>> + id => $job, >>> + type => 'mirror', >

[pve-devel] [PATCH pve-storage] qcow2 format: enable subcluster allocation by default

2024-07-03 Thread Alexandre Derumier via pve-devel
--- Begin Message --- extended_l2 is an optimisation to reduce write amplification. Currently,without it, when a vm write 4k, a full 64k cluster need to be writen. When enabled, the cluster is splitted in 32 subclusters. We use a 128k cluster by default, to have 32 * 4k subclusters https://blogs