[pve-devel] [PATCH v2 manager] vzdump config: add fleecing property string

2024-06-12 Thread Fiona Ebner
This makes it clear(er) that fleecing can be configured as a node-wide default too. Signed-off-by: Fiona Ebner --- Changes in v2: * rebase Since the new pbs-change-detection-mode got added, would be nice to add fleecing soon too to avoid pestering admins twice with the ==> Package distribut

Re: [pve-devel] [PATCH proxmox-backup-qemu] tree-wide: fix typos in comments

2024-06-12 Thread Fiona Ebner
Ping, still applies ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 common] REST environment: warn helpers: also log messages to syslog

2024-06-12 Thread Fiona Ebner
Ping Am 09.02.24 um 15:15 schrieb Fiona Ebner: > for better visibility. When not in a task, warnings from these helpers > are only logged to STDERR, which is particularly unhelpful in case of > daemons. This is the main motivation behind this change. > > For tasks, warnings from these helpers are

[pve-devel] applied: [PATCH proxmox-backup-qemu] tree-wide: fix typos in comments

2024-06-12 Thread Fabian Grünbichler
thanks! On January 19, 2024 10:57 am, Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > header-preamble.c | 4 ++-- > src/backup.rs | 2 +- > src/commands.rs | 6 +++--- > src/lib.rs| 24 > 4 files changed, 18 insertions(+), 18 deletions(-) > > di

[pve-devel] applied: [PATCH v2 manager] vzdump config: add fleecing property string

2024-06-12 Thread Fabian Grünbichler
thanks! On June 12, 2024 10:16 am, Fiona Ebner wrote: > This makes it clear(er) that fleecing can be configured as a node-wide > default too. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * rebase > > Since the new pbs-change-detection-mode got added, would be nice to > add fle

Re: [pve-devel] [PATCH guest-common v10 2/11] add dir mapping section config

2024-06-12 Thread Fiona Ebner
Am 14.05.24 um 12:54 schrieb Markus Frank: > diff --git a/src/PVE/Mapping/Dir.pm b/src/PVE/Mapping/Dir.pm > new file mode 100644 > index 000..8f131c2 > --- /dev/null > +++ b/src/PVE/Mapping/Dir.pm > @@ -0,0 +1,205 @@ > +package PVE::Mapping::Dir; > + > +use strict; > +use warnings; > + > +use P

Re: [pve-devel] [PATCH docs v10 3/11] add doc section for the shared filesystem virtio-fs

2024-06-12 Thread Fiona Ebner
Am 14.05.24 um 12:54 schrieb Markus Frank: > Signed-off-by: Markus Frank > --- > qm.adoc | 94 +++-- > 1 file changed, 92 insertions(+), 2 deletions(-) > > diff --git a/qm.adoc b/qm.adoc > index 42c26db..755e20e 100644 > --- a/qm.adoc > +++ b/q

Re: [pve-devel] [PATCH qemu-server v10 4/11] add virtiofsd as runtime dependency for qemu-server

2024-06-12 Thread Fiona Ebner
Commit title should be prefixed with "d/control:" Am 14.05.24 um 12:54 schrieb Markus Frank: > Signed-off-by: Markus Frank > --- > debian/control | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/debian/control b/debian/control > index 1301a36..8e4ca7f 100644 > --- a/debian/control > +++

Re: [pve-devel] [PATCH qemu-server v10 5/11] fix #1027: virtio-fs support

2024-06-12 Thread Fiona Ebner
Am 14.05.24 um 12:54 schrieb Markus Frank: > add support for sharing directories with a guest vm > > virtio-fs needs virtiofsd to be started. > In order to start virtiofsd as a process (despite being a daemon it is does > not > run in the background), a double-fork is used. > > virtiofsd should

[pve-devel] [PATCH qemu-server 1/2] api: add missing use statements

2024-06-12 Thread Fiona Ebner
--- PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 0c3f451a..cf53e820 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -29,6 +29,7 @@ use PVE::QemuServer; use PVE::QemuServer::Cloudinit; use PVE::QemuServer::CPUConfig; us

[pve-devel] [PATCH qemu-server 2/2] api: fix typo reported by perlcritic

2024-06-12 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index cf53e820..86527bd5 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1572,7 +1572,7 @@ __PACKAGE__->register_method({

Re: [pve-devel] [PATCH manager 1/4] ui: homogenize uses of Zstd and SCSI

2024-06-12 Thread Fiona Ebner
Am 23.04.24 um 10:27 schrieb Maximiliano Sandoval: > diff --git a/www/manager6/window/GuestImport.js > b/www/manager6/window/GuestImport.js > index 944d275b..69e7c9bb 100644 > --- a/www/manager6/window/GuestImport.js > +++ b/www/manager6/window/GuestImport.js > @@ -924,6 +924,7 @@ Ext.define('PVE.

Re: [pve-devel] [PATCH manager 4/4] ui: backup job: simplify translatable string

2024-06-12 Thread Fiona Ebner
Am 23.04.24 um 10:27 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > www/manager6/panel/BackupAdvancedOptions.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/panel/BackupAdvancedOptions.js > b/www/manager6/panel/BackupAdvanced

Re: [pve-devel] [PATCH manager] ui: fix pbs storage edit reset behavior

2024-06-12 Thread Fiona Ebner
Am 24.04.24 um 13:03 schrieb Dominik Csapak: > two similar things to fix here: > * the 'crypt-allow-edit' field was not submitted, but it's value was > only ever set with a bind, so a reset always set it to it's > default 'false' value (disabling the radio buttons, even when > it was not visi

[pve-devel] applied: [PATCH manager] ui: fix align mode of two column container

2024-06-12 Thread Fiona Ebner
Am 24.04.24 um 13:39 schrieb Dominik Csapak: > 'stretch' is most often the wrong value, as that will stretch > everything, to the height of the whole container, including fields. > That is not desirable, since fields look not good when stretched this > way (e.g. the controls are not correctly align

[pve-devel] [PATCH storage] add API method to move a volume between storages

2024-06-12 Thread Filip Schauer
Add the ability to move a backup, ISO, container template or snippet between storages of a node via an API method. Moving a VMA backup to a Proxmox Backup Server requires the proxmox-vma-to-pbs package to be installed. Currently only VMA backups can be moved to a Proxmox Backup Server and moving ba

Re: [pve-devel] [PATCH storage] add API method to move a volume between storages

2024-06-12 Thread Filip Schauer
I forgot to mention that this fixes #5191 On 12/06/2024 16:45, Filip Schauer wrote: Add the ability to move a backup, ISO, container template or snippet between storages of a node via an API method. Moving a VMA backup to a Proxmox Backup Server requires the proxmox-vma-to-pbs package to be inst

Re: [pve-devel] [PATCH storage/qemu-server/manager v4] implement ova/ovf import for file based storages

2024-06-12 Thread Max Carrara
On Fri May 24, 2024 at 3:21 PM CEST, Dominik Csapak wrote: > This series enables importing ova/ovf from directory based storages, > inclusive upload/download via the webui (ova only). > > It also improves the ovf importer by parsing the ostype, nics, bootorder > (and firmware from vmware exported f

Re: [pve-devel] [PATCH storage v4 03/12] plugin: dir: handle ova files for import

2024-06-12 Thread Max Carrara
On Fri May 24, 2024 at 3:21 PM CEST, Dominik Csapak wrote: > since we want to handle ova files (which are only ovf+images bundled in > a tar file) for import, add code that handles that. > > we introduce a valid volname for files contained in ovas like this: > > storage:import/archive.ova/disk-1.v

Re: [pve-devel] [PATCH storage v4 10/12] plugin: enable import for nfs/btrfs/cifs/cephfs/glusterfs

2024-06-12 Thread Max Carrara
On Fri May 24, 2024 at 3:21 PM CEST, Dominik Csapak wrote: > and reuse the DirPlugin implementation > > Signed-off-by: Dominik Csapak > --- > src/PVE/Storage/BTRFSPlugin.pm | 5 + > src/PVE/Storage/CIFSPlugin.pm | 6 +- > src/PVE/Storage/CephFSPlugin.pm| 6 +- > src/PVE/S

Re: [pve-devel] [PATCH qemu-server v4 3/4] api: create: implement extracting disks when needed for import-from

2024-06-12 Thread Max Carrara
On Fri May 24, 2024 at 3:21 PM CEST, Dominik Csapak wrote: > when 'import-from' contains a disk image that needs extraction > (currently only from an 'ova' archive), do that in 'create_disks' > and overwrite the '$source' volid. > > Collect the names into a 'delete_sources' list, that we use later

Re: [pve-devel] [PATCH qemu-server v4 4/4] api: create: add 'import-extraction-storage' parameter

2024-06-12 Thread Max Carrara
On Fri May 24, 2024 at 3:22 PM CEST, Dominik Csapak wrote: > this is to override the target extraction storage for the option disk > extraction for 'import-from'. This way if the storage does not > supports the content type 'images', one can give an alternative one. > > Signed-off-by: Dominik Csap

Re: [pve-devel] [PATCH manager v4 2/9] ui: guest import: add ova-needs-extracting warning text

2024-06-12 Thread Max Carrara
On Fri May 24, 2024 at 3:22 PM CEST, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/window/GuestImport.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/window/GuestImport.js > b/www/manager6/window/GuestImport.js > index 4bedc211..76ba6dc8 1006