but slight follow-up question below
On May 3, 2024 10:34 am, Fiona Ebner wrote:
> There's functions from all of those being used, but without importing
> first.
>
> Signed-off-by: Fiona Ebner
> ---
> PVE/QemuMigrate.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/PVE/QemuMigrate
one nit below, otherwise very nice to have this!
On May 3, 2024 10:34 am, Fiona Ebner wrote:
> There is a possibility that the drive-mirror job is not yet done when
> the migration wants to inactivate the source's blockdrives:
>
>> bdrv_co_write_req_prepare: Assertion `!(bs->open_flags & BDRV_O_I
Am 23/05/2024 um 11:08 schrieb Fabian Grünbichler:
>> +my $kvm_version = PVE::QemuServer::kvm_user_version();
> wouldn't this need to check the *running* qemu binary for the migrated
> VM, not the *installed* qemu binary on the system?
Yes, this would need to check the running QEMU version via
Signed-off-by: Fabian Grünbichler
---
6.8/master only, patch straight from the linked LKML thread
affected user confirmed it fixes the issue, patch is very small and
straight-forward.
...-devices-which-return-an-unusually-l.patch | 51 +++
1 file changed, 51 insertions(+)
creat
On 5/22/24 12:08, Fabian Grünbichler wrote:
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
since we want to handle ova files (which are only ovf+images bundled in
a tar file) for import, add code that handles that.
we introduce a valid volname for files contained in ovas like this:
storage
It's only used internally there anyway, so make it slightly less
confusing.
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/options.rs | 15 ---
proxmox-tui-installer/src/main.rs | 4 ++--
proxmox-tui-installer/src/options.rs| 18 --
3 files
So we never accidentally show/log the password somewhere. Need to drop
it from `InstallerOptions` in turn too, but it's never used currently
anyway.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/options.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pro
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/setup.rs | 12 ++--
proxmox-tui-installer/src/setup.rs| 10 --
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/proxmox-installer-common/src/setup.rs
b/proxmox-installer-common/src/setup.rs
index 6
A hashed password can be created e.g. using the `mkpasswd(1)`.
This then will allow the auto-installer to pass along a
already-hashed password from the user, instead of simple plaintext.
Signed-off-by: Christoph Heiss
---
Proxmox/Install.pm| 25 ++---
Proxmox/Install/
This series adds a new answer option `global.root_password_hashed`
for the auto-installer, enabling administrators to specify the root
password of the new installation in a hashed format - as generated by
e.g. mkpasswd(1) - instead of plain-text.
Administrators/users might want to avoid passing al
Signed-off-by: Christoph Heiss
---
.../parse_answer/hashed_root_password.json| 20 +++
.../parse_answer/hashed_root_password.toml| 14 +
2 files changed, 34 insertions(+)
create mode 100644
proxmox-auto-installer/tests/resources/parse_answer/hashed_root_passw
Signed-off-by: Christoph Heiss
---
proxmox-auto-installer/src/utils.rs | 9 +++--
.../tests/resources/parse_answer/disk_match.json | 2 +-
.../tests/resources/parse_answer/disk_match_all.json | 2 +-
.../tests/resources/parse_answer/disk_match_any.json | 2
This allows user to specify the root password in a hashed format,
generated using e.g. mkpasswd(1), instead of plaintext.
Signed-off-by: Christoph Heiss
---
proxmox-auto-installer/src/answer.rs | 3 ++-
proxmox-auto-installer/src/utils.rs | 4
2 files changed, 6 insertions(+), 1 deletion(-
On Wed, 2024-05-22 at 10:33 +0200, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> changes since v1:
> * incorporated suggested changes in phrasing to fix grammar and
> distinguish the steps on how to power down the nodes better
>
> pveceph.adoc | 50 +
On May 23, 2024 12:40 pm, Dominik Csapak wrote:
> On 5/22/24 12:08, Fabian Grünbichler wrote:
>> On April 29, 2024 1:21 pm, Dominik Csapak wrote:
>>> since we want to handle ova files (which are only ovf+images bundled in
>>> a tar file) for import, add code that handles that.
>>>
>>> we introduce
On 5/23/24 14:25, Fabian Grünbichler wrote:
On May 23, 2024 12:40 pm, Dominik Csapak wrote:
On 5/22/24 12:08, Fabian Grünbichler wrote:
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
[snip]
+ $target_volname = "$vmid/" . $target_diskname;
this encodes a fact about volname semantics
16 matches
Mail list logo
