Re: [pve-devel] [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-05-08 Thread Aaron Lauterer
ping? can be push out a new version of the assistant with this change? it is unfortunately a rather annoying bug for people who want to install in uefi mode from a usb flash drive On 2024-04-30 12:46, Aaron Lauterer wrote: booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash d

[pve-devel] [PATCH pve-esxi-import-tools/storage] improve error handling/logging

2024-05-08 Thread Dominik Csapak
two smaller patches that improve which error gets shown to the user and logged to syslog in case of an early error when trying to fuse mount pve-esxi-import-tools: Dominik Csapak (1): improve error handling before mounting src/main.rs | 36 +++- 1 file changed,

[pve-devel] [PATCH storage 1/1] esxi: improve error handling for fuse mount tool

2024-05-08 Thread Dominik Csapak
if the fuse tool encounters an error early, it prints it like: Error: some error message on stderr. We can capture that here by redirecting STDERR to $wr and die'ing with the error message. With this we die with the original error message instead of only with the return code which is telling t

[pve-devel] [PATCH pve-esxi-import-tools 1/1] improve error handling before mounting

2024-05-08 Thread Dominik Csapak
when we fail early in the mount process, we did not log any error to the syslog, but only the top most one to stderr. sadly we were not able to see them anywhere, so improve the log by * log the complete error chain with log::error (so we also can see the causes) * add more context hints in main

[pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear

2024-05-08 Thread Dominik Csapak
'MDev' could be interpreted as either 'Mediated Device' or 'Mapped Device', which can confuse users. At least one user was confused: https://forum.proxmox.com/threads/146586/#post-662091 Fix that by writing out 'Mediated Device'. Signed-off-by: Dominik Csapak --- sending as RFC because the text

[pve-devel] applied-series: [PATCH installer v3 0/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-05-08 Thread Thomas Lamprecht
On 30/04/2024 12:46, Aaron Lauterer wrote: > booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash > drive) did not work as grub could not find the partition. > > we now read the uuid / volume_date from the source iso and always set it > explictly to the same value when injecting fil

Re: [pve-devel] [PATCH pve-esxi-import-tools 1/1] improve error handling before mounting

2024-05-08 Thread Thomas Lamprecht
On 08/05/2024 14:41, Dominik Csapak wrote: > when we fail early in the mount process, we did not log any error to the > syslog, but only the top most one to stderr. > > sadly we were not able to see them anywhere, so improve the log by > * log the complete error chain with log::error (so we also c

Re: [pve-devel] [PATCH storage 1/1] esxi: improve error handling for fuse mount tool

2024-05-08 Thread Thomas Lamprecht
On 08/05/2024 14:41, Dominik Csapak wrote: > if the fuse tool encounters an error early, it prints it like: >Error: some error message > on stderr. > > We can capture that here by redirecting STDERR to $wr and die'ing with using just a variable name like $wr without context in a commit messag

Re: [pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear

2024-05-08 Thread Thomas Lamprecht
On 08/05/2024 14:54, Dominik Csapak wrote: > 'MDev' could be interpreted as either 'Mediated Device' or 'Mapped > Device', which can confuse users. > > At least one user was confused: > https://forum.proxmox.com/threads/146586/#post-662091 > > Fix that by writing out 'Mediated Device'. > > Signe