Re: [pve-devel] [PATCH qemu-server v6 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-22 Thread Thomas Lamprecht
Am 19/04/2024 um 12:59 schrieb Markus Frank > diff --git a/amd-sev-support/amd-sev-support.c > b/amd-sev-support/amd-sev-support.c > new file mode 100644 > index 000..73a7bd8 > --- /dev/null > +++ b/amd-sev-support/amd-sev-support.c > @@ -0,0 +1,48 @@ > +#include > +#include > +#include > +

[pve-devel] [PATCH manager 2/2] ui: use pveDescriptionFieldContainer for the advanced backup options

2024-04-22 Thread Dominik Csapak
where we generally want to show a field on the left, but a description on the right. merges the column1/2/B into just items. Signed-off-by: Dominik Csapak --- www/manager6/panel/BackupAdvancedOptions.js | 45 ++--- 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/

[pve-devel] [PATCH manager 1/2] ui: form: add DescriptionFieldContainer

2024-04-22 Thread Dominik Csapak
this is a field container, showing a field on the left column and a description on the right one, with a (default) flex ratio of 1:2 this is helpful when wanting a longer description on the right column but still have the fields aligned. Signed-off-by: Dominik Csapak --- alternatively, we could

Re: [pve-devel] [PATCH manager v3 13/22] vzdump: handle new 'fleecing' property string

2024-04-22 Thread Fiona Ebner
Am 11.04.24 um 11:29 schrieb Fiona Ebner: > @@ -282,6 +293,7 @@ sub read_vzdump_defaults { > } keys %$confdesc_for_defaults > }; > $parse_prune_backups_maxfiles->($defaults, "defaults in VZDump schema"); > +parse_fleecing($defaults); > parse_performance($defaults); > >

[pve-devel] [PATCH manager v2 1/2] ui: form: add TwoColumnContainer

2024-04-22 Thread Dominik Csapak
this is a container, showing a widget on the left column and another one on the right one, with a (default) flex ratio of 1:2 this is helpful when wanting fields to align vertically in an input panel that have different height (e.g. because of text wrapping) Signed-off-by: Dominik Csapak --- cha

[pve-devel] [PATCH manager v2 2/2] ui: use pveTwoColumnContainer for the advanced backup options

2024-04-22 Thread Dominik Csapak
where we generally want to show a field on the left, but a description on the right. merges the column1/2/B into just items. Signed-off-by: Dominik Csapak --- changes from v1: * adapt to changes in 1/2 better viewed with -w, since most of the patch is just adding a level of indent www/manager

Re: [pve-devel] [PATCH manager v2 2/2] ui: use pveTwoColumnContainer for the advanced backup options

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 10:16 schrieb Dominik Csapak: > where we generally want to show a field on the left, but a description > on the right. > > merges the column1/2/B into just items. > > Signed-off-by: Dominik Csapak Getting eslint errors: > [./panel/BackupAdvancedOptions.js]: > WARN: line 158 col

Re: [pve-devel] [PATCH manager v2 2/2] ui: use pveTwoColumnContainer for the advanced backup options

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 10:22 schrieb Fiona Ebner: > Am 22.04.24 um 10:16 schrieb Dominik Csapak: >> where we generally want to show a field on the left, but a description >> on the right. >> >> merges the column1/2/B into just items. >> >> Signed-off-by: Dominik Csapak > > Getting eslint errors: > >> [.

[pve-devel] [PATCH pve-guest-common v6 01/16] vzdump: common: allow 'job-id' as a parameter without being in schema

2024-04-22 Thread Lukas Wagner
'job-id' is passed when a backup as started as a job and will be passed to the notification system as matchable metadata. It it can be considered 'internal'. Signed-off-by: Lukas Wagner --- src/PVE/VZDump/Common.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/VZDum

[pve-devel] [PATCH manager v6 03/16] ui: dc: backup: send 'job-id' property when starting a backup job manually

2024-04-22 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 2619a77b..d68f553c 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -586,11 +586,12

[pve-devel] [PATCH manager v6 02/16] api: jobs: vzdump: pass job 'job-id' parameter

2024-04-22 Thread Lukas Wagner
This allows us to access us the backup job id in the send_notification function, where we can set it as metadata for the notification. Signed-off-by: Lukas Wagner --- PVE/API2/VZDump.pm | 8 PVE/Jobs/VZDump.pm | 4 +++- PVE/VZDump.pm | 6 +++--- 3 files changed, 14 insertions(+), 4

[pve-devel] [PATCH manager v6 06/16] vzdump: apt: notification: do not include domain in 'hostname' field

2024-04-22 Thread Lukas Wagner
- The man page warns about the usage of `hostname -f`, since a host may have multiple domains (or none at all) - The fallback PVE::INotify::nodename() already only returned the hostname without the domain part - Fencing notifications didn't include the domain part anyway This may result i

[pve-devel] [PATCH docs/guest-common/manager/widget-toolkit v6 00/16] notifications: notification metadata matching improvements

2024-04-22 Thread Lukas Wagner
NOTE: Might need a versionened break, since the widget-toolkit-patches depend on new APIs provided by pve-manager. If the API is not present, creating matchers with 'match-field' does not work (cannot load lists of known values/fields) This patch series attempts to improve the user experience when

[pve-devel] [PATCH widget-toolkit v6 12/16] notification: matcher: move match-calendar fields to panel

2024-04-22 Thread Lukas Wagner
Also introduce a local viewModel that is linked to a parent viewModel, allowing us to move the formulas to the panel. This should make the code more cohesive and easier to follow. No functional changes. Signed-off-by: Lukas Wagner Tested-by: Maximiliano Sandoval --- src/window/NotificationMatc

[pve-devel] [PATCH manager v6 08/16] api: notification: add API for getting known metadata fields/values

2024-04-22 Thread Lukas Wagner
This new API route returns known notification metadata fields and a list of known possible values. This will be used by the UI to provide suggestions when adding/modifying match rules. Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 139 ++ 1 file

[pve-devel] [PATCH widget-toolkit v6 11/16] notification: matcher: move match-field formulas to local viewModel

2024-04-22 Thread Lukas Wagner
This should make the code more cohesive and easier to follow. No functional changes. Signed-off-by: Lukas Wagner Tested-by: Maximiliano Sandoval --- src/window/NotificationMatcherEdit.js | 186 +- 1 file changed, 92 insertions(+), 94 deletions(-) diff --git a/src/windo

[pve-devel] [PATCH widget-toolkit v6 13/16] notification: matcher: move match-severity fields to panel

2024-04-22 Thread Lukas Wagner
Also introduce a local viewModel that is linked to a parent viewModel, allowing us to move the formulas to the panel. This should make the code more cohesive and easier to follow. No functional changes. Signed-off-by: Lukas Wagner Tested-by: Maximiliano Sandoval --- src/window/NotificationMatc

[pve-devel] [PATCH widget-toolkit v6 10/16] notification: matcher: match-field: show known fields/values

2024-04-22 Thread Lukas Wagner
These changes introduce combogrid pickers for the 'field' and 'value' form elements for 'match-field' match rules. The 'field' picker shows a list of all known metadata fields, while the 'value' picker shows a list of all known values, filtered depending on the current value of 'field'. The list o

[pve-devel] [PATCH manager v6 09/16] ui: utils: add overrides for translatable notification fields/values

2024-04-22 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- www/manager6/Utils.js | 11 +++ 1 file changed, 11 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 5216198b..89929d21 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -2060,6 +2060,17 @@ Ext.define('PVE.Utils

[pve-devel] [PATCH manager v6 05/16] api: replication: add 'job-id' to notification metadata

2024-04-22 Thread Lukas Wagner
This allows users to create notification match rules for specific replication jobs, if they so desire. Signed-off-by: Lukas Wagner --- PVE/API2/Replication.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index 0dc944c9..5d7

[pve-devel] [PATCH manager v6 04/16] ui: dc: backup: allow to set custom job id in advanced settings

2024-04-22 Thread Lukas Wagner
This might be useful if somebody wants to match on the new 'backup-job' field in a notification match rule. Signed-off-by: Lukas Wagner --- www/manager6/Utils.js | 1 + www/manager6/panel/BackupAdvancedOptions.js | 15 +++ 2 files changed, 16 insertions(+) dif

[pve-devel] [PATCH manager v6 07/16] api: replication: include 'hostname' field for notifications

2024-04-22 Thread Lukas Wagner
The field contains the hostname of the host (without any domain part) which sends the notification. This field can be used in match-field match rules. Signed-off-by: Lukas Wagner --- PVE/API2/Replication.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Replication.pm b/PVE/API2/

[pve-devel] [PATCH docs v6 14/16] notification: clarify that 'hostname' does not include the domain

2024-04-22 Thread Lukas Wagner
This was a bit inconsistent between the different notification types: - APT/VZDump included the domain part - fence notifications did not A decision has been made to unify this by removing the domain part from APT/VZDump notifications. Signed-off-by: Lukas Wagner --- notifications.adoc | 2

[pve-devel] [PATCH docs v6 16/16] notifications: match-field 'exact'-mode can now match multiple values

2024-04-22 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index dec878a..07f0b3e 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -221,11 +221,16 @@ configurable sch

[pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields

2024-04-22 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index 57053c8..dec878a 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -289,19 +289,21 @@ Notification E

Re: [pve-devel] [PATCH widget-toolkit v6 10/16] notification: matcher: match-field: show known fields/values

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 10:31 schrieb Lukas Wagner: > @@ -416,10 +416,22 @@ Ext.define('Proxmox.panel.NotificationRulesEditPanel', { > let me = this; > let record = me.get('selectedRecord'); > let currentData = record.get('data'); > + > +

[pve-devel] [PATCH manager] acme: ui: handle missing meta field in directory response

2024-04-22 Thread Folke Gleumes
When none of the meta fields is set by the directory, the whole dictionary is missing from the response, leading to an exception when testing for fields inside it. Signed-off-by: Folke Gleumes --- www/manager6/node/ACME.js | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --gi

Re: [pve-devel] [PATCH manager] acme: ui: handle missing meta field in directory response

2024-04-22 Thread Stoiko Ivanov
Gave this patch a spin against a quickly setup step-ca container I had lying around - the issue of not being able to register an account without EAB is gone with it. Tested-by: Stoiko Ivanov On Mon, 22 Apr 2024 11:01:02 +0200 Folke Gleumes wrote: > When none of the meta fields is set by the di

Re: [pve-devel] [PATCH manager] acme: ui: handle missing meta field in directory response

2024-04-22 Thread Folke Gleumes
Forgot the reported by trailer: Reported-by: Stoiko Ivanov On Mon, 2024-04-22 at 11:01 +0200, Folke Gleumes wrote: > When none of the meta fields is set by the directory, the whole > dictionary is missing from the response, leading to an exception > when testing for fields inside it. > > Signed

Re: [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 10:31 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > notifications.adoc | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/notifications.adoc b/notifications.adoc > index 57053c8..dec878a 100644 > --- a/notifications.adoc >

Re: [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields

2024-04-22 Thread Lukas Wagner
On 2024-04-22 11:10, Fiona Ebner wrote: >> +| Cluster node fenced |`fencing` | `error` | >> `hostname` >> +| Storage replication job failed |`replication` | `error` | >> `hostname`, `job-id` >> +| Backup succeeded |`vzdump` | `info` |

Re: [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 11:15 schrieb Lukas Wagner: > > > On 2024-04-22 11:10, Fiona Ebner wrote: >>> +| Cluster node fenced |`fencing` | `error` | >>> `hostname` >>> +| Storage replication job failed |`replication` | `error` | >>> `hostname`, `job-id` >>> +| Backup succe

[pve-devel] applied: [PATCH manager v2 1/2] ui: form: add TwoColumnContainer

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 10:16 schrieb Dominik Csapak: > this is a container, showing a widget on the left column and another one > on the right one, with a (default) flex ratio of 1:2 > > this is helpful when wanting fields to align vertically in an input > panel that have different height (e.g. because

Re: [pve-devel] [PATCH manager v16 1/2] ui: qemu: change DisplayEdit logic to use ViewModel instead of listener function

2024-04-22 Thread Dominik Csapak
one minor nit inline, otherwise Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 4/8/24 12:33, Markus Frank wrote: Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 57 ++-- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git

Re: [pve-devel] [PATCH manager v16 2/2] ui: qemu: add clipboard ComboBox as a advanced option in DisplayEdit

2024-04-22 Thread Dominik Csapak
a few comments inline On 4/8/24 12:33, Markus Frank wrote: For SPICE and VNC, a different message is displayed. The backend code for the clipboard option can be found in the 'config: enable vnc clipboard parameter in vga_fmt'-commit in qemu-server. Signed-off-by: Markus Frank --- www/manage

Re: [pve-devel] pve-devel Digest, Vol 167, Issue 233

2024-04-22 Thread Lucio Magini via pve-devel
--- Begin Message --- Ok, ottimo :-) Grazie Lucio Da: "undefined" A: "undefined" Inviato: lunedì 22 aprile 2024 12:00 Oggetto: pve-devel Digest, Vol 167, Issue 233 Send pve-devel mailing list submissions to pve-devel@lists.proxmox.com To subscribe or unsubscribe via the World Wide We

Re: [pve-devel] pve-devel Digest, Vol 167, Issue 233

2024-04-22 Thread Lucio Magini via pve-devel
--- Begin Message --- Certo Edoardo, nessun problema :-) Da: "undefined" A: "undefined" Inviato: lunedì 22 aprile 2024 12:00 Oggetto: pve-devel Digest, Vol 167, Issue 233 Send pve-devel mailing list submissions to pve-devel@lists.proxmox.com To subscribe or unsubscribe via the World Wide W

Re: [pve-devel] [PATCH manager 1/2] ui: form: add DescriptionFieldContainer

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 09:43 schrieb Dominik Csapak: > this is a field container, showing a field on the left column and a > description on the right one, with a (default) flex ratio of 1:2 > > this is helpful when wanting a longer description on the right column > but still have the fields aligned. >

[pve-devel] [PATCH manager v17 1/2] ui: qemu: change logic to use ViewModel instead of listener function

2024-04-22 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- v17: * moved regex to inline match as it is only used once. www/manager6/qemu/DisplayEdit.js | 56 +++- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/www/manager6

[pve-devel] [PATCH manager v17 2/2] ui: qemu: add clipboard ComboBox as a advanced option in DisplayEdit

2024-04-22 Thread Markus Frank
For SPICE and VNC, a different message is displayed. The backend code for the clipboard option can be found in the 'config: enable vnc clipboard parameter in vga_fmt'-commit in qemu-server. Signed-off-by: Markus Frank --- v17: * added "value: '__default__'" to clipboard ComboBox so that reset do

[pve-devel] applied: [PATCH manager] acme: ui: handle missing meta field in directory response

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 11:01 schrieb Folke Gleumes: > When none of the meta fields is set by the directory, the whole > dictionary is missing from the response, leading to an exception > when testing for fields inside it. > > Signed-off-by: Folke Gleumes > --- > www/manager6/node/ACME.js | 9 ++---

Re: [pve-devel] [PATCH storage v2 02/10] plugin: dir: implement import content type

2024-04-22 Thread Fiona Ebner
Am 19.04.24 um 11:45 schrieb Dominik Csapak: > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 22a9729..39a8354 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -654,6 +654,10 @@ sub parse_volname { > return ('backup', $fn); > } e

Re: [pve-devel] [PATCH storage v2 02/10] plugin: dir: implement import content type

2024-04-22 Thread Dominik Csapak
On 4/22/24 13:00, Fiona Ebner wrote: Am 19.04.24 um 11:45 schrieb Dominik Csapak: diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 22a9729..39a8354 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -654,6 +654,10 @@ sub parse_volname { retu

Re: [pve-devel] [PATCH storage v2 02/10] plugin: dir: implement import content type

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 13:09 schrieb Dominik Csapak: > On 4/22/24 13:00, Fiona Ebner wrote: >> Am 19.04.24 um 11:45 schrieb Dominik Csapak: >>> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm >>> index 22a9729..39a8354 100644 >>> --- a/src/PVE/Storage/Plugin.pm >>> +++ b/src/PVE/Storage/

Re: [pve-devel] [PATCH storage v2 02/10] plugin: dir: implement import content type

2024-04-22 Thread Dominik Csapak
On 4/22/24 13:34, Fiona Ebner wrote: Am 22.04.24 um 13:09 schrieb Dominik Csapak: On 4/22/24 13:00, Fiona Ebner wrote: Am 19.04.24 um 11:45 schrieb Dominik Csapak: diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 22a9729..39a8354 100644 --- a/src/PVE/Storage/Plugin.pm +

[pve-devel] applied: [PATCH container/docs/firewall/manager/qemu-server v4 0/5] proxmox firewall nftables

2024-04-22 Thread Thomas Lamprecht
Am 19/04/2024 um 11:42 schrieb Stefan Hanreich: > This patch series contains the remaining patches that are necessary for > proxmox-firewall to work. It adds documentation as well as changes how > firewall-bridges are created when proxmox-firewall is activated. It also > patches > pve-firewall to

[pve-devel] applied: [PATCH pve-network 1/1] api: sdn: fix missing types for 'pending' fields.

2024-04-22 Thread Thomas Lamprecht
Am 18/04/2024 um 18:44 schrieb Johannes Cornelis Draaijer: > Signed-off-by: Johannes Cornelis Draaijer > --- > src/PVE/API2/Network/SDN/Controllers.pm | 2 +- > src/PVE/API2/Network/SDN/Zones.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH pve-network] fix #5319: frr.local: add support for bgp-community

2024-04-22 Thread Thomas Lamprecht
Am 16/04/2024 um 18:25 schrieb Alexandre Derumier: > Need to be inserted after ip prefix-list and before route map > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > applied, th

[pve-devel] applied: [PATCH pve-network] fix #5344: isis: add isis networkid parser

2024-04-22 Thread Thomas Lamprecht
Am 16/04/2024 um 18:24 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Controllers/IsisPlugin.pm | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > applied, thanks! this had some slight conflict with the other patches that git c

[pve-devel] applied: [PATCH v2 pve-network] fix #5364: bgp|evpn: derivated router-id from mac address for ipv6 underlay

2024-04-22 Thread Thomas Lamprecht
Am 12/04/2024 um 14:57 schrieb Alexandre Derumier: > for ipv4, we use the iface ipv4 router-id as router-id need to 32bit. > > That's doesn't work for pure ipv6 underlay network. > > since https://www.rfc-editor.org/rfc/rfc6286, we can use any 32bit id, > it's just need to be unique in the ASN. >

Re: [pve-devel] [PATCH pve-network 0/3] Advertise MTU via DHCP / RA

2024-04-22 Thread Thomas Lamprecht
Am 14/12/2023 um 17:46 schrieb Stefan Hanreich: > Stefan Hanreich (3): > dhcp: fix function signatures in abstract class > zones: add method for getting MTU > dhcp: dnsmasq: send mtu option via dhcp > > src/PVE/Network/SDN/Dhcp.pm | 2 +- > src/PVE/Network/SDN/Dhcp/Dnsmasq.pm

[pve-devel] applied: [PATCH pve-network] fix #5343 : isis: fix ipv6 && custom router config

2024-04-22 Thread Thomas Lamprecht
Am 16/04/2024 um 18:52 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Controllers/IsisPlugin.pm| 3 ++- > src/test/zones/evpn/isis/expected_controller_config | 2 ++ > src/test/zones/evpn/isis_loopback/expected_controller_confi

Re: [pve-devel] [PATCH v2 manager] pve7to8: reword and fix typos in description

2024-04-22 Thread Fiona Ebner
Am 19.04.24 um 18:33 schrieb Alexander Zeidler: > diff --git a/bin/Makefile b/bin/Makefile > index 180a91b5..6c5f9b14 100644 > --- a/bin/Makefile > +++ b/bin/Makefile > @@ -66,10 +66,10 @@ pve6to7.1: > > pve7to8.1: > printf ".TH PVE7TO8 1\n.SH NAME\npve7to8 \- Proxmox VE upgrade checker >

Re: [pve-devel] [PATCH storage v2 02/10] plugin: dir: implement import content type

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 13:56 schrieb Dominik Csapak: > i have to apologize, it seems my previous message was wrong. > after re-checking and re-testing a variant i had before changing it > to not returning any format for ova/ovfs it seems to work fine. > > not sure where the error i got came from (maybe i

[pve-devel] [PATCH qemu-server v7 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-22 Thread Markus Frank
Implement a systemd service that runs a C program that extracts AMD SEV hardware parameters such as reduced-phys-bios and cbitpos from CPUID at boot time, looks if SEV, SEV-ES & SEV-SNP are enabled, and outputs these details as JSON to /run/qemu-server/hw-params.json. This programm can also be use

[pve-devel] [PATCH docs v7 3/3] add AMD SEV documentation

2024-04-22 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- v5: * removed NodeConfig part v4: * added text that SEV-ES is experimental qm.adoc | 103 1 file changed, 103 insertions(+

[pve-devel] [PATCH qemu-server v7 2/3] config: QEMU AMD SEV enable

2024-04-22 Thread Markus Frank
This patch is for enabling AMD SEV (Secure Encrypted Virtualization) support in QEMU VM-Config-Examples: amd_sev: type=std,nodbg=1,noks=1 amd_sev: es,nodbg=1,kernel-hashes=1 Node-Config-Example (gets generated automatically): amd_sev: cbitpos=47,reduced-phys-bios=1 kernel-hashes, reduced-phys-bi

[pve-devel] applied: [PATCH manager v17 1/2] ui: qemu: change logic to use ViewModel instead of listener function

2024-04-22 Thread Dominik Csapak
applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-22 Thread Fiona Ebner
Am 15.04.24 um 10:50 schrieb Markus Frank: > Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM. > If i440fx is selected, another ComboBox will be enabled/visible that does not > have the Intel option, as Intel-vIOMMU is not compatible with i440fx. > Just wondering, is it po

[pve-devel] applied: [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-22 Thread Dominik Csapak
applied both patches, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-22 Thread Fiona Ebner
Am 15.04.24 um 10:50 schrieb Markus Frank: > --- > www/manager6/qemu/MachineEdit.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/qemu/MachineEdit.js > b/www/manager6/qemu/MachineEdit.js > index 48c72c1d..ee2b2dac 100644 > --- a/www/manager6/qemu/MachineEdit.js > +++ b/ww

[pve-devel] [PATCH network v2 0/3] Advertise MTU via DHCP / RA

2024-04-22 Thread Stefan Hanreich
Changes from v1 -> v2: * rebased branch, everything else unchanged pve-network: Stefan Hanreich (3): dhcp: fix function signatures in abstract class zones: add method for getting MTU dhcp: dnsmasq: send mtu option via dhcp src/PVE/Network/SDN/Dhcp.pm | 2 +- src/PVE/Network

[pve-devel] [PATCH pve-network v2 1/3] dhcp: fix function signatures in abstract class

2024-04-22 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Dhcp/Plugin.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/Network/SDN/Dhcp/Plugin.pm b/src/PVE/Network/SDN/Dhcp/Plugin.pm index b99f598..6e985cd 100644 --- a/src/PVE/Network/SDN/Dhcp/Plugin.pm ++

[pve-devel] [PATCH pve-network v2 2/3] zones: add method for getting MTU

2024-04-22 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Zones.pm | 8 src/PVE/Network/SDN/Zones/Plugin.pm | 7 +++ src/PVE/Network/SDN/Zones/SimplePlugin.pm | 8 +++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Zones.pm b/s

[pve-devel] [PATCH pve-network v2 3/3] dhcp: dnsmasq: send mtu option via dhcp

2024-04-22 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Dhcp.pm | 2 +- src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 7 ++- src/PVE/Network/SDN/Dhcp/Plugin.pm | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/SDN/Dhcp.pm inde

Re: [pve-devel] [PATCH pve-network 0/3] Advertise MTU via DHCP / RA

2024-04-22 Thread Stefan Hanreich
On 4/22/24 14:06, Thomas Lamprecht wrote: > seems OK from a high-level glance, would need a rebase now though sent a rebased v2: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063588.html ___ pve-devel mailing list pve-devel@lists.proxmox.c

Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-22 Thread Dominik Csapak
On 4/22/24 15:11, Fiona Ebner wrote: Am 15.04.24 um 10:50 schrieb Markus Frank: Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM. If i440fx is selected, another ComboBox will be enabled/visible that does not have the Intel option, as Intel-vIOMMU is not compatible with i4

Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-22 Thread Dominik Csapak
On 4/22/24 15:13, Fiona Ebner wrote: Am 15.04.24 um 10:50 schrieb Markus Frank: --- www/manager6/qemu/MachineEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/MachineEdit.js b/www/manager6/qemu/MachineEdit.js index 48c72c1d..ee2b2dac 100644 --- a/www/manager6/qemu/

Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 15:18 schrieb Dominik Csapak: > On 4/22/24 15:13, Fiona Ebner wrote: >> Am 15.04.24 um 10:50 schrieb Markus Frank: >>> --- >>>   www/manager6/qemu/MachineEdit.js | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/www/manager6/qemu/MachineEdit.js >>> b/www/manager6/qemu/M

Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 15:18 schrieb Dominik Csapak: > On 4/22/24 15:13, Fiona Ebner wrote: >> Why not the more accurate 'qm_machine_type' (was introduced in pve-docs = >> 8.1.0)? > > you're right, would be even better (did not realize that existed), i/you can > send/push a follow up? > both of you

Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-22 Thread Dominik Csapak
On 4/22/24 15:21, Thomas Lamprecht wrote: Am 22/04/2024 um 15:18 schrieb Dominik Csapak: On 4/22/24 15:13, Fiona Ebner wrote: Why not the more accurate 'qm_machine_type' (was introduced in pve-docs = 8.1.0)? you're right, would be even better (did not realize that existed), i/you can send/p

Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-22 Thread Fiona Ebner
Am 22.04.24 um 15:16 schrieb Dominik Csapak: > On 4/22/24 15:11, Fiona Ebner wrote: > >> >> Should we display some hint that Intel can/should also be used even if >> you have an AMD? Maybe even just in the text we display, like "Intel >> (also used for AMD)" but hope somebody can come up with some

[pve-devel] applied: [PATCH network v2 0/3] Advertise MTU via DHCP / RA

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 15:15 schrieb Stefan Hanreich: > Changes from v1 -> v2: > * rebased branch, everything else unchanged > > pve-network: > > Stefan Hanreich (3): > dhcp: fix function signatures in abstract class > zones: add method for getting MTU > dhcp: dnsmasq: send mtu option via dhcp >

Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-22 Thread Thomas Lamprecht
Am 22/04/2024 um 15:24 schrieb Fiona Ebner: > Am 22.04.24 um 15:16 schrieb Dominik Csapak: >> On 4/22/24 15:11, Fiona Ebner wrote: >>> Should we display some hint that Intel can/should also be used even if >>> you have an AMD? Maybe even just in the text we display, like "Intel >>> (also used for A

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-04-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 118 +++--- 1 file changed, 39 insertions(+), 79 deletions(-) diff --git a/it.po b/it.po index af63294..26e6e69 100644 --- a/it.po +++ b/it.po @@ -714,9 +714,8 @@ msgid "Are you sure you want to remove