Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-22 Thread Dominik Csapak
On 3/21/24 18:07, Thomas Lamprecht wrote: On 20/03/2024 16:39, Dominik Csapak wrote: needing one less step when adding the storage, assuming most esxi certificates are self-signed. Well this makes it insecure by default though? Which is not something I'd just not mention in such a commit messa

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-22 Thread Thomas Lamprecht
On 22/03/2024 08:29, Dominik Csapak wrote: > On 3/21/24 18:07, Thomas Lamprecht wrote: >> On 20/03/2024 16:39, Dominik Csapak wrote: >>> needing one less step when adding the storage, assuming most esxi >>> certificates are self-signed. >> >> Well this makes it insecure by default though? Which is

Re: [pve-devel] [PATCH manager] ui: storage: esxi: check 'skip certificate verification' by default

2024-03-22 Thread Dominik Csapak
On 3/22/24 09:46, Thomas Lamprecht wrote: On 22/03/2024 08:29, Dominik Csapak wrote: On 3/21/24 18:07, Thomas Lamprecht wrote: On 20/03/2024 16:39, Dominik Csapak wrote: needing one less step when adding the storage, assuming most esxi certificates are self-signed. Well this makes it insecur

Re: [pve-devel] release a new pve-network package ? (evpn fix)

2024-03-22 Thread Thomas Lamprecht
Hi! On 21/03/2024 09:13, DERUMIER, Alexandre wrote: > a critical bug in evpn with multiple nodes is fixed in git, > https://git.proxmox.com/?p=pve-network.git;a=commit;h=e614da43f13e3c61f9b78ee9984364495eff91b6 > but package is still not released > > I see a lot of user bug report since 4 months

[pve-devel] applied: [PATCH stable-7 qemu] fix #2258: select correct device when removing drive snapshot via QEMU

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 13:29, Maximiliano Sandoval wrote: > The QMP command needs to be issued for the device where the disk is > currently attached, not for the device where the disk was attached at > the time the snapshot was taken. > > Fixes the following scenario with a disk image for which > do_snapsh

[pve-devel] applied: [PATCH storage v2] esxi: detect correct os type in 'other' family

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 10:07, Gabriel Goller wrote: > This patch introduces the conversion table for all possible OS Types > that are in the VMWare 'other' family and sets the pve counterpart. > Our default OS Type is 'linux', so including mappings to 'other' makes > sense. > > Signed-off-by: Gabriel Golle

[pve-devel] applied-series: [PATCH docs v3 0/5] improve & unify installation(-related) documentation

2024-03-22 Thread Thomas Lamprecht
On 21/03/2024 16:29, Christoph Heiss wrote: > This series in short tries to bring the documentation for the > ISO installation flow and anything related to it in line the with > respective documentation for PMG. As both products use the same > installer (minus small differences such as LVM options

[pve-devel] applied: [PATCH installer] unconfigured: move terminal size setting before starting debug shell

2024-03-22 Thread Thomas Lamprecht
On 12/03/2024 12:59, Christoph Heiss wrote: > Otherwise, when using the serial debug shell, the console size will be > 0x0. This in turn breaks the TUI installer, as it cannot detect the size > properly. > > It also adjust the size to the proper 80x24 instead of 80x25, as > advertised in the log m

[pve-devel] applied: [PATCH installer] build: run shellcheck as part of `test` step

2024-03-22 Thread Thomas Lamprecht
On 15/03/2024 11:23, Christoph Heiss wrote: > Especially unconfigured.sh is worth checking consistently. > > Running shellcheck also does not really have any notable impact on build > time, so no downside there either. > > Signed-off-by: Christoph Heiss > --- > Makefile| 14 +---

[pve-devel] [PATCH docs] installation: update link to installing on top of Debian to bookworm version

2024-03-22 Thread Christoph Heiss
Seems this just was forgotten, Buster is quite old at this point. Signed-off-by: Christoph Heiss --- pve-installation.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index d123cd4..2c034d6 100644 --- a/pve-installation.adoc +

Re: [pve-devel] [PATCH qemu-server 1/4] usb: fix undef error on string match

2024-03-22 Thread Fiona Ebner
Am 18.03.24 um 12:18 schrieb Dominik Csapak: > '$entry->{host}' can be empty, so we have to check for that before > doing a regex check, otherwise we get ugly errors in the log > > Signed-off-by: Dominik Csapak applied this one, thanks! ___ pve-devel

Re: [pve-devel] [PATCH guest-common 1/2] mapping: pci: add 'live-migration-capable' flag to mappings

2024-03-22 Thread Fiona Ebner
Am 18.03.24 um 12:18 schrieb Dominik Csapak: > so that we can decide in qemu-server to allow live-migration. > the driver and qemu must be capable of that, and it's the > admins responsibility to know and configure that > Nit: "The" and "QEMU" should be capitalized like this. "admins" -> "admin's

Re: [pve-devel] [PATCH qemu-server 3/4] check_local_resources: add more info per mapped device

2024-03-22 Thread Fiona Ebner
Am 18.03.24 um 12:18 schrieb Dominik Csapak: > such as the mapping name and if it's marked for live-migration (pci only) > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 2 +- > PVE/QemuMigrate.pm | 5 +++-- > PVE/QemuServer.pm | 10 ++ > 3 files changed, 10 insertions(+

Re: [pve-devel] [PATCH guest-common 2/2] mapping: pci: optionally return the config in 'find_on_current_node'

2024-03-22 Thread Fiona Ebner
Am 18.03.24 um 12:18 schrieb Dominik Csapak: > this is useful to get to the config without having to parse it again > You could also adapt the call sites that need it to use PVE::Mapping::PCI::config() and PVE::Mapping::PCI::get_node_mapping() instead of PVE::Mapping::PCI::find_on_current_node().

Re: [pve-devel] [PATCH qemu-server 4/4] api: enable live migration for marked mapped pci devices

2024-03-22 Thread Fiona Ebner
Am 18.03.24 um 12:18 schrieb Dominik Csapak: > They have to be marked as 'live-migration-capable' in the mapping > config, and the driver and qemu must support it. > > For the gui checks, we now return a list of 'mapped-with-live-migration' > entries in the migration preflight api call too. > > S

[pve-devel] [PATCH manager 4/9] report: add `apt-cache policy` to list recognized APT sources

2024-03-22 Thread Alexander Zeidler
with their details as well as pinned packages. Omit the "origin" lines, as their value is already visible in the URLs. # apt-cache policy ... Package files: 100 /var/lib/dpkg/status release a=now 500 https://enterprise.proxmox.com/debian/pve bookworm/pve-enterprise amd64 Packages

[pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time

2024-03-22 Thread Alexander Zeidler
While using `/proc/cmdline` would already provide an initial info for debugging passthrough and similar, the use of `dmesg` is an easy way to get the boot date as an absolute value for free (additional to the relative value in `uptime` from `top`). Signed-off-by: Alexander Zeidler --- PVE/Report

[pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections

2024-03-22 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- PVE/Report.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 2c2a5e12..505629c7 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -41,8 +41,6 @@ my $init_report_cmds = sub { 'cat /etc

[pve-devel] [PATCH manager 3/9] report: add list of upgradable packages

2024-03-22 Thread Alexander Zeidler
* to easily see if APT already knows about old packages in use and their exact version * to reconsider asking for applying updates as a first recommendation if the list is empty and no updates have been released very recently # apt list --upgradable ... Listing... pve-manager testing 8.1.

[pve-devel] [PATCH manager 2/9] report: add `jobs.cfg` to debug related network/load/backup/etc issues

2024-03-22 Thread Alexander Zeidler
Suggested-by: Friedrich Weber Signed-off-by: Alexander Zeidler --- PVE/Report.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Report.pm b/PVE/Report.pm index d4191769..6014f13e 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -35,6 +35,7 @@ my $init_report_cmds = sub {

[pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info

2024-03-22 Thread Alexander Zeidler
like on this system: # dmidecode -t bios # dmidecode 3.4 Getting SMBIOS data from sysfs. SMBIOS 3.0.0 present. Handle 0x, DMI type 0, 24 bytes Handle 0x005C, DMI type 13, 22 bytes Signed-off-by: Alexander Zeidler --- PVE/Report.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[pve-devel] [PATCH manager 8/9] report: add info about (un)used memory slots

2024-03-22 Thread Alexander Zeidler
* to see if a RAM upgrade is slot/capacity-wise possible * to spot added/replaced RAM that may now be causing issues # dmidecode -t memory ... Maximum Capacity: 2 TB Number Of Devices: 8 Size: 16 GB Micron Technology 18ASF2G72PZ-2G6D1 Size: 16 GB Micr

[pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts

2024-03-22 Thread Alexander Zeidler
* list availability and installation status of `*microcode` packages * grep for applied "Early OS Microcode Updates" * grep for (un)patched CPU vulnerability messages Signed-off-by: Alexander Zeidler --- PVE/Report.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Report.pm b/PVE/Repo

[pve-devel] [PATCH manager 7/9] report: add info of the mainboard in use

2024-03-22 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- PVE/Report.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Report.pm b/PVE/Report.pm index 3a81bdb2..f28d7b38 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -104,6 +104,7 @@ my $init_report_cmds = sub { hardware => { order =>

Re: [pve-devel] [PATCH manager 7/9] report: add info of the mainboard in use

2024-03-22 Thread Aaron Lauterer
If we add more info, then dmidecode -t {1,2,3} might be interesting as well as those deliver motherboard, system and chassis infos. If you want to see what you get there, run them on some decent servers as most consumer boards and systems will not show useful information here On 2024-03-22

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-22 Thread Christian Ebner
> On 21.03.2024 18:27 CET Thomas Lamprecht wrote: > > > On 05/03/2024 13:54, Christian Ebner wrote: > > +'wakeonlan-bind-interface' => { > > + type => 'string', > > + description => 'Bind to this interface when sending wake on LAN packet', > > + format => 'pve-iface', > > + optiona

Re: [pve-devel] [PATCH manager] ui: pool members: avoid setting request parameter for all edit windows

2024-03-22 Thread Friedrich Weber
On 14/03/2024 15:43, Stefan Sterz wrote: > On Wed Mar 13, 2024 at 9:44 AM CET, Friedrich Weber wrote: >> Currently, after adding a storage to a pool, opening any edit window >> will send a GET request with a superfluous `poolid` parameter and >> cause a parameter verification error in the GUI. This

Re: [pve-devel] [PATCH qemu-server 1/3] stop cleanup: remove unnecessary tpmstate cleanup

2024-03-22 Thread Fiona Ebner
Am 20.03.24 um 13:51 schrieb Dominik Csapak: > tpmstate0 is already included in `get_vm_volumes`, and our only storage > plugin that has unmap_volume implemented is the RBDPlugin, where we call > unmap in `deactivate_volume`. So it's already ummapped by the > `deactivate_volumes` calls above. > >

Re: [pve-devel] [PATCH qemu-server 3/3] api: include not mapped resources for running vms in migrate preconditions

2024-03-22 Thread Stefan Sterz
On Wed Mar 20, 2024 at 1:51 PM CET, Dominik Csapak wrote: > so that we can show a proper warning in the migrate dialog and check it > in the bulk migrate precondition check > > the unavailable_storages and allowed_nodes should be the same as before > > Signed-off-by: Dominik Csapak > --- > not sup

Re: [pve-devel] [PATCH qemu-server 2/3] migrate: call vm_stop_cleanup after stopping in phase3_cleanup

2024-03-22 Thread Fiona Ebner
Am 20.03.24 um 13:51 schrieb Dominik Csapak: > @@ -1591,12 +1593,10 @@ sub phase3_cleanup { > $self->{errors} = 1; > } > > -# always deactivate volumes - avoid lvm LVs to be active on several nodes > -eval { > - PVE::Storage::deactivate_volumes($self->{storecfg}, $sourcevol

[pve-devel] applied: [PATCH storage] zfs: fix duplicate word typo in error message

2024-03-22 Thread Thomas Lamprecht
On 30/01/2024 10:11, Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > src/PVE/Storage/ZFSPoolPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied (since a while already), thanks! ___ pve-devel mailing list pve-devel@l

Re: [pve-devel] [PATCH qemu-server 3/3] api: include not mapped resources for running vms in migrate preconditions

2024-03-22 Thread Fiona Ebner
Am 20.03.24 um 13:51 schrieb Dominik Csapak: > so that we can show a proper warning in the migrate dialog and check it > in the bulk migrate precondition check > > the unavailable_storages and allowed_nodes should be the same as before > > Signed-off-by: Dominik Csapak > --- > not super happy wi

Re: [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating

2024-03-22 Thread Fiona Ebner
Am 21.12.23 um 10:46 schrieb Fabian Grünbichler: > Signed-off-by: Fabian Grünbichler Reviewed-by: Fiona Ebner Tested-by: Fiona Ebner by removing my existing ones, attempt to SSH to other node and fail (just to be sure), running pvecm updatecerts and SSH-ing to other node with new key. > --- >

Re: [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts

2024-03-22 Thread Stoiko Ivanov
On Fri, 22 Mar 2024 14:59:33 +0100 Alexander Zeidler wrote: > * list availability and installation status of `*microcode` packages > * grep for applied "Early OS Microcode Updates" > * grep for (un)patched CPU vulnerability messages > > Signed-off-by: Alexander Zeidler > --- > PVE/Report.pm |

Re: [pve-devel] [PATCH manager 8/9] report: add info about (un)used memory slots

2024-03-22 Thread Alexander Zeidler
On Fri, 2024-03-22 at 14:59 +0100, Alexander Zeidler wrote: > * to see if a RAM upgrade is slot/capacity-wise possible > * to spot added/replaced RAM that may now be causing issues > > # dmidecode -t memory ... > Maximum Capacity: 2 TB > Number Of Devices: 8 > Size: 16 GB Mi

[pve-devel] [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py

2024-03-22 Thread Max Carrara
Improve listvms.py - Version 2 == Notable Changes Since v1 * mypy [0] is now a build dependency and runs automatically on `make install` (and thus also on `make deb` etc.) * JSON output is now directly streamed to stdout via `json.dump()` i

[pve-devel] [PATCH v2 pve-esxi-import-tools 1/7] listvms: remove unused import and variable

2024-03-22 Thread Max Carrara
Signed-off-by: Max Carrara --- Changes v1 --> v2: * none listvms.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/listvms.py b/listvms.py index 0a1b830..d52d184 100755 --- a/listvms.py +++ b/listvms.py @@ -2,7 +2,6 @@ from typing import List, Dict, Optional import json -import os i

[pve-devel] [PATCH v2 pve-esxi-import-tools 4/7] listvms: add arg parser, context manager for connections, fetch helper

2024-03-22 Thread Max Carrara
In order to make the CLI interface more friendly to humans, Python's `argparse` [0] module from the standard library is used to parse the arguments provided to the script. Each option and positional argument also contain a short help text that is shown when running the script with either "-h" or "-

[pve-devel] [PATCH v2 pve-esxi-import-tools 2/7] listvms: reorder imports

2024-03-22 Thread Max Carrara
Signed-off-by: Max Carrara --- Changes v1 --> v2: * remove unused import of `Tuple` type (was accidentally added during spurious rebasing) listvms.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/listvms.py b/listvms.py index d52d184..0b64b0b 100755 --- a/listvms.p

[pve-devel] [PATCH v2 pve-esxi-import-tools 3/7] listvms: improve typing and add dataclasses to represent dicts

2024-03-22 Thread Max Carrara
This commit replaces some of the explicitly imported types from the `typing` module with their inbuilt counterparts, e.g. `typing.List` becomes `list`. This is supported since Python 3.9 [0]. Additionally, file paths are now represented as `pathlib.Path` [1], which also checks whether the given st

[pve-devel] [PATCH v2 pve-esxi-import-tools 7/7] use mypy for automatic type checks in Python

2024-03-22 Thread Max Carrara
This commit adds mypy [0] as build dependency and ensures it is invoked during the package build process. mypy can also be manually invoked via `make lint`. A mypy.ini file [1] is also added to disable errors regarding missing type stubs for pyVmomi and pyVim. [0]: https://www.mypy-lang.org/ [1]

[pve-devel] [PATCH v2 pve-esxi-import-tools 5/7] listvms: dump json directly to stdout

2024-03-22 Thread Max Carrara
Signed-off-by: Max Carrara --- Changes v1 --> v2: * new (thanks for the suggestion, Lukas!) listvms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/listvms.py b/listvms.py index 354844b..58b09df 100755 --- a/listvms.py +++ b/listvms.py @@ -254,7 +254,7 @@ def main():

[pve-devel] [PATCH v2 pve-esxi-import-tools 6/7] listvms: run formatter

2024-03-22 Thread Max Carrara
This commit formats the script using `black -l 80` [0], even though we don't have an official style guide for Python. [0]: https://github.com/psf/black Signed-off-by: Max Carrara --- Changes v1 --> v2: * none listvms.py | 30 +++--- 1 file changed, 23 insertions(+), 7

Re: [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts

2024-03-22 Thread Alexander Zeidler
On Fri, 2024-03-22 at 17:44 +0100, Stoiko Ivanov wrote: > On Fri, 22 Mar 2024 14:59:33 +0100 > Alexander Zeidler wrote: > > > * list availability and installation status of `*microcode` packages > > * grep for applied "Early OS Microcode Updates" > > * grep for (un)patched CPU vulnerability messa