Am 27.11.23 um 12:40 schrieb Philipp Hufnagl:
> Parts contained in activate_storage are needed to be run to fix #5008,
> however, implementing a namespace check there would cause unneeded
> overhead.
>
Actually, maybe we can do without the overhead, which would also avoid
the need for making the
Signed-off-by: Maximiliano Sandoval
---
js/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.LoginView', {
i
By default they have 'autocomplete=off'. From [1]:
> In most modern browsers, setting autocomplete to "off" will not
> prevent a password manager from asking the user if they would like to
> save username and password information, or from automatically filling
> in those values in a site's log
Signed-off-by: Maximiliano Sandoval
---
src/window/TfaWindow.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define('Proxmox.w
Signed-off-by: Maximiliano Sandoval
---
www/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.LoginView', {
I sent this twice by mistake and the commit titles are wrong. Will send
a v2.
Maximiliano Sandoval writes:
> By default they have 'autocomplete=off'. From [1]:
>
> > In most modern browsers, setting autocomplete to "off" will not
> > prevent a password manager from asking the user if they wo
Signed-off-by: Maximiliano Sandoval
---
src/window/TfaWindow.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define('Proxmox.w
Signed-off-by: Maximiliano Sandoval
---
www/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.LoginView', {
Signed-off-by: Maximiliano Sandoval
---
js/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.LoginView', {
i
By default they have 'autocomplete=off'. From [1]:
> In most modern browsers, setting autocomplete to "off" will not
> prevent a password manager from asking the user if they would like to
> save username and password information, or from automatically filling
> in those values in a site's log
--- Begin Message ---
Hello,
As a newcomer to the Proxmox VE community, I'd love to contribute. Being
new I would appreciate any guidance or feedback you have about anything I
could do to fit in with community practices / rules / expectations -
official, unspoken, or otherwise. Also, sorry for the
Signed-off-by: Filip Schauer
---
www/manager6/qemu/HardwareView.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 5b33b1e2..672a7e1a 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView
Allow moving unused/detached disks to another storage.
Signed-off-by: Filip Schauer
---
PVE/API2/Qemu.pm | 3 ---
PVE/QemuServer.pm | 5 +++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 69c5896..97216a3 100644
--- a/PVE/API2/Qemu.pm
Allow moving unused/detached disks to another storage.
qemu-server:
Filip Schauer (1):
fix #1905: Allow moving unused disks
PVE/API2/Qemu.pm | 3 ---
PVE/QemuServer.pm | 5 +++--
2 files changed, 3 insertions(+), 5 deletions(-)
pve-manager:
Filip Schauer (1):
Allow moving unused disks to
Am 19/02/2024 um 12:11 schrieb Filip Schauer:
> Allow moving unused/detached disks to another storage.
this is a repetition of the commit subject, while that is on it's
own OK, I'd rather see a description about why this is OK to do, i.e.,
why was the original check added, what changed since then,
Am 07.12.23 um 14:11 schrieb Maximiliano Sandoval:
> The strings were hard to translate and required some tricks like passing
> 'Ceph ' as an argument. The `/main` part was also removed to simplify
> the flow and UX.
>
But people who have a Ceph repository with 'main' component configured
might b
Am 07.12.23 um 14:35 schrieb Dominik Csapak:
> with this the title is now completely visible when the column is
> expanded, even if it's originally too narrow.
>
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Dominik Csapak
Tested-by: Fiona Ebner
> @@ -139,6 +149,12 @@ Ext.define('PVE.node
Am 14.12.23 um 16:02 schrieb Hannes Duerr:
> Signed-off-by: Hannes Duerr
> ---
> pve-firewall.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pve-firewall.adoc b/pve-firewall.adoc
> index 836a51c..a5e40f9 100644
> --- a/pve-firewall.adoc
> +++ b/pve-firewall.adoc
>
Am 07/12/2023 um 14:35 schrieb Dominik Csapak:
> with this the title is now completely visible when the column is
> expanded, even if it's originally too narrow.
>
> Suggested-by: Thomas Lamprecht
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * wrap the text in the column, instead o
On 2/19/24 14:57, Thomas Lamprecht wrote:
Am 07/12/2023 um 14:35 schrieb Dominik Csapak:
with this the title is now completely visible when the column is
expanded, even if it's originally too narrow.
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
changes from v1:
* wrap the
Am 19/02/2024 um 14:59 schrieb Dominik Csapak:
> On 2/19/24 14:57, Thomas Lamprecht wrote:
>> btw. I first tried `pve-eslint --fix .` inside the (clean) www/manager6
>> folder, but that just resulted in a truncated ceph/Status.js file, so while
>> eslint seems to correctly get the fix option and fi
Am 19.12.23 um 10:40 schrieb Filip Schauer:
> Add an is_native($arch) subroutine to compare a CPU architecture to the
> host CPU architecture. This is brought in from PVE::QemuServer.
>
> Signed-off-by: Filip Schauer
> ---
> src/PVE/Tools.pm | 6 ++
> 1 file changed, 6 insertions(+)
>
> dif
Am 19.12.23 um 10:40 schrieb Filip Schauer:
> Make the default value for 'kvm' consistent and take into account
> whether the VM will run on the same CPU architecture as the host. This
> is a breaking change for VMs with a different CPU architecture running
> on an x86_64 host, since in this case t
Am 19.12.23 um 10:40 schrieb Filip Schauer:
> Signed-off-by: Filip Schauer
> ---
> PVE/QemuServer/CPUConfig.pm | 9 +++--
> PVE/QemuServer/Helpers.pm | 10 ++
> 2 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfi
Am 19.12.23 um 10:40 schrieb Filip Schauer:
> @@ -716,6 +728,33 @@ sub get_cpu_from_running_vm {
> return $1;
> }
>
> +sub get_cpu_bitness {
> +my ($cpu_prop_str, $arch) = @_;
> +
> +die "missing 'arch'\n" if !$arch;
The config's 'arch' defaults to the host arch, so we could do the
Am 19.02.24 um 15:47 schrieb Fiona Ebner:
>> +
>> +if (my $model = $builtin_models->{$cputype}) {
>> +$cputype = $model->{'reported-model'};
>> +} elsif (is_custom_model($cputype)) {
>> +my $custom_cpu = get_custom_model($cputype);
>> +$cputype = $custom_cpu->{'repor
Am 21.12.23 um 10:29 schrieb Fabian Grünbichler:
> we could also add a check somewhere in pve-cluster for this.
>
> Signed-off-by: Fabian Grünbichler
> ---
> pvecm.adoc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/pvecm.adoc b/pvecm.adoc
> index 03fba9f..adfc33f 100644
> --- a/pv
We have some API endpoints that can access the network from the POV of
a Proxmox VE node, like e.g., the one for downloading a template/ISO
image directly to a PVE storage from an HTTP URL, and the matching
query-url-metadata that makes this functionality much more convenient
to use in the UI. But
Adds a new Sys.AccessNetwork privilege that can be used to guard API
endpoints that can do outgoing network requests with (some) user control
over said requests, like e.g. the "download URL to storage" one.
## Backstory:
This stems from an user request [0] w.r.t. the "download image through
and U
Now that the new Sys.AccessNetwork privilege got added to
access-control and the storage download and manager query API
endpoints, the UI should reflect that change and allow opening the
dialogue to download an image from URL also for the users that are
allowed to do so through the new privilege.
The download-url API endpoint has some implications that admins are
unaware of, namely that it basically allow to scan the whole network
via HTTP URLs, and potentially even download some image that the user
should not have access to and adding to a VM that the user controls.
That's why in addition
This was restricted to Sys.Modify + Sys.Audit on the whole cluster to
ensure that only trusted users get access to a method that can scan
the (local) network from the POV of the Proxmox VE node, even if only
through HTTP HEAD requests.
Nowadays there's enough user interest [0] to warrant a separat
What I forgot to mention:
- docs patch is still missing, but would just add an entry for this new priv
in the list of existing privileges with a short description
- there aren't really hard dependencies between the patches of the different
packages, it just won't work, so I do not think we ne
33 matches
Mail list logo
