Re: [pve-devel] [PATCH v1 installer 15/18] auto-installer: use glob crate for pattern matching

2024-02-08 Thread Christoph Heiss
On Tue, Jan 23, 2024 at 06:00:50PM +0100, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > proxmox-auto-installer/Cargo.toml | 1 + > proxmox-auto-installer/src/utils.rs | 48 +++-- > 2 files changed, 19 insertions(+), 30 deletions(-) > > diff --git a/proxm

Re: [pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation

2024-02-08 Thread Christoph Heiss
Did some testing, doing various installs using * different filesystems * pre/post hooks * simple udev matching for disks and network interfaces I did not exercise the udev-matching exhaustively, but as it is pretty generic, that should cover it. The `proxmox-installer-filter` is a nice tooling ad

Re: [pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation

2024-02-08 Thread Christoph Heiss
On Thu, Feb 08, 2024 at 11:26:01AM +0100, Christoph Heiss wrote: > Did some testing, doing various installs using > * different filesystems > * pre/post hooks > * simple udev matching for disks and network interfaces > > I did not exercise the udev-matching exhaustively, but as it is pretty > gener

Re: [pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation

2024-02-08 Thread Aaron Lauterer
On 2/8/24 11:34, Christoph Heiss wrote: On Thu, Feb 08, 2024 at 11:26:01AM +0100, Christoph Heiss wrote: Did some testing, doing various installs using * different filesystems * pre/post hooks * simple udev matching for disks and network interfaces I did not exercise the udev-matching exhaust

Re: [pve-devel] [PATCH v1 installer 14/18] auto-installer: add fetch answer binary

2024-02-08 Thread Christoph Heiss
Sorry for not including this in the first email. On Tue, Jan 23, 2024 at 06:00:49PM +0100, Aaron Lauterer wrote: [..] > diff --git a/proxmox-auto-installer/src/fetch_plugins/partition.rs > b/proxmox-auto-installer/src/fetch_plugins/partition.rs > new file mode 100644 > index 000..0552ddd > --

Re: [pve-devel] [PATCH v1 installer 14/18] auto-installer: add fetch answer binary

2024-02-08 Thread Aaron Lauterer
On 2/8/24 15:18, Christoph Heiss wrote: Sorry for not including this in the first email. On Tue, Jan 23, 2024 at 06:00:49PM +0100, Aaron Lauterer wrote: [..] diff --git a/proxmox-auto-installer/src/fetch_plugins/partition.rs b/proxmox-auto-installer/src/fetch_plugins/partition.rs new file m

[pve-devel] applied: [PATCH pve-access-control] fix #5190: access-control: openid acr format regex

2024-02-08 Thread Thomas Lamprecht
Am 06/02/2024 um 11:11 schrieb Gabriel Goller: > Restrict the acr-value regex a little bit so as to align the behavior > with PBS. The openid documentation says that the acr-value *should* be > an URI [0]. Added a regex that loosely disallows some of the reserved URI > characters specified in the R