by fixing the SCSI feature compatibility check helper. The helper is
also called for disks using import-from, so it has to use the extended
schema when parsing the drive.
Fixes: d1feab4a ("fix #4957: add vendor and product information passthrough for
SCSI-Disks")
Signed-off-by: Fiona Ebner
---
On January 30, 2024 3:34 pm, Fiona Ebner wrote:
> Am 25.01.24 um 13:33 schrieb Fabian Grünbichler:
>> PVE::Storage::path() neither activates the storage of the passed-in volume,
>> nor
>> does it ensure that the returned value is actually a file or block device, so
>> this actually fixes two issue
On January 31, 2024 11:53 am, Fiona Ebner wrote:
> by fixing the SCSI feature compatibility check helper. The helper is
> also called for disks using import-from, so it has to use the extended
> schema when parsing the drive.
>
> Fixes: d1feab4a ("fix #4957: add vendor and product information pass
On 23/01/2024 11:01, Friedrich Weber wrote:
> On 19/01/2024 12:31, Fiona Ebner wrote:
>> Am 19.01.24 um 11:59 schrieb Fiona Ebner:
[...]
>>> Please use log_warn() from PVE::RESTEnvironment for new warnings, so
>>> they also show up in task logs.
>>
>> Sorry, I mean "show up more visibly", because t
Am 08.11.23 um 09:52 schrieb Markus Frank:
> Adds a config file for directories by using a 'map'
> array propertystring for each node mapping.
>
> Next to node & path, there is the optional
> submounts parameter in the map array.
> Additionally there are the default settings for xattr & acl.
>
>
Am 08.11.23 um 09:52 schrieb Markus Frank:
> Add it to both, the perl side (PVE/Cluster.pm) and pmxcfs side
> (status.c).
>
A short explanation what it will be used for would be nice for context.
> Signed-off-by: Markus Frank
Reviewed-by: Fiona Ebner
Am 08.11.23 um 09:52 schrieb Markus Frank:
> build-order:
> 1. cluster
> 2. guest-common
> 3. docs
> 4. qemu-server
> 5. manager
>
> I did not get virtiofsd to run with run_command without creating zombie
> processes after stutdown.
> So I replaced run_command with exec for now.
> Maybe someone c
Am 08.11.23 um 09:52 schrieb Markus Frank:
> +my $map_fmt = {
> +node => get_standard_option('pve-node'),
> +path => {
> + description => "Directory-path that should be shared with the guest.",
> + type => 'string',
> + format => 'pve-storage-path',
> +},
> +submounts =>
On January 30, 2024 7:40 pm, Max Carrara wrote:
> This commit adds the `set_ceph_crash_conf` function, which dynamically
> adapts the host's Ceph configuration in order to allow the Ceph crash
> module's daemon to run without elevated privileges.
>
> This adaptation is only performed if:
> * Ceph
On January 30, 2024 7:40 pm, Max Carrara wrote:
> SC3043 (warning): In POSIX sh, 'local' is undefined.
while I get why you sent this here, it's not related at all to this
series, please send such changes on their own and reference them if
needed in the future.
in this case it's actually not neede
On January 30, 2024 7:40 pm, Max Carrara wrote:
> when creating the cluster's first monitor.
>
> Signed-off-by: Max Carrara
> ---
> PVE/API2/Ceph/MON.pm | 28 +++-
> PVE/Ceph/Services.pm | 12 ++--
> PVE/Ceph/Tools.pm| 38 ++
On January 30, 2024 7:40 pm, Max Carrara wrote:
> Signed-off-by: Max Carrara
> ---
> src/PVE/CephConfig.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm
> index 6b10d46..46b92ea 100644
> --- a/src/PVE/CephConfig.pm
> +++ b/src/PVE/CephConf
On January 30, 2024 7:40 pm, Max Carrara wrote:
> Having a file named e.g. "60" in your current directory will cause it
> to be deleted when executind `pveceph purge`. This commit fixes that
> by making the config hash differ between which values represent file
> paths and which don't.
>
> Signed-
On January 30, 2024 7:40 pm, Max Carrara wrote:
> Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*'
> to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'.
>
> This patch therefore also updates the permissions of '/var/lib/ceph/*/*'.
>
> Signed-off-by: Ma
On January 30, 2024 7:40 pm, Max Carrara wrote:
> Introduction
>
>
> This series fixes #4759 [0], an issue where Ceph's crash daemon is
> unable to post crash logs due to insufficient permissions, through an
> adaptation of our `pveceph` CLI as well as an accompanying Debian
> postins
IMHO the wording/word order with "shared filesystem doc" could be
improved. It's the doc/section for the shared filesystem virtio-fs.
Am 08.11.23 um 09:52 schrieb Markus Frank:
> Signed-off-by: Markus Frank
> ---
> qm.adoc | 84 +++--
> 1 file
Am 08.11.23 um 09:52 schrieb Markus Frank:
> +
> +Known limitations
> +^
> +
> +* Virtiofsd crashing means no recovery until VM is fully stopped
> +and restarted.
> +* Virtiofsd not responding may result in NFS-like hanging access in the VM.
> +* Memory hotplug does not work in comb
Thanks for the review,
2 answers inline. The rest is clear.
On 2024-01-31 13:01, Fiona Ebner wrote:
Am 08.11.23 um 09:52 schrieb Markus Frank:
Adds a config file for directories by using a 'map'
array propertystring for each node mapping.
Next to node & path, there is the optional
submounts
On Tue, Jan 23, 2024 at 06:00:42PM +0100, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer
> ---
> proxmox-auto-installer/Cargo.toml | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/proxmox-auto-installer/Cargo.toml
> b/proxmox-auto-installer/Cargo.toml
> index 75cfb2c..211c605
Am 31.01.24 um 14:42 schrieb Markus Frank:
>>
>> I haven't looked at the code where this is used yet, so I'm as confused
>> as a user now ;) Does this affect mount points within the directory
>> (which the "sub" prefix suggests)? But it's a boolean, so how can I tell
>> "which directories"? The des
Am 31.01.24 um 14:53 schrieb Fiona Ebner:
> Am 31.01.24 um 14:42 schrieb Markus Frank:
>
>
>>>
>>> What could also be mentioned for xattr and acl: do the underlying file
>>> systems need to support these? What happens if they don't?
>> ACLs and xattrs just get ignored if not supported.
>
>
> Pl
On 2024-01-31 15:00, Fiona Ebner wrote:
Am 31.01.24 um 14:53 schrieb Fiona Ebner:
Am 31.01.24 um 14:42 schrieb Markus Frank:
What could also be mentioned for xattr and acl: do the underlying file
systems need to support these? What happens if they don't?
ACLs and xattrs just get ignored
Thanks a lot for tackling this issue!
Gave this a quick spin on a pre-existing 3-node Quincy cluster on which
I provoked a few crashes with `kill -n11 $(pidof ceph-osd)`.
ceph-base with patch 2 applied (provided by Max off-list) correctly
changed the /var/lib/ceph/crash/posted permissions to ceph
Am 08.11.23 um 09:52 schrieb Markus Frank:
> add support for sharing directories with a guest vm
>
> virtio-fs needs virtiofsd to be started.
> In order to start virtiofsd as a process (despite being a daemon it is does
> not run
> in the background), a double-fork is used.
>
> virtiofsd should
Clarify the naming of mount point utils to clearly indicate their
relation to LXC containers.
Signed-off-by: Filip Schauer
---
www/manager6/Utils.js| 12 ++--
www/manager6/lxc/MPEdit.js | 4 ++--
www/manager6/lxc/MultiMPEdit.js | 4 ++--
www/m
Changes since v2:
* Clarify naming of mount point and device passthrough related utils
* Remove unnecessary cbind
* Make the device index selectible
* Add default values as emptyText to the UI elements
* Reorder UI elements to improve the layout
* Disable the Device Passthrough menu entries for non
Signed-off-by: Filip Schauer
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 11 ++
www/manager6/lxc/DeviceEdit.js | 190 +
www/manager6/lxc/Resources.js | 31 +-
4 files changed, 232 insertions(+), 1 deletion(-)
create mode 100
Thanks for the review!
On 26/01/2024 12:14, Fiona Ebner wrote:
>> Some points to discuss:
>>
>> * Fabian and I discussed whether it may be better to pass `-K` and set the
>> "activation skip" flag only for LVs on a *shared* LVM storage. But this may
>> cause issues for users that incorrectly m
On 26/01/2024 16:23, Fiona Ebner wrote:
I might be missing something, but isn't this a normal ExtJS text field?
Does this cbind have any actual consequences? Same for the others.
This cbind is indeed not needed here.
A patch v3 that incorporates your feedback is available:
https://lists.proxm
I feel like this patch should be squashed into the last one, because the
checks are an essential part of the feature and they always should be
applied together anyways.
Am 08.11.23 um 09:52 schrieb Markus Frank:
> +my sub check_vm_create_dir_perm {
> +my ($rpcenv, $authuser, $vmid, $pool, $par
A 'migration: ' prefix would be nice for the commit title.
Am 08.11.23 um 09:52 schrieb Markus Frank:
> add dir mapping checks to check_local_resources
>
So, as long as there is a mapping for the target node, the migration
check goes through. Should it? I mean, nothing ensures that the contents
Since you require the invariant that there is no duplicate entry for a
single node in qemu-server, you could check when adding or updating the
mapping that no such duplicate is created. For example,
pvesh create /cluster/mapping/dir --id foo --map
node=pve8a1,path=/root/bar --map node=pve8a1,path=
32 matches
Mail list logo
