On 17/11/2023 13:53, Wolfgang Bumiller wrote:
> Patch itself LGTM, just a note on sending patch series in general:
>
> If you number patches throughout a whole series rather than the
> individual repositories (as in, this one is labeled 4/4 instead of 1/1),
> it would be nice if the order also hel
Thanks for the review! I'll prepare a v2 that incorporates the UI
changes I suggested earlier. I do have some questions regarding the
concurrent tasks scenario in patch #2, see my separate mail.
On 17/11/2023 13:31, Wolfgang Bumiller wrote:
[...]
>> On 26/01/2023 09:32, Friedrich Weber wrote:
>>>
Thanks for looking into this!
On 17/11/2023 14:09, Wolfgang Bumiller wrote:
[...]
>> return PVE::LXC::Config->lock_config($vmid, $lockcmd);
>
> ^ Here we lock first, then fork the worker, then do `vm_stop` with the
> config lock inherited.
>
> This means that creating multiple shutdown
Previously, the /cluster/replication API handler would fail completely
with a HTTP 403 if a user does have VM.Audit permissions for
a single VM/CT. That was due to the 'noerr' parameter not set for
$rpcenv->check()
Signed-off-by: Lukas Wagner
---
Not sure if this violates our API stability guaran
Signed-off-by: Alexander Zeidler
---
bin/Makefile | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/bin/Makefile b/bin/Makefile
index 06d8148e..2185b009 100644
--- a/bin/Makefile
+++ b/bin/Makefile
@@ -62,10 +62,11 @@ pve6to7.1:
pve7to8.1:
printf ".TH PVE7TO8
xgettext is a robust tool to extract translatable strings from source
code.
Using msgcat for concatenating pot files is not recommended, hence we
also switch to xgettext. It also added garbage when there were comments.
What do we get for free:
- It de-escapes strings. there are 3 cases in our co
