[pve-devel] applied: [PATCH proxmox-kernel-helper] grub-wrapper: don't fail on reinit/refresh error

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 08:53 schrieb Fabian Grünbichler: > these can happen for example if the system > - is set up to boot using systemd-boot > - but grub updates trigger a call to "grub-install" > - and systemd-boot is not installed > > in this case, "proxmox-boot-tool reinit" will fail because of the

[pve-devel] [PATCH manager] ui: qemu wizard: use better boot order for second cd drive

2023-11-21 Thread Dominik Csapak
in the case we add a second cd drive (for windows), we don't want the backend logic to only include the first one, since we cannot know which is bootable and which is (probably) the virtio iso. so instead, emulate the backend logic for the wizard but include both cd drives in that case, otherwise

Re: [pve-devel] pve-network : downgrading frr dependency to suggested

2023-11-21 Thread DERUMIER, Alexandre
> > > > For the code it would be nice to add a helper that asserts that > > > frr > > > is installed > > > for all API endpoints that need it, that way user get informed > > > upfront, similar > > > to how we do it for ceph (but no full web installer for now ^^) > > Yes good idea. > > I don't k

[pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
SI units are used for storage size information, as typically used by hard disk manufacturers. Change the root filesystem usage values in the node summary to be consistent. Signed-off-by: Christian Ebner --- www/manager6/node/StatusView.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[pve-devel] [PATCH container] setup: nixos: set cmode to console by default

2023-11-21 Thread Christoph Heiss
In the default NixOS configuration (e.g. when using prebuilt container images from the Hydra pipeline [0]), getty is only configured for /dev/console, but not any TTY ports. This results in the user just getting a blank, black screen when opening the console in the web UI. With this, the mentioned

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 10:00, Christian Ebner wrote: > SI units are used for storage size information, as typically used by > hard disk manufacturers. > > Change the root filesystem usage values in the node summary to be > consistent. > > Signed-off-by: Christian Ebner > --- > www/manager6/node/StatusView

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Fiona Ebner
Am 21.11.23 um 10:00 schrieb Christian Ebner: > diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js > index d34724f7..a6975b6e 100644 > --- a/www/manager6/node/StatusView.js > +++ b/www/manager6/node/StatusView.js > @@ -72,7 +72,9 @@ Ext.define('PVE.node.StatusView', { >

[pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough

2023-11-21 Thread Filip Schauer
Signed-off-by: Filip Schauer --- Changes since v1: * Remove usb mapping * Add mode, uid and gid fields To get this to build on top of the current master cd731902b7a7, comment out the call to $notification_config->add_matcher in PVE/VZDump.pm for now. www/manager6/Makefile | 1 + www/

[pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This patch series adds the 'notification-mode' setting for backup jobs. It allows users to choose between the 'old-style' notifications (mail to configured address, directly via a call to sendmail) or the 'new-style' notification system. notification-mode has three possible values: - legacy-se

[pve-devel] [PATCH v2 pve-manager 3/4] ui: backup jobs: add 'notification-mode' selector for backup jobs

2023-11-21 Thread Lukas Wagner
This selector allows one to selected between the 'old' (send email directly via sendmail) or the 'new' notification system. The default is 'auto', which sends and email if one is configured, and uses the notification system if no email address is set. Signed-off-by: Lukas Wagner --- www/manager

[pve-devel] [PATCH v2 pve-manager 2/4] vzdump: support 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This parameter lets us choose between the 'legacy' notification system (sendmail to some email addresses) and the 'new' notification system (pub-sub based system with targets and matchers). 'auto' (default) will use the 'legacy' system if a mail address is provided and the 'new' system if not. This

[pve-devel] [PATCH v2 pve-manager 4/4] ui: backup: add 'notification-mode' param for one-shot backup jobs.

2023-11-21 Thread Lukas Wagner
This selector allows one to selected between the 'old' (send email directly via sendmail) or the 'new' notification system. The default is 'auto', which sends and email if one is configured, and uses the notification system if no email address is set. Signed-off-by: Lukas Wagner --- www/manager

[pve-devel] [PATCH v2 pve-guest-common 1/4] vzdump: config: add 'notification-mode' param for backup jobs

2023-11-21 Thread Lukas Wagner
'legacy-sendmail': Use mailto/mailnotification parameters and send emails directly. 'notification-system': Always notify via notification system 'auto': Notify via mail if mailto is set, otherwise use notification system. Signed-off-by: Lukas Wagner --- src/PVE/VZDump/Common.pm | 14

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This is actually v1, not v2. My bad. -- - Lukas ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: lxc: add edit window for device passthrough

2023-11-21 Thread Filip Schauer
Patch v2 available: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060583.html On 30/10/2023 12:27, Filip Schauer wrote: Signed-off-by: Filip Schauer --- Depends on: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059616.html www/manager6/Makefile | 1 +

[pve-devel] [PATCH installer 0/4] tui: small fixup round

2023-11-21 Thread Christoph Heiss
Christoph Heiss (4): tui: do not center EULA text tui: preserve autoreboot checkbox state when switching views tui: add missing argument for low-level installer test-session common: enforce even number of disks for ZFS RAID-10 proxmox-installer-common/src/disk_checks.rs | 8 ++ proxm

[pve-devel] [PATCH installer 3/4] tui: add missing argument for low-level installer test-session

2023-11-21 Thread Christoph Heiss
This broke running the TUI installer in debug mode, does not effect release builds in any way. Fixes: 4b4dfa1 ("low level: testmode: take path to disk image instead of using /dev/null") Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/setup.rs | 2 +- 1 file changed, 1 insertion(

[pve-devel] [PATCH installer 1/4] tui: do not center EULA text

2023-11-21 Thread Christoph Heiss
Brings it in line with the GUI installer. Reported-by: Fiona Ebner Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 4b6b5b2.

[pve-devel] [PATCH installer 2/4] tui: preserve autoreboot checkbox state when switching views

2023-11-21 Thread Christoph Heiss
Instead of reading the checkbox when continuing to the next screen, save its toggle status to the installer state instead on change. Reported-by: Fiona Ebner Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 25 + 1 file changed, 13 insertions(+), 12

[pve-devel] [PATCH installer 4/4] common: enforce even number of disks for ZFS RAID-10

2023-11-21 Thread Christoph Heiss
An uneven number of disks otherwise causes a panic due to an out-of-bounds array access in the loop below. Reported-by: Fiona Ebner Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/disk_checks.rs | 8 1 file changed, 8 insertions(+) diff --git a/proxmox-installer-common

Re: [pve-devel] pve-network : downgrading frr dependency to suggested

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 09:54 schrieb DERUMIER, Alexandre: >> For the code it would be nice to add a helper that asserts that frr is installed for all API endpoints that need it, that way user get informed upfront, similar to how we do it for ceph (but no full web installer f

Re: [pve-devel] [PATCH installer 4/4] common: enforce even number of disks for ZFS RAID-10

2023-11-21 Thread Christoph Heiss
Sent bit to quickly and missed the proper prefix; this fixes #5050 [0]. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5050 On Tue, Nov 21, 2023 at 11:45:51AM +0100, Christoph Heiss wrote: > > An uneven number of disks otherwise causes a panic due to an > out-of-bounds array access in the loo

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Fiona Ebner
Am 21.11.23 um 11:22 schrieb Lukas Wagner: > This patch series adds the 'notification-mode' setting for backup jobs. > It allows users to choose between the 'old-style' notifications > (mail to configured address, directly via a call to sendmail) or > the 'new-style' notification system. > > not

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
> On 21.11.2023 11:05 CET Fiona Ebner wrote: > > > Am 21.11.23 um 10:00 schrieb Christian Ebner: > > diff --git a/www/manager6/node/StatusView.js > > b/www/manager6/node/StatusView.js > > index d34724f7..a6975b6e 100644 > > --- a/www/manager6/node/StatusView.js > > +++ b/www/manager6/node/St

[pve-devel] [PATCH installer 2/2] serial installer: add serial config for grub to target system

2023-11-21 Thread Stoiko Ivanov
Matching if a serial will be needed for grub is based on the target commandline - the speed is also read from there. The unit is based on the ttyS device - although I'd assume that this might not always match up. Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 8 +++- 1 file changed, 7

[pve-devel] [PATCH installer 0/2] fix 2 small issues with recent installer patches

2023-11-21 Thread Stoiko Ivanov
both issues are unrelated, and can be applied individually first is that with the recent creation of /var/lib/vz as dedicated dataset, systems yielded a failed service for var.mount upon shutdown. The fix simply sets the canmount property for the intermediate dataset var and var/lib to off - follo

[pve-devel] [PATCH installer 1/2] zfs: set canmount=off on /var/lib

2023-11-21 Thread Stoiko Ivanov
as explained in zfsprops(4) setting canmount to off is similar to setting mountpoint to none - except that you can still use the dataset for storing properties to be inherited to children (and we want /var/lib/vz to have a mountpoint set) Follows recommendations from upstreams ZFS on / guide: http

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
> On 21.11.2023 12:03 CET Christian Ebner wrote: > > > > On 21.11.2023 11:05 CET Fiona Ebner wrote: > > > > > > Am 21.11.23 um 10:00 schrieb Christian Ebner: > > > diff --git a/www/manager6/node/StatusView.js > > > b/www/manager6/node/StatusView.js > > > index d34724f7..a6975b6e 100644 >

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-21 Thread Stefan Lendl
"DERUMIER, Alexandre" writes: >>>  * dnsmasq and IPv6 (and DHCP in general) do not really play well >>>together, >>>    so using subnets with IPv6 configured is wonky > > I didn't have tested yet, but it's seem that dnsmasq only support old > classic duid reservation and not mac ? > I tested the

[pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
SI units are used for storage size information, as typically used by hard disk manufacturers. Change the root filesystem usage values in the node summary to be consistent. Signed-off-by: Christian Ebner --- Will also send a patch for PMG to be consistent across all of them. changes since v1: -

Re: [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 12:36, Christian Ebner wrote: > SI units are used for storage size information, as typically used by > hard disk manufacturers. > > Change the root filesystem usage values in the node summary to be > consistent. > > Signed-off-by: Christian Ebner > --- > > Will also send a patch

Re: [pve-devel] [PATCH installer 1/2] zfs: set canmount=off on /var/lib

2023-11-21 Thread Fabian Grünbichler
> Stoiko Ivanov hat am 21.11.2023 12:09 CET geschrieben: > > > as explained in zfsprops(4) setting canmount to off is similar to > setting mountpoint to none - except that you can still use the dataset > for storing properties to be inherited to children (and we want > /var/lib/vz to have a m

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
On 11/21/23 11:55, Fiona Ebner wrote: Am 21.11.23 um 11:22 schrieb Lukas Wagner: This patch series adds the 'notification-mode' setting for backup jobs. It allows users to choose between the 'old-style' notifications (mail to configured address, directly via a call to sendmail) or the 'new-style

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Christian Ebner
> On 16.11.2023 11:35 CET Philipp Hufnagl wrote: > > > Currently, when adding a PBS storage with a namespace that does not > exist, the storage gets added normally, but browsing/using it only > returns a cryptic error message. > > This change checks if the namespace entered when adding is vali

[pve-devel] applied: [PATCH installer 2/2] serial installer: add serial config for grub to target system

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 12:09 schrieb Stoiko Ivanov: > Matching if a serial will be needed for grub is based on the target > commandline - the speed is also read from there. The unit is based > on the ttyS device - although I'd assume that this might not always > match up. > > Signed-off-by: Stoiko Ivano

[pve-devel] applied: [PATCH installer 0/4] tui: small fixup round

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 11:45 schrieb Christoph Heiss: > Christoph Heiss (4): > tui: do not center EULA text > tui: preserve autoreboot checkbox state when switching views > tui: add missing argument for low-level installer test-session > common: enforce even number of disks for ZFS RAID-10 > >

[pve-devel] [PATCH v3 pve-manager 3/5] ui: backup jobs: add 'notification-mode' selector for backup jobs

2023-11-21 Thread Lukas Wagner
This selector allows one to selected between the 'old' (send email directly via sendmail) or the 'new' notification system. The default is 'auto', which sends and email if one is configured, and uses the notification system if no email address is set. Signed-off-by: Lukas Wagner --- www/manager

[pve-devel] [PATCH v3 pve-manager 5/5] ui: backup job: change field text for 'mailnotification' field

2023-11-21 Thread Lukas Wagner
... to highlight that this setting only affects the 'legacy-sendmail' mail notifications. Signed-off-by: Lukas Wagner --- Notes: New in v3. www/manager6/dc/Backup.js | 2 +- www/manager6/form/NotificationPolicySelector.js | 2 +- 2 files changed, 2 insertions(+), 2 de

[pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add 'notification-mode' param for one-shot backup jobs.

2023-11-21 Thread Lukas Wagner
This selector allows one to selected between the 'old' (send email directly via sendmail) or the 'new' notification system. The default is 'auto', which sends and email if one is configured, and uses the notification system if no email address is set. Signed-off-by: Lukas Wagner --- www/manager

[pve-devel] [PATCH v3 pve-manager 2/5] vzdump: support 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This parameter lets us choose between the 'legacy' notification system (sendmail to some email addresses) and the 'new' notification system (pub-sub based system with targets and matchers). 'auto' (default) will use the 'legacy' system if a mail address is provided and the 'new' system if not. This

[pve-devel] [PATCH v3 guest-common/manager 0/5] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This patch series adds the 'notification-mode' setting for backup jobs. It allows users to choose between the 'old-style' notifications (mail to configured address, directly via a call to sendmail) or the 'new-style' notification system. notification-mode has three possible values: - legacy-se

[pve-devel] [PATCH v3 pve-guest-common 1/5] vzdump: config: add 'notification-mode' param for backup jobs

2023-11-21 Thread Lukas Wagner
'legacy-sendmail': Use mailto/mailnotification parameters and send emails directly. 'notification-system': Always notify via notification system 'auto': Notify via mail if mailto is set, otherwise use notification system. Signed-off-by: Lukas Wagner --- src/PVE/VZDump/Common.pm | 14

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Philipp Hufnagl
The build in mail-to-root target can be disabled but not be deleted. Is this on purpose? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v2 pve-guest-common 1/4] vzdump: config: add 'notification-mode' param for backup jobs

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 11:22 schrieb Lukas Wagner: > 'legacy-sendmail': Use mailto/mailnotification parameters and send > emails directly. > 'notification-system': Always notify via notification system > 'auto': Notify via mail if mailto is set, otherwise use notification > system. > > Signed-off-by: Lu

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 13:29 schrieb Philipp Hufnagl: > The build in mail-to-root target can be disabled but not be deleted. > Is this on purpose? > it's built-in after all (hardcoded in the code), so yes. ___ pve-devel mailing list pve-devel@lists.proxmox

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Fiona Ebner
Am 21.11.23 um 13:13 schrieb Lukas Wagner: > On 11/21/23 11:55, Fiona Ebner wrote: >> Am 21.11.23 um 11:22 schrieb Lukas Wagner: >>> This should provide a fix/workaround for the users' reports of >>>    - double notifications (these happened in case mailto was set to >>> the same address >>> a

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 13:13 schrieb Lukas Wagner: > On 11/21/23 11:55, Fiona Ebner wrote: >> Can't we just treat 'failure' mode as always defaulting to legacy >> sendmail? And properly deprecate the setting, showing a warning/info >> that new notification system is not used if set to 'failure' for both

[pve-devel] [PATCH docs v15 2/2] add VNC clipboard documentation

2023-11-21 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index 55a4728..cd0d907 100644 --- a/qm.adoc +++ b/qm.adoc @@ -817,6 +817,24 @@ Selecting `serialX` as display '

[pve-devel] [PATCH pve-network] dhcp: fix allocating IP for every defined dhcp-range

2023-11-21 Thread Stefan Hanreich
Due to the wrong check an IP was allocated for every DHCP range, instead of only allocating an IP in the first free DHCP range. Suggested-By: Stefan Lendl Signed-off-by: Stefan Hanreich --- The fix I talked about off-list was actually unrelated to this. It prevented allocating IP addresses in mu

[pve-devel] [PATCH manager v15 1/2] add clipboard comboBox to VM Options

2023-11-21 Thread Markus Frank
For SPICE and VNC, a different message is displayed. Save config in DisplayEdit so that the clipboard setting persist. Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- v15: * changed style of line break in vncHint field www/manager6/qemu/DisplayEdit.js |

Re: [pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add 'notification-mode' param for one-shot backup jobs.

2023-11-21 Thread Lukas Wagner
On 11/21/23 13:38, Philipp Hufnagl wrote: + let notificationModeSelector = Ext.create({ + xtype: 'proxmoxKVComboBox', + comboItems: [ + ['auto', gettext('Auto')], + ['legacy-sendmail', gettext('Email (legacy)')], + ['notificat

[pve-devel] [PATCH docs v2 1/1] gui: add anchor for tags chapter

2023-11-21 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- pve-gui.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pve-gui.adoc b/pve-gui.adoc index bda370f..9e4650d 100644 --- a/pve-gui.adoc +++ b/pve-gui.adoc @@ -383,6 +383,7 @@ and the corresponding interfaces for each menu item on the right. * *Permissions

[pve-devel] [PATCH widget-toolkit v2 1/1] css: add some conditions to the tag classes for the tag view

2023-11-21 Thread Dominik Csapak
in the tag view, we have a custom 'full' style in a place where we can have another tagstyle class above. to compensate for that, we have to add another condition to those styles, namely that there is not the 'proxmox-tags-full' in between. Signed-off-by: Dominik Csapak --- src/css/ext6-pmx.css

[pve-devel] [PATCH docs/wt/manager v2] implement tagview

2023-11-21 Thread Dominik Csapak
this adds a 'tagview' to the web ui, organizing guests by their tags (for details see the pve-manager patch) changes from v1: * rebase on master * adapt to recent tooltip changes * add a comment to TagConfig class to better explain what it does pve-docs: Dominik Csapak (1): gui: add anchor for

[pve-devel] [PATCH manager v2 1/1] ui: implement 'Tag View' for the resource tree

2023-11-21 Thread Dominik Csapak
and keep the functionality in ResourceTree as generic as possible. We achieve this by having an 'itemMap' function that can split one item from the store into multiple to add to the tree. for the updates, we have to have an 'idMapFn' (to get the original id back) we also have to modify how the m

Re: [pve-devel] [PATCH v3 pve-manager 3/5] ui: backup jobs: add 'notification-mode' selector for backup jobs

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 13:23, Lukas Wagner wrote: > This selector allows one to selected between the 'old' (send email > directly via sendmail) or the 'new' notification system. > > The default is 'auto', which sends and email if one is configured, > and uses the notification system if no email address is

[pve-devel] [PATCH v4 pve-manager 4/4] ui: backup job: change field text for 'mailnotification' field

2023-11-21 Thread Lukas Wagner
... to highlight that this setting only affects the 'legacy-sendmail' mail notifications. Signed-off-by: Lukas Wagner --- Notes: New in v3. www/manager6/dc/Backup.js | 2 +- www/manager6/form/NotificationPolicySelector.js | 2 +- 2 files changed, 2 insertions(+), 2 de

[pve-devel] [PATCH v4 pve-manager 1/4] vzdump: support 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This parameter lets us choose between the 'legacy' notification system (sendmail to some email addresses) and the 'new' notification system (pub-sub based system with targets and matchers). 'auto' (default) will use the 'legacy' system if a mail address is provided and the 'new' system if not. This

[pve-devel] [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Lukas Wagner
This patch series adds the 'notification-mode' setting for backup jobs. It allows users to choose between the 'old-style' notifications (mail to configured address, directly via a call to sendmail) or the 'new-style' notification system. notification-mode has three possible values: - legacy-se

[pve-devel] [PATCH v4 pve-manager 2/4] ui: backup jobs: add 'notification-mode' selector for backup jobs

2023-11-21 Thread Lukas Wagner
This selector allows one to selected between the 'old' (send email directly via sendmail) or the 'new' notification system. The default is 'auto', which sends and email if one is configured, and uses the notification system if no email address is set. Signed-off-by: Lukas Wagner --- Notes:

[pve-devel] [PATCH v4 pve-manager 3/4] ui: backup: add 'notification-mode' param for one-shot backup jobs.

2023-11-21 Thread Lukas Wagner
This selector allows one to selected between the 'old' (send email directly via sendmail) or the 'new' notification system. The default is 'auto', which sends and email if one is configured, and uses the notification system if no email address is set. Signed-off-by: Lukas Wagner --- Notes:

Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-21 Thread Christoph Heiss
On Wed, Nov 15, 2023 at 02:30:06PM +0100, Thomas Lamprecht wrote: > > Am 15/11/2023 um 13:23 schrieb Markus Frank: > > Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" > > to allow hyphen in ldap attribute names for pve & pmg. > > [..] > > --- a/src/PVE/JSONSchema.pm > > +++ b/src/P

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-21 Thread DERUMIER, Alexandre
>> >>I tested the DHCPv6 setup now and unfortunately it does not work >>fully. >> >>I have a VNet with both IPv4 and IPv6 subnets. >>The IPAM part works correctly, registering both IPv4 and IPv6. >>In the VM I can get an IPv4 from the DHCP but IPv6 does not work. >> >>I only get a /128 address but

[pve-devel] [PATCH installer v2] zfs: create dataset var-lib-vz for /var/lib/vz

2023-11-21 Thread Stoiko Ivanov
Creating rpool/var/lib/vz and all intermediate datasets causes a service-failure of `var.mount` upon shutdown. creating the dataset for /var/lib/vz directly at the rpool and setting its mountpoint property seems the most robust way to address this. The alternative approach of setting `canmount=of

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 13:16, Christian Ebner wrote: >> On 16.11.2023 11:35 CET Philipp Hufnagl wrote: >> >> >> Currently, when adding a PBS storage with a namespace that does not >> exist, the storage gets added normally, but browsing/using it only >> returns a cryptic error message. >> >> This change

[pve-devel] [PATCH installer] ZFS: detect and handle secure boot

2023-11-21 Thread Fabian Grünbichler
and switch the ESP to grub if it is enabled. Signed-off-by: Fabian Grünbichler --- Proxmox/Install.pm | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 1a4ee93..a2f35ae 100644 --- a/Proxmox/Install.pm +++ b/Proxmo

[pve-devel] [PATCH installer 2/3] set correct maximum for hdsize input

2023-11-21 Thread Folke Gleumes
previously, when opening the dialog multiple times, the maximum was determined by the previous set value, not the maxium possible for the storage Signed-off-by: Folke Gleumes --- proxinstall | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/proxinstal

[pve-devel] [PATCH installer 3/3] only set hdsize when deviating from the maximum

2023-11-21 Thread Folke Gleumes
this prevents a lower hdsize to be set, when intermittently adding a smaller storage device. Signed-off-by: Folke Gleumes --- proxinstall | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 4fc31f8..695826d 100755 --- a/proxinstall +++ b/proxin

[pve-devel] [PATCH installer 1/3] perform early check on hdsize

2023-11-21 Thread Folke Gleumes
until now it was only checked at install time, failing the whole installation Signed-off-by: Folke Gleumes --- proxinstall | 6 ++ 1 file changed, 6 insertions(+) diff --git a/proxinstall b/proxinstall index 01d4cfe..cf8f510 100755 --- a/proxinstall +++ b/proxinstall @@ -1526,6 +1526,12 @@

[pve-devel] applied: [PATCH installer v2] zfs: create dataset var-lib-vz for /var/lib/vz

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 14:11 schrieb Stoiko Ivanov: > Creating rpool/var/lib/vz and all intermediate datasets causes a > service-failure of `var.mount` upon shutdown. > > creating the dataset for /var/lib/vz directly at the rpool and setting > its mountpoint property seems the most robust way to address

[pve-devel] applied: [PATCH installer] ZFS: detect and handle secure boot

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 14:13 schrieb Fabian Grünbichler: > and switch the ESP to grub if it is enabled. > > Signed-off-by: Fabian Grünbichler > --- > Proxmox/Install.pm | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > applied, thanks! _

[pve-devel] applied: [PATCH manager v2 1/2] ui: refactor iso selector out of the cd input panel

2023-11-21 Thread Thomas Lamprecht
Am 20/11/2023 um 16:45 schrieb Dominik Csapak: > and make it into a proper field > it's intended to be used like a single field and exactly as before > > Signed-off-by: Dominik Csapak > --- > no changes > www/manager6/Makefile| 1 + > www/manager6/form/IsoSelector.js | 107

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-21 Thread DERUMIER, Alexandre
see this old article: https://www.isc.org/blogs/routing-configuration-over-dhcpv6-2/ for the custom dhcp option + script on client side ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 13:52, Lukas Wagner wrote: > This patch series adds the 'notification-mode' setting for backup jobs. > It allows users to choose between the 'old-style' notifications > (mail to configured address, directly via a call to sendmail) or > the 'new-style' notification system. > > noti

Re: [pve-devel] [PATCH v4 cluster/network/manager/qemu-server/container/docs 00/33] Add support for DHCP servers to SDN

2023-11-21 Thread DERUMIER, Alexandre
Another example with custom dhcpv6 options + client script https://serverfault.com/a/528425 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs v15 2/2] add VNC clipboard documentation

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 13:39 schrieb Markus Frank: > Signed-off-by: Markus Frank > Reviewed-by: Dominik Csapak > Tested-by: Dominik Csapak > --- > qm.adoc | 18 ++ > 1 file changed, 18 insertions(+) > > applied, thanks! ___ pve-devel mai

[pve-devel] [PATCH pve-network 2/2] sdn: simple: Improve dhcp property description and validation

2023-11-21 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Zones/SimplePlugin.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm b/src/PVE/Network/SDN/Zones/SimplePlugin.pm index f4525d5..7cb65c2 100644 --- a/src/PVE/Network/SDN/Zon

[pve-devel] [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp

2023-11-21 Thread Stefan Hanreich
Suggested-By: Wolfgang Bumiller Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm b/src/PVE/Network/SDN/Zones/SimplePlugin.pm index f30278c..f4525d5 100644 --- a/src/PVE/Netw

[pve-devel] applied: [PATCH manager] ui: qemu wizard: use better boot order for second cd drive

2023-11-21 Thread Thomas Lamprecht
Am 21/11/2023 um 09:35 schrieb Dominik Csapak: > in the case we add a second cd drive (for windows), we don't want the > backend logic to only include the first one, since we cannot know > which is bootable and which is (probably) the virtio iso. > > so instead, emulate the backend logic for the w

[pve-devel] applied: [PATCH manager v4 0/3] fix 2515 use size defaults

2023-11-21 Thread Thomas Lamprecht
Am 29/09/2023 um 15:02 schrieb Aaron Lauterer: > The main goal of this series is to improve the handling of configured > default size & min_size values when creating a new Ceph Pool in the GUI. > > A new Ceph API endpoint, 'cfg/value', is added. It allows us to fetch > values for config keys that

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Christian Ebner
> On 21.11.2023 14:12 CET Philipp Hufnagl wrote: > > > Hmmm... thats very curios. I tried that on my end and it worked fine. > > What datastore did you try to delete? Did you have a valid > configuration for it? Not deleting a datastore (that works fine), I was testing if I am able to deact

[pve-devel] applied-series: [PATCH pve-network 1/2] sdn: require ipam in simple plugin for dhcp

2023-11-21 Thread Wolfgang Bumiller
applied both, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH v4 pve-container 27/33] nic hotplug : add|del ips in ipam

2023-11-21 Thread Wolfgang Bumiller
applied container series with a small `$have_sdn` guard fixup ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network] dhcp: fix allocating IP for every defined dhcp-range

2023-11-21 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH v4 qemu-server 21/33] vmnic add|remove : add|del ip in ipam

2023-11-21 Thread Wolfgang Bumiller
applied qemu-server series (also with a small $have_sdn guard fixup ;-) ) thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 14:40, Christian Ebner wrote: > >> On 21.11.2023 14:12 CET Philipp Hufnagl wrote: >> >> >> Hmmm... thats very curios. I tried that on my end and it worked fine. >> >> What datastore did you try to delete? Did you have a valid >> configuration for it? > > Not deleting a datastore

[pve-devel] [PATCH pve-manager 3/4] ui: dc: config: remove onlineHelp for notification config view

2023-11-21 Thread Lukas Wagner
The 'onlineHelp' is now set in the component definition in 'proxmox-widget-toolkit'. Signed-off-by: Lukas Wagner --- www/manager6/dc/Config.js | 1 - 1 file changed, 1 deletion(-) diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index 74a84e91..f22688f8 100644 --- a/www/manage

[pve-devel] [PATCH docs/manager/proxmox-widget-toolkit 0/4] notifications: add help buttons, linking to the appropriate sections

2023-11-21 Thread Lukas Wagner
Add help buttons for notification related UIs, linking to the appropriate section in the documentation. First patch for pve-manager fixes the build against the latest pve-doc-generator package from the current git master. Requires pve-doc packages to be bumped (due to new section anchors) pve

[pve-devel] [PATCH proxmox-widget-toolkit 4/4] notification ui: add appropriate onlineHelp anchors

2023-11-21 Thread Lukas Wagner
This links the dialog windows to the correct help section (different target types, matchers). Signed-off-by: Lukas Wagner --- src/panel/GotifyEditPanel.js | 1 + src/panel/NotificationConfigView.js | 1 + src/panel/SendmailEditPanel.js| 1 + src/panel/SmtpEditPanel.js

[pve-devel] [PATCH pve-docs 1/4] notification: add anchors for target types/matchers

2023-11-21 Thread Lukas Wagner
This enables us to directly link to the appropriate section from the UI. Signed-off-by: Lukas Wagner --- notifications.adoc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/notifications.adoc b/notifications.adoc index 74447e5..21e13c4 100644 --- a/notifications.adoc +++ b/notifications

[pve-devel] [PATCH pve-manager 2/4] ui: sdn: fix onlineHelp anchors

2023-11-21 Thread Lukas Wagner
These have been renamed in: bcb72b 'sdn: overall language and consistency rework' in pve-docs Signed-off-by: Lukas Wagner --- www/manager6/sdn/VnetPanel.js| 2 +- www/manager6/sdn/VnetView.js | 6 +++--- www/manager6/sdn/ZoneContentPanel.js | 2 +- 3 files changed, 5 insertions(+

[pve-devel] [PATCH network/container/qemu-server 0/3] sdn: register a new IP at VM start if missing

2023-11-21 Thread Stefan Lendl
If a VM or LXC starts and no IP was found in the IPAM, register a new one. This is very seful as a fallback if for some reason an IP mapping was deleted or there is a bug somewhere that does not register an IP. This acts more like DHCP to allocate an IP on demand. Special case that is not cove

[pve-devel] [PATCH pve-network 1/3] sdn: register MAC in IPAM if not found

2023-11-21 Thread Stefan Lendl
if inside add_dhcp_mapping, which is called at VM or LCX start, we do not find an IP in IPAM, register the MAC. This is very useful as a fallback if for some reason an IP mapping was deleted or there is a bug somewhere that does not register an IP. This acts more like DHCP to allocate an IP on de

[pve-devel] [PATCH qemu-server 3/3] sdn: pass vmid and hostname to add_dhcp_mapping

2023-11-21 Thread Stefan Lendl
if no DHCP mapping was found in IPAM it will request a new IP which requires these values. Signed-off-by: Stefan Lendl --- PVE/QemuServer.pm | 2 +- vm-network-scripts/pve-bridge | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServ

[pve-devel] [PATCH pve-container 2/3] sdn: pass vmid and hostname to add_dhcp_mapping

2023-11-21 Thread Stefan Lendl
If no DHCP mapping was found in IPAM it will request a new IP. In order to register an IPAM mapping it requires these values. Signed-off-by: Stefan Lendl --- src/PVE/LXC.pm| 4 ++-- src/lxc-pve-prestart-hook | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/P

[pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible

2023-11-21 Thread Maximiliano Sandoval
We replace the use of nested boxes with grids when possible to ensure correct margins and alignment of widgets. At the end we also remove trailing spaces and colons from labels preceding an input widget, e.g. we replace `DNS Server: ` with `DNS Server`. Differences from v1: - Rebased on top of

[pve-devel] [PATCH installer v2 5/7] gui: change margins in create_basic_grid

2023-11-21 Thread Maximiliano Sandoval
Previously the grids were inserted in a succession of boxes each with its own set of margins and spacing. We define the margins now exclusively in the grid and account for previous values. Note that we match the top and bottom margins of the 'Target Harddisk' panel which does not need to use a gri

[pve-devel] [PATCH installer v2 1/7] gui: move create_basic_grid subroutine definition up

2023-11-21 Thread Maximiliano Sandoval
This will be used in future commits to create grids so we need it to be defined. Signed-off-by: Maximiliano Sandoval --- proxinstall | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/proxinstall b/proxinstall index 01d4cfe..8f40234 100755 --- a/

[pve-devel] [PATCH installer v2 6/7] gui: use basic grid in the network panel

2023-11-21 Thread Maximiliano Sandoval
Using boxes causes the labels to not align correctly in certain circumstances. In the following commits we replace the use of boxes with grids and set the margins and spacing directly on the respective grid. Signed-off-by: Maximiliano Sandoval --- proxinstall | 52 ---

[pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry

2023-11-21 Thread Maximiliano Sandoval
This accounts for the different layout set in the previous commit. Signed-off-by: Maximiliano Sandoval --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 8f40234..a5de06c 100755 --- a/proxinstall +++ b/proxinstall @@ -308,7 +308,7

  1   2   >