one additional comment to the ux:
the match field could use a bit of improvement:
the docs describe the current fields, but for users that
don't deep dive into the docs first it may be confusing having
a simple text input field for that
at least when the type is 'exact' we could offer a
dropdow
Am 12/09/2023 um 11:16 schrieb Fiona Ebner:
> 10 minutes is not long enough when disks are large and/or network
> storages are used when preallocation is not disabled. The default is
> metadata preallocation for qcow2, so there are still reports of the
> issue [0][1]. If allocation really does not
Hi,
Any chance to have it one merged for 8.1 ?
Message initial
De: Alexandre Derumier
Répondre à: Proxmox VE development discussion
À: pve-devel@lists.proxmox.com
Objet: [pve-devel] [PATCH v5 qemu-server 0/3] remote-migration:
migration with different cpu
Date: 26/10/2023 10:
On Fri, Nov 17, 2023 at 06:49:27AM +, DERUMIER, Alexandre wrote:
> Message initial
> De: "DERUMIER, Alexandre"
> À: pve-devel@lists.proxmox.com ,
> aderum...@odiso.com , s.hanre...@proxmox.com
>
> Objet: Re: [pve-devel] [PATCH dnsmasq 0/1] purge previous ip/mac lease
> of dh
Am 17/11/2023 um 09:52 schrieb DERUMIER, Alexandre:
> Any chance to have it one merged for 8.1 ?
rather unlikely, this is very core stuff and could add regressions to one
of our most important use case, would like to avoid rushing it now, sorry.
___
pv
Am 16/11/2023 um 16:21 schrieb Dominik Csapak:
> this series implementes the oneOf schema for the api, see the individual
> patches for more details and changelog
>
> only change is the fixed test for pve-common 3/3
> (did accidentally include the wrong file when sending the patches)
>
> pve-comm
Tested on a 3-node cluster.
Set `osd_pool_default_min_size` and `osd_pool_default_size` on
ceph.confg to min_size=1 size=2, created a pool using the web UI and it
has the correct size after creation.
One things I noticed is that if you set them to, for example min_size=3,
size=2, no errors will b
Am 17/11/2023 um 09:52 schrieb DERUMIER, Alexandre:
> Any chance to have it one merged for 8.1 ?
>>rather unlikely, this is very core stuff and could add regressions to
>>one
>>of our most important use case, would like to avoid rushing it now,
>>sorry.
Ok, no problem.
I'll still maintain it
Am 27/07/2023 um 12:37 schrieb Friedrich Weber:
> Expand the existing section on systemd network interface names with a
> link to the systemd.net-naming-scheme(7) manpage and some information
> about naming scheme versions. Also mention the possibility of
> interface naming changes due to a new nam
#What command did you use?
dhcp_release
or
dhcp_release
>>If all you need is the `lease_prune()` call from your C patch,
>>dnsmasq
>>also does this on a SIGALRM so you could try to see if sending that
>>helps.
>>
>>(dnsmasq also has a dbus api to add/remove leases for the worst
>>case..
Am 13/11/2023 um 16:08 schrieb Stefan Lendl:
> Try to homogenize style and format
> Title case naming conventions for configuration options
> Simplify examples
> Re-phrase descriptions
>
> Signed-off-by: Stefan Lendl
> ---
>
> Notes:
> Used single line heading style
>
> The multi li
> > If all you need is the `lease_prune()` call from your C patch,
> > dnsmasq
> > also does this on a SIGALRM so you could try to see if sending that
> > helps.
> >
> > (dnsmasq also has a dbus api to add/remove leases for the worst
> > case...)
>>ah ok ! didn't known that, I'll try the SIGALRM
Am 03/07/2023 um 14:04 schrieb Noel Ullreich:
> In the docs for pve, pmg, and pbs, the consistency and grammatical
> correctness of some common words was not always good.
> I fixed the words:
> * USB flash drive
> * command line/command-line/commandline
> * motherboard/mainboard/main board
> * pass
On Thu, Nov 16, 2023 at 04:31:25PM +0100, Fabian Grünbichler wrote:
> with ACLs being inherited along the pool hierarchy.
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/PVE/AccessControl.pm | 10 --
> src/test/perm-test6.pl | 16
> src/test/test6.cfg | 5
On Thu, Nov 16, 2023 at 04:31:26PM +0100, Fabian Grünbichler wrote:
> and ensure a missing intermediate pool exists at all times.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> a "missing link" should never happen when modifying via the API (both
> deletion
> with children and
On Fri, Nov 17, 2023 at 06:37:08AM +0100, Thomas Lamprecht wrote:
>
> Am 16/11/2023 um 20:59 schrieb Stoiko Ivanov:
> > without this patch the hostname ends up as the empty string in
> > run-env-info.json, which results in a parse-error in the TUI code
> > (an empty string is not None, but still
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Additionally the access
mode, uid and gid can be specified through their respective properties.
Signed-off-by: Filip Schauer
---
Changes since v5:
* Add error message for when
Patch v6 available
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060367.html
On 16/11/2023 14:35, Wolfgang Bumiller wrote:
On Thu, Nov 16, 2023 at 12:50:44PM +0100, Filip Schauer wrote:
Add a dev[n] argument to the container config to pass devices through to
a container. A device
As reported in the community forum [0] and reproduced locally this
breaks VirtIO network adapters in (at least) the German ISO of Windows
Server 2022. The fix itself was for
> Issue is not fatal but as result acpi-index/"PCI Label ID" property
> is either not shown in device details page or shows
> > If all you need is the `lease_prune()` call from your C patch,
> > dnsmasq
> > also does this on a SIGALRM so you could try to see if sending that
> > helps.
> >
> > (dnsmasq also has a dbus api to add/remove leases for the worst
> > case...)
> > ah ok ! didn't known that, I'll try the SIGA
On 11/17/23 11:46, DERUMIER, Alexandre wrote:
> The problem is that dbus is only working with 1 instance of dnsmasq. :/
>
> That mean it'll not work if we need mulitple instance, in differents
> zones/vrf for example
You should be able to set the service name via `--enable-dbus` then you
can ha
On 11/17/23 11:46, DERUMIER, Alexandre wrote:
> The problem is that dbus is only working with 1 instance of dnsmasq.
> :/
>
> That mean it'll not work if we need mulitple instance, in differents
> zones/vrf for example
>>You should be able to set the service name via `--enable-dbus` then
>>you
>>c
The FQDN (retrieved via the DHCP `host-name` option) might contain the
domain name too, as allowed by RFC 2132.
E.g. if the DHCP server sends
`host-name` => "foo.bar" `domain-name` => "bar"
that would show up in the network setup screen in both UIs as
"foo.bar.bar" as hostname/FQDN.
Fixes
Am 17/11/2023 um 11:45 schrieb Fiona Ebner:
> As reported in the community forum [0] and reproduced locally this
> breaks VirtIO network adapters in (at least) the German ISO of Windows
> Server 2022. The fix itself was for
>
>> Issue is not fatal but as result acpi-index/"PCI Label ID" property
>
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Zones/SimplePlugin.pm | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm
b/src/PVE/Network/SDN/Zones/SimplePlugin.pm
index 4922903..f30278c
This patch series adds support for automatically deploying dnsmasq as a DHCP
server to a simple SDN Zone. This series is now in a state where I think it is
okay to integrate into the respective repositories **except** for pve-container
You can (and should) check out the documentation, but here is
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Zones.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/Network/SDN/Zones.pm
b/src/PVE/API2/Network/SDN/Zones.pm
index 4c8b7e1..1c3356e 100644
--- a/src/PVE/API2/Network/SDN/Zones.pm
+++ b/src/PVE/API2/Network/SDN/Zone
Signed-off-by: Stefan Hanreich
---
PVE/API2/Network.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 00d964a79..f39f04f52 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -660,6 +660,7 @@ __PACKAGE__->register_method({
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/test/run_test_subnets.pl | 8 +++-
src/test/run_test_vnets.pl | 4 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/test/run_test_subnets.pl b/src/test/run_test_subnets.pl
index f6564e1..c98359a 100755
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN.pm | 6 +
src/PVE/API2/Network/SDN/Ipam.pm | 221 ++
src/PVE/API2/Network/SDN/Makefile | 2 +-
3 files changed, 228 insertions(+), 1 deletion(-)
create mode 100644 src/PVE/API2/Network/SDN/Ipam.pm
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b4cb741..5e158b3 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5339,6 +5339,7 @@ sub vmconfig_update_net
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/test/ipams/netbox/expected.add_ip| 2 +-
src/test/ipams/netbox/expected.add_ip_notgateway | 2 +-
src/test/ipams/netbox/expected.add_next_freeip | 2 +-
src/test/ipams/netbox/expected.update_ip | 2 +-
src/
Those methods are used by the DHCP plugins to attain the next free
IP address for a given DHCP range, as well as delete all entries with
a certain MAC address.
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 3 +-
src/PVE/Network/SDN
Signed-off-by: Stefan Hanreich
---
www/manager6/Makefile | 1 +
www/manager6/sdn/SubnetEdit.js | 160 -
2 files changed, 160 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index dccd2ba1c..093452cd7 100644
--- a/
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/lxc-pve-prestart-hook | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook
index 936d0bf..fc577e4 100755
--- a/src/lxc-pve-prestart-hook
+++ b/src/lxc-pve-pre
Adds a new file priv/macs.db for caching the queries to IPAM.
Additionally adds and imeplements methods to the IPAM plugins that
are required for the DHCP functionality.
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams.pm | 80 ++
Additionally add a helper function for parsing the DHCP ranges of a
subnet.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/SubnetPlugin.pm | 29 +
src/PVE/Network/SDN/Subnets.pm | 23 +++
2 files changed, 52 insertions(+)
diff --git a
From: Alexandre Derumier
use to cache mac-ip list association.
can be use by external ipam, firewall,etc for fast lookup
Signed-off-by: Alexandre Derumier
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Clus
Add the option to retrieve the running configuration instead of only
the pending configuration via the config methods. Refactor methods
using the running config to utilize the new parameter.
Add helper methods and return additional attributes from the getter
functions that are needed by the dhcp p
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Subnets.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/API2/Network/SDN/Subnets.pm
b/src/PVE/API2/Network/SDN/Subnets.pm
index eb6b41b..c263cd5 100644
--- a/src/PVE/API2/Network/SDN/Subnets.pm
+++ b/src/PVE/API2/Network/
This abstract class provides several hooks that should be called
during the config generation process, they expose the functionality
for the different configuration tasks required from the DHCP plugins.
add_ip_mapping
Adds a mapping from MAC address to an IP for a given DHCP server. The
DHCP serve
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index 057034f..c306527 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -12,6 +12,7 @@ use PVE::
This helper can be used to create DHCP entries for a specific zone. It
is used by the API to create DHCP leases for VMs/CTs.
Co-Authored-By: Alexandre Derumier
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Dhcp.pm | 115 +++
src/PVE/Network/SDN/Makefile
The plugin creates a dnsmasq@ service that spawns a dnsmasq
instance that handles dhcp for that zone.
The configuration files for a dnsmasq instance lie within
/etc/dnsmasq.d/
The plugin generates the following configuration files:
* 00-default.conf
Contains the default global configuration for
From: Alexandre Derumier
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
vm-network-scripts/pve-bridge | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vm-network-scripts/pve-bridge b/vm-network-scripts/pve-bridge
index d37ce33..e8f8798 100755
--- a/vm-network-scripts
From: Alexandre Derumier
Co-Authored-By: Stefan Hanreich
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 17 +
1 file changed, 17 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b92743c..b4cb741 100644
--- a/PVE/
From: Alexandre Derumier
Co-Authored-by: Stefan Lendl
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 40
1 file changed, 40 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c465fb6..5f15c
From: Alexandre Derumier
also delete ips in case of failure
Signed-off-by: Alexandre Derumier
---
src/PVE/API2/LXC.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index e15de28..ee4fdca 100644
--- a/src/PVE/API2/LXC.pm
+++ b
From: Alexandre Derumier
also delete ips on create failure
Co-Authored-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
src/PVE/API2/LXC.pm | 4
src/PVE/LXC.pm | 13 +
2 files changed, 17 insertions(+)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
ind
From: Alexandre Derumier
Co-Authored-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
src/PVE/LXC.pm| 17 +
src/PVE/LXC/Config.pm | 12
2 files changed, 29 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 8f53b53..b6df6d6 100644
--
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 122
1 file changed, 122 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index b796c5e..24878e2 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -79,6 +79,9 @@ In addition to this, the followi
simply uses the json_config_properties for the vm config and maps them
to "vm_${opt}"
Signed-off-by: Dominik Csapak
---
PVE/Makefile | 1 +
PVE/Profiles/Makefile | 5 +
PVE/Profiles/VM.pm| 28
3 files changed, 34 insertions(+)
create mode 100644 P
This series aims to provide profile support when creating guests (ct/vm)
so that users can reuse options without having to specify them every
time.
UI is still not done, but sending the backend again.
changes from v3:
* adapt to the changes in section config regarding the 'init' ->
now `init(pr
we use the the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from the
profile easily
also we add the used profile to the meta info in the config, since
it might be interesting which one was used
Signed-off-by: Dominik Csapa
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index b17b4fe2..82240ba3 100755
--- a/PVE/CLI/qm.pm
this is intended to house custom profiles which can be used
on guest creation instead of manually needing to specify every option.
we do special things here:
* we always set 'allow_unknown' to 1, because when using the guest
specific parts in the cli, we cannot depend on the other one, else
we
we use the profile cfg as the 'param' hash, but overwrite the values
with the ones from the api call, so one can overwrite options from
the profile easily
Signed-off-by: Dominik Csapak
---
src/PVE/API2/LXC.pm | 23 +++
1 file changed, 23 insertions(+)
diff --git a/src/PVE/AP
Signed-off-by: Dominik Csapak
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index cfa2583..c01bf89 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -80,6 +80,7 @@ my $observed = {
's
simply uses the json_config_properties for the ct config and maps them
to "ct_${opt}"
Signed-off-by: Dominik Csapak
---
src/PVE/Makefile | 1 +
src/PVE/Profiles/CT.pm| 28
src/PVE/Profiles/Makefile | 4
3 files changed, 33 insertions(+)
create mo
we have to that here, so the properties/options are correctly configured
when using that feature on the cli
Signed-off-by: Dominik Csapak
---
src/PVE/CLI/pct.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index a0b9bce..e579b7a 100755
--- a/s
basic CRUD for the profile section config
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 7 +
PVE/API2/Cluster/Makefile| 1 +
PVE/API2/Cluster/Profiles.pm | 239 +++
3 files changed, 247 insertions(+)
create mode 100644 PVE/API2/Cluster/
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/PVE/LXC.pm | 16
1 file changed, 16 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index b6df6d6..4472e0f 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -46,6 +46,7 @@ use PVE::LXC::Tools;
my
From: Alexandre Derumier
Co-Authored-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
src/PVE/LXC/Config.pm | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index c884313..823a2b9 100644
--- a/src/PVE/LXC/Config.pm
+++
Signed-off-by: Stefan Hanreich
---
www/css/ext6-pve.css | 22 ++-
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 12 +-
www/manager6/sdn/IpamEdit.js | 78 ++
www/manager6/tree/DhcpTree.js | 267 ++
5 files changed, 372 i
From: Alexandre Derumier
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Dhcp.pm | 9 ---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 40 -
src/PVE/Network/SDN/Dhcp/Plugin.pm | 2 +-
src/PVE/Network/SDN/Vnets.pm| 15 +++
4 files cha
Co-Authored-by: Stefan Lendl
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/zones/Base.js | 6 --
www/manager6/sdn/zones/SimpleEdit.js | 10 ++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js
From: Alexandre Derumier
Co-Authored-by: Stefan Lendl
Signed-off-by: Stefan Hanreich
Signed-off-by: Alexandre Derumier
---
PVE/API2/Qemu.pm | 6 ++
PVE/QemuServer.pm | 15 +++
2 files changed, 21 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 38bdaab..
From: Alexandre Derumier
We want to notify guest of the change, so it can resubmit dhcp request,
or send gratuitous arp,...
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5e1
Encapsulation of the functionality for determining the scsi device type in a
new function
for reusability in QemuServer/Drive.pm
Signed-off-by: Hannes Duerr
---
PVE/QemuServer.pm | 29 -
PVE/QemuServer/Drive.pm | 35 ++-
2 files
changes in v2:
- when calling the API to create/update a VM, check whether the devices
are "scsi-hd" or "scsi-cd" devices,where there is the option to add
vendor and product information, if not error out
- change the format in product_fmt and vendor_fmt to a pattern that only
allows 40 characters c
Prepare for introduction of new helper
Signed-off-by: Hannes Duerr
---
PVE/QemuServer.pm | 62 +
PVE/QemuServer/Drive.pm | 61
2 files changed, 62 insertions(+), 61 deletions(-)
diff --git a/PVE/QemuServer.pm
Move it due to better context and preparation of fix
Signed-off-by: Hannes Duerr
---
PVE/API2/Qemu.pm| 10 --
PVE/QemuServer/Drive.pm | 1 +
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 38bdaab..b9c8f20 100644
--- a/PVE
adds vendor and product information for SCSI devices to the json schema and
checks in the VM create/update API call if it is possible to add these to QEMU
as a device option
Signed-off-by: Hannes Duerr
---
PVE/API2/Qemu.pm| 39 +++
PVE/QemuServer.pm
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Dhcp/Dnsmasq.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
b/src/PVE/Network/SDN/Dhcp/Dnsmasq.pm
index 2db7f4f..f4225d0 100644
--- a/src/PVE/Network/SDN/Dhcp/Dnsma
we don't want dynamic lease, simply define each subnet as a static range.
dhcp-range defined on a subnet is only used by ipam plugin.
This will also allow to use dhcp subnet without need to define a range.
Can be usefull for external ipam like phpipam, where you can't define ranges.
Signed-off-b
This need to deploy permission for dbus uk.org.thekelleys.dnsmasq.*
/etc/dbus-1/system.d/dnsmasq-pve.conf
I don't have added patch for this.
http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd";>
minor issue
On Fri, Nov 17, 2023 at 08:09:10AM +0100, Fabian Grünbichler wrote:
> since poolid can now contain `/`, it's not possible to use it (properly) as
> path parameter anymore.
>
> accordingly:
> - merge `read_pool` (`GET /pools/{poolid}`) into 'index' (`GET
> /pools/?poolid={poolid}`) (
Happens due to a force-unwrap() under the false assumption that the
disk for LVM configurations always exists when switching to a LVM
filesystem.
This fails spectacularly with a panic when switching from e.g. Btrfs to
ext4 in the filesystem chooser.
Fixes: eda9fa0 ("fix #4856: tui: bootdisk: use c
changes in v2:
- when calling the API to create/update a VM, check whether the devices
are "scsi-hd" or "scsi-cd" devices,where there is the option to add
vendor and product information, if not error out
- change the format in product_fmt and vendor_fmt to a pattern that only
allows 40 characters c
Prepare for introduction of new helper
Signed-off-by: Hannes Duerr
---
PVE/QemuServer.pm | 62 +
PVE/QemuServer/Drive.pm | 61
2 files changed, 62 insertions(+), 61 deletions(-)
diff --git a/PVE/QemuServer.pm
Encapsulation of the functionality for determining the scsi device type in a
new function
for reusability in QemuServer/Drive.pm
Signed-off-by: Hannes Duerr
---
PVE/QemuServer.pm | 29 -
PVE/QemuServer/Drive.pm | 35 ++-
2 files
Move it due to better context and preparation of fix
Signed-off-by: Hannes Duerr
---
PVE/API2/Qemu.pm| 10 --
PVE/QemuServer/Drive.pm | 1 +
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 38bdaab..b9c8f20 100644
--- a/PVE
adds vendor and product information for SCSI devices to the json schema and
checks in the VM create/update API call if it is possible to add these to QEMU
as a device option
Signed-off-by: Hannes Duerr
---
PVE/API2/Qemu.pm| 39 +++
PVE/QemuServer.pm
Am 17/11/2023 um 13:12 schrieb Christoph Heiss:
> Happens due to a force-unwrap() under the false assumption that the
> disk for LVM configurations always exists when switching to a LVM
> filesystem.
> This fails spectacularly with a panic when switching from e.g. Btrfs to
> ext4 in the filesystem
New Version can be found here:
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060429.html
On 11/17/23 12:53, Hannes Duerr wrote:
adds vendor and product information for SCSI devices to the json schema and
checks in the VM create/update API call if it is possible to add these to QEMU
no in-depth review, but a meta style issue and some nits in line, the former
could be fixed up on applying, the nits are not really important in general.
Am 17/11/2023 um 13:17 schrieb Hannes Duerr:
> adds vendor and product information for SCSI devices to the json schema and
> checks in the VM cr
On Wed, Sep 27, 2023 at 11:04:26AM +0200, Friedrich Weber wrote:
> Lost track of this a bit, reviving due to user interest [1].
>
> As the series does not apply anymore, I'll send a new version in any
> case, but wanted to ask for feedback before I do.
>
> My questions from the cover letter still
Thanks!
On Fri, Nov 17, 2023 at 01:20:31PM +0100, Thomas Lamprecht wrote:
>
> Am 17/11/2023 um 13:12 schrieb Christoph Heiss:
> > Happens due to a force-unwrap() under the false assumption that the
> > disk for LVM configurations always exists when switching to a LVM
> > filesystem.
> > This fai
I took another look at ballooning+PCI passthrough and reporting of
memory usage with Markus. Apparently QEMU does not *always* map the
complete guest memory -- at least it didn't with a passed-through NIC.
So both the warning as well as the docs section may be worded too
strongly ("Ballooning is no
Patch itself LGTM, just a note on sending patch series in general:
If you number patches throughout a whole series rather than the
individual repositories (as in, this one is labeled 4/4 instead of 1/1),
it would be nice if the order also helps determine dependencies.
Since the sub introduced her
On Thu, Jan 26, 2023 at 09:32:12AM +0100, Friedrich Weber wrote:
> The new `overrule-shutdown` parameter is boolean and defaults to 0. If
> it is 1, all active `vzshutdown` tasks by the current user for the same
> CT are aborted before attempting to stop the CT.
>
> Passing `overrule-shutdown=1` i
This one LGTM.
On Thu, Jan 26, 2023 at 09:32:13AM +0100, Friedrich Weber wrote:
> The new `overrule-shutdown` parameter is boolean and defaults to 0. If
> it is 1, all active `qmshutdown` tasks by the current user for the same
> VM are aborted before attempting to stop the VM.
>
> Passing `overru
The line-based protocol currently used cannot handle this properly, so
introduce this as a stop-gap measure - otherwise messages might be cut
off.
This makes it work for now, and the text is wrapped correctely for the
screen width in the TUI anyway - which is the only user of this so far.
Will be
The GTK installer/UI module in the low-level installer does the same.
Messages used with this are worded for this, using yes/no instead can be
quite confusing (e.g.
Proxmox::Install::ask_existing_vg_rename_or_abort())
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs
Am 17/11/2023 um 12:45 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak
> ---
> src/PVE/Cluster.pm | 1 +
> src/pmxcfs/status.c | 1 +
> 2 files changed, 2 insertions(+)
>
>
I'm currently preparing a version bump, and it might be easier for all
if this is already included, even if we'd
Am 17/11/2023 um 12:39 schrieb Stefan Hanreich:
> From: Alexandre Derumier
>
> use to cache mac-ip list association.
>
> can be use by external ipam, firewall,etc for fast lookup
>
> Signed-off-by: Alexandre Derumier
> ---
> src/PVE/Cluster.pm | 1 +
> src/pmxcfs/status.c | 1 +
> 2 files ch
Signed-off-by: Stefan Lendl
---
pvesdn.adoc | 66 ++---
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 73d3dee..450955d 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -425,56 +425,56 @@ Loopback:: Use
* Try to homogenize style and format
* Title case naming conventions for configuration options
* Simplify examples
* Re-phrase descriptions
Changes to v1 -> v2:
* Split changes per chapter.
* Use multi-line heading format like in the original file.
I used search and replace to "revert" and now
Signed-off-by: Stefan Lendl
---
pvesdn.adoc | 46 --
1 file changed, 28 insertions(+), 18 deletions(-)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 8a71c03..c4b77f0 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -272,32 +272,40 @@ MTU:: Because VXLAN en
refs only work with subsequent patches
Signed-off-by: Stefan Lendl
---
pvesdn.adoc | 67 +
1 file changed, 37 insertions(+), 30 deletions(-)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index b796c5e..562e081 100644
--- a/pvesdn.adoc
+++ b/pvesdn.ad
1 - 100 of 142 matches
Mail list logo