[pve-devel] [PATCH proxmox 06/27] notify: let a matcher always match if it has no matching directives

This should be a bit more intuitive to users than the current behavior, which is 'always match' for mode==all and 'never match' for mode==any. The current behavior originates in the neutral element of the underlying logical operation (and, or). Signed-off-by: Lukas Wagner --- proxmox-notify/src/

[pve-devel] [PATCH proxmox 05/27] notify: matcher: introduce common trait for match directives

This allows us to make the match-checking code a bit shorter. Signed-off-by: Lukas Wagner --- proxmox-notify/src/matcher.rs | 92 +-- 1 file changed, 45 insertions(+), 47 deletions(-) diff --git a/proxmox-notify/src/matcher.rs b/proxmox-notify/src/matcher.rs inde

[pve-devel] [PATCH pve-ha-manager 10/27] env: switch to matcher-based notification system

Signed-off-by: Lukas Wagner --- src/PVE/HA/Env/PVE2.pm | 10 ++ src/PVE/HA/NodeStatus.pm | 11 +-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm index ea9e6e4..fcb60a9 100644 --- a/src/PVE/HA/Env/PVE2.pm +++ b/sr

[pve-devel] [PATCH proxmox 02/27] notify: factor out notification content into its own type

This will be useful later for system mail forwarding, where the content of the mail should be forwarded unchanged. This moves notification properties into this new type and calls them 'data'. They will exclusively used for template rendering. `Notification` will receive a separate field for metada

[pve-devel] [PATCH pve-guest-common 09/27] vzdump: deprecate mailto/mailnotification/notification-{target, policy}

The first two will be migrated to the notification system, the second were part for the first attempt for the new notification system. The first attempt only ever hit pvetest, so we simply tell the user to not use the two params. Signed-off-by: Lukas Wagner --- src/PVE/VZDump/Common.pm | 16

[pve-devel] [PATCH proxmox 01/27] notify: introduce Error::Generic

... as leaf error-type for anything for which we do not necessarily want a separate enum variant. Signed-off-by: Lukas Wagner --- proxmox-notify/src/lib.rs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs index 7500778..f7d480

[pve-devel] [PATCH proxmox-widget-toolkit 26/27] notification ui: unprotected mailto-root target

A default notification config will now be created in pve-manager's postinst hook - which is not magic in any way and can be modified and deleted as desired. Signed-off-by: Lukas Wagner --- src/panel/NotificationConfigView.js | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/panel/Noti

[pve-devel] [PATCH proxmox-widget-toolkit 21/27] notification ui: add target selector for matcher

Signed-off-by: Lukas Wagner --- src/window/NotificationFilterEdit.js | 145 +++ 1 file changed, 145 insertions(+) diff --git a/src/window/NotificationFilterEdit.js b/src/window/NotificationFilterEdit.js index 703a9e2..bcde4fa 100644 --- a/src/window/NotificationFilterEdi

[pve-devel] [PATCH proxmox-widget-toolkit 23/27] notification ui: remove notification groups

Signed-off-by: Lukas Wagner --- src/Makefile| 1 - src/Schema.js | 5 - src/panel/NotificationConfigView.js | 4 - src/panel/NotificationGroupEditPanel.js | 174 4 files changed, 184 deletions(-) delete mode

[pve-devel] [PATCH pve-manager 11/27] api: notification: remove notification groups

Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 267 +- 1 file changed, 4 insertions(+), 263 deletions(-) diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notifications.pm index ec666903..b34802c8 100644 --- a/PVE/API2/Cluster/Not

[pve-devel] [PATCH proxmox-widget-toolkit 22/27] notification ui: remove filter setting for targets

Signed-off-by: Lukas Wagner --- src/Makefile| 1 - src/form/NotificationFilterSelector.js | 58 - src/panel/GotifyEditPanel.js| 9 src/panel/NotificationGroupEditPanel.js | 9 src/panel/SendmailEditPanel.js |

[pve-devel] [PATCH proxmox-perl-rs 07/27] notify: adapt to new matcher-based notification routing

Signed-off-by: Lukas Wagner --- common/src/notify.rs | 167 +-- 1 file changed, 50 insertions(+), 117 deletions(-) diff --git a/common/src/notify.rs b/common/src/notify.rs index 9f44225..4fbd705 100644 --- a/common/src/notify.rs +++ b/common/src/notify.rs

[pve-devel] [PATCH proxmox 04/27] notify: add calendar matcher

This allows matching by a notification's timestamp: matcher: foo match-calendar mon..fri 8-12 Signed-off-by: Lukas Wagner --- proxmox-notify/src/api/matcher.rs | 6 +++ proxmox-notify/src/lib.rs | 4 ++ proxmox-notify/src/matcher.rs | 65 +++ 3 files

[pve-devel] [PATCH many 00/27] overhaul notification system, use matchers instead of filters

This series replaces notification filters and groups with notification matchers. Instead of having a per-notification event target/policy setting (at the moment stored in datacenter.cfg and jobs.cfg), this shifts the routing part into the matcher completely. Config example, I think this demonstr

[pve-devel] [PATCH pve-cluster 08/27] notify: adapt to matcher based notification system

This commit removes the target paramters from all notify calls. Also, the default 'mail-to-root' target is not added automatically any more - this target will be added by an dpkg hook in the future. Signed-off-by: Lukas Wagner --- src/PVE/Notify.pm | 101 +

[pve-devel] [PATCH pve-manager 16/27] api: replication: adapt to matcher-based notification system

Signed-off-by: Lukas Wagner --- PVE/API2/Replication.pm | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index d61518ba..0dc944c9 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@

[pve-devel] [PATCH pve-manager 18/27] test: fix vzdump notification test

The signature of the PVE::Notify functions have changed, this commit adapts the mocked functions so that the tests work again. Signed-off-by: Lukas Wagner --- test/vzdump_notification_test.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/vzdump_notification_test.

[pve-devel] [PATCH pve-manager 20/27] ui: dc: config: show notification panel again

Rework should be done now. Signed-off-by: Lukas Wagner --- www/manager6/dc/Config.js | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js index 0dea1c67..74a84e91 100644 --- a/www/manager6/dc/Config.js +++ b/www/man

[pve-devel] [PATCH pve-manager 15/27] api: apt: adapt to matcher-based notifications

Signed-off-by: Lukas Wagner --- PVE/API2/APT.pm | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index a213fc59..da75a4dc 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -286,8 +286,6 @@ __PACKAGE__->register

[pve-devel] [PATCH pve-manager 17/27] debian: postinst: create notifications.cfg if it does not exist

We only warn on failure so that the postinst script does not fail in case pmxcfs is not running. Signed-off-by: Lukas Wagner --- debian/postinst | 28 1 file changed, 28 insertions(+) diff --git a/debian/postinst b/debian/postinst index 4c9a1f25..7dad2b1a 100755 ---

[pve-devel] [PATCH pve-manager 14/27] vzdump: adapt to new matcher based notification system

To ease the migration from old-style mailto/mailnotification paramters for backup jobs, the code will add a ephemeral sendmail endpoint and a matcher. Signed-off-by: Lukas Wagner --- PVE/API2/VZDump.pm | 8 +--- PVE/VZDump.pm | 40 +++- 2 files chang

[pve-devel] [PATCH pve-manager 19/27] ui: vzdump: remove left-overs from target/policy based notifications

Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js | 81 --- .../form/NotificationPolicySelector.js| 1 - www/manager6/window/Backup.js | 35 +--- 3 files changed, 15 insertions(+), 102 deletions(-) diff --git a/www/manager6

[pve-devel] [PATCH proxmox-widget-toolkit 27/27] noficiation: matcher edit: make 'field' an editable combobox

For now with fixed options that are shared between most notification events - later, once we have a notification registry, this should be filled dynamically. Signed-off-by: Lukas Wagner --- src/window/NotificationMatcherEdit.js | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) d

[pve-devel] [PATCH proxmox-widget-toolkit 25/27] notification: matcher: add UI for matcher editing

This modifies the old filter edit window in the following ways: - Split content into multiple panels - Name and comment in the first tab - Match rules in a tree-structure in the second tab - Targets to notify in the third tab Signed-off-by: Lukas Wagner --- Notes: The code bind

[pve-devel] [PATCH proxmox-widget-toolkit 24/27] notification ui: rename filter to matcher

Signed-off-by: Lukas Wagner --- src/Makefile | 2 +- src/data/model/NotificationConfig.js | 2 +- src/panel/NotificationConfigView.js | 26 +-- ...lterEdit.js => NotificationMatcherEdit.js} | 14 +- 4 files changed, 22

[pve-devel] [PATCH pve-manager 13/27] ui: dc: remove unneeded notification events panel

The notification event settings are replaced by notification matchers, which will combine the notification routing and filtering into a single concept. Signed-off-by: Lukas Wagner --- www/manager6/Makefile | 4 - www/manager6/dc/Config.js | 17 +- www/manager6/dc/N

[pve-devel] [PATCH pve-manager 12/27] api: notification: add new matcher-based notification API

This renames filters -> matchers and adds new configuration options needed by matchers (e.g. match-field, match-calendar, etc.) Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 195 ++ 1 file changed, 88 insertions(+), 107 deletions(-) diff --git a

[pve-devel] [PATCH proxmox 03/27] notify: replace filters and groups with matcher-based system

This shifts notification routing into the matcher-system. Every notification has associated metadata (key-value fields, severity - to be extended) that can be match with match directives in notification matchers. Right now, there are 2 matching directives, match-field and match-severity. The first

[pve-devel] [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate

The message in the Task Log has been 'Start/Stop/Migrate all...', which is misleading since not everything might be affected by bulk actions. This also affects the messages send at a nodes startup and shutdown, but since this just affects a subgroup of VMs/Containers (those who are onboot=1) the ne

[pve-devel] [PATCH installer v4 1/6] run env: remove debug print

Signed-off-by: Christoph Heiss --- Proxmox/Install/RunEnv.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm index 9116397..5f68d82 100644 --- a/Proxmox/Install/RunEnv.pm +++ b/Proxmox/Install/RunEnv.pm @@ -319,7 +319,6 @@ sub default_zfs_a

[pve-devel] [PATCH installer v4 2/6] install: use correct variable names in zfs_setup_module_conf()

That's what happens when you do some last-minute variable renaming and trust that nothing broke .. Fixes: 42aa2fa ("fix #4829: install: add new ZFS `arc_max` setup option") Signed-off-by: Christoph Heiss --- Proxmox/Install.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[pve-devel] [PATCH installer v4 3/6] proxinstall: expose `arc_max` ZFS option for PVE installations

Signed-off-by: Christoph Heiss --- proxinstall | 15 +++ 1 file changed, 15 insertions(+) diff --git a/proxinstall b/proxinstall index 113bf37..857281d 100755 --- a/proxinstall +++ b/proxinstall @@ -1162,6 +1162,21 @@ my $create_raid_advanced_grid = sub { $spinbutton_copies->set

[pve-devel] [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE

The installer `arc_max` option ZFS was introduced in [0], this exposes this option in the GUI/TUI installer for PVE installations. This can be adjusted when creating a ZFS RAID under "Advanced Options". The default value is choosen as 10% of system memory, clamped to between 64 MiB as lower limit

[pve-devel] [PATCH installer v4 5/6] common: add ZFS `arc_max` installer setup option

Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/options.rs | 62 +++-- proxmox-installer-common/src/setup.rs | 2 + proxmox-tui-installer/src/views/bootdisk.rs | 18 -- 3 files changed, 71 insertions(+), 11 deletions(-) diff --git a/proxmox-installe

[pve-devel] [PATCH installer v4 6/6] tui: bootdisk: expose `arc_max` ZFS option for PVE installations

To set the maximum value for arc_max accordingly, simply pass down `RuntimeInfo` directly instead of the disks array to the views. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs | 2 +- proxmox-tui-installer/src/views/bootdisk.rs | 68 ++--- proxm

[pve-devel] [PATCH installer v4 4/6] test: add tests for zfs_arc_max calculations

Signed-off-by: Christoph Heiss --- Makefile| 3 ++ debian/control | 1 + test/Makefile | 10 ++ test/zfs-arc-max.pl | 81 + 4 files changed, 95 insertions(+) create mode 100644 test/Makefile create mode 100755 test/zfs-arc

[pve-devel] [PATCH installer] tui: fix same "Administrator" typo in password and summary view

Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/main.rs| 2 +- proxmox-tui-installer/src/options.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 2e5a194..82ae1bb 100644 --- a/pr

[pve-devel] [PATCH access-control 1/2] acl: allow more nesting for /mapping acl paths

This will be needed for ACL paths for the notification system, which will get separate namespaces for targets and matchers: /mapping/notification/targets/ as well as /mapping/notification/matchers/ Signed-off-by: Lukas Wagner --- src/PVE/AccessControl.pm | 1 + 1 file changed, 1 insertion(+) d

[pve-devel] [PATCH manager 2/2] api: notifications: give targets and matchers their own ACL namespace

Right now, matchers and targets share a single namespace due to limitations of the section-config parser. This will probably be fixed some time in the future. As a preparation for that we need to ensure that the ACL tree has separate namespaces for both. Signed-off-by: Lukas Wagner --- This patch

[pve-devel] [PATCH v3 common 1/1] tools: Add mknod syscall

Signed-off-by: Filip Schauer --- src/PVE/Syscall.pm | 1 + src/PVE/Tools.pm | 5 + 2 files changed, 6 insertions(+) diff --git a/src/PVE/Syscall.pm b/src/PVE/Syscall.pm index 4c0b9cf..2a423e8 100644 --- a/src/PVE/Syscall.pm +++ b/src/PVE/Syscall.pm @@ -16,6 +16,7 @@ BEGIN { openat

[pve-devel] [PATCH v3 many] Add container device passthrough

Changes since v1: * mknod the devices in /var/lib/lxc/$vmid/passthrough and setup proper permissions instead of bind mounting the devices from /dev directly * Add support for USB mapping * Add foreach_passthrough_device helper function Changes since v2: * Remove support for USB mapping * Add mkn

[pve-devel] [PATCH v3 container 1/1] Add device passthrough

Add a dev[n] argument to the container config to pass devices through to a container. A device can be passed by its path. Additionally the access mode, uid and gid can be specified through their respective properties. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm| 29 +-

[pve-devel] [PATCH v3 manager 4/4] ui: backup job: disable zstd thread count field when zstd isn't used

Also need to check for enable/disable of the compression selector, because with PBS the value zstd is set, but the thread count setting doesn't apply. Suggested-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- No changes in v3. www/manager6/dc/Backup.js | 18 +

[pve-devel] [PATCH v3 manager 1/4] vzdump: actually honor schema defaults for performance

The 'performance' option itself defines no 'default' in the schema, so what happened is that the defaults used by the backends (i.e. QEMU and proxmox-backup-client) would be used. Luckily, they correspond to the default values defined in the schema, i.e. in the 'backup-performance' format. Make the

[pve-devel] [PATCH v3 manager 3/4] close #4513: ui: backup job: add performance tab

pigz is not exposed, because it only works after manually installing the pigz package. ionice is not exposed, because it only works in combination with the BFQ scheduler and even then not in all cases (only affects the compressor when doing snapshot/suspend mode backup of a VM). The pbs-entries-m

Re: [pve-devel] [PATCH v2 container 1/1] Add device passthrough

Patch v3 available: https://lists.proxmox.com/pipermail/pve-devel/2023-November/059844.html On 03/11/2023 09:14, Wolfgang Bumiller wrote: On Thu, Nov 02, 2023 at 03:28:22PM +0100, Filip Schauer wrote: On 30/10/2023 14:34, Wolfgang Bumiller wrote: On Tue, Oct 24, 2023 at 02:55:53PM +0200, Fili

[pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs

Improve fallback for the 'performance' sub-properties by using a per-property fallback and honor schema defaults. Expose commonly used performance-related properties in the backup job UI under a new tab. Changes in v3: * new patch to actually honor default values for performance format

[pve-devel] [PATCH v3 manager 2/4] vzdump: use per-property fallback for performance settings

Currently, fallback for the 'performance' option is done as a whole, taking away flexibility from the user. It also means that when only one of the two sub-properties is specified, the other one will default to the backend (i.e. QEMU or proxmox-backup-client) default rather than the schema default.

[pve-devel] [PATCH v3 docs 5/5] backup: update information about performance settings

Signed-off-by: Fiona Ebner --- Changes in v3: * rebase on current master vzdump.adoc | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 8dc49f5..682c9d1 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -214,13 +214,13 @@ the behav

Re: [pve-devel] [PATCH qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs

Am 12.09.23 um 13:55 schrieb Fiona Ebner: > The implementation of the helper is_path_tmpfs() is similar to the > existing (in upstream) qemu_fd_getfs() function in util/mmap-alloc.c, > which unfortunately only takes an existing fd. > Ping. Even though it came before the 8.1 rebase, it still appli

Re: [pve-devel] [PATCH qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs

Am 07.11.23 um 15:23 schrieb Fiona Ebner: > Am 12.09.23 um 13:55 schrieb Fiona Ebner: >> The implementation of the helper is_path_tmpfs() is similar to the >> existing (in upstream) qemu_fd_getfs() function in util/mmap-alloc.c, >> which unfortunately only takes an existing fd. >> > > Ping. Even t

[pve-devel] [PATCH v2 qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs

The implementation of the helper is_path_tmpfs() is similar to the existing qemu_fd_getfs() function in util/mmap-alloc.c, which unfortunately only takes an existing fd. Signed-off-by: Fiona Ebner --- Changes in v2: * rebase on current master (just context changes) ...VE-Backup-add-vma-bac

[pve-devel] applied: [PATCH v2 qemu] fix #4710: vma create: don't use O_DIRECT for tmpfs

Am 07/11/2023 um 15:28 schrieb Fiona Ebner: > The implementation of the helper is_path_tmpfs() is similar to the > existing qemu_fd_getfs() function in util/mmap-alloc.c, which > unfortunately only takes an existing fd. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * rebase on cu

[pve-devel] applied: [PATCH installer] tui: fix same "Administrator" typo in password and summary view

Am 07/11/2023 um 13:23 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > proxmox-tui-installer/src/main.rs| 2 +- > proxmox-tui-installer/src/options.rs | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > applied, thanks!

[pve-devel] applied: [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE

Am 07/11/2023 um 13:20 schrieb Christoph Heiss: > run env: remove debug print > install: use correct variable names in zfs_setup_module_conf() > proxinstall: expose `arc_max` ZFS option for PVE installations > test: add tests for zfs_arc_max calculations > common: add ZFS `arc_max` instal

[pve-devel] applied: [PATCH manager] fix #2336: ui: adjust message for bulk start/stop/migrate

Am 07/11/2023 um 12:38 schrieb Folke Gleumes: > The message in the Task Log has been 'Start/Stop/Migrate all...', > which is misleading since not everything might be affected by bulk actions. > This also affects the messages send at a nodes startup and shutdown, but > since this just affects a subg

[pve-devel] [PATCH access-control] acl: add missing SDN ACL paths to allowed list

else it's not actually possible to define ACLs on them, which means they are effectively root only instead of allowing their intended permission scheme. Signed-off-by: Fabian Grünbichler --- src/PVE/AccessControl.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/AccessControl.