Re: [pve-devel] [PATCH v2 installer] fix #4869: Make management interface selection more verbose

2023-10-13 Thread Christoph Heiss
See inline comments. Also, `cargo fmt` please :^) On Thu, Oct 12, 2023 at 03:02:08PM +0200, Filip Schauer wrote: > [..] > diff --git a/proxinstall b/proxinstall > index d5b2565..51170cd 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -347,7 +347,9 @@ sub create_ipconf_view { > > my $get

[pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI

2023-10-13 Thread Stefan Lendl
Make this consistent with PVE networking which has a Comment option. Aliases used in VNet are basically comments if the id which is limited to 8 chars is too long. Signed-off-by: Stefan Lendl --- www/manager6/sdn/VnetEdit.js| 2 +- www/manager6/sdn/VnetView.js| 2 +- www/manager6

Re: [pve-devel] [PATCH manager] SDN: Rename VNet Alias to Comment in the UI

2023-10-13 Thread Thomas Lamprecht
Am 13/10/2023 um 13:03 schrieb Stefan Lendl: > Make this consistent with PVE networking which has a Comment option. > Aliases used in VNet are basically comments if the id which is limited > to 8 chars is too long. but comments have no effect, these have a real effect, this is set on the interface

[pve-devel] [RFC] towards automated integration testing

2023-10-13 Thread Lukas Wagner
Hello, I am currently doing the groundwork that should eventually enable us to write automated integration tests for our products. Part of that endeavor will be to write a custom test runner, which will - setup a specified test environment - execute test cases in that environment - create

[pve-devel] [PATCH qemu-server] Fix races with suspended VMs that can wake up

2023-10-13 Thread Filip Schauer
Fix races with ACPI-suspended VMs which could wake up during migration or during a suspend-mode backup. Revert prevention, of ACPI-suspended VMs automatically resuming after migration, introduced by 7ba974a6828d. The commit introduced a potential problem that causes a suspended VM that wakes up du