Re: [pve-devel] [PATCH pve-manager] website: update external links to www.proxmox.com

2023-10-02 Thread Christian Ebner
Okay, thanks for the clarification. > On 30.09.2023 10:07 CEST Thomas Lamprecht wrote: > > > Am 11/08/2023 um 12:46 schrieb Christian Ebner: > > During the redesign of www.proxmox.com the menu structure and therefore > > some url changed. Update the external link in order to avoid an > > unnec

[pve-devel] [PATCH proxmox-perl-rs] notify context: fix 'default_sendmail_from' context method

2023-10-02 Thread Lukas Wagner
The name of the configuration option in datacenter.cfg is `email_from` and not `mail_from`. Signed-off-by: Lukas Wagner --- Reported in our forum: https://forum.proxmox.com/threads/mail-alerts-not-sent-with-datacenter-default.134305/ pve-rs/src/notify_context.rs | 2 +- 1 file changed, 1 insert

[pve-devel] [PATCH v2 proxmox 03/11] notify: introduce Error::Generic

2023-10-02 Thread Lukas Wagner
... as leaf error-type for anything for which we do not necessarily want a separate enum variant. Signed-off-by: Lukas Wagner --- proxmox-notify/src/lib.rs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs index 7500778..f7d480

[pve-devel] [PATCH v2 proxmox 02/11] sys: email: add `forward`

2023-10-02 Thread Lukas Wagner
This new function forwards an email to new recipients. Signed-off-by: Lukas Wagner --- proxmox-sys/src/email.rs | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs index 8b3a1b6..c94f634

[pve-devel] [PATCH v2 pve-docs 11/11] notification: add docs for system mail forwarding

2023-10-02 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index c4d2931..0b00b1e 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -19,9 +19,10 @@ such as:

[pve-devel] [PATCH v2 many 00/11] notifications: feed system mails into proxmox_notify

2023-10-02 Thread Lukas Wagner
The aim of this patch series is to adapt `proxmox-mail-forward` so that it forwards emails that were sent to the local root user through the `proxmox_notify` crate. A short summary of the status quo: Any mail that is sent to the local `root` user is forwarded by postfix to the `proxmox-mail-forwa

[pve-devel] [PATCH v2 pve-manager 09/11] ui: notify: add system-mail settings, configuring mail forwarding

2023-10-02 Thread Lukas Wagner
The 'Notifications' panel in Datacenter view now features a new entry 'System mail', allowing the user to configure target and policy for mails sent to the local root user. Signed-off-by: Lukas Wagner --- www/manager6/dc/NotificationEvents.js | 27 +++ 1 file changed, 27

[pve-devel] [PATCH v2 pve-cluster 08/11] datacenter config: add new parameters for system mail forwarding

2023-10-02 Thread Lukas Wagner
This commit adds two new paramters to the 'notify' property string: - 'system-mail': Determine whether mails to root should be forwarded by the notification system - 'system-mail-target': Determine the target to which the notification should be forwarded to. Signed-off-by: Lukas Wagner

[pve-devel] [PATCH v2 proxmox 04/11] notify: add mechanisms for email message forwarding

2023-10-02 Thread Lukas Wagner
As preparation for the integration of `proxmox-mail-foward` into the notification system, this commit makes a few changes that allow us to forward raw email messages (as passed from postfix). For mail-based notification targets, the email will be forwarded as-is, including all headers. The only th

[pve-devel] [PATCH v2 debcargo-conf 01/11] package mail-parser 0.8.2

2023-10-02 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- src/mail-parser/debian/changelog | 6 ++ src/mail-parser/debian/copyright | 49 .../debian/copyright.debcargo.hint| 77 +++ src/mail-parser/debian/debcargo.toml | 2 + 4 files changed, 13

[pve-devel] [PATCH v2 proxmox-perl-rs 06/11] notify: construct Notification via constructor

2023-10-02 Thread Lukas Wagner
This keeps us isolated from any further changes in the proxmox_notify::Notification struct. Signed-off-by: Lukas Wagner --- common/src/notify.rs | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/common/src/notify.rs b/common/src/notify.rs index 9f44225..203acca 100644 --

[pve-devel] [PATCH v2 proxmox-perl-rs 07/11] pve-rs: notify: remove notify_context for PVE

2023-10-02 Thread Lukas Wagner
The context has now been moved to `proxmox-notify` due to the fact that we also need it in `proxmox-mail-forward` now. Signed-off-by: Lukas Wagner --- pve-rs/Cargo.toml| 2 +- pve-rs/src/lib.rs| 7 ++- pve-rs/src/notify_context.rs | 117 ---

[pve-devel] [PATCH v2 proxmox 05/11] notify: add PVE/PBS context

2023-10-02 Thread Lukas Wagner
This commit moves PVEContext from `proxmox-perl-rs` into the `proxmox-notify` crate, since we now also need to access it from `promxox-mail-forward`. The context is now hidden behind a feature flag `pve-context`, ensuring that we only compile it when needed. This commit adds PBSContext, since we n

[pve-devel] [PATCH v2 proxmox-mail-forward 10/11] feed forwarded mails into proxmox_notify

2023-10-02 Thread Lukas Wagner
This allows us to send notifications for events from daemons that are not under our control, e.g. zed, smartd, cron. etc... For mail-based notification targets (sendmail, soon smtp) the mail is forwarded as is, including all headers. All other target types will try to parse the email to extra subj

[pve-devel] Watchdog hardware vor VMS

2023-10-02 Thread Sascha Schmidt via pve-devel
--- Begin Message --- Hi, i have the whish to use watchdog inside of VMs. I also want to develop this feature for Proxmox. Can i go with this or is there a pro / con for? best regards sascha --- End Message --- ___ pve-devel mailing list pve-devel@li

[pve-devel] [PATCH manager v5] ui: ceph: improve discoverability of warning details

2023-10-02 Thread Aaron Lauterer
by * replacing the info button with expandable rows that contain the details of the warning * adding two action buttons to copy the summary and details * making the text selectable The row expander works like the one in the mail gateway tracking center -> doubleclick only opens it. The height o

[pve-devel] applied: [PATCH proxmox-perl-rs] notify context: fix 'default_sendmail_from' context method

2023-10-02 Thread Thomas Lamprecht
Am 02/10/2023 um 09:40 schrieb Lukas Wagner: > The name of the configuration option in datacenter.cfg is `email_from` > and not `mail_from`. > > Signed-off-by: Lukas Wagner > --- > Reported in our forum: > https://forum.proxmox.com/threads/mail-alerts-not-sent-with-datacenter-default.134305/ > >

Re: [pve-devel] [PATCH installer] install: install correct grub metapackage for the current boot-mode

2023-10-02 Thread Friedrich Weber
Tested-by: Friedrich Weber Tested patched ISO provided by Stoiko: * installed in legacy VM ** checked that `grub-pc` is installed ** re-installing it prints "Installing for i386-pc platform" * installed in UEFI VM ** checked that `grub-efi-amd64` is installed ** re-installing it prints "Installin