if we're parsing an unknown section, we cannot check the schema with
`is_array` to check if it's an array type or not, thus we have to
handle that separately.
fix this by handling data in unknown sections like an array for all
analogous to "cb2646c7b4974e33f4148752deec71f0d589b0f3" in
proxmox-sect
Am 16.08.23 um 09:41 schrieb Dominik Csapak:
> if we're parsing an unknown section, we cannot check the schema with
> `is_array` to check if it's an array type or not, thus we have to
> handle that separately.
>
> fix this by handling data in unknown sections like an array for all
> analogous to "
While it makes sense to reload the Web UI after ordering a certificate
for the same node, it is unnecessary to reload the Web UI when ordering
a certificate for a different node.
Signed-off-by: Filip Schauer
---
This change has been tested by ordering a valid Let's Encrypt
certificate for another
if we're parsing an unknown section, we cannot check the schema with
`is_array` to check if it's an array type or not, thus we have to
handle that separately.
fix this by handling data in unknown sections like an array similar to
"cb2646c7b4974e33f4148752deec71f0d589b0f3" in proxmox-section-config
Am 16.08.23 um 11:09 schrieb Dominik Csapak:
> if we're parsing an unknown section, we cannot check the schema with
> `is_array` to check if it's an array type or not, thus we have to
> handle that separately.
>
> fix this by handling data in unknown sections like an array similar to
> "cb2646c7b4
semantically the patch looks good to me, but please check our style guide:
https://pve.proxmox.com/wiki/Javascript_Style_Guide
i know that the surrounding code isn't correctly formatted that way, but
for new code please don't use single line if statements
On 8/16/23 10:25, Filip Schauer wrote:
While it makes sense to reload the Web UI after ordering a certificate
for the same node, it is unnecessary to reload the Web UI when ordering
a certificate for a different node.
Signed-off-by: Filip Schauer
---
Changes since v1:
* Format the code to adhere to the style guide
www/manager6/node/
applied both patches with Wolfgang's Acked-by
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied series, thanks
fixed up the mocking in tests & bumped dependencies accordingly
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--- Begin Message ---
From: Yuri Konotopov
Hello!
Here is a patch that allows to specify multiple comma-separated ISCSI portals
using Proxmox UI.
With that patch my Proxmox instances don't loses iscsi multipath storage in UI
and successfully restores iscsi storage on reboot.
Relevant bug: https
--- Begin Message ---
From: Yuri Konotopov
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=254
---
PVE/Storage/ISCSIPlugin.pm | 44 +++---
PVE/Storage/Plugin.pm | 18
2 files changed, 45 insertions(+), 17 deletions(-)
diff --git a/PVE/St
Currently we are using the MemoryCurrent property of the OSD service
to determine the used memory of a Ceph OSD. This includes, among other
things, the memory used by buffers [1]. Since BlueFS uses buffered
I/O, this can lead to extremely high values shown in the UI.
Instead we are now reading the
one small nitL: if the OSD is powered off, we now send null for the meminfo.
Maybe set it explicitly to 0 to not change the behavior?
but overall:
Tested-By: Aaron Lauterer
On 8/16/23 16:34, Stefan Hanreich wrote:
Currently we are using the MemoryCurrent property of the OSD service
to determ
On 8/16/23 16:59, Aaron Lauterer wrote:
> one small nitL: if the OSD is powered off, we now send null for the
> meminfo. Maybe set it explicitly to 0 to not change the behavior?
ah yes, I even had it that way initially but seems like it got removed
again when I tried to be smart and culled th
Currently we are using the MemoryCurrent property of the OSD service
to determine the used memory of a Ceph OSD. This includes, among other
things, the memory used by buffers [1]. Since BlueFS uses buffered
I/O, this can lead to extremely high values shown in the UI.
Instead we are now reading the
15 matches
Mail list logo
