[pve-devel] [PATCH installer 0/1] fix #4869: Show state in management interface ComboBox

2023-08-04 Thread Filip Schauer
This can be tested by modifying an existing Proxmox-VE ISO file as described in the following forum post: https://forum.proxmox.com/threads/create-custom-pve-iso-from-original-pve-iso.123606/post-538612 Filip Schauer (1): fix #4869: Show state in management interface ComboBox proxinstall | 2

[pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

2023-08-04 Thread Filip Schauer
Signed-off-by: Filip Schauer --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index d5b2565..9316578 100755 --- a/proxinstall +++ b/proxinstall @@ -347,7 +347,7 @@ sub create_ipconf_view { my $get_device_desc = sub { my $

[pve-devel] applied: [PATCH common v4 1/2] fix #4849: download file from url: add opt parameter for a decompression command

2023-08-04 Thread Fabian Grünbichler
with a few follow-ups. On August 1, 2023 4:46 pm, Philipp Hufnagl wrote: > Signed-off-by: Philipp Hufnagl > --- > src/PVE/Tools.pm | 31 +-- > 1 file changed, 25 insertions(+), 6 deletions(-) > > diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm > index 9ffac12..159ec

[pve-devel] applied: [PATCH common v4 2/2] fix whitespaces

2023-08-04 Thread Fabian Grünbichler
the indentation part, skipping the alignment hunks as discussed off-list. On August 1, 2023 4:46 pm, Philipp Hufnagl wrote: > Signed-off-by: Philipp Hufnagl > --- > src/PVE/Tools.pm | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/src/PVE

[pve-devel] applied: [PATCH storage v4 2/2] fix whitespaces

2023-08-04 Thread Fabian Grünbichler
again, limited to the non-alignmnet changes On August 1, 2023 4:46 pm, Philipp Hufnagl wrote: > Signed-off-by: Philipp Hufnagl > --- > src/PVE/Storage/Plugin.pm | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/

[pve-devel] applied: [PATCH manager v4 2/2] fix whitespaces

2023-08-04 Thread Fabian Grünbichler
On August 1, 2023 4:46 pm, Philipp Hufnagl wrote: > Signed-off-by: Philipp Hufnagl > --- > PVE/API2/Nodes.pm | 16 > www/manager6/window/DownloadUrlToStorage.js | 4 ++-- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/PVE/API2/No

Re: [pve-devel] [PATCH storage v4 1/2] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-08-04 Thread Fabian Grünbichler
On August 1, 2023 4:45 pm, Philipp Hufnagl wrote: a bit of description here would be nice.. that being said, Reviewed-by: Fabian Grünbichler Tested-by: Fabian Grünbichler can be applied with a corresponding bumped dep on libpve-common-perl after that one has been released! > Signed-off-by: P

Re: [pve-devel] [PATCH manager v4 1/2] fix #4849: download to storage: automatically dectect and configure compression

2023-08-04 Thread Fabian Grünbichler
On August 1, 2023 4:46 pm, Philipp Hufnagl wrote: same here - please add a commit message! with one nit below that could be folded in together with the commit message, after pve-common and pve-storage have been bumped, since this one requires their changes and a corresponding bump in d/control:

[pve-devel] [PATCH qemu] backup: drop broken BACKUP_FORMAT_DIR

2023-08-04 Thread Fiona Ebner
Since upstream QEMU 8.0, it's no longer possible to call bdrv_img_create() from a coroutine anymore, meaning a backup with the directory format would crash the QEMU instance. The feature is only exposed via the monitor and was intended to be experimental. There were no user reports about the break