[pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

2023-08-02 Thread Thomas Lamprecht
Am 27/07/2023 um 14:47 schrieb Lukas Wagner: > Before, there was zero space between the the grid border line and the > button, making it look a bit odd. > > The ListField form component is currently used in the > 'User Tag Access' and 'Registered Tags' dialog windows in datacenter > option view. >

Re: [pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

2023-08-02 Thread Lukas Wagner
On Wed Aug 2, 2023 at 10:02 AM CEST, Thomas Lamprecht wrote: > FWIW, it might be also look slightly better, and save some space, if we'd > move the add button inside the grid, i.e., at the right side below the last > row. Would also shorten the way one has to move between adding a new tag input > a

Re: [pve-devel] [PATCH widget-toolkit 1/1] fixes #4874: Improve VM Name error message

2023-08-02 Thread Thomas Lamprecht
First thanks for this patch, such polishing are important contributions! Am 26/07/2023 um 17:36 schrieb Amin Vakil: please add the cover letter text to the commit message so that the context is actually conserved in git history. Also, for a simple single patch a cover letter is rather overhead,

[pve-devel] [PATCH docs 1/1] gui: add anchor for tags chapter

2023-08-02 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- pve-gui.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pve-gui.adoc b/pve-gui.adoc index e0fc873..0dd6646 100644 --- a/pve-gui.adoc +++ b/pve-gui.adoc @@ -379,6 +379,7 @@ and the corresponding interfaces for each menu item on the right. * *Permissions

[pve-devel] [PATCH manager 1/1] ui: implement 'Tag View' for the resource tree

2023-08-02 Thread Dominik Csapak
and keep the functionality in ResourceTree as generic as possible. We achieve this by having an 'itemMap' function that can split one item from the store into multiple to add to the tree. for the updates, we have to have an 'idMapFn' (to get the original id back) we also have to modify how the m

[pve-devel] [PATCH docs/wt/manager] implement tagview

2023-08-02 Thread Dominik Csapak
this adds a 'tagview' to the web ui, organizing guests by their tags (for details see the pve-manager patch) pve-docs: Dominik Csapak (1): gui: add anchor for tags chapter pve-gui.adoc | 1 + 1 file changed, 1 insertion(+) proxmox-widget-toolkit: Dominik Csapak (1): css: add some conditio

[pve-devel] [PATCH widget-toolkit 1/1] css: add some conditions to the tag classes for the tag view

2023-08-02 Thread Dominik Csapak
in the tag view, we have a custom 'full' style in a place where we can have another tagstyle class above. to compensate for that, we have to add another condition to those styles, namely that there is not the 'proxmox-tags-full' in between. Signed-off-by: Dominik Csapak --- src/css/ext6-pmx.css