Thanks for the review!
On 7/17/23 17:48, Maximiliano Sandoval wrote:
Lukas Wagner writes:
Signed-off-by: Lukas Wagner
---
Cargo.toml | 1 +
proxmox-notify/Cargo.toml | 9 +
proxmox-notify/src/config.rs| 51 +
proxmox-notify/src/endpoi
ping?
On 6/14/23 13:10, Aaron Lauterer wrote:
It can happen, that an RBD image isn't cleaned up 100%. Calling 'rbd ls
-l' will then show errors that it is not possible to open the image in
question:
```
rbd: error opening vm-103-disk-1: (2) No such file or directory
rbd: listing images failed: (
Signed-off-by: Fabian Grünbichler
---
the proxmox-mailgateway meta package could get a versioned dep on
pmg-api with this change, but it's not strictly required.
src/PMG/API2/APT.pm | 2 +-
src/PMG/CLI/pmg7to8.pm| 2 +-
src/PMG/CLI/pmgupgrade.pm | 2 +-
3 files changed, 3 insertions(+)
Signed-off-by: Fabian Grünbichler
---
the meta package could get a versioned dep on the proxmox-backup-server
package containing this change, but it is not strictly required.
docs/system-booting.rst | 2 +-
src/api2/node/apt.rs| 3 ++-
src/bin/pbs2to3.rs | 2 +-
3 files changed, 4 inser
following the rename in our kernel packaging, otherwise the scripts here
wouldn't pick up the new kernels (except if currently booted).
Signed-off-by: Fabian Grünbichler
---
src/bin/proxmox-boot-tool | 6 +++---
src/proxmox-boot/functions| 4 ++--
src/proxmox-boot/proxmox
and force upgrade of proxmox-kernel-helper with support for the new package
names.
Signed-off-by: Fabian Grünbichler
---
Notes:
we could rename pve-headers to pmg-headers and Provides/Replaces/Breaks
pve-headers with a version guard here..
the dependency on pmg-api could get a minimum v
this series enables lockdown and module signing in our kernel build.
since that effectively means every kernel build is an ABI bump, it also
uses this opportunity to fold in the kernel meta packages into the
pve-kernel git repo and source package, since those packages now always
need to be bumped
long overdue, and avoids the issue of the meta packages version going down
after being folded in from the pve-kernel-meta repository.
the ABI needs to be bumped for every published kernel package now that modules
are signed, else the booted kernel image containing the public part of the
ephemeral
Signed-off-by: Fabian Grünbichler
---
proxmox-ve could get a versioned dep on pve-manager with this change
included, but it's not strictly required.
PVE/API2/APT.pm| 2 +-
PVE/CLI/pve7to8.pm | 2 +-
bin/pveupgrade | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE
and force upgrade of proxmox-kernel-helper with support for the new package
names.
Signed-off-by: Fabian Grünbichler
---
Notes:
we could add a pbs-headers meta package here if desired
the dep on proxmox-backup-server could get a minimum version
debian/control | 4 ++--
1 file changed,
and force upgrade of proxmox-kernel-helper with support for the new package
names.
Signed-off-by: Fabian Grünbichler
---
Notes:
the dependency on pve-manager could get a minimum version here
debian/changelog | 6 ++
debian/control | 6 +++---
2 files changed, 9 insertions(+), 3 deleti
this is required for secure boot support.
at build time, an ephemeral key pair will be generated and all built modules
will be signed with it. the private key is discarded, and the public key
embedded in the kernel image for signature validation at module load time.
these changes allow booting th
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Backup.js| 3 +--
www/manager6/grid/Replication.js | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 03a02651..e662dd36 100644
--- a/www/manager6/dc/Backup.js
Not an in-depth review, just an explanation:
On Tue, Jul 18, 2023 at 09:19:54AM +0200, Lukas Wagner wrote:
> Thanks for the review!
>
> On 7/17/23 17:48, Maximiliano Sandoval wrote:
> >
> > Lukas Wagner writes:
> >
(...)
> > > +#[derive(Debug)]
> > > +pub enum Error {
> > > +ConfigSerializ
When called from the command line, it was not possible to calculate
cpu load because there was no 2nd data point available for the
calculation. Now (when called) from the command line, cpu stats will
be fetched twice with a minimum delta of 20ms. That way the load can
be calculated
Signed-off
On Mon, Jul 17, 2023 at 04:59:47PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner
> ---
(...)
> +/// Notification bus - distributes notifications to all registered endpoints
> +// The reason for the split between `Config` and this struct is to make
> testing with mocked
> +// endpoints
When called from the command line, it was not possible to calculate
cpu load because there was no 2nd data point available for the
calculation. Now (when called) from the command line, cpu stats will
be fetched twice with a minimum delta of 20ms. That way the load can
be calculated
fixes #476
Sorry forgott to tag as v2
On 7/18/23 13:58, Philipp Hufnagl wrote:
When called from the command line, it was not possible to calculate
cpu load because there was no 2nd data point available for the
calculation. Now (when called) from the command line, cpu stats will
be fetched twice wit
FYI: I'm not through the entire series yet, but I think it's fine for
the *API* methods to use `anyhow::Error` instead.
Also:
I'd like to move this here to a separate crate to replace
`proxmox_router::HttpError` (since the router one has no `source`
support atm and we don't want to depend on the ro
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn't be
disabled, that should imo only be there if i select 'never' ?
(conversely, the
On Mon, Jul 17, 2023 at 04:59:51PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner
> ---
> proxmox-notify/src/api/mod.rs | 7 +
> proxmox-notify/src/api/sendmail.rs | 254 +
> 2 files changed, 261 insertions(+)
> create mode 100644 proxmox-notify/src/a
On Mon, Jul 17, 2023 at 04:59:53PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner
> ---
> proxmox-notify/src/api/gotify.rs | 284 +++
> proxmox-notify/src/api/mod.rs| 6 +
> 2 files changed, 290 insertions(+)
> create mode 100644 proxmox-notify/src/api
set_min/max_proto_version is recommended upstream nowadays, and it seems to be
required for some reason if *only* TLS v1.3 is supposed to be enabled.
querying via get_options gives us the union of
- system-wide openssl defaults
- our internal SSL defaults
- flags configured by the user via /etc/de
Tested the following:
* created a mapping on a 3-node cluster, added mapping to PVE8 VM,
offline-migrated VM between cluster nodes, checked that `mount` inside
the VM mounts the correct host directory
* checked that `xattr=1` makes xattrs available in the guest, and
`acl=1` makes acls available i
On Mon, Jul 17, 2023 at 05:00:00PM +0200, Lukas Wagner wrote:
> Since `proxmox-notify` is intended to be used by multiple products,
> there needs to be a way to inject product-specific behavior.
>
> Signed-off-by: Lukas Wagner
> ---
> proxmox-notify/src/context.rs | 13 +
> proxmox-n
sorry for the missing subject prefix, this one is for
proxmox-backup-meta
On July 18, 2023 11:10 am, Fabian Grünbichler wrote:
> and force upgrade of proxmox-kernel-helper with support for the new package
> names.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> we could add a pbs-h
and this one for proxmox-kernel-helper
On July 18, 2023 11:10 am, Fabian Grünbichler wrote:
> following the rename in our kernel packaging, otherwise the scripts here
> wouldn't pick up the new kernels (except if currently booted).
>
> Signed-off-by: Fabian Grünbichler
> ---
> src/bin/proxmox-b
this one's for proxmox-mailgateway
On July 18, 2023 11:10 am, Fabian Grünbichler wrote:
> and force upgrade of proxmox-kernel-helper with support for the new package
> names.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> we could rename pve-headers to pmg-headers and Provides/Rep
Am 18/07/2023 um 14:00 schrieb Philipp Hufnagl:
> Sorry forgott to tag as v2
and also forgot to document the patch changelog like asked yesterday..
>
> On 7/18/23 13:58, Philipp Hufnagl wrote:
>> When called from the command line, it was not possible to calculate
>> cpu load because there wa
and this one and 2/2 are obviously for pve-kernel :-/ fixed up the git
settings so that it doesn't happen again..
On July 18, 2023 11:11 am, Fabian Grünbichler wrote:
> this is required for secure boot support.
>
> at build time, an ephemeral key pair will be generated and all built modules
> wil
On Mon, Jul 17, 2023 at 05:00:04PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner
> ---
> proxmox-notify/src/api/common.rs | 11 +++
> proxmox-notify/src/api/mod.rs| 125 +++
> 2 files changed, 136 insertions(+)
>
> diff --git a/proxmox-notify/src/api/c
On 7/18/23 14:34, Dominik Csapak wrote:
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn't be
disabled, that should imo only be there
On 7/18/23 14:44, Wolfgang Bumiller wrote:
+}
+
+if super::endpoint_exists(config, &endpoint_config.name) {
(*could* dedup the whole if into a helper in `super` so we don't need to
copy-pasta the message to every new endpoint - we already have this
twice now ;-) )
Yup, a later com
On Mon, Jul 17, 2023 at 05:00:05PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner
> ---
> proxmox-notify/src/api/filter.rs | 1 +
> proxmox-notify/src/api/gotify.rs | 1 +
> proxmox-notify/src/api/mod.rs | 113 ++---
> proxmox-notify/src/api/sendmail
On Mon, Jul 17, 2023 at 05:00:08PM +0200, Lukas Wagner wrote:
(...)
> +++ b/proxmox-notify/debian/copyright
This is still the old template.
> @@ -0,0 +1,16 @@
> +Copyright (C) 2023 Proxmox Server Solutions GmbH
> +
> +This software is written by Proxmox Server Solutions GmbH
>
> +
> +This progr
The `proxmox.git` part here so far is
Acked-by: Wolfgang Bumiller
Requested changes can happen as follow-ups.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Hello
On 7/18/23 15:02, Thomas Lamprecht wrote:
Am 18/07/2023 um 14:00 schrieb Philipp Hufnagl:
Sorry forgott to tag as v2
and also forgot to document the patch changelog like asked yesterday..
Sorry. I did not know that. I will add a changelog
On 7/18/23 13:58, Philipp Hufnagl wrote:
On 7/18/23 15:14, Lukas Wagner wrote:
On 7/18/23 14:34, Dominik Csapak wrote:
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn't be
Am 29/06/2023 um 13:34 schrieb Maximiliano Sandoval:
> When running `pct status VMID` the variable
> $last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
>
> For consistency with the qt command we do not print the cpu usage.
>
> Signed-off-by: Maximiliano Sandoval
> ---
>
> Th
On 7/18/23 15:58, Dominik Csapak wrote:
I already have patches laying around that implement the additional filter
matchers, but
decided to not include them in the patch series yet. Before the new matchers
are merged,
I would need to 'stabilize' the properties associate with every single
not
Am 18/07/2023 um 14:34 schrieb Dominik Csapak:
> * the backup edit window is rather tall at this point, and if we assume a
> minimum
> screen size of 1280x720 there is not quite enough space when you subtract
> the (typical) os bar and browser window decoration, maybe a 'notification'
> tab
41 matches
Mail list logo
