[pve-devel] applied: [PATCH pve-manager v4] fix #4551: ui: use gettext on hardcoded byte units

2023-07-05 Thread Thomas Lamprecht
Am 03/07/2023 um 14:15 schrieb Noel Ullreich: > Since some languages translate byte units like 'GiB' or write them in their > own script, this patch wraps units in the `gettext` function. > > While most occurrences of byte strings can be translated within the > `format_size` function in `proxmox-w

[pve-devel] [PATCH manager v2 3/5] pveproxy, ui, d/control: add font-logos

2023-07-05 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- PVE/Service/pveproxy.pm | 2 ++ debian/control | 1 + www/index.html.tpl | 1 + 3 files changed, 4 insertions(+) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index 9e8a2fecd..ac1085457 100755 --- a/PVE/Service/pveproxy.pm +++ b/P

[pve-devel] [PATCH font-logos v2 1/5] d/install: fix typo in css install path

2023-07-05 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- debian/install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/install b/debian/install index 0ef0655..69b9d81 100644 --- a/debian/install +++ b/debian/install @@ -1,2 +1,2 @@ font-logos/assets/* /usr/share/fonts-font-logos/fonts -fon

[pve-devel] [PATCH manager v2 5/5] ui: GuestStatusView: show distro logo and name in summary header

2023-07-05 Thread Christoph Heiss
It fits neatly there, is rather unintrusive and yet still visible at first sight. It also solves the problem of having to create a bigger row, so that the icon is still easily recognisable. At the default font-size of 13pt, this really wasn't the case. Verified that each supported distro is presen

[pve-devel] [PATCH font-logos v2 2/5] css: fix missing `@` for font-face rule

2023-07-05 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- src/font-logos.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/font-logos.css b/src/font-logos.css index 0de3d12..ab6c57d 100644 --- a/src/font-logos.css +++ b/src/font-logos.css @@ -1,4 +1,4 @@ -font-face { +@font-face { font-disp

[pve-devel] [PATCH manager v2 4/5] ui: GuestStatusView: show privileged status as new row

2023-07-05 Thread Christoph Heiss
As that info is not available through the store (which stores the status), it must be fetched separately. Signed-off-by: Christoph Heiss --- www/manager6/panel/GuestStatusView.js | 32 +++ 1 file changed, 32 insertions(+) diff --git a/www/manager6/panel/GuestStatusView.j

[pve-devel] [PATCH font-logos/manager v2 0/5] fix #2435: lxc: show distro and privileged status in summary

2023-07-05 Thread Christoph Heiss
This implements #2435 [0]. Show the unprivileged status in the summary panel, the distro logo and name in the title of the summary panel. Patch 1 & 2 fix two small typos in the `fonts-font-logos` package. Patch 3 then prepares the pveproxy to serve the required CSS and font files for the icon font

[pve-devel] [PATCH container v2 2/2] net: drop unused `firewall` argument to add_bridge_fdb()

2023-07-05 Thread Christoph Heiss
PVE::Network::SDN::Zones::add_bridge_fdb() does not actually have a `firewall` parameter, so drop it. No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/s

[pve-devel] [PATCH qemu-server v2 3/3] net: drop unused `firewall` argument to {add, del}_bridge_fdb()

2023-07-05 Thread Christoph Heiss
PVE::Network::{add,del}_bridge_fdb() do not actually have a `firewall` parameter, so drop it. Same for the SDN equivalents. No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes PVE/QemuServer.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[pve-devel] [PATCH network v2 1/1] sdn: zones: drop unused `firewall` argument to {add, del}_bridge_fdb()

2023-07-05 Thread Christoph Heiss
PVE::Network::{add,del}_bridge_fdb() do not actually have a `firewall` parameter, so drop it. And since it wasn't used anywhere else in these subroutines, drop it completely. No functional changes. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes src/PVE/Network/SDN/Zones.pm

[pve-devel] [PATCH network/container/qemu-server v2 0/3] drop unused `firewall` argument to {add, del}_bridge_fdb()

2023-07-05 Thread Christoph Heiss
While working on this code, I noticed that the `firewall` argument is never used (nor even declared) [0] in both PVE::Network::{add,del}_bridge_fdb(). Thus drop it everywhere and avoid needlessly passing around things which are never used anyway. Did some quick smoke-testing and everything kept w

[pve-devel] [PATCH manager v2] fix #4364: pveceph: add confirmation dialogue for ceph installation

2023-07-05 Thread Max Carrara
Displays a confirmation dialogue if the user didn't explicitly provide a valid ceph version via the `--version` flag and if stdout is connected to a tty. Signed-off-by: Max Carrara --- v2 of this little patch incorporates the given feedback[0] (thanks btw!) Regarding exit codes: Even though it'