[pve-devel] [PATCH manager 1/2] api: ceph: remove deprecrated Pools path

2023-06-15 Thread Aaron Lauterer
The replacement is Pool (singular). Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph.pm | 7 - PVE/API2/Ceph/Makefile | 1 - PVE/API2/Ceph/Pools.pm | 766 - 3 files changed, 774 deletions(-) delete mode 100644 PVE/API2/Ceph/Pools.pm diff --git a

[pve-devel] [PATCH manager 2/2] api: ceph: remove deprecrated config and configdb endpoints

2023-06-15 Thread Aaron Lauterer
Both are superseeded by ceph/cfg/raw and ceph/cfg/db Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph.pm | 73 1 file changed, 73 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 4893c957..1b765b75 100644 --- a/PVE/API2/Ceph.pm

Re: [pve-devel] [PATCH v3 manager 0/3]fix 2515 use size defaults

2023-06-15 Thread Aaron Lauterer
ping? On 4/11/23 15:40, Aaron Lauterer wrote: The main goal of this series is to improve the handling of configured default size & min_size values when creating a new Ceph Pool in the GUI. A new Ceph API endpoint, 'cfg/value', is added. It allows us to fetch values for config keys that are set

[pve-devel] applied-series: [PATCH v2 firewall manager] firewall: introduce scoping for ipsets/aliases

2023-06-15 Thread Wolfgang Bumiller
applied series, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 firewall 1/2] api: fix scoping for ipset endpoint

2023-06-15 Thread Wolfgang Bumiller
picked this into stable-7 as well On Tue, Jun 13, 2023 at 02:06:32PM +0200, Leo Nunner wrote: > in the cluster class, we save the cluster config into the 'fw_conf' > variable, and not into 'cluster_conf', which in turns is set to 'undef' > instead. > > Signed-off-by: Leo Nunner > --- > src/PVE/

[pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-06-15 Thread Dominik Csapak
this field has a fixed height, which is too tall for the create wizard, and one cannot see the last entry when scrolling all the way down. to fix this, make it 20px shorter Signed-off-by: Dominik Csapak --- alternatively we could also increase the height in the create wizard the optimal solutio

Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

2023-06-15 Thread Dominik Csapak
forgot to write: we should apply this for stable-7 as well On 6/15/23 10:08, Dominik Csapak wrote: this field has a fixed height, which is too tall for the create wizard, and one cannot see the last entry when scrolling all the way down. to fix this, make it 20px shorter Signed-off-by: Dominik

[pve-devel] [PATCH RFC common] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Dominik Csapak
if a real json boolean is sent via the api, $value is a JSON::PP::Boolean here instead of a string/scalar so we should validate that too the $value itself can be used normally in conditions like if ($value) { This worked for most api calls by accident before commit: f398a3d ("proxy req

[pve-devel] [PATCH v2 container manager] Show dynamic container IPs in GUI

2023-06-15 Thread Leo Nunner
Changes since v1: - fix some style nits - add a new component to show IPs in the LXC summary page container: Leo Nunner (1): api: network: get interfaces from containers src/PVE/API2/LXC.pm | 50 + src/PVE/LXC.pm | 26 ++

[pve-devel] [PATCH v2 container] api: network: get interfaces from containers

2023-06-15 Thread Leo Nunner
Adds an 'interfaces' endpoint in the API (/nodes/{node}/lxc/{vmid}/interfaces'), which returns a list of interface names, together with a MAC, IPv4 and IPv6 address. This list may be expanded in the future. Note that this is only returned for *running* containers, stopped containers simply return a

[pve-devel] [PATCH v2 manager 2/2] lxc: show IPs in summary view

2023-06-15 Thread Leo Nunner
modelled after the QEMU Guest Agent UI. We only show the first non-loopback IP on the summary page itself. Signed-off-by: Leo Nunner --- www/manager6/Makefile | 1 + www/manager6/lxc/ContainerIPView.js | 194 ++ www/manager6/panel/GuestStatusView.js |

[pve-devel] [PATCH v2 manager 1/2] lxc: show dynamically assigned IPs in network tab

2023-06-15 Thread Leo Nunner
adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the returned data with the existing configuration. This will update the IPv4 and IPv6 address, as well as the interface name (in case the container changed it). Signed-off-by: Leo Nunner --- www/manager6/lxc/Network.js | 57 ++

Re: [pve-devel] [PATCH RFC common] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Wolfgang Bumiller
On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote: > if a real json boolean is sent via the api, $value is a > JSON::PP::Boolean here instead of a string/scalar > > so we should validate that too > > the $value itself can be used normally in conditions like > > if ($value) { > -

[pve-devel] [PATCH proxmox-backup 3/3] file-restore: set loglevel considering PBS_QEMU_DEBUG

2023-06-15 Thread Stoiko Ivanov
during some tests recently I wondered why a debug log-message was not printed, despite running with PBS_QEMU_DEBUG. This patch sets the loglevel for the cli logger to debug if the variable is present and not-empty (see qemu_helper.rs for the other usage). Signed-off-by: Stoiko Ivanov --- proxmo

[pve-devel] [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly

2023-06-15 Thread Stoiko Ivanov
The first two patches fix the setting of zfs_arc_min and zfs_arc_max via the kernel commandline - afaics they should not have been honored until now - verification was done in the debug-image by inspecting `grep '^c_' /proc/spl/kstat/zfs/arcstats` the first 2 patches can be squashed - it explicit

[pve-devel] [PATCH proxmox-backup 2/3] file-restore: set zfs_arc_min to current minimum of 32M

2023-06-15 Thread Stoiko Ivanov
zfs_arc_min was raised to 32M (for linux) in zfs-commit 121b3cae742a0670d902a51bc61d49dc4a3e4445 while the current logic would still set the min_size to 32M (it's max(32M, allmem/32), which results to 32M for memory sizes up to 1024M), setting it explicitly to the minimum makes it clear, and will

[pve-devel] [PATCH proxmox-backup 1/3] file-restore: add zfs. prefix to arc_min/max settings

2023-06-15 Thread Stoiko Ivanov
Currently the values set for zfs_arc_min and zfs_arc_max are ignored by the kernel: ``` Unknown kernel command line parameters... will be passed to user space ``` module parameters provided on the commandline usually need to be prefixed with the modulename (e.g. zfs.zfs_arc_min, see [0] for a bit o

Re: [pve-devel] [PATCH RFC common] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Dominik Csapak
On 6/15/23 11:51, Wolfgang Bumiller wrote: On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote: if a real json boolean is sent via the api, $value is a JSON::PP::Boolean here instead of a string/scalar so we should validate that too the $value itself can be used normally in conditio

[pve-devel] [PATCH storage] content-dirs check: silently skip paths that cannot be resolved

2023-06-15 Thread Friedrich Weber
Since commit 8e623a2930f7aee4b3309b1f297613a250ee4698, the inequality check for content-dirs prints a warning if a content directory path could not be resolved, i.e., if `abs_path` returns undef. Among other things, `abs_path` returns undef if the path has an inner (= any but last) component that d

[pve-devel] [PATCH qemu 2/2] fix checks for drive mirror with bitmap

2023-06-15 Thread Fiona Ebner
The QAPI change for QEMU 8.0 dropped redundant has_foo parameters, but in the blockdev_mirror_common() function (which is not part of the QAPI itself but called from there) the argument pair was has_bitmap and bitmap_name rather than has_bitmap and bitmap. Reported-by: Aaron Lauterer Signed-off-b

[pve-devel] [PATCH qemu 1/2] regenerate patches

2023-06-15 Thread Fiona Ebner
There's still some context changes not covered by earlier series. No functional change intended. Signed-off-by: Fiona Ebner --- ...VE-add-savevm-async-for-background-state-snapshots.patch | 4 ++-- .../pve/0020-PVE-Add-dummy-id-command-line-parameter.patch | 4 ++-- ...E-Compat-4.0-used-balloon

[pve-devel] [PATCH pve-manager v3]ui: add field to set subdir-depth in web interface

2023-06-15 Thread Noel Ullreich
When adding or editing a storage device in Datacenter->Storage in the web interface, the subdirectory depth can be set in the advanced menu. Signed-off-by: Noel Ullreich --- www/manager6/storage/Base.js | 11 +++ 1 file changed, 11 insertions(+) diff --git a/www/manager6/storage/Base.js

[pve-devel] [PATCH pve-storage/pve-manager v3 0/4] fix #623: show isos/vztmpl/snippets in subdirs

2023-06-15 Thread Noel Ullreich
This patch fixes #623, allowing isos/vztmpl/snippets in subdirectories. This feature is opt-in and can be set from the API, web interface or with `pvesm`. I addressed the security concerns raised by Fabian, now parent directories in the path (i.e. `/my/path/../somewhere/`) are forbidded. I have ke

[pve-devel] [PATCH pve-storage v3 3/3] update test for recursive subdir search

2023-06-15 Thread Noel Ullreich
Tests now also test if traversing subdirectories works. That means checking if: - parent directories in paths are caught - checking that nested files are found - checking that files below the maximum depth set are not found Signed-off-by: Noel Ullreich --- src/test/filesystem_path_test.pm | 1

[pve-devel] [PATCH pve-storage v3 2/3] add `subdir-depth` option to filesystems

2023-06-15 Thread Noel Ullreich
Add the `subdir-depth` to the filesystems that can hold isos/vztmpl/snippets. Signed-off-by: Noel Ullreich --- src/PVE/Storage/CIFSPlugin.pm | 1 + src/PVE/Storage/CephFSPlugin.pm| 1 + src/PVE/Storage/DirPlugin.pm | 1 + src/PVE/Storage/GlusterfsPlugin.pm | 1 + src/PVE/Storage/N

[pve-devel] [PATCH pve-storage v3 1/3] recursively go through subdirs to find files

2023-06-15 Thread Noel Ullreich
This patch allows `get_subdir_files` to recursively call itself, so that subdirectories of set depth can be searched. We allow searching for isos, vztmpl and snippets but not backups. As a security measure, when parsing a given path, parent directories (`/../`) are forbidden. The feature is opt-i

Re: [pve-devel] [PATCH qemu-server/novnc/manager/docs v9 0/5] Feature VNC-Clipboard

2023-06-15 Thread Dominik Csapak
Looks good from my side now, maybe someone else wants to chime in regarding the splitting of the setting in the gui (but IMHO that's good) consider the series: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak ___ pve-devel mailing list pve-dev

[pve-devel] [PATCH installer 0/4] Drop deprecated GTK 3 methods

2023-06-15 Thread Maximiliano Sandoval
Small series of patches to drop the use of properties and methods that were deprecated in GTK 3. Maximiliano Sandoval (4): stop using Gtk3::Misc->set_alignment stop using Gtk3::HBox and Gtk3::VBox stop using Gtk3::HSeparator stop using Gtk3::Window->set_has_resize_grip proxinstall | 84 +

[pve-devel] [PATCH installer 4/4] stop using Gtk3::Window->set_has_resize_grip

2023-06-15 Thread Maximiliano Sandoval
The property GtkWindow::has-resize-grip was deprecated in GTK 3.14, instead we make the window unresizable. Note that we set the value of resizable only after the window has been mapped and knows how much space it needs, also note that this only works correctly if the window is properly displayed

[pve-devel] [PATCH installer 3/4] stop using Gtk3::HSeparator

2023-06-15 Thread Maximiliano Sandoval
This was deprecated in GTK 3.2, the replacement Gtk3::Separator was added in GTK 3.0. Signed-off-by: Maximiliano Sandoval --- proxinstall | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proxinstall b/proxinstall index 105904f..d2f3d26 100755 --- a/proxinstall +++ b/pr

[pve-devel] [PATCH installer 2/4] stop using Gtk3::HBox and Gtk3::VBox

2023-06-15 Thread Maximiliano Sandoval
These widgets were deprecated in GTK 3.2 and replaced by Gtk3::Box which was introduced in 3.0. The packing changes require to horizontally expand the WebKit2::WebView widget. Signed-off-by: Maximiliano Sandoval --- proxinstall | 49 + 1 file chan

[pve-devel] [PATCH installer 1/4] stop using Gtk3::Misc->set_alignment

2023-06-15 Thread Maximiliano Sandoval
This was deprecated in GTK 3.14, instead we use GtkLabel:{xalign,yalign}. Note that by default they are both set to 0.5. Signed-off-by: Maximiliano Sandoval --- proxinstall | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/proxinstall b/proxinstall ind

[pve-devel] applied-series: [PATCH qemu 1/2] regenerate patches

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 13:38 schrieb Fiona Ebner: > There's still some context changes not covered by earlier series. No > functional change intended. > > Signed-off-by: Fiona Ebner > --- > ...VE-add-savevm-async-for-background-state-snapshots.patch | 4 ++-- > .../pve/0020-PVE-Add-dummy-id-command-li

[pve-devel] applied: [PATCH storage] content-dirs check: silently skip paths that cannot be resolved

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 13:36 schrieb Friedrich Weber: > Since commit 8e623a2930f7aee4b3309b1f297613a250ee4698, the inequality > check for content-dirs prints a warning if a content directory path > could not be resolved, i.e., if `abs_path` returns undef. Among other > things, `abs_path` returns undef if

[pve-devel] applied: [PATCH v2 storage] api: config: add/update storage: check for type mismatch first

2023-06-15 Thread Thomas Lamprecht
Am 12/06/2023 um 16:27 schrieb Fiona Ebner: > This avoids confusing errors about other properties when the storage > type doesn't match. By highlighting that the type doesn't match, users > should know right away what the issue is. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > *

Re: [pve-devel] [PATCH RFC common] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 13:12 schrieb Dominik Csapak: > On 6/15/23 11:51, Wolfgang Bumiller wrote: >> On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote: >>> if a real json boolean is sent via the api, $value is a >>> JSON::PP::Boolean here instead of a string/scalar >>> >>> so we should valid

[pve-devel] [PATCH common v2] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Dominik Csapak
if a real json boolean is sent via the api, $value is a JSON::PP::Boolean here instead of a string/scalar so we should validate that too the $value itself can be used normally in conditions like if ($value) { if the value is stringified, the result is either '1' or '0' so even if we ha

Re: [pve-devel] [PATCH RFC common] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Wolfgang Bumiller
On Thu, Jun 15, 2023 at 02:28:02PM +0200, Thomas Lamprecht wrote: > Am 15/06/2023 um 13:12 schrieb Dominik Csapak: > > On 6/15/23 11:51, Wolfgang Bumiller wrote: > >> On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote: > >>> if a real json boolean is sent via the api, $value is a > >>>

Re: [pve-devel] [PATCH pve-storage/pve-manager v3 0/4] fix #623: show isos/vztmpl/snippets in subdirs

2023-06-15 Thread Markus Frank
Works fine. Seems to be a good addition for organizing ISOs, vztmpl, etc. You could add a selector for a directory or a "destination path" text-input to the file upload as a follow-up patch. Tested-by: Markus Frank On 6/15/23 14:03, Noel Ullreich wrote: This patch fixes #623, allowing isos/vz

[pve-devel] applied: [PATCH common v2] fix #4778: fix boolean type check for json parameters over the api

2023-06-15 Thread Wolfgang Bumiller
applied, thanks On Thu, Jun 15, 2023 at 02:36:43PM +0200, Dominik Csapak wrote: > if a real json boolean is sent via the api, $value is a > JSON::PP::Boolean here instead of a string/scalar > > so we should validate that too > > the $value itself can be used normally in conditions like > >

[pve-devel] [PATCH manager stable-7] pve7to8: content-dirs check: skip paths that cannot be resolved

2023-06-15 Thread Friedrich Weber
The current inequality check for content-dirs does not correctly handle the case in which `abs_path` returns undef. This can result in confusing warnings: storage [...] uses directory for multiple content types [...] Fix this by skipping paths for which `abs_path` returns undef. This matches t

[pve-devel] Dropping spanning tree packets

2023-06-15 Thread Mark Schouten via pve-devel
--- Begin Message --- Hi, We have a customer that allows people to build EthernetOverIP tunnels, and bridge the endpoints of those tunnels to their hypervisor interface. This causes the hypervisor to transmit BPDU's, which causes the uplink-switches to trigger on security and shut the uplink.

[pve-devel] [PATCH v2 manager 2/4] api: backup: add 'pbs-entries-max' to permission check & config

2023-06-15 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes from v1: Add 'pbs-entries-max' according to the new shortened permission check PVE/API2/Backup.pm | 2 +- configs

[pve-devel] [PATCH v2 manager 1/4] api: backup: refactor backup permission check

2023-06-15 Thread Alexander Zeidler
Alter style to make the parameter check more concise Signed-off-by: Alexander Zeidler --- Changes from v1: Shorten permission check PVE/API2/Backup.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 45eb47e2..70753c2e 100644 ---

[pve-devel] [PATCH v2 guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

2023-06-15 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- Changes from v1: Improve description Move description to 'performance' section Remove arrow alignment src/PVE/VZDump/Common.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index a6fe483..

[pve-devel] [PATCH v2 container 3/4]: add 'pbs-entries-max' parameter

2023-06-15 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes from v1: Reword loginfo message and include new set value Fix indentation src/PVE/VZDump/LXC.pm | 5 + 1 file

[pve-devel] [PATCH v2 manager/container/guest-common 0/4] fix #3069: add pbs-entries-max to vzdump.conf

2023-06-15 Thread Alexander Zeidler
Users reported[1] about failing backups to PBS when having a large amount of files in a directory. proxmox-backup-client has already 'entries-max' implemented. The default value is also a kind of DOS prevention feature. Overriding this parameter needs at least 'Sys.Modify' permissions. This pa

[pve-devel] applied: [PATCH manager stable-7] pve7to8: content-dirs check: skip paths that cannot be resolved

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 15:22 schrieb Friedrich Weber: > The current inequality check for content-dirs does not correctly > handle the case in which `abs_path` returns undef. This can result in > confusing warnings: > > storage [...] uses directory for multiple content types [...] > > Fix this by ski

[pve-devel] applied: [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly

2023-06-15 Thread Thomas Lamprecht
Am 15/06/2023 um 12:42 schrieb Stoiko Ivanov: > The first two patches fix the setting of zfs_arc_min and zfs_arc_max via > the kernel commandline - afaics they should not have been honored until > now - verification was done in the debug-image by inspecting > `grep '^c_' /proc/spl/kstat/zfs/arcstat