[pve-devel] applied: [PATCH v2 ha-manager 1/2] tests: simulate stale maintainance node caused by simultaneous cluster shutdown

2023-06-13 Thread Thomas Lamprecht
Am 12/06/2023 um 17:27 schrieb Fiona Ebner: > In the test log, it can be seen that the service will unexpectedly be > migrated back. This is caused by the service's maintainance node > property being set by the initial shutdown, but never cleared, because > that currently happens only when the serv

[pve-devel] applied: [PATCH v2 ha-manager 2/2] manager: clear stale maintenance node caused by simultaneous cluster shutdown

2023-06-13 Thread Thomas Lamprecht
Am 12/06/2023 um 17:27 schrieb Fiona Ebner: > Currently, the maintenance node for a service is only cleared when the > service is started on another node. In the edge case of a simultaneous > cluster shutdown however, it might be that the service never was > started anywhere else after the maintena

Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

2023-06-13 Thread Fiona Ebner
Am 12.06.23 um 16:54 schrieb Thomas Lamprecht: > Am 12/06/2023 um 13:22 schrieb Fiona Ebner: >> Instead of getting rid of the "print once per line" handling, can't we >> rather adapt the invocation for backup to bubble up the other log lines too? > > would it make sense to differ between stderr/st

Re: [pve-devel] applied: [PATCH pve-network] fix permissions && use new /sdn/zones// path

2023-06-13 Thread Fabian Grünbichler
On June 12, 2023 5:29 pm, DERUMIER, Alexandre wrote: > Le lundi 12 juin 2023 à 16:36 +0200, Fabian Grünbichler a écrit : >> one more thing I realized while testing that might be worthy of a >> follow >> up - if you configure SDN, but for some reason, your >> /etc/network/interfaces is missing the "

[pve-devel] [PATCH manager v2 1/4] ui: realm sync edit: improve ux when there is no ldap/ad realm

2023-06-13 Thread Dominik Csapak
by adding an empty text to the dropdown, and disabling the other possibly invalid fields, so that it's clear why the panel is invalid as soon as there is an ldap/ad realm, it gets autoselected anyway and the fields get re-enabled. Signed-off-by: Dominik Csapak --- changes from v1: * fix eslint w

[pve-devel] [PATCH manager v2 0/4] improve ui for reaml sync jobs

2023-06-13 Thread Dominik Csapak
by implementing @thomas suggestions. The only thing not done for now is a 'run now' button, but for that we either have to create a new api call, or change the existing 'sync' call to read the job config with an extra parameter (i'd lean to do the latter) changes from v1: * fix eslint warnings *

[pve-devel] [PATCH manager v2 4/4] ui: realm sync: add 'run now' button

2023-06-13 Thread Dominik Csapak
by simply passing the sync job config to the 'sync' api endpoint, like we do for vzdump jobs Signed-off-by: Dominik Csapak --- new in v2 www/manager6/dc/RealmSyncJob.js | 41 + 1 file changed, 41 insertions(+) diff --git a/www/manager6/dc/RealmSyncJob.js b/www/ma

[pve-devel] [PATCH manager v2 2/4] ui: realm sync: change enabled column rendering

2023-06-13 Thread Dominik Csapak
to make it consistent with the repositories ui, since having a checkbox that is not clickable is confusing Signed-off-by: Dominik Csapak --- www/manager6/dc/RealmSyncJob.js | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/www/manager6/dc/RealmSyncJob.js b/www/manager6

[pve-devel] [PATCH manager v2 3/4] ui: realm: move sync job panel into realm panel

2023-06-13 Thread Dominik Csapak
and make it collapsible, so that users can hide it if they're not interested in it Signed-off-by: Dominik Csapak --- changes from v1: * fix eslint warning www/manager6/dc/AuthView.js | 2 +- www/manager6/dc/Config.js | 28 2 files changed, 21 insertions(+), 9 dele

[pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.1.12

2023-06-13 Thread Stoiko Ivanov
patches still applied cleanly Signed-off-by: Stoiko Ivanov --- upstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upstream b/upstream index e25f9131..86783d7d 16 --- a/upstream +++ b/upstream @@ -1 +1 @@ -Subproject commit e25f9131d679692704c11dc0c1df6d4585b70c35 +S

[pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12

2023-06-13 Thread Stoiko Ivanov
ZFS 2.1.12 got released one week ago [0]. Some commits fix data-corruption with mmap on rollback or clone. The issue with mountpoint=legacy mounts for rpool in Proxmox VE were addressed by reverting the change that introduced it [1]. Potential performance-optimization in [2,3,4] Improved handlin

[pve-devel] [PATCH zfsonlinux 2/2] /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316)

2023-06-13 Thread Stoiko Ivanov
(cherry picked from debian-upstream[0] commit 8ed69adac193f6463832f6ae34b5ded88b8014d8) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/t

[pve-devel] applied: [PATCH pve-network 1/2] zones: fix status

2023-06-13 Thread Fabian Grünbichler
On June 12, 2023 7:43 pm, Alexandre Derumier wrote: > Vnets were wrongly displayed in the main tree because of this, > and error was not set on zone > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Zones.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [pve-devel] [PATCH pve-network 2/2] zones: status: add a special message if vnet is not generated

2023-06-13 Thread Fabian Grünbichler
On June 12, 2023 7:43 pm, Alexandre Derumier wrote: > if vnet has not been generated (this should never happend) > warn the user to check if "source /etc/network/interfaces.d/sdn' > exist > > Signed-off-by: Alexandre Derumier > --- > src/PVE/Network/SDN/Zones.pm | 6 +- > 1 file changed, 5 i

Re: [pve-devel] [PATCH v5 02/15] api: add resource map api endpoints for PCI and USB

2023-06-13 Thread Wolfgang Bumiller
On Tue, Jun 06, 2023 at 03:52:09PM +0200, Dominik Csapak wrote: > this adds the typical section config crud API calls for > USB and PCI resource mapping to /cluster/resource/{TYPE} > > the only special thing that this series does is the list call > for both has a special 'check-node' parameter tha

Re: [pve-devel] [PATCH pve-network 2/2] zones: status: add a special message if vnet is not generated

2023-06-13 Thread Fabian Grünbichler
On June 13, 2023 1:21 pm, Fabian Grünbichler wrote: > On June 12, 2023 7:43 pm, Alexandre Derumier wrote: >> if vnet has not been generated (this should never happend) >> warn the user to check if "source /etc/network/interfaces.d/sdn' >> exist >> >> Signed-off-by: Alexandre Derumier >> --- >> s

[pve-devel] [PATCH manager 2/2] pve7to8: add check for dropped Permissions.Modify

2023-06-13 Thread Fabian Grünbichler
as a warning only - depending on desired privileges, no action might be necessary. Signed-off-by: Fabian Grünbichler --- PVE/CLI/pve7to8.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 7dc66499a..82441b0f8 100644 ---

[pve-devel] [PATCH manager 1/2] pve7to8: refactor user.cfg loop

2023-06-13 Thread Fabian Grünbichler
next patch adds acl-related checks Signed-off-by: Fabian Grünbichler --- PVE/CLI/pve7to8.pm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 6b51e98eb..7dc66499a 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI/

[pve-devel] [PATCH v2 manager] firewall: add scope field to IPRefSelector

2023-06-13 Thread Leo Nunner
and send the scoped value to the firewall when choosing new values. This happens for both IPSets and aliases. Signed-off-by: Leo Nunner --- www/manager6/form/IPRefSelector.js | 35 +++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/www/manager6/form/IPR

[pve-devel] [PATCH v2 firewall manager] firewall: introduce scoping for ipsets/aliases

2023-06-13 Thread Leo Nunner
Changes since v1: - fix adding entries to IPSets on the cluster level - code style improvements - adapt to the scoping change with 'guest/' The GUI now just shows the scope "Datacenter/Guest", and returns the concatenated value ('$scope/$value') automatically. pve-firew

[pve-devel] [PATCH v2 firewall 2/2] fix #4556: api: return scoped IPSets and aliases

2023-06-13 Thread Leo Nunner
Introduce a new 'scope' field in the return values for the /ref endpoints. Also add the 'ref' field in the VM endpoint, since it has been missing up until now. Signed-off-by: Leo Nunner --- src/PVE/API2/Firewall/Cluster.pm | 34 +++ src/PVE/API2/Firewall/VM.pm | 46 +

[pve-devel] [PATCH v2 firewall 1/2] api: fix scoping for ipset endpoint

2023-06-13 Thread Leo Nunner
in the cluster class, we save the cluster config into the 'fw_conf' variable, and not into 'cluster_conf', which in turns is set to 'undef' instead. Signed-off-by: Leo Nunner --- src/PVE/API2/Firewall/IPSet.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/API2/Firewall/IPSet.pm b

Re: [pve-devel] [PATCH qemu-server v5 1/6] enable cluster mapped USB devices for guests

2023-06-13 Thread Wolfgang Bumiller
On Tue, Jun 06, 2023 at 03:52:02PM +0200, Dominik Csapak wrote: > this patch allows configuring usb devices that are mapped via > cluster resource mapping when the user has 'Resource.Use' on the ACL > path '/resource/usb/{ID}' (in addition to the usual required vm config ^ should be /mapping in th

Re: [pve-devel] [PATCH qemu-server v5 3/6] check_local_resources: extend for mapped resources

2023-06-13 Thread Wolfgang Bumiller
On Tue, Jun 06, 2023 at 03:52:04PM +0200, Dominik Csapak wrote: > by adding them to their own list, saving the nodes where > they are not allowed, and return those on 'wantarray' so we don't break > existing callers that don't expect it. > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.p

Re: [pve-devel] [PATCH qemu-server v5 4/6] api: migrate preconditions: use new check_local_resources info

2023-06-13 Thread Wolfgang Bumiller
On Tue, Jun 06, 2023 at 03:52:05PM +0200, Dominik Csapak wrote: > for offline migration, limit the allowed nodes to the ones where the > mapped resources are available > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 17 - > 1 file changed, 12 insertions(+), 5 deletio

[pve-devel] [PATCH widget-toolkit] window: addtotp: Increase the size of the quiet zone

2023-06-13 Thread Maximiliano Sandoval
It is recommended that the quiet zone has the width of 4 blocks, since each block is around 4 pixels each, we need a margin of 16 pixels and a size of 256 + 2 * 16 pixels. Signed-off-by: Maximiliano Sandoval --- src/window/AddTotp.js | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[pve-devel] [PATCH manager 2/4] add 'pbs-entries-max' to permission check & config

2023-06-13 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- PVE/API2/Backup.pm | 2 +- configs/vzdump.conf | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/AP

[pve-devel] [PATCH container 3/4] add 'pbs-entries-max' parameter

2023-06-13 Thread Alexander Zeidler
configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- src/PVE/VZDump/LXC.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.p

[pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

2023-06-13 Thread Alexander Zeidler
Signed-off-by: Alexander Zeidler --- src/PVE/VZDump/Common.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index a6fe483..28ab0d3 100644 --- a/src/PVE/VZDump/Common.pm +++ b/src/PVE/VZDump/Common.pm @@ -282,6 +282,12 @@ my $confdesc

[pve-devel] [PATCH manager/container/guest-common 0/4] fix #3069: add pbs-entries-max to vzdump.conf

2023-06-13 Thread Alexander Zeidler
Users reported[1] about failing backups to PBS when having a large amount of files in a directory. proxmox-backup-client has already 'entries-max' implemented. The default value is also a kind of DOS prevention feature. Overriding this parameter needs at least 'Sys.Modify' permissions. This pa

[pve-devel] [PATCH manager 1/4] api: backup: refactor backup permission check

2023-06-13 Thread Alexander Zeidler
Unify style before adding another parameter check Signed-off-by: Alexander Zeidler --- PVE/API2/Backup.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 45eb47e2..cae889f4 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Bac

[pve-devel] applied-series: [PATCH zfsonlinux 0/2] update to 2.1.12

2023-06-13 Thread Thomas Lamprecht
Am 13/06/2023 um 11:57 schrieb Stoiko Ivanov: > ZFS 2.1.12 got released one week ago [0]. > > Some commits fix data-corruption with mmap on rollback or clone. > The issue with mountpoint=legacy mounts for rpool in Proxmox VE were > addressed by reverting the change that introduced it [1]. > > Pot

Re: [pve-devel] [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-13 Thread Stoiko Ivanov
I just realized that this has been reported in our bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=4515 can gladly resent with the fitting prefix, (and will add it in case this needs more work and a v2) - but if it gets applied as is adding a reference to the bug would be appreciated! On

[pve-devel] applied: [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-13 Thread Thomas Lamprecht
Am 09/06/2023 um 19:36 schrieb Stoiko Ivanov: > Templates not built directly by us, but redistributed from > images.linuxcontainer.org contain the following line in /etc/hosts: > `127.0.1.1 LXC_NAME` > > While it is mostly cosmetic - LXC_NAME, contains an underscore and is > not a valid DNS

Re: [pve-devel] [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-13 Thread Thomas Lamprecht
Am 09/06/2023 um 19:36 schrieb Stoiko Ivanov: > diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm > index 5534397..2d14599 100644 > --- a/src/PVE/LXC/Setup/Base.pm > +++ b/src/PVE/LXC/Setup/Base.pm > @@ -841,4 +841,15 @@ sub remove_pve_sections { > return $data =~ s/^\h*\Q$hea