applied, thanks
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Aside from what wolfgang already answered, one minor thing inline
On 5/17/23 13:59, Wolfgang Bumiller wrote:
If we get an empty challenge, tell the user to contact an
administrator as it means no 2nd factors and no recovery
keys are available.
Currently if only 1 key was available and it had a
Am 12.05.23 um 14:40 schrieb Aaron Lauterer:
> Aliased volumes (referencing the same disk image multiple times) can
> lead to unexpected behavior in a migration.
>
> Therefore, stop the migration in such a case.
>
> The check works by comparing the path returned by the storage plugin.
> This mean
Am 24.05.23 um 16:40 schrieb Aaron Lauterer:
> On 5/22/23 16:17, Fiona Ebner wrote:
>> Am 12.05.23 um 14:40 schrieb Aaron Lauterer:
>>> Aliased volumes (referencing the same disk image multiple times) can
>>> lead to unexpected behavior in a migration.
>>
>> Not only migration, but snapshots, stora
On Tue, May 23, 2023 at 02:17:18PM +0200, Stefan Sterz wrote:
> On 23.05.23 12:12, Christoph Heiss wrote:
> > On Tue, May 23, 2023 at 10:56:24AM +0200, Stefan Sterz wrote:
> > [..]
>
> yeah that would probably be best, as it's also closer to what the user
> wants (a working ldap setup) than either
this patch allows configuring usb devices that are mapped via
cluster resource mapping when the user has 'Resource.Use' on the ACL
path '/resource/usb/{ID}' (in addition to the usual required vm config
privileges)
for now, this is only valid if there is exactly one mapping for the
host, since we d
by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray' so we don't break
existing callers that don't expect it.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm| 43 ++--
test/MigrationTest/Sha
adds a config file for each type of resource (usb/pci) by using a 'map'
array propertystring for each node mapping
in each mapping we save the path(s) and some other information to detect
hardware changes (if possible) like the vendor/device id
both configs have custom header parser/formatter to
resource/pci.cfg and
resource/usb.cfg
to PVE/Cluster.pm
and status.c
Signed-off-by: Dominik Csapak
---
src/PVE/Cluster.pm | 2 ++
src/pmxcfs/status.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index efca58f..05f84bf 100644
--- a/src/PVE/Clust
Signed-off-by: Dominik Csapak
---
test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17
.../q35-linux-hostpci-mapping.conf.cmd| 36
test/run_config2command_tests.pl | 82 +++
3 files changed, 135 insertions(+)
create mode 100644 test/cfg2cmd/q35-l
uses the privileges:
Resource.Use
Resource.Modify
on /resource/{TYPE}/{id}
so that we can assign privileges on resource level
this will generate new roles (PVEResourceUser, PVEResourceAdmin)
note that every user with Permissions.Modify on '/' and propagate can add these
new roles to themselves
this series aims to add a cluster-wide device mapping for pci and usb
devices. so that an admin can configure a device to be availble for
migration and configuring for uses that are non-root
(the existing pattern can be copied easily for other types, e.g.
markus upcoming folder sharing)
note that
for offline migration, limit the allowed nodes to the ones where the
mapped resources are available
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 68d1b818..e73a35
in pve-http-server the proxyto_callback always has a complete list of
parameters, not only the ones in the url, so adapt the implementation
here to do the same
Signed-off-by: Dominik Csapak
---
PVE/CLI/pvesh.pm | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/PVE/CL
they can only be migrated to nodes where there exists a mapping and if
the migration is done offline
Signed-off-by: Dominik Csapak
---
PVE/QemuMigrate.pm | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 09c
this patch allows configuring pci devices that are mapped via cluster
resource mapping when the user has 'Resource.Use' on the ACL path
'/resource/pci/{ID}' (in addition to the usual required vm config
privileges)
When given multiple mappings in the config, we use them as alternatives
for the pas
this adds the typical section config crud API calls for
USB and PCI resource mapping to /cluster/resource/{TYPE}
the only special thing that this series does is the list call
for both has a special 'check-node' parameter that uses the
'proxyto_callback' to reroute the api call to the given node
so
On 5/25/23 12:17, Dominik Csapak wrote:
adds a config file for each type of resource (usb/pci) by using a 'map'
array propertystring for each node mapping
in each mapping we save the path(s) and some other information to detect
hardware changes (if possible) like the vendor/device id
both confi
18 matches
Mail list logo