On December 9, 2022 1:58 pm, Aaron Lauterer wrote:
> /nodes/{node}/ceph/pools/{pool} returns the pool details right away on a
> GET. This makes it bad practice to add additional sub API endpoints.
>
> By deprecating it and replacing it with /nodes/{node}/ceph/pool/{pool}
> (singular instead of pl
On March 16, 2023 2:48 pm, Aaron Lauterer wrote:
> Consolidating the different config paths lets us add more as needed
> without polluting our API with too many 'configxxx' endpoints.
>
> The config and configdb paths are renamed under the ceph/cfg path:
> * config -> raw (returns the ceph.conf fi
Am 17.03.23 um 17:23 schrieb DERUMIER, Alexandre:
> Hi Fiona,
>
> I don't have checked yet, but does I need to rebase the other virtio-
> mem patches ?
>
No, they still apply for me. But this patch(series)[0] and a versioned
breaks is needed for HA manager, before the 'memory' config property ca
Le lundi 20 mars 2023 à 09:36 +0100, Fiona Ebner a écrit :
> Am 17.03.23 um 17:23 schrieb DERUMIER, Alexandre:
> > Hi Fiona,
> >
> > I don't have checked yet, but does I need to rebase the other
> > virtio-
> > mem patches ?
> >
>
> No, they still apply for me. But this patch(series)[0] and a
>
this makes the background mask a bit brighter and more see-through to
make it possible to read values from behind the mask, if needed. it
also adds a more visible shadow to windows so that the stand out more
at the same time.
Signed-off-by: Stefan Sterz
---
src/proxmox-dark/scss/extjs/_presentat
this series adds a few more fix-ups for the dark theme:
* fix the contrast ratio of the focus state of help buttons
* make help buttons hovered/focused state brigther to be more
consistent with the rest of the theme
* dim warning and invalid colors further to be more consistent with
crisp
* d
by making the highlight more subtle, the theme is more consistent with
the look of crisp.
Signed-off-by: Stefan Sterz
---
src/proxmox-dark/scss/extjs/_grid.scss | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/proxmox-dark/scss/extjs/_grid.scss
b/src/proxmox-dark/scss/ext
also improves the hovered/focused state and makes it more consistent
with other buttons by making it brighter than the default state.
Signed-off-by: Stefan Sterz
---
src/proxmox-dark/scss/abstracts/_variables.scss | 2 +-
src/proxmox-dark/scss/proxmox/_helpbutton.scss | 3 ++-
2 files changed,
this brings them more in-line with the appearance of crisp.
Signed-off-by: Stefan Sterz
---
src/proxmox-dark/scss/abstracts/_variables.scss | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/proxmox-dark/scss/abstracts/_variables.scss
b/src/proxmox-dark/scss/abstracts/_
ceph/pools (plural) is deprecated, use the new one.
Since the details / status of a pool has been moved from previously
ceph/pools/{name} to now ceph/pool/{name}/status, we need to pass the
'loadUrl' to the edit window.
Signed-off-by: Aaron Lauterer
---
no changes since v1
www/manager6/ceph/Poo
The API::Ceph::Pools module is deprecated. Use the new API::Ceph::Pool
(singular) module.
Signed-off-by: Aaron Lauterer
---
this patch has been added since v1 to also adapt the pveceph CLI tool to
the new module. Since all the methods kept their name and only the API
paths changed, there is not
/nodes/{node}/ceph/pools/{pool} returns the pool details right away on a
GET. This makes it bad practice to add additional sub API endpoints.
By deprecating it and replacing it with /nodes/{node}/ceph/pool/{pool}
(singular instead of plural) we can turn that into an index GET
response, making it
Signed-off-by: Aaron Lauterer
---
nothing changes since v1
www/manager6/ceph/Config.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/ceph/Config.js b/www/manager6/ceph/Config.js
index 7f07f15f..d4da20a8 100644
--- a/www/manager6/ceph/Config.js
+++ b/www/man
Consolidating the different config paths lets us add more as needed
without polluting our API with too many 'configxxx' endpoints.
The config and configdb paths are renamed under the ceph/cfg path:
* config -> raw (returns the ceph.conf file as is)
* configdb -> db (returns the ceph config db cont
to avoid multiple configXXX endpoints for different things.
A new API endpoint is used: 'cfg' and the current 'config' and
'configdb' are moved there (first 2 patches). The result is
* cfg/
* raw (formerly config)
* db (formerly configdb)
The other patches from the previous series (adding a n
Am 20/03/2023 um 10:02 schrieb Stefan Sterz:
> this series adds a few more fix-ups for the dark theme:
>
> * fix the contrast ratio of the focus state of help buttons
> * make help buttons hovered/focused state brigther to be more
> consistent with the rest of the theme
> * dim warning and inva
one super small nit inline, rest LGTM
On 3/20/23 11:50, Aaron Lauterer wrote:
Consolidating the different config paths lets us add more as needed
without polluting our API with too many 'configxxx' endpoints.
The config and configdb paths are renamed under the ceph/cfg path:
* config -> raw (re
aside from the one nit (which can be fixed up)
Reviewed-By: Dominik Csapak
Tested-By: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
series LGTM
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
since my reservations about being too strict were unfounded
(since these configs wouldn't have worked in the first place)
i'll send a follow up for adding a link to the rfc shortly
consider this:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
Signed-off-by: Dominik Csapak
---
pveum.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pveum.adoc b/pveum.adoc
index fa6579b..fa32b11 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -394,8 +394,8 @@ The main options for syncing are:
Reserved characters
Am 14/03/2023 um 14:14 schrieb Leo Nunner:
> Remove the requirement for paths to start with a /, as it might be
> confusing to users.
>
> Signed-off-by: Leo Nunner
> ---
> RFC: I'm not really sure how much input validation we want to do here.
> e.g., should we keep the user from appending or prep
Am 20/03/2023 um 14:36 schrieb Dominik Csapak:
> aside from the one nit (which can be fixed up)
fixed up in a follow up
>
> Reviewed-By: Dominik Csapak
> Tested-By: Dominik Csapak
>
with above: applied series, thanks!
___
pve-devel mailing list
p
Am 20/03/2023 um 14:47 schrieb Dominik Csapak:
> Reviewed-by: Dominik Csapak
> Tested-by: Dominik Csapak
With above: applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 15/03/2023 um 10:54 schrieb Dominik Csapak:
> hi,
>
> so high level comment:
> i'd write most of what you wrote in the cover letter here in the commit
> message,
> makes it much more convenient to find it only via git ;)
>
> also i'm missing a bit the rationale for how the regex was chosen, b
Am 09/03/2023 um 10:41 schrieb Christian Ebner:
> `pvesh get /nodes/{node}/storage/{storage}/content/{volume}` failed for
> several storage types, because the respective storage plugins returned
> only the volumes `size` on `volume_size_info` calls, while also the format
> is required.
>
> This pa
Am 09/02/2023 um 14:18 schrieb Aaron Lauterer:
> The `mkdir` option has two meanings[0][1] which are split up in `create-path`
> and `create-sub-dirs`.
>
> The `create-path` option decides if the path to the storage is
> automatically created or not.
> The `create-sub-dirs` options decides if the
Am 20/03/2023 um 15:22 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak
> ---
> pveum.adoc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.p
Am 31/01/2023 um 13:50 schrieb Christoph Heiss:
> Signed-off-by: Christoph Heiss
> ---
> pveum.adoc | 33 +
> 1 file changed, 33 insertions(+)
>
>
applied, dropped the extra newlines for the list and the backtick quoting on
the whitespace character to play safe a
Am 14/03/2023 um 14:14 schrieb Leo Nunner:
> Signed-off-by: Leo Nunner
> ---
> pve-storage-dir.adoc | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>
applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://list
Am 14/03/2023 um 14:14 schrieb Leo Nunner:
> Add a separate tab for the storage edit/create panels to set the
> recently introduced "content-dirs" property which overrides the
> default directory locations. Analogous to the API implementation,
> the tab was added for Directory, CIFS and NFS storage
Signed-off-by: Alexandre Derumier
---
pvesdn.adoc | 13 +
1 file changed, 13 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index be62769..d1ff036 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -928,6 +928,19 @@ and 10.0.2.0/24 in this example), will be announced
dynamically.
32 matches
Mail list logo
