Re: [pve-devel] applied: [RFC pve-qemu] disable jemalloc

2023-03-13 Thread DERUMIER, Alexandre
I have done tests writing a small C program calling malloc_trim(0), and it don't break/segfault with LD_PRELOAD tcmalloc. I don't think that tcmalloc override this specific gblic function, but maybe malloc_trim is triming empty glibc malloc memory. I have done 2 days of continous fio benchmark

Re: [pve-devel] [PATCH manager] ui: PBSEdit: cleanup iframe for paperkey

2023-03-13 Thread Aaron Lauterer
On 3/11/23 17:49, Thomas Lamprecht wrote: Am 10/03/2023 um 15:36 schrieb Aaron Lauterer: Otherwise the iframe used to print the paperkey will remain even after the encryption key window is closed. thanks for noticing! Additionally clean before creating a new one as otherwise we might end

Re: [pve-devel] [PATCH manager 1/2] api: ceph: deprecate pools in favor or pool

2023-03-13 Thread Aaron Lauterer
Ping? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH-SERIES v3 storage/docs] fix #2920: add options parameter to CIFS plugin

2023-03-13 Thread Friedrich Weber
Tested-by: Friedrich Weber I think that would be nice to have, e.g. to set noserverino [1] or actimeo [2] without having to mount manually. [1] https://forum.proxmox.com/threads/proxmox-backup-problem.123560/#post-537586 [2] https://forum.proxmox.com/threads/pve-cifs-connection-timed-out-59

[pve-devel] applied: [PATCH pve-firewall] Fix #4550 : host options: add nf_conntrack_helpers

2023-03-13 Thread Wolfgang Bumiller
applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: PBSEdit: cleanup iframe for paperkey

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 09:30 schrieb Aaron Lauterer: > On 3/11/23 17:49, Thomas Lamprecht wrote: >> Am 10/03/2023 um 15:36 schrieb Aaron Lauterer: >>> @@ -181,6 +187,7 @@ ${prettifiedKey} >>>     printFrame.src = "data:text/html;base64," + btoa(html); >>>   document.body.appendChild(printFrame);

[pve-devel] [PATCH qemu-server] qemu options: add memory_allocator

2023-03-13 Thread Alexandre Derumier
Add optional memory_allocator. Default is glibc malloc, tcmalloc is available to improve performance of ceph librbd. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 40be44d..8de

[pve-devel] [PATCH qemu] add patches to fix regression with LSI SCSI controller

2023-03-13 Thread Fiona Ebner
The patch 0008-memory-prevent-dma-reentracy-issues.patch introduced a regression for the LSI SCSI controller leading to boot failures [0], because, in its current form, it relies on reentrancy for a particular ram_io region. [0]: https://forum.proxmox.com/threads/123843 Signed-off-by: Fiona Ebner

[pve-devel] [PATCH qemu-server] fix: api: fix permission check for cloudinit drive update

2023-03-13 Thread Friedrich Weber
Trying to regenerate a cloudinit drive as a non-root user via the API currently throws a Perl error, as reported in the forum [1]. This is due to a type mismatch in the permission check, where a string is passed but an array is expected. [1] https://forum.proxmox.com/threads/regenerate-cloudinit-

Re: [pve-devel] [PATCH manager 1/3] api: ceph: add endpoint to fetch config keys

2023-03-13 Thread Aaron Lauterer
On 3/11/23 18:07, Thomas Lamprecht wrote: Am 08/03/2023 um 13:14 schrieb Dominik Csapak: high level: as you mentioned the path 'configkey' is not really optimal i recently mentioned off-list that we could clean this up on the next breaking major release with a breaking api change: have a '

Re: [pve-devel] [PATCH manager 1/3] api: ceph: add endpoint to fetch config keys

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 13:58 schrieb Aaron Lauterer: > On 3/11/23 18:07, Thomas Lamprecht wrote: >> We could add the full >> >> cfg/ >>     raw >>     db >>     value >> >> now already, re-mount the 'cfg/raw' one on the current 'config' (or just keep >> the code duplicated, not much gain if we remove it

[pve-devel] applied-series: [PATCH qemu 1/2] fixup patch "ide: avoid potential deadlock when draining during trim"

2023-03-13 Thread Thomas Lamprecht
Am 09/03/2023 um 14:37 schrieb Fiona Ebner: > The patch was incomplete and (re-)introduced an issue with a potential > failing assertion upon cancelation of the DMA request. > > There is a patch on qemu-devel now[0], and it's the same as this one > code-wise (except for comments). But the discussi

[pve-devel] applied-series: [PATCH qemu] add patches to fix regression with LSI SCSI controller

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 12:43 schrieb Fiona Ebner: > The patch 0008-memory-prevent-dma-reentracy-issues.patch introduced a > regression for the LSI SCSI controller leading to boot failures [0], > because, in its current form, it relies on reentrancy for a particular > ram_io region. > > [0]: https://foru

Re: [pve-devel] [PATCH qemu-server] qemu options: add memory_allocator

2023-03-13 Thread Thomas Lamprecht
Am 13/03/2023 um 11:16 schrieb Alexandre Derumier: > Add optional memory_allocator. > > Default is glibc malloc, tcmalloc is available to improve performance > of ceph librbd. Looks ok besides some config/api schema details I'd like to see changed. > > Signed-off-by: Alexandre Derumier > --- >

[pve-devel] [PATCH v2 qemu-server] qemu options: add tuning allocator

2023-03-13 Thread Alexandre Derumier
Add a new tuning option with allocator property. Available values: - Default is 'system', aka glibc malloc - tcmalloc (improve performance ceph librbd) Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 35 +++ 1 file changed, 35 insertions(+) diff --git

[pve-devel] [PATCH manager] ui: qemu : add tuning option

2023-03-13 Thread Alexandre Derumier
with memory allocator property Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 13 + www/manager6/form/TuningSelector.js | 41 + www/manager6/qemu/Options.js| 14 ++ 4 file